[INFO] updating cached repository kc1212/tokio-p2p [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kc1212/tokio-p2p [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kc1212/tokio-p2p" "work/ex/clippy-test-run/sources/stable/gh/kc1212/tokio-p2p"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kc1212/tokio-p2p'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kc1212/tokio-p2p" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kc1212/tokio-p2p"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kc1212/tokio-p2p'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c2d86a2a5931a287966303cdf9536aec0d8f2bb4 [INFO] sha for GitHub repo kc1212/tokio-p2p: c2d86a2a5931a287966303cdf9536aec0d8f2bb4 [INFO] validating manifest of kc1212/tokio-p2p on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kc1212/tokio-p2p on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kc1212/tokio-p2p [INFO] finished frobbing kc1212/tokio-p2p [INFO] frobbed toml for kc1212/tokio-p2p written to work/ex/clippy-test-run/sources/stable/gh/kc1212/tokio-p2p/Cargo.toml [INFO] started frobbing kc1212/tokio-p2p [INFO] finished frobbing kc1212/tokio-p2p [INFO] frobbed toml for kc1212/tokio-p2p written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kc1212/tokio-p2p/Cargo.toml [INFO] crate kc1212/tokio-p2p has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kc1212/tokio-p2p against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kc1212/tokio-p2p:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3260d54d58a270fb0012a02ac4ec2a828993f345c38b370484221801e1591456 [INFO] running `"docker" "start" "-a" "3260d54d58a270fb0012a02ac4ec2a828993f345c38b370484221801e1591456"` [INFO] [stderr] Checking net2 v0.2.26 [INFO] [stderr] Checking futures v0.1.10 [INFO] [stderr] Checking serde_json v0.9.8 [INFO] [stderr] Checking uuid v0.4.0 [INFO] [stderr] Checking mio v0.6.4 [INFO] [stderr] Checking tokio-timer v0.1.0 [INFO] [stderr] Checking tokio-core v0.1.4 [INFO] [stderr] Checking tokio-p2p v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | return Box::new(client); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(client)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | return Box::new(client); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(client)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/node.rs:108:64 [INFO] [stderr] | [INFO] [stderr] 108 | let srv = socket.incoming().for_each(move |(tcpstream, addr)| { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tx` [INFO] [stderr] --> src/node.rs:240:41 [INFO] [stderr] | [INFO] [stderr] 240 | fn handle_payload(&self, m: String, tx: Tx) -> Result<(), io::Error> { [INFO] [stderr] | ^^ help: consider using `_tx` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/node.rs:108:64 [INFO] [stderr] | [INFO] [stderr] 108 | let srv = socket.incoming().for_each(move |(tcpstream, addr)| { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tx` [INFO] [stderr] --> src/node.rs:240:41 [INFO] [stderr] | [INFO] [stderr] 240 | fn handle_payload(&self, m: String, tx: Tx) -> Result<(), io::Error> { [INFO] [stderr] | ^^ help: consider using `_tx` instead [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/node.rs:88:78 [INFO] [stderr] | [INFO] [stderr] 88 | mpsc::UnboundedSender::send(&tx2, Msg::Ping((inner2.borrow().id, inner2.borrow().addr.clone()))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `inner2.borrow().addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/node.rs:164:32 [INFO] [stderr] | [INFO] [stderr] 164 | .map(|(k, v)| (k.clone(), v.1.clone())) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/node.rs:164:43 [INFO] [stderr] | [INFO] [stderr] 164 | .map(|(k, v)| (k.clone(), v.1.clone())) [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `v.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/node.rs:166:16 [INFO] [stderr] | [INFO] [stderr] 166 | Ok(inner.borrow().send_random(Msg::AddrVec(m))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 166 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/node.rs:88:78 [INFO] [stderr] | [INFO] [stderr] 88 | mpsc::UnboundedSender::send(&tx2, Msg::Ping((inner2.borrow().id, inner2.borrow().addr.clone()))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `inner2.borrow().addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/node.rs:164:32 [INFO] [stderr] | [INFO] [stderr] 164 | .map(|(k, v)| (k.clone(), v.1.clone())) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*k` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/node.rs:164:43 [INFO] [stderr] | [INFO] [stderr] 164 | .map(|(k, v)| (k.clone(), v.1.clone())) [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `v.1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/node.rs:166:16 [INFO] [stderr] | [INFO] [stderr] 166 | Ok(inner.borrow().send_random(Msg::AddrVec(m))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 166 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/main.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / match msg { [INFO] [stderr] 32 | | Some(msg) => { [INFO] [stderr] 33 | | let f = timer.sleep(Duration::from_secs(1)) [INFO] [stderr] 34 | | .and_then(move |_| { [INFO] [stderr] ... | [INFO] [stderr] 40 | | None => (), [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 31 | if let Some(msg) = msg { [INFO] [stderr] 32 | let f = timer.sleep(Duration::from_secs(1)) [INFO] [stderr] 33 | .and_then(move |_| { [INFO] [stderr] 34 | node.broadcast(msg); [INFO] [stderr] 35 | Ok(()) [INFO] [stderr] 36 | }); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/main.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / match msg { [INFO] [stderr] 32 | | Some(msg) => { [INFO] [stderr] 33 | | let f = timer.sleep(Duration::from_secs(1)) [INFO] [stderr] 34 | | .and_then(move |_| { [INFO] [stderr] ... | [INFO] [stderr] 40 | | None => (), [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 31 | if let Some(msg) = msg { [INFO] [stderr] 32 | let f = timer.sleep(Duration::from_secs(1)) [INFO] [stderr] 33 | .and_then(move |_| { [INFO] [stderr] 34 | node.broadcast(msg); [INFO] [stderr] 35 | Ok(()) [INFO] [stderr] 36 | }); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.94s [INFO] running `"docker" "inspect" "3260d54d58a270fb0012a02ac4ec2a828993f345c38b370484221801e1591456"` [INFO] running `"docker" "rm" "-f" "3260d54d58a270fb0012a02ac4ec2a828993f345c38b370484221801e1591456"` [INFO] [stdout] 3260d54d58a270fb0012a02ac4ec2a828993f345c38b370484221801e1591456