[INFO] updating cached repository kbknapp/cargo-graph [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kbknapp/cargo-graph [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kbknapp/cargo-graph" "work/ex/clippy-test-run/sources/stable/gh/kbknapp/cargo-graph"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kbknapp/cargo-graph'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kbknapp/cargo-graph" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kbknapp/cargo-graph"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kbknapp/cargo-graph'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d895af1b7840c7ae8eddaf4e990bfa594c22ba01 [INFO] sha for GitHub repo kbknapp/cargo-graph: d895af1b7840c7ae8eddaf4e990bfa594c22ba01 [INFO] validating manifest of kbknapp/cargo-graph on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kbknapp/cargo-graph on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kbknapp/cargo-graph [INFO] finished frobbing kbknapp/cargo-graph [INFO] frobbed toml for kbknapp/cargo-graph written to work/ex/clippy-test-run/sources/stable/gh/kbknapp/cargo-graph/Cargo.toml [INFO] started frobbing kbknapp/cargo-graph [INFO] finished frobbing kbknapp/cargo-graph [INFO] frobbed toml for kbknapp/cargo-graph written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kbknapp/cargo-graph/Cargo.toml [INFO] crate kbknapp/cargo-graph has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kbknapp/cargo-graph against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kbknapp/cargo-graph:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1c6ce6df2e9f3e053e75b444904bc64f87c86b0c2bbeaffdae568b29cb2e9da9 [INFO] running `"docker" "start" "-a" "1c6ce6df2e9f3e053e75b444904bc64f87c86b0c2bbeaffdae568b29cb2e9da9"` [INFO] [stderr] Checking term_size v0.2.3 [INFO] [stderr] Checking toml v0.2.1 [INFO] [stderr] Checking clap v2.11.3 [INFO] [stderr] Checking cargo-graph v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | cfg: cfg, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cfg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/project.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | Ok(Project { cfg: cfg }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cfg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dep.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dep.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dep.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dep.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | ver: ver, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | cfg: cfg, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cfg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/project.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | Ok(Project { cfg: cfg }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cfg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dep.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dep.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dep.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dep.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | ver: ver, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / macro_rules! werr( [INFO] [stderr] 9 | | ($($arg:tt)*) => ({ [INFO] [stderr] 10 | | use std::io::{Write, stderr}; [INFO] [stderr] 11 | | write!(&mut stderr(), $($arg)*).ok(); [INFO] [stderr] 12 | | }) [INFO] [stderr] 13 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / macro_rules! verbose( [INFO] [stderr] 16 | | ($cfg:expr, $($arg:tt)*) => ({ [INFO] [stderr] 17 | | if $cfg.verbose { [INFO] [stderr] 18 | | use std::io::{Write, stdout}; [INFO] [stderr] ... | [INFO] [stderr] 21 | | }) [INFO] [stderr] 22 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | / macro_rules! verboseln( [INFO] [stderr] 25 | | ($cfg:expr, $($arg:tt)*) => ({ [INFO] [stderr] 26 | | if $cfg.verbose { [INFO] [stderr] 27 | | use std::io::{Write, stdout}; [INFO] [stderr] ... | [INFO] [stderr] 30 | | }) [INFO] [stderr] 31 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / macro_rules! regex( [INFO] [stderr] 34 | | ($s:expr) => ({::regex::Regex::new($s).unwrap()}) [INFO] [stderr] 35 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | / macro_rules! debug { [INFO] [stderr] 57 | | ($fmt:expr) => (); [INFO] [stderr] 58 | | ($fmt:expr, $($arg:tt)*) => (); [INFO] [stderr] 59 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/config.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/config.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | / arg_enum! { [INFO] [stderr] 29 | | #[derive(Debug, Copy, Clone)] [INFO] [stderr] 30 | | pub enum DotLineShape { [INFO] [stderr] 31 | | Solid, [INFO] [stderr] ... | [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/config.rs:47:1 [INFO] [stderr] | [INFO] [stderr] 47 | / arg_enum!{ [INFO] [stderr] 48 | | #[derive(Debug, Copy, Clone)] [INFO] [stderr] 49 | | pub enum DotColor { [INFO] [stderr] 50 | | Blue, [INFO] [stderr] ... | [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/config.rs:76:1 [INFO] [stderr] | [INFO] [stderr] 76 | / arg_enum!{ [INFO] [stderr] 77 | | #[derive(Debug, Copy, Clone)] [INFO] [stderr] 78 | | pub enum DotShape { [INFO] [stderr] 79 | | Box, [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / macro_rules! werr( [INFO] [stderr] 9 | | ($($arg:tt)*) => ({ [INFO] [stderr] 10 | | use std::io::{Write, stderr}; [INFO] [stderr] 11 | | write!(&mut stderr(), $($arg)*).ok(); [INFO] [stderr] 12 | | }) [INFO] [stderr] 13 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / macro_rules! verbose( [INFO] [stderr] 16 | | ($cfg:expr, $($arg:tt)*) => ({ [INFO] [stderr] 17 | | if $cfg.verbose { [INFO] [stderr] 18 | | use std::io::{Write, stdout}; [INFO] [stderr] ... | [INFO] [stderr] 21 | | }) [INFO] [stderr] 22 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | / macro_rules! verboseln( [INFO] [stderr] 25 | | ($cfg:expr, $($arg:tt)*) => ({ [INFO] [stderr] 26 | | if $cfg.verbose { [INFO] [stderr] 27 | | use std::io::{Write, stdout}; [INFO] [stderr] ... | [INFO] [stderr] 30 | | }) [INFO] [stderr] 31 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / macro_rules! regex( [INFO] [stderr] 34 | | ($s:expr) => ({::regex::Regex::new($s).unwrap()}) [INFO] [stderr] 35 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/macros.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | / macro_rules! debug { [INFO] [stderr] 57 | | ($fmt:expr) => (); [INFO] [stderr] 58 | | ($fmt:expr, $($arg:tt)*) => (); [INFO] [stderr] 59 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/config.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/config.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | / arg_enum! { [INFO] [stderr] 29 | | #[derive(Debug, Copy, Clone)] [INFO] [stderr] 30 | | pub enum DotLineShape { [INFO] [stderr] 31 | | Solid, [INFO] [stderr] ... | [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/config.rs:47:1 [INFO] [stderr] | [INFO] [stderr] 47 | / arg_enum!{ [INFO] [stderr] 48 | | #[derive(Debug, Copy, Clone)] [INFO] [stderr] 49 | | pub enum DotColor { [INFO] [stderr] 50 | | Blue, [INFO] [stderr] ... | [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/config.rs:76:1 [INFO] [stderr] | [INFO] [stderr] 76 | / arg_enum!{ [INFO] [stderr] 77 | | #[derive(Debug, Copy, Clone)] [INFO] [stderr] 78 | | pub enum DotShape { [INFO] [stderr] 79 | | Box, [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/config.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/config.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the BTreeMap [INFO] [stderr] --> src/project.rs:205:48 [INFO] [stderr] | [INFO] [stderr] 205 | for (name, dep_table) in table.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the BTreeMap [INFO] [stderr] --> src/project.rs:218:40 [INFO] [stderr] | [INFO] [stderr] 218 | for (name, _) in table.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | fn write(&self, f: &mut fmt::Formatter) -> fmt::Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | fn write(&self, f: &mut fmt::Formatter) -> fmt::Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:87:14 [INFO] [stderr] | [INFO] [stderr] 87 | fn write(&self, f: &mut fmt::Formatter) -> fmt::Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/util.rs:54:16 [INFO] [stderr] | [INFO] [stderr] 54 | if let None = parent { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 55 | | break; [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________- help: try this: `if parent.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:341:12 [INFO] [stderr] | [INFO] [stderr] 341 | if let None = p.file_name() { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 342 | | return Err(format!("'{}' doesn't appear to be a valid file name", &*s)); [INFO] [stderr] 343 | | } [INFO] [stderr] | |_____- help: try this: `if p.file_name().is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the BTreeMap [INFO] [stderr] --> src/project.rs:205:48 [INFO] [stderr] | [INFO] [stderr] 205 | for (name, dep_table) in table.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the BTreeMap [INFO] [stderr] --> src/project.rs:218:40 [INFO] [stderr] | [INFO] [stderr] 218 | for (name, _) in table.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | fn write(&self, f: &mut fmt::Formatter) -> fmt::Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | fn write(&self, f: &mut fmt::Formatter) -> fmt::Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:87:14 [INFO] [stderr] | [INFO] [stderr] 87 | fn write(&self, f: &mut fmt::Formatter) -> fmt::Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/util.rs:54:16 [INFO] [stderr] | [INFO] [stderr] 54 | if let None = parent { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 55 | | break; [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________- help: try this: `if parent.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:341:12 [INFO] [stderr] | [INFO] [stderr] 341 | if let None = p.file_name() { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 342 | | return Err(format!("'{}' doesn't appear to be a valid file name", &*s)); [INFO] [stderr] 343 | | } [INFO] [stderr] | |_____- help: try this: `if p.file_name().is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.48s [INFO] running `"docker" "inspect" "1c6ce6df2e9f3e053e75b444904bc64f87c86b0c2bbeaffdae568b29cb2e9da9"` [INFO] running `"docker" "rm" "-f" "1c6ce6df2e9f3e053e75b444904bc64f87c86b0c2bbeaffdae568b29cb2e9da9"` [INFO] [stdout] 1c6ce6df2e9f3e053e75b444904bc64f87c86b0c2bbeaffdae568b29cb2e9da9