[INFO] updating cached repository kbf09/rust_birabira_webserver [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kbf09/rust_birabira_webserver [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kbf09/rust_birabira_webserver" "work/ex/clippy-test-run/sources/stable/gh/kbf09/rust_birabira_webserver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kbf09/rust_birabira_webserver'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kbf09/rust_birabira_webserver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kbf09/rust_birabira_webserver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kbf09/rust_birabira_webserver'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ed01f801ccc369dae623b589f6e64663318528a0 [INFO] sha for GitHub repo kbf09/rust_birabira_webserver: ed01f801ccc369dae623b589f6e64663318528a0 [INFO] validating manifest of kbf09/rust_birabira_webserver on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kbf09/rust_birabira_webserver on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kbf09/rust_birabira_webserver [INFO] finished frobbing kbf09/rust_birabira_webserver [INFO] frobbed toml for kbf09/rust_birabira_webserver written to work/ex/clippy-test-run/sources/stable/gh/kbf09/rust_birabira_webserver/Cargo.toml [INFO] started frobbing kbf09/rust_birabira_webserver [INFO] finished frobbing kbf09/rust_birabira_webserver [INFO] frobbed toml for kbf09/rust_birabira_webserver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kbf09/rust_birabira_webserver/Cargo.toml [INFO] crate kbf09/rust_birabira_webserver has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kbf09/rust_birabira_webserver against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kbf09/rust_birabira_webserver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bb77a2eaf2abe1be411f20209895c3dbdfa2dd95c04893db3fb6dbf835cda115 [INFO] running `"docker" "start" "-a" "bb77a2eaf2abe1be411f20209895c3dbdfa2dd95c04893db3fb6dbf835cda115"` [INFO] [stderr] Checking rust_birabira_webserver v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bira/webserver.rs:21:19 [INFO] [stderr] | [INFO] [stderr] 21 | Webserver{config: config} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bira/http_headers.rs:36:77 [INFO] [stderr] | [INFO] [stderr] 36 | HttpHeaders {http_method: method.to_string(), uri: uri.to_string(), headers: headers} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bira/webserver.rs:21:19 [INFO] [stderr] | [INFO] [stderr] 21 | Webserver{config: config} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bira/http_headers.rs:36:77 [INFO] [stderr] | [INFO] [stderr] 36 | HttpHeaders {http_method: method.to_string(), uri: uri.to_string(), headers: headers} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `http_headers` [INFO] [stderr] --> src/bira/webserver.rs:53:17 [INFO] [stderr] | [INFO] [stderr] 53 | let http_headers = http_headers::HttpHeaders::new(&mut request_http_headers); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_http_headers` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bira/http_headers.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | let mut raw_method_header = request_http_headers.remove(0); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bira/http_headers.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | let mut a = raw_method_header.as_str(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: field is never used: `headers` [INFO] [stderr] --> src/bira/http_headers.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | headers: HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/bira/webserver.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | s.write(b"HTTP/1.1 200 OK\r\nConnection: close\r\n\r\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/bira/webserver.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | s.write(value.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/bira/webserver_config.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | Err(_) => panic!("config file not found!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bira/http_headers.rs:26:48 [INFO] [stderr] | [INFO] [stderr] 26 | header = header.trim_right_matches("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bira/http_headers.rs:27:48 [INFO] [stderr] | [INFO] [stderr] 27 | header = header.trim_right_matches("\r"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\r'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_birabira_webserver`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `http_headers` [INFO] [stderr] --> src/bira/webserver.rs:53:17 [INFO] [stderr] | [INFO] [stderr] 53 | let http_headers = http_headers::HttpHeaders::new(&mut request_http_headers); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_http_headers` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bira/http_headers.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | let mut raw_method_header = request_http_headers.remove(0); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bira/http_headers.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | let mut a = raw_method_header.as_str(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: field is never used: `headers` [INFO] [stderr] --> src/bira/http_headers.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | headers: HashMap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/bira/webserver.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | s.write(b"HTTP/1.1 200 OK\r\nConnection: close\r\n\r\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/bira/webserver.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | s.write(value.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/bira/webserver_config.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | Err(_) => panic!("config file not found!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bira/http_headers.rs:26:48 [INFO] [stderr] | [INFO] [stderr] 26 | header = header.trim_right_matches("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bira/http_headers.rs:27:48 [INFO] [stderr] | [INFO] [stderr] 27 | header = header.trim_right_matches("\r"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\r'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_birabira_webserver`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "bb77a2eaf2abe1be411f20209895c3dbdfa2dd95c04893db3fb6dbf835cda115"` [INFO] running `"docker" "rm" "-f" "bb77a2eaf2abe1be411f20209895c3dbdfa2dd95c04893db3fb6dbf835cda115"` [INFO] [stdout] bb77a2eaf2abe1be411f20209895c3dbdfa2dd95c04893db3fb6dbf835cda115