[INFO] updating cached repository kbacha/cxn_pool_test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kbacha/cxn_pool_test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kbacha/cxn_pool_test" "work/ex/clippy-test-run/sources/stable/gh/kbacha/cxn_pool_test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kbacha/cxn_pool_test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kbacha/cxn_pool_test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kbacha/cxn_pool_test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kbacha/cxn_pool_test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 09461ed362ccc9b6b95c4e46b24719f923bbb378 [INFO] sha for GitHub repo kbacha/cxn_pool_test: 09461ed362ccc9b6b95c4e46b24719f923bbb378 [INFO] validating manifest of kbacha/cxn_pool_test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kbacha/cxn_pool_test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kbacha/cxn_pool_test [INFO] finished frobbing kbacha/cxn_pool_test [INFO] frobbed toml for kbacha/cxn_pool_test written to work/ex/clippy-test-run/sources/stable/gh/kbacha/cxn_pool_test/Cargo.toml [INFO] started frobbing kbacha/cxn_pool_test [INFO] finished frobbing kbacha/cxn_pool_test [INFO] frobbed toml for kbacha/cxn_pool_test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kbacha/cxn_pool_test/Cargo.toml [INFO] crate kbacha/cxn_pool_test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kbacha/cxn_pool_test against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kbacha/cxn_pool_test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 64c0a4e3c189c051dcdc1abf01ee75292ce6bd663b72e435c319e389de95f607 [INFO] running `"docker" "start" "-a" "64c0a4e3c189c051dcdc1abf01ee75292ce6bd663b72e435c319e389de95f607"` [INFO] [stderr] Checking r2d2 v0.8.2 [INFO] [stderr] Checking cxn_pool_test v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `conn` [INFO] [stderr] --> src/main.rs:95:22 [INFO] [stderr] | [INFO] [stderr] 95 | let conn = pool.get().unwrap(); [INFO] [stderr] | ^^^^ help: consider using `_conn` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `conn` [INFO] [stderr] --> src/main.rs:95:22 [INFO] [stderr] | [INFO] [stderr] 95 | let conn = pool.get().unwrap(); [INFO] [stderr] | ^^^^ help: consider using `_conn` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Broke` [INFO] [stderr] --> src/main.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | Broke, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Broke` [INFO] [stderr] --> src/main.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | Broke, [INFO] [stderr] | ^^^^^ [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match self { [INFO] [stderr] 36 | | &Error::NotValid => "not valid", [INFO] [stderr] 37 | | &Error::Broke => "broke", [INFO] [stderr] 38 | | &Error::ConnectFailed => "connection failed", [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | match *self { [INFO] [stderr] 36 | Error::NotValid => "not valid", [INFO] [stderr] 37 | Error::Broke => "broke", [INFO] [stderr] 38 | Error::ConnectFailed => "connection failed", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match self { [INFO] [stderr] 36 | | &Error::NotValid => "not valid", [INFO] [stderr] 37 | | &Error::Broke => "broke", [INFO] [stderr] 38 | | &Error::ConnectFailed => "connection failed", [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | match *self { [INFO] [stderr] 36 | Error::NotValid => "not valid", [INFO] [stderr] 37 | Error::Broke => "broke", [INFO] [stderr] 38 | Error::ConnectFailed => "connection failed", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.52s [INFO] running `"docker" "inspect" "64c0a4e3c189c051dcdc1abf01ee75292ce6bd663b72e435c319e389de95f607"` [INFO] running `"docker" "rm" "-f" "64c0a4e3c189c051dcdc1abf01ee75292ce6bd663b72e435c319e389de95f607"` [INFO] [stdout] 64c0a4e3c189c051dcdc1abf01ee75292ce6bd663b72e435c319e389de95f607