[INFO] updating cached repository kazu69/gistit [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kazu69/gistit [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kazu69/gistit" "work/ex/clippy-test-run/sources/stable/gh/kazu69/gistit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kazu69/gistit'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kazu69/gistit" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kazu69/gistit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kazu69/gistit'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fa34462b3cd35b708c6793c41087c8d2845d1a39 [INFO] sha for GitHub repo kazu69/gistit: fa34462b3cd35b708c6793c41087c8d2845d1a39 [INFO] validating manifest of kazu69/gistit on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kazu69/gistit on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kazu69/gistit [INFO] finished frobbing kazu69/gistit [INFO] frobbed toml for kazu69/gistit written to work/ex/clippy-test-run/sources/stable/gh/kazu69/gistit/Cargo.toml [INFO] started frobbing kazu69/gistit [INFO] finished frobbing kazu69/gistit [INFO] frobbed toml for kazu69/gistit written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kazu69/gistit/Cargo.toml [INFO] crate kazu69/gistit has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kazu69/gistit against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kazu69/gistit:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f6061aa3b1c62aa7a6e545ad494433b311ecf8fd9be2ba1d5792e72430706179 [INFO] running `"docker" "start" "-a" "f6061aa3b1c62aa7a6e545ad494433b311ecf8fd9be2ba1d5792e72430706179"` [INFO] [stderr] Checking exitcode v1.1.2 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Compiling libgit2-sys v0.7.3 [INFO] [stderr] Checking tokio-io v0.1.7 [INFO] [stderr] Checking tokio-threadpool v0.1.4 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking libflate v0.1.15 [INFO] [stderr] Compiling emojicons v1.0.1 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking tokio-reactor v0.1.2 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking tokio-fs v0.1.1 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking git2 v0.7.1 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.6 [INFO] [stderr] Checking gistit v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gist.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | username: username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gist.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | username: username, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `username` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/gist.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | response [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/gist.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | let response = client.post(&url).headers(headers).json(&body).send(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/gist.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | pushed [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/gist.rs:56:30 [INFO] [stderr] | [INFO] [stderr] 56 | let pushed = self.push_reository(repository, gist_id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/gist.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | ret [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/gist.rs:67:24 [INFO] [stderr] | [INFO] [stderr] 67 | let ret = if status.contains(git2::Status::WT_MODIFIED) || [INFO] [stderr] | ________________________^ [INFO] [stderr] 68 | | status.contains(git2::Status::WT_NEW) || [INFO] [stderr] 69 | | status.contains(git2::Status::WT_DELETED) { [INFO] [stderr] 70 | | 0 [INFO] [stderr] 71 | | } else { [INFO] [stderr] 72 | | 1 [INFO] [stderr] 73 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/utils.rs:13:35 [INFO] [stderr] | [INFO] [stderr] 13 | let home_dir: PathBuf = match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/utils.rs:14:23 [INFO] [stderr] | [INFO] [stderr] 14 | Some(path) => PathBuf::from(path), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:116:12 [INFO] [stderr] | [INFO] [stderr] 116 | if description.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!description.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:122:12 [INFO] [stderr] | [INFO] [stderr] 122 | if hostname.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!hostname.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:130:12 [INFO] [stderr] | [INFO] [stderr] 130 | if files.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!files.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/gist.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | response [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/gist.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | let response = client.post(&url).headers(headers).json(&body).send(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/gist.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | pushed [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/gist.rs:56:30 [INFO] [stderr] | [INFO] [stderr] 56 | let pushed = self.push_reository(repository, gist_id); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/gist.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | ret [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/gist.rs:67:24 [INFO] [stderr] | [INFO] [stderr] 67 | let ret = if status.contains(git2::Status::WT_MODIFIED) || [INFO] [stderr] | ________________________^ [INFO] [stderr] 68 | | status.contains(git2::Status::WT_NEW) || [INFO] [stderr] 69 | | status.contains(git2::Status::WT_DELETED) { [INFO] [stderr] 70 | | 0 [INFO] [stderr] 71 | | } else { [INFO] [stderr] 72 | | 1 [INFO] [stderr] 73 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/utils.rs:13:35 [INFO] [stderr] | [INFO] [stderr] 13 | let home_dir: PathBuf = match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/utils.rs:14:23 [INFO] [stderr] | [INFO] [stderr] 14 | Some(path) => PathBuf::from(path), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:116:12 [INFO] [stderr] | [INFO] [stderr] 116 | if description.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!description.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:122:12 [INFO] [stderr] | [INFO] [stderr] 122 | if hostname.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!hostname.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:130:12 [INFO] [stderr] | [INFO] [stderr] 130 | if files.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!files.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 48.89s [INFO] running `"docker" "inspect" "f6061aa3b1c62aa7a6e545ad494433b311ecf8fd9be2ba1d5792e72430706179"` [INFO] running `"docker" "rm" "-f" "f6061aa3b1c62aa7a6e545ad494433b311ecf8fd9be2ba1d5792e72430706179"` [INFO] [stdout] f6061aa3b1c62aa7a6e545ad494433b311ecf8fd9be2ba1d5792e72430706179