[INFO] updating cached repository kavniekerk/neovim-gtk [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kavniekerk/neovim-gtk [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kavniekerk/neovim-gtk" "work/ex/clippy-test-run/sources/stable/gh/kavniekerk/neovim-gtk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kavniekerk/neovim-gtk'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kavniekerk/neovim-gtk" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kavniekerk/neovim-gtk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kavniekerk/neovim-gtk'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 620328a66802fb246ee0d2802241027309c8e4f2 [INFO] sha for GitHub repo kavniekerk/neovim-gtk: 620328a66802fb246ee0d2802241027309c8e4f2 [INFO] validating manifest of kavniekerk/neovim-gtk on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kavniekerk/neovim-gtk on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kavniekerk/neovim-gtk [INFO] finished frobbing kavniekerk/neovim-gtk [INFO] frobbed toml for kavniekerk/neovim-gtk written to work/ex/clippy-test-run/sources/stable/gh/kavniekerk/neovim-gtk/Cargo.toml [INFO] started frobbing kavniekerk/neovim-gtk [INFO] finished frobbing kavniekerk/neovim-gtk [INFO] frobbed toml for kavniekerk/neovim-gtk written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kavniekerk/neovim-gtk/Cargo.toml [INFO] crate kavniekerk/neovim-gtk has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kavniekerk/neovim-gtk against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kavniekerk/neovim-gtk:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5552d936b8724abede1a75c82d72dde9df8849eb9ecb1260a16bd98307166fcb [INFO] running `"docker" "start" "-a" "5552d936b8724abede1a75c82d72dde9df8849eb9ecb1260a16bd98307166fcb"` [INFO] [stderr] Compiling gio v0.5.0 [INFO] [stderr] Compiling gdk-pixbuf v0.5.0 [INFO] [stderr] Compiling cairo-rs v0.5.0 [INFO] [stderr] Checking fragile v0.3.0 [INFO] [stderr] Compiling gdk v0.9.0 [INFO] [stderr] Compiling gtk v0.5.0 [INFO] [stderr] Compiling pangocairo v0.6.0 [INFO] [stderr] Compiling glib-sys v0.7.0 [INFO] [stderr] Compiling gobject-sys v0.7.0 [INFO] [stderr] Compiling gio-sys v0.7.0 [INFO] [stderr] Compiling pango-sys v0.7.0 [INFO] [stderr] Compiling cairo-sys-rs v0.7.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.7.0 [INFO] [stderr] Compiling gdk-sys v0.7.0 [INFO] [stderr] Compiling atk-sys v0.7.0 [INFO] [stderr] Compiling gtk-sys v0.7.0 [INFO] [stderr] Compiling pangocairo-sys v0.8.0 [INFO] [stderr] Checking unix-daemonize v0.1.2 [INFO] [stderr] Checking phf_shared v0.7.22 [INFO] [stderr] Checking unix_socket v0.5.0 [INFO] [stderr] Checking serde_bytes v0.10.4 [INFO] [stderr] Compiling syn v0.14.7 [INFO] [stderr] Checking rmp v0.8.7 [INFO] [stderr] Compiling nvim-gtk v0.2.0 (/opt/crater/workdir) [INFO] [stderr] Checking phf v0.7.22 [INFO] [stderr] Checking env_logger v0.5.12 [INFO] [stderr] Checking rmpv v0.4.0 [INFO] [stderr] Checking glib v0.6.0 [INFO] [stderr] Checking neovim-lib v0.5.4 [INFO] [stderr] Compiling serde_derive v1.0.71 [INFO] [stderr] Checking pango v0.5.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui_model/model_rect.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | top: top, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `top` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui_model/model_rect.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | bot: bot, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui_model/model_rect.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui_model/model_rect.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | right: right, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui_model/model_rect.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | top: top, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `top` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui_model/model_rect.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | bot: bot, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui_model/model_rect.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui_model/model_rect.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | right: right, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/ui_model/model_rect.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | / if cell.attrs.double_width { [INFO] [stderr] 129 | | if right < dw_char_idx { [INFO] [stderr] 130 | | right = dw_char_idx; [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 128 | if cell.attrs.double_width && right < dw_char_idx { [INFO] [stderr] 129 | right = dw_char_idx; [INFO] [stderr] 130 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/ui.rs:381:9 [INFO] [stderr] | [INFO] [stderr] 381 | update_subtitle [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/ui.rs:374:13 [INFO] [stderr] | [INFO] [stderr] 374 | / shell [INFO] [stderr] 375 | | .state [INFO] [stderr] 376 | | .borrow() [INFO] [stderr] 377 | | .subscribe("DirChanged", &["getcwd()"], move |args| { [INFO] [stderr] 378 | | header_bar.set_subtitle(&*args[0]); [INFO] [stderr] 379 | | }); [INFO] [stderr] | |__________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/file_browser.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | file_browser [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/file_browser.rs:84:28 [INFO] [stderr] | [INFO] [stderr] 84 | let file_browser = FileBrowserWidget { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 85 | | store, [INFO] [stderr] 86 | | tree, [INFO] [stderr] 87 | | widget, [INFO] [stderr] ... | [INFO] [stderr] 100 | | })), [INFO] [stderr] 101 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/file_browser.rs:348:12 [INFO] [stderr] | [INFO] [stderr] 348 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 349 | | if lhs_metadata.is_dir() { [INFO] [stderr] 350 | | Ok(Ordering::Less) [INFO] [stderr] 351 | | } else { [INFO] [stderr] 352 | | Ok(Ordering::Greater) [INFO] [stderr] 353 | | } [INFO] [stderr] 354 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 348 | } else if lhs_metadata.is_dir() { [INFO] [stderr] 349 | Ok(Ordering::Less) [INFO] [stderr] 350 | } else { [INFO] [stderr] 351 | Ok(Ordering::Greater) [INFO] [stderr] 352 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/nvim-gtk-3950c752c73cabb0/out/key_map_table.rs:2:10 [INFO] [stderr] | [INFO] [stderr] 2 | key: 9603444721912725599, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_603_444_721_912_725_599` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/nvim/mod.rs:178:12 [INFO] [stderr] | [INFO] [stderr] 178 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 179 | | if let Some(input_data) = input_data { [INFO] [stderr] 180 | | let mut nvim = nvim.borrow().unwrap(); [INFO] [stderr] 181 | | let buf = nvim.get_current_buf().ok_and_report(); [INFO] [stderr] ... | [INFO] [stderr] 192 | | } [INFO] [stderr] 193 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 178 | } else if let Some(input_data) = input_data { [INFO] [stderr] 179 | let mut nvim = nvim.borrow().unwrap(); [INFO] [stderr] 180 | let buf = nvim.get_current_buf().ok_and_report(); [INFO] [stderr] 181 | [INFO] [stderr] 182 | if let Some(buf) = buf { [INFO] [stderr] 183 | buf.set_lines( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/ui_model/model_rect.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | / if cell.attrs.double_width { [INFO] [stderr] 129 | | if right < dw_char_idx { [INFO] [stderr] 130 | | right = dw_char_idx; [INFO] [stderr] 131 | | } [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 128 | if cell.attrs.double_width && right < dw_char_idx { [INFO] [stderr] 129 | right = dw_char_idx; [INFO] [stderr] 130 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/ui.rs:381:9 [INFO] [stderr] | [INFO] [stderr] 381 | update_subtitle [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/ui.rs:374:13 [INFO] [stderr] | [INFO] [stderr] 374 | / shell [INFO] [stderr] 375 | | .state [INFO] [stderr] 376 | | .borrow() [INFO] [stderr] 377 | | .subscribe("DirChanged", &["getcwd()"], move |args| { [INFO] [stderr] 378 | | header_bar.set_subtitle(&*args[0]); [INFO] [stderr] 379 | | }); [INFO] [stderr] | |__________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/file_browser.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | file_browser [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/file_browser.rs:84:28 [INFO] [stderr] | [INFO] [stderr] 84 | let file_browser = FileBrowserWidget { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 85 | | store, [INFO] [stderr] 86 | | tree, [INFO] [stderr] 87 | | widget, [INFO] [stderr] ... | [INFO] [stderr] 100 | | })), [INFO] [stderr] 101 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/file_browser.rs:348:12 [INFO] [stderr] | [INFO] [stderr] 348 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 349 | | if lhs_metadata.is_dir() { [INFO] [stderr] 350 | | Ok(Ordering::Less) [INFO] [stderr] 351 | | } else { [INFO] [stderr] 352 | | Ok(Ordering::Greater) [INFO] [stderr] 353 | | } [INFO] [stderr] 354 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 348 | } else if lhs_metadata.is_dir() { [INFO] [stderr] 349 | Ok(Ordering::Less) [INFO] [stderr] 350 | } else { [INFO] [stderr] 351 | Ok(Ordering::Greater) [INFO] [stderr] 352 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/nvim-gtk-3950c752c73cabb0/out/key_map_table.rs:2:10 [INFO] [stderr] | [INFO] [stderr] 2 | key: 9603444721912725599, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_603_444_721_912_725_599` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/nvim/mod.rs:178:12 [INFO] [stderr] | [INFO] [stderr] 178 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 179 | | if let Some(input_data) = input_data { [INFO] [stderr] 180 | | let mut nvim = nvim.borrow().unwrap(); [INFO] [stderr] 181 | | let buf = nvim.get_current_buf().ok_and_report(); [INFO] [stderr] ... | [INFO] [stderr] 192 | | } [INFO] [stderr] 193 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 178 | } else if let Some(input_data) = input_data { [INFO] [stderr] 179 | let mut nvim = nvim.borrow().unwrap(); [INFO] [stderr] 180 | let buf = nvim.get_current_buf().ok_and_report(); [INFO] [stderr] 181 | [INFO] [stderr] 182 | if let Some(buf) = buf { [INFO] [stderr] 183 | buf.set_lines( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:36:14 [INFO] [stderr] | [INFO] [stderr] 36 | (std::u16::MAX as f64 * self.0) as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(std::u16::MAX)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:37:14 [INFO] [stderr] | [INFO] [stderr] 37 | (std::u16::MAX as f64 * self.1) as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(std::u16::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | (std::u16::MAX as f64 * self.2) as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(std::u16::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/color.rs:73:44 [INFO] [stderr] | [INFO] [stderr] 73 | cell.attrs.background.as_ref().or(Some(&self.bg_color)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(&self.bg_color))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/color.rs:89:44 [INFO] [stderr] | [INFO] [stderr] 89 | cell.attrs.foreground.as_ref().or(Some(&self.fg_color)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(&self.fg_color))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/color.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / pub fn pmenu_bg<'a>(&'a self) -> Color { [INFO] [stderr] 99 | | self.theme [INFO] [stderr] 100 | | .pmenu() [INFO] [stderr] 101 | | .bg [INFO] [stderr] 102 | | .clone() [INFO] [stderr] 103 | | .unwrap_or_else(|| self.bg_color.clone()) [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/ui_model/item.rs:86:12 [INFO] [stderr] | [INFO] [stderr] 86 | if left == 0 && right == 0 && top == 0 && right == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 86 | if left == 0 && right == 0 && top == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 86 | if !(top != 0 || right != 0 || left != 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ui_model/item.rs:90:23 [INFO] [stderr] | [INFO] [stderr] 90 | left: left as f64 / pango::SCALE as f64, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(left)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ui_model/item.rs:90:37 [INFO] [stderr] | [INFO] [stderr] 90 | left: left as f64 / pango::SCALE as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pango::SCALE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ui_model/item.rs:91:24 [INFO] [stderr] | [INFO] [stderr] 91 | right: right as f64 / pango::SCALE as f64, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(right)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ui_model/item.rs:91:39 [INFO] [stderr] | [INFO] [stderr] 91 | right: right as f64 / pango::SCALE as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pango::SCALE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ui_model/item.rs:92:22 [INFO] [stderr] | [INFO] [stderr] 92 | top: top as f64 / pango::SCALE as f64, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(top)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ui_model/item.rs:92:35 [INFO] [stderr] | [INFO] [stderr] 92 | top: top as f64 / pango::SCALE as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pango::SCALE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ui_model/item.rs:93:22 [INFO] [stderr] | [INFO] [stderr] 93 | bot: bot as f64 / pango::SCALE as f64, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(bot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ui_model/item.rs:93:35 [INFO] [stderr] | [INFO] [stderr] 93 | bot: bot as f64 / pango::SCALE as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pango::SCALE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/line.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | target.line[left..right + 1].swap_with_slice(&mut self.line[left..right + 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `left..=right` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/line.rs:34:69 [INFO] [stderr] | [INFO] [stderr] 34 | target.line[left..right + 1].swap_with_slice(&mut self.line[left..right + 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `left..=right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/line.rs:38:38 [INFO] [stderr] | [INFO] [stderr] 38 | for cell in &mut target.line[left..right + 1] { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `left..=right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/line.rs:44:36 [INFO] [stderr] | [INFO] [stderr] 44 | for cell in &mut self.line[left..right + 1] { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `left..=right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/line.rs:93:26 [INFO] [stderr] | [INFO] [stderr] 93 | if self.line[new_item.start_cell..new_item.end_cell + 1] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `new_item.start_cell..=new_item.end_cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/line.rs:151:18 [INFO] [stderr] | [INFO] [stderr] 151 | for i in start_cell..end_cell + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `start_cell..=end_cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/line.rs:155:18 [INFO] [stderr] | [INFO] [stderr] 155 | for i in start_cell + 1..end_cell + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `start_cell + 1..=end_cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/ui_model/model_rect.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | / { [INFO] [stderr] 29 | | return Some(i); [INFO] [stderr] 30 | | } else if rect.in_horizontal(neighbor) && rect.in_vertical(neighbor) { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/ui_model/model_rect.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | / { [INFO] [stderr] 24 | | return Some(i); [INFO] [stderr] 25 | | } else if (neighbor.left > 0 && rect.left == neighbor.left - 1 [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/model_rect.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | for i in self.top..self.bot + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.top..=self.bot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/model_rect.rs:157:20 [INFO] [stderr] | [INFO] [stderr] 157 | for row in self.top..self.bot + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.top..=self.bot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/model_rect.rs:200:20 [INFO] [stderr] | [INFO] [stderr] 200 | for col in self.left..self.right + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.left..=self.right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/mod.rs:128:43 [INFO] [stderr] | [INFO] [stderr] 128 | for (row_idx, line) in self.model[0..to_row + 1].iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `0..=to_row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/mod.rs:159:24 [INFO] [stderr] | [INFO] [stderr] 159 | for row in top..(bot - count + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `top..=bot - count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/mod.rs:163:24 [INFO] [stderr] | [INFO] [stderr] 163 | for row in ((top - count)..(bot + 1)).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((top - count)..=bot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/mod.rs:190:36 [INFO] [stderr] | [INFO] [stderr] 190 | for row in &mut self.model[top..bot + 1] { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `top..=bot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cmd_line.rs:84:18 [INFO] [stderr] | [INFO] [stderr] 84 | content: &Vec, String)>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<(HashMap, String)>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/cmd_line.rs:98:32 [INFO] [stderr] | [INFO] [stderr] 98 | let max_width_chars = (max_width as f64 / char_width) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(max_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/cmd_line.rs:132:6 [INFO] [stderr] | [INFO] [stderr] 132 | ) -> (usize, Vec<(Option, Vec)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/cmd_line.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | / self.levels [INFO] [stderr] 210 | | .get_mut(level - 1) [INFO] [stderr] 211 | | .map(|l| l.set_cursor(render_state, pos)); [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 209 | if let Some(l) = self.levels [INFO] [stderr] 210 | .get_mut(level - 1) { l.set_cursor(render_state, pos) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cmd_line.rs:416:18 [INFO] [stderr] | [INFO] [stderr] 416 | content: &Vec, String)>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<(HashMap, String)>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cmd_line.rs:427:45 [INFO] [stderr] | [INFO] [stderr] 427 | pub fn block_append(&mut self, content: &Vec<(HashMap, String)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(HashMap, String)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/cmd_line.rs:485:46 [INFO] [stderr] | [INFO] [stderr] 485 | let list_store = gtk::ListStore::new(&vec![gtk::Type::String; 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[gtk::Type::String; 1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/cmd_line.rs:532:28 [INFO] [stderr] | [INFO] [stderr] 532 | ctx.translate(0.0, (gap / 2) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(gap / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/cmd_line.rs:545:28 [INFO] [stderr] | [INFO] [stderr] 545 | ctx.translate(0.0, block.preferred_height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(block.preferred_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/cmd_line.rs:592:13 [INFO] [stderr] | [INFO] [stderr] 592 | / content [INFO] [stderr] 593 | | .last_mut() [INFO] [stderr] 594 | | .map(|line| line.extend(content_line.remove(0))); [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 592 | if let Some(line) = content [INFO] [stderr] 593 | .last_mut() { line.extend(content_line.remove(0)) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/file_browser.rs:466:78 [INFO] [stderr] | [INFO] [stderr] 466 | iter.filter(|entry| !entry.file_name().to_string_lossy().starts_with(".")) [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/file_browser.rs:467:76 [INFO] [stderr] | [INFO] [stderr] 467 | .filter(|entry| !entry.file_name().to_string_lossy().ends_with("~")) [INFO] [stderr] | ^^^ help: try using a char instead: `'~'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:36:14 [INFO] [stderr] | [INFO] [stderr] 36 | (std::u16::MAX as f64 * self.0) as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(std::u16::MAX)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:37:14 [INFO] [stderr] | [INFO] [stderr] 37 | (std::u16::MAX as f64 * self.1) as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(std::u16::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/color.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | (std::u16::MAX as f64 * self.2) as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(std::u16::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/misc.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / pub fn escape_filename<'t>(filename: &'t str) -> Cow<'t, str> { [INFO] [stderr] 8 | | lazy_static! { [INFO] [stderr] 9 | | static ref SPECIAL_CHARS: Regex = if cfg!(target_os = "windows") { [INFO] [stderr] 10 | | // On Windows, don't escape `:` and `\`, as these are valid components of the path. [INFO] [stderr] ... | [INFO] [stderr] 17 | | SPECIAL_CHARS.replace_all(&*filename, r"\$0") [INFO] [stderr] 18 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/color.rs:73:44 [INFO] [stderr] | [INFO] [stderr] 73 | cell.attrs.background.as_ref().or(Some(&self.bg_color)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(&self.bg_color))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/color.rs:89:44 [INFO] [stderr] | [INFO] [stderr] 89 | cell.attrs.foreground.as_ref().or(Some(&self.fg_color)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| Some(&self.fg_color))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/misc.rs:32:50 [INFO] [stderr] | [INFO] [stderr] 32 | static ref SLASH: Regex = Regex::new(r"/").unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/color.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / pub fn pmenu_bg<'a>(&'a self) -> Color { [INFO] [stderr] 99 | | self.theme [INFO] [stderr] 100 | | .pmenu() [INFO] [stderr] 101 | | .bg [INFO] [stderr] 102 | | .clone() [INFO] [stderr] 103 | | .unwrap_or_else(|| self.bg_color.clone()) [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/ui_model/item.rs:86:12 [INFO] [stderr] | [INFO] [stderr] 86 | if left == 0 && right == 0 && top == 0 && right == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 86 | if left == 0 && right == 0 && top == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 86 | if !(top != 0 || right != 0 || left != 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ui_model/item.rs:90:23 [INFO] [stderr] | [INFO] [stderr] 90 | left: left as f64 / pango::SCALE as f64, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(left)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ui_model/item.rs:90:37 [INFO] [stderr] | [INFO] [stderr] 90 | left: left as f64 / pango::SCALE as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pango::SCALE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ui_model/item.rs:91:24 [INFO] [stderr] | [INFO] [stderr] 91 | right: right as f64 / pango::SCALE as f64, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(right)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ui_model/item.rs:91:39 [INFO] [stderr] | [INFO] [stderr] 91 | right: right as f64 / pango::SCALE as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pango::SCALE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ui_model/item.rs:92:22 [INFO] [stderr] | [INFO] [stderr] 92 | top: top as f64 / pango::SCALE as f64, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(top)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ui_model/item.rs:92:35 [INFO] [stderr] | [INFO] [stderr] 92 | top: top as f64 / pango::SCALE as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pango::SCALE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ui_model/item.rs:93:22 [INFO] [stderr] | [INFO] [stderr] 93 | bot: bot as f64 / pango::SCALE as f64, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(bot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ui_model/item.rs:93:35 [INFO] [stderr] | [INFO] [stderr] 93 | bot: bot as f64 / pango::SCALE as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pango::SCALE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/line.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | target.line[left..right + 1].swap_with_slice(&mut self.line[left..right + 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `left..=right` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/line.rs:34:69 [INFO] [stderr] | [INFO] [stderr] 34 | target.line[left..right + 1].swap_with_slice(&mut self.line[left..right + 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `left..=right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/line.rs:38:38 [INFO] [stderr] | [INFO] [stderr] 38 | for cell in &mut target.line[left..right + 1] { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `left..=right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/line.rs:44:36 [INFO] [stderr] | [INFO] [stderr] 44 | for cell in &mut self.line[left..right + 1] { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `left..=right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/line.rs:93:26 [INFO] [stderr] | [INFO] [stderr] 93 | if self.line[new_item.start_cell..new_item.end_cell + 1] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `new_item.start_cell..=new_item.end_cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/line.rs:151:18 [INFO] [stderr] | [INFO] [stderr] 151 | for i in start_cell..end_cell + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `start_cell..=end_cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/line.rs:155:18 [INFO] [stderr] | [INFO] [stderr] 155 | for i in start_cell + 1..end_cell + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `start_cell + 1..=end_cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/ui_model/model_rect.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | / { [INFO] [stderr] 29 | | return Some(i); [INFO] [stderr] 30 | | } else if rect.in_horizontal(neighbor) && rect.in_vertical(neighbor) { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/nvim/redraw_handler.rs:159:51 [INFO] [stderr] | [INFO] [stderr] 159 | try_str!(args.get(1).cloned().unwrap_or("1.0".into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "1.0".into())` [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] note: same as this [INFO] [stderr] --> src/ui_model/model_rect.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | / { [INFO] [stderr] 24 | | return Some(i); [INFO] [stderr] 25 | | } else if (neighbor.left > 0 && rect.left == neighbor.left - 1 [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/nvim/redraw_handler.rs:162:51 [INFO] [stderr] | [INFO] [stderr] 162 | try_str!(args.get(2).cloned().unwrap_or("1.0".into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "1.0".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/nvim/redraw_handler.rs:167:81 [INFO] [stderr] | [INFO] [stderr] 167 | let prefer_dark_theme = match try_str!(args.get(1).cloned().unwrap_or(Value::from("off"))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Value::from("off"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/nvim/redraw_handler.rs:185:11 [INFO] [stderr] | [INFO] [stderr] 185 | args: &Vec, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Value]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/model_rect.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | for i in self.top..self.bot + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.top..=self.bot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/nvim/redraw_handler.rs:201:70 [INFO] [stderr] | [INFO] [stderr] 201 | let t = clipboard.wait_for_text().unwrap_or_else(|| String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/nvim/redraw_handler.rs:203:33 [INFO] [stderr] | [INFO] [stderr] 203 | t.split("\n").map(|s| s.into()).collect::>(), [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/model_rect.rs:157:20 [INFO] [stderr] | [INFO] [stderr] 157 | for row in self.top..self.bot + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.top..=self.bot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/model_rect.rs:200:20 [INFO] [stderr] | [INFO] [stderr] 200 | for col in self.left..self.right + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.left..=self.right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/mod.rs:128:43 [INFO] [stderr] | [INFO] [stderr] 128 | for (row_idx, line) in self.model[0..to_row + 1].iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `0..=to_row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/mod.rs:159:24 [INFO] [stderr] | [INFO] [stderr] 159 | for row in top..(bot - count + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `top..=bot - count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/mod.rs:163:24 [INFO] [stderr] | [INFO] [stderr] 163 | for row in ((top - count)..(bot + 1)).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((top - count)..=bot)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ui_model/mod.rs:190:36 [INFO] [stderr] | [INFO] [stderr] 190 | for row in &mut self.model[top..bot + 1] { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `top..=bot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cmd_line.rs:84:18 [INFO] [stderr] | [INFO] [stderr] 84 | content: &Vec, String)>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<(HashMap, String)>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/cmd_line.rs:98:32 [INFO] [stderr] | [INFO] [stderr] 98 | let max_width_chars = (max_width as f64 / char_width) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(max_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/cmd_line.rs:132:6 [INFO] [stderr] | [INFO] [stderr] 132 | ) -> (usize, Vec<(Option, Vec)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/cmd_line.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | / self.levels [INFO] [stderr] 210 | | .get_mut(level - 1) [INFO] [stderr] 211 | | .map(|l| l.set_cursor(render_state, pos)); [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 209 | if let Some(l) = self.levels [INFO] [stderr] 210 | .get_mut(level - 1) { l.set_cursor(render_state, pos) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cmd_line.rs:416:18 [INFO] [stderr] | [INFO] [stderr] 416 | content: &Vec, String)>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<(HashMap, String)>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cmd_line.rs:427:45 [INFO] [stderr] | [INFO] [stderr] 427 | pub fn block_append(&mut self, content: &Vec<(HashMap, String)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(HashMap, String)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/cmd_line.rs:485:46 [INFO] [stderr] | [INFO] [stderr] 485 | let list_store = gtk::ListStore::new(&vec![gtk::Type::String; 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[gtk::Type::String; 1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/cmd_line.rs:532:28 [INFO] [stderr] | [INFO] [stderr] 532 | ctx.translate(0.0, (gap / 2) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(gap / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/cmd_line.rs:545:28 [INFO] [stderr] | [INFO] [stderr] 545 | ctx.translate(0.0, block.preferred_height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(block.preferred_height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/cmd_line.rs:592:13 [INFO] [stderr] | [INFO] [stderr] 592 | / content [INFO] [stderr] 593 | | .last_mut() [INFO] [stderr] 594 | | .map(|line| line.extend(content_line.remove(0))); [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 592 | if let Some(line) = content [INFO] [stderr] 593 | .last_mut() { line.extend(content_line.remove(0)) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/cursor.rs:334:9 [INFO] [stderr] | [INFO] [stderr] 334 | assert_eq!(line_y + line_height - line_height / 4.0, y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/cursor.rs:334:9 [INFO] [stderr] | [INFO] [stderr] 334 | assert_eq!(line_y + line_height - line_height / 4.0, y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/cursor.rs:335:9 [INFO] [stderr] | [INFO] [stderr] 335 | assert_eq!(char_width, width); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/cursor.rs:335:9 [INFO] [stderr] | [INFO] [stderr] 335 | assert_eq!(char_width, width); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/cursor.rs:336:9 [INFO] [stderr] | [INFO] [stderr] 336 | assert_eq!(line_height / 4.0, height); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/cursor.rs:336:9 [INFO] [stderr] | [INFO] [stderr] 336 | assert_eq!(line_height / 4.0, height); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/cursor.rs:356:9 [INFO] [stderr] | [INFO] [stderr] 356 | assert_eq!(line_y + line_height - line_height / 4.0, y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/plug_manager/ui.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | add_plug_btn.get_style_context().map(|c| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 47 | || c.add_class("suggested-action") [INFO] [stderr] 48 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(c) = add_plug_btn.get_style_context() { c.add_class("suggested-action") }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/cursor.rs:356:9 [INFO] [stderr] | [INFO] [stderr] 356 | assert_eq!(line_y + line_height - line_height / 4.0, y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/cursor.rs:357:9 [INFO] [stderr] | [INFO] [stderr] 357 | assert_eq!(char_width * 2.0, width); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/cursor.rs:357:9 [INFO] [stderr] | [INFO] [stderr] 357 | assert_eq!(char_width * 2.0, width); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/cursor.rs:358:9 [INFO] [stderr] | [INFO] [stderr] 358 | assert_eq!(line_height / 4.0, height); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/cursor.rs:358:9 [INFO] [stderr] | [INFO] [stderr] 358 | assert_eq!(line_height / 4.0, height); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/plug_manager/ui.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | scroll.get_style_context().map(|c| c.add_class("view")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(c) = scroll.get_style_context() { c.add_class("view") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/cursor.rs:378:9 [INFO] [stderr] | [INFO] [stderr] 378 | assert_eq!(line_y, y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/cursor.rs:378:9 [INFO] [stderr] | [INFO] [stderr] 378 | assert_eq!(line_y, y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/cursor.rs:379:9 [INFO] [stderr] | [INFO] [stderr] 379 | assert_eq!(char_width / 4.0, width); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/cursor.rs:379:9 [INFO] [stderr] | [INFO] [stderr] 379 | assert_eq!(char_width / 4.0, width); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/cursor.rs:380:9 [INFO] [stderr] | [INFO] [stderr] 380 | assert_eq!(line_height, height); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/cursor.rs:380:9 [INFO] [stderr] | [INFO] [stderr] 380 | assert_eq!(line_height, height); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/plug_manager/ui.rs:393:9 [INFO] [stderr] | [INFO] [stderr] 393 | categories.get_style_context().map(|c| c.add_class("view")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(c) = categories.get_style_context() { c.add_class("view") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/plug_manager/ui.rs:403:49 [INFO] [stderr] | [INFO] [stderr] 403 | clone!(stack, rows => move |_, row| if let &Some(ref row) = row { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 404 | | if let Some(ref r) = rows.borrow().iter().find(|r| r.0 == *row) { [INFO] [stderr] 405 | | if let Some(child) = stack.get_child_by_name(&r.1) { [INFO] [stderr] 406 | | stack.set_visible_child(&child); [INFO] [stderr] ... | [INFO] [stderr] 410 | | } [INFO] [stderr] 411 | | }), [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 403 | clone!(stack, rows => move |_, row| if let Some(ref row) = *row { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/plug_manager/vim_plug.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | .ok_or("Can't retrive g:plugs map".to_owned())? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Can't retrive g:plugs map".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/plug_manager/vim_plug.rs:38:54 [INFO] [stderr] | [INFO] [stderr] 38 | let order_arr = g_plugs_order.as_array().ok_or( [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 39 | | "Can't find g:plugs_order array" [INFO] [stderr] 40 | | .to_owned(), [INFO] [stderr] 41 | | )?; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | let order_arr = g_plugs_order.as_array().ok_or_else(|| "Can't find g:plugs_order array" [INFO] [stderr] 39 | .to_owned())?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/plug_manager/vim_plug.rs:75:46 [INFO] [stderr] | [INFO] [stderr] 75 | .map_or(false, |loaded_plug| if loaded_plug > 0 { [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 76 | | true [INFO] [stderr] 77 | | } else { [INFO] [stderr] 78 | | false [INFO] [stderr] 79 | | }) [INFO] [stderr] | |_________________^ help: you can reduce it to: `loaded_plug > 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/file_browser.rs:466:78 [INFO] [stderr] | [INFO] [stderr] 466 | iter.filter(|entry| !entry.file_name().to_string_lossy().starts_with(".")) [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/file_browser.rs:467:76 [INFO] [stderr] | [INFO] [stderr] 467 | .filter(|entry| !entry.file_name().to_string_lossy().ends_with("~")) [INFO] [stderr] | ^^^ help: try using a char instead: `'~'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/plug_manager/store.rs:68:47 [INFO] [stderr] | [INFO] [stderr] 68 | if self.settings.plugs.iter().any(|p| { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 69 | | p.get_plug_path() == path || p.name == plug.name [INFO] [stderr] 70 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/misc.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / pub fn escape_filename<'t>(filename: &'t str) -> Cow<'t, str> { [INFO] [stderr] 8 | | lazy_static! { [INFO] [stderr] 9 | | static ref SPECIAL_CHARS: Regex = if cfg!(target_os = "windows") { [INFO] [stderr] 10 | | // On Windows, don't escape `:` and `\`, as these are valid components of the path. [INFO] [stderr] ... | [INFO] [stderr] 17 | | SPECIAL_CHARS.replace_all(&*filename, r"\$0") [INFO] [stderr] 18 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/misc.rs:32:50 [INFO] [stderr] | [INFO] [stderr] 32 | static ref SLASH: Regex = Regex::new(r"/").unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/nvim/redraw_handler.rs:159:51 [INFO] [stderr] | [INFO] [stderr] 159 | try_str!(args.get(1).cloned().unwrap_or("1.0".into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "1.0".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/nvim/redraw_handler.rs:162:51 [INFO] [stderr] | [INFO] [stderr] 162 | try_str!(args.get(2).cloned().unwrap_or("1.0".into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "1.0".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/nvim/redraw_handler.rs:167:81 [INFO] [stderr] | [INFO] [stderr] 167 | let prefer_dark_theme = match try_str!(args.get(1).cloned().unwrap_or(Value::from("off"))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Value::from("off"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/plug_manager/vimawesome.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | scroll.get_style_context().map(|c| c.add_class("view")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(c) = scroll.get_style_context() { c.add_class("view") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/nvim/redraw_handler.rs:185:11 [INFO] [stderr] | [INFO] [stderr] 185 | args: &Vec, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Value]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/nvim/redraw_handler.rs:201:70 [INFO] [stderr] | [INFO] [stderr] 201 | let t = clipboard.wait_for_text().unwrap_or_else(|| String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/nvim/redraw_handler.rs:203:33 [INFO] [stderr] | [INFO] [stderr] 203 | t.split("\n").map(|s| s.into()).collect::>(), [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/popup_menu.rs:101:27 [INFO] [stderr] | [INFO] [stderr] 101 | let kind_exists = ctx.menu_items.iter().find(|i| i.kind.len() > 0).is_some(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|i| i.kind.len() > 0).is_some()` with `any(|i| i.kind.len() > 0)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/popup_menu.rs:101:58 [INFO] [stderr] | [INFO] [stderr] 101 | let kind_exists = ctx.menu_items.iter().find(|i| i.kind.len() > 0).is_some(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!i.kind.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/popup_menu.rs:128:12 [INFO] [stderr] | [INFO] [stderr] 128 | if max_menu_line.menu.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!max_menu_line.menu.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/popup_menu.rs:155:46 [INFO] [stderr] | [INFO] [stderr] 155 | let list_store = gtk::ListStore::new(&vec![gtk::Type::String; 4]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[gtk::Type::String; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/popup_menu.rs:377:5 [INFO] [stderr] | [INFO] [stderr] 377 | / match gtk::CssProviderExt::load_from_data( [INFO] [stderr] 378 | | css_provider, [INFO] [stderr] 379 | | &format!( [INFO] [stderr] 380 | | ".view :selected {{ color: {}; background-color: {};}}\n [INFO] [stderr] ... | [INFO] [stderr] 388 | | Ok(_) => (), [INFO] [stderr] 389 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 377 | if let Err(e) = gtk::CssProviderExt::load_from_data( [INFO] [stderr] 378 | css_provider, [INFO] [stderr] 379 | &format!( [INFO] [stderr] 380 | ".view :selected {{ color: {}; background-color: {};}}\n [INFO] [stderr] 381 | .view {{ background-color: {}; }}", [INFO] [stderr] 382 | fg.to_hex(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/project.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | self.store.take().map(|s| s.save()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(s) = self.store.take() { s.save() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/plug_manager/ui.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | add_plug_btn.get_style_context().map(|c| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 47 | || c.add_class("suggested-action") [INFO] [stderr] 48 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(c) = add_plug_btn.get_style_context() { c.add_class("suggested-action") }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/plug_manager/ui.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | scroll.get_style_context().map(|c| c.add_class("view")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(c) = scroll.get_style_context() { c.add_class("view") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/plug_manager/ui.rs:393:9 [INFO] [stderr] | [INFO] [stderr] 393 | categories.get_style_context().map(|c| c.add_class("view")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(c) = categories.get_style_context() { c.add_class("view") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/plug_manager/ui.rs:403:49 [INFO] [stderr] | [INFO] [stderr] 403 | clone!(stack, rows => move |_, row| if let &Some(ref row) = row { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 404 | | if let Some(ref r) = rows.borrow().iter().find(|r| r.0 == *row) { [INFO] [stderr] 405 | | if let Some(child) = stack.get_child_by_name(&r.1) { [INFO] [stderr] 406 | | stack.set_visible_child(&child); [INFO] [stderr] ... | [INFO] [stderr] 410 | | } [INFO] [stderr] 411 | | }), [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 403 | clone!(stack, rows => move |_, row| if let Some(ref row) = *row { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/plug_manager/vim_plug.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | .ok_or("Can't retrive g:plugs map".to_owned())? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Can't retrive g:plugs map".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/plug_manager/vim_plug.rs:38:54 [INFO] [stderr] | [INFO] [stderr] 38 | let order_arr = g_plugs_order.as_array().ok_or( [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 39 | | "Can't find g:plugs_order array" [INFO] [stderr] 40 | | .to_owned(), [INFO] [stderr] 41 | | )?; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | let order_arr = g_plugs_order.as_array().ok_or_else(|| "Can't find g:plugs_order array" [INFO] [stderr] 39 | .to_owned())?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/plug_manager/vim_plug.rs:75:46 [INFO] [stderr] | [INFO] [stderr] 75 | .map_or(false, |loaded_plug| if loaded_plug > 0 { [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 76 | | true [INFO] [stderr] 77 | | } else { [INFO] [stderr] 78 | | false [INFO] [stderr] 79 | | }) [INFO] [stderr] | |_________________^ help: you can reduce it to: `loaded_plug > 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/plug_manager/store.rs:68:47 [INFO] [stderr] | [INFO] [stderr] 68 | if self.settings.plugs.iter().any(|p| { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 69 | | p.get_plug_path() == path || p.name == plug.name [INFO] [stderr] 70 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/plug_manager/vimawesome.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | scroll.get_style_context().map(|c| c.add_class("view")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(c) = scroll.get_style_context() { c.add_class("view") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/render/model_clip_iterator.rs:102:31 [INFO] [stderr] | [INFO] [stderr] 102 | model_iter: model[model_clip_top..model_clip_bot + 1].iter(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `model_clip_top..=model_clip_bot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/popup_menu.rs:101:27 [INFO] [stderr] | [INFO] [stderr] 101 | let kind_exists = ctx.menu_items.iter().find(|i| i.kind.len() > 0).is_some(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|i| i.kind.len() > 0).is_some()` with `any(|i| i.kind.len() > 0)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/popup_menu.rs:101:58 [INFO] [stderr] | [INFO] [stderr] 101 | let kind_exists = ctx.menu_items.iter().find(|i| i.kind.len() > 0).is_some(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!i.kind.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/popup_menu.rs:128:12 [INFO] [stderr] | [INFO] [stderr] 128 | if max_menu_line.menu.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!max_menu_line.menu.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/popup_menu.rs:155:46 [INFO] [stderr] | [INFO] [stderr] 155 | let list_store = gtk::ListStore::new(&vec![gtk::Type::String; 4]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[gtk::Type::String; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/popup_menu.rs:377:5 [INFO] [stderr] | [INFO] [stderr] 377 | / match gtk::CssProviderExt::load_from_data( [INFO] [stderr] 378 | | css_provider, [INFO] [stderr] 379 | | &format!( [INFO] [stderr] 380 | | ".view :selected {{ color: {}; background-color: {};}}\n [INFO] [stderr] ... | [INFO] [stderr] 388 | | Ok(_) => (), [INFO] [stderr] 389 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 377 | if let Err(e) = gtk::CssProviderExt::load_from_data( [INFO] [stderr] 378 | css_provider, [INFO] [stderr] 379 | &format!( [INFO] [stderr] 380 | ".view :selected {{ color: {}; background-color: {};}}\n [INFO] [stderr] 381 | .view {{ background-color: {}; }}", [INFO] [stderr] 382 | fg.to_hex(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/project.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | self.store.take().map(|s| s.save()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(s) = self.store.take() { s.save() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/shell.rs:398:14 [INFO] [stderr] | [INFO] [stderr] 398 | (alloc.width as f64 / char_width).trunc() as usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(alloc.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/shell.rs:399:14 [INFO] [stderr] | [INFO] [stderr] 399 | (alloc.height as f64 / line_height).trunc() as usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(alloc.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/render/model_clip_iterator.rs:102:31 [INFO] [stderr] | [INFO] [stderr] 102 | model_iter: model[model_clip_top..model_clip_bot + 1].iter(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `model_clip_top..=model_clip_bot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/shell.rs:1253:13 [INFO] [stderr] | [INFO] [stderr] 1253 | let x = alloc.width as f64 / 2.0 - width as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(alloc.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/shell.rs:1253:40 [INFO] [stderr] | [INFO] [stderr] 1253 | let x = alloc.width as f64 / 2.0 - width as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/shell.rs:1254:13 [INFO] [stderr] | [INFO] [stderr] 1254 | let y = alloc.height as f64 / 2.0 - height as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(alloc.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/shell.rs:1254:41 [INFO] [stderr] | [INFO] [stderr] 1254 | let y = alloc.height as f64 / 2.0 - height as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/shell.rs:1265:21 [INFO] [stderr] | [INFO] [stderr] 1265 | ctx.move_to(x + width as f64, y); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/shell.rs:398:14 [INFO] [stderr] | [INFO] [stderr] 398 | (alloc.width as f64 / char_width).trunc() as usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(alloc.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/shell.rs:399:14 [INFO] [stderr] | [INFO] [stderr] 399 | (alloc.height as f64 / line_height).trunc() as usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(alloc.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/shell.rs:1253:13 [INFO] [stderr] | [INFO] [stderr] 1253 | let x = alloc.width as f64 / 2.0 - width as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(alloc.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/shell.rs:1253:40 [INFO] [stderr] | [INFO] [stderr] 1253 | let x = alloc.width as f64 / 2.0 - width as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/shell.rs:1254:13 [INFO] [stderr] | [INFO] [stderr] 1254 | let y = alloc.height as f64 / 2.0 - height as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(alloc.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/shell.rs:1254:41 [INFO] [stderr] | [INFO] [stderr] 1254 | let y = alloc.height as f64 / 2.0 - height as f64 / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/shell.rs:1265:21 [INFO] [stderr] | [INFO] [stderr] 1265 | ctx.move_to(x + width as f64, y); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/subscriptions.rs:74:57 [INFO] [stderr] | [INFO] [stderr] 74 | let entry = self.0.entry(event_name.to_owned()).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/subscriptions.rs:78:24 [INFO] [stderr] | [INFO] [stderr] 78 | args: args.into_iter().map(|&s| s.to_owned()).collect(), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/subscriptions.rs:140:29 [INFO] [stderr] | [INFO] [stderr] 140 | let subscription = &self.0.get(&handle.event_name).unwrap()[handle.index]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.0[&handle.event_name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/subscriptions.rs:74:57 [INFO] [stderr] | [INFO] [stderr] 74 | let entry = self.0.entry(event_name.to_owned()).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/subscriptions.rs:78:24 [INFO] [stderr] | [INFO] [stderr] 78 | args: args.into_iter().map(|&s| s.to_owned()).collect(), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/subscriptions.rs:140:29 [INFO] [stderr] | [INFO] [stderr] 140 | let subscription = &self.0.get(&handle.event_name).unwrap()[handle.index]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.0[&handle.event_name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:149:10 [INFO] [stderr] | [INFO] [stderr] 149 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:149:10 [INFO] [stderr] | [INFO] [stderr] 149 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:196:14 [INFO] [stderr] | [INFO] [stderr] 196 | .map(|timeout| Duration::from_secs(timeout)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Duration::from_secs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:196:14 [INFO] [stderr] | [INFO] [stderr] 196 | .map(|timeout| Duration::from_secs(timeout)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Duration::from_secs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to 10 previous errors [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `nvim-gtk`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `nvim-gtk`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5552d936b8724abede1a75c82d72dde9df8849eb9ecb1260a16bd98307166fcb"` [INFO] running `"docker" "rm" "-f" "5552d936b8724abede1a75c82d72dde9df8849eb9ecb1260a16bd98307166fcb"` [INFO] [stdout] 5552d936b8724abede1a75c82d72dde9df8849eb9ecb1260a16bd98307166fcb