[INFO] updating cached repository katam-rando-dev/katam-randomizer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/katam-rando-dev/katam-randomizer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/katam-rando-dev/katam-randomizer" "work/ex/clippy-test-run/sources/stable/gh/katam-rando-dev/katam-randomizer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/katam-rando-dev/katam-randomizer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/katam-rando-dev/katam-randomizer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/katam-rando-dev/katam-randomizer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/katam-rando-dev/katam-randomizer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 32edba75a3fa80cc3e8f7e935fa5485d71bcbdc0 [INFO] sha for GitHub repo katam-rando-dev/katam-randomizer: 32edba75a3fa80cc3e8f7e935fa5485d71bcbdc0 [INFO] validating manifest of katam-rando-dev/katam-randomizer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of katam-rando-dev/katam-randomizer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing katam-rando-dev/katam-randomizer [INFO] finished frobbing katam-rando-dev/katam-randomizer [INFO] frobbed toml for katam-rando-dev/katam-randomizer written to work/ex/clippy-test-run/sources/stable/gh/katam-rando-dev/katam-randomizer/Cargo.toml [INFO] started frobbing katam-rando-dev/katam-randomizer [INFO] finished frobbing katam-rando-dev/katam-randomizer [INFO] frobbed toml for katam-rando-dev/katam-randomizer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/katam-rando-dev/katam-randomizer/Cargo.toml [INFO] crate katam-rando-dev/katam-randomizer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting katam-rando-dev/katam-randomizer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/katam-rando-dev/katam-randomizer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 39fda7c54d176d9e5020a8c7502f2c2ac56eb089e0b1e38ad7193af8b355e57b [INFO] running `"docker" "start" "-a" "39fda7c54d176d9e5020a8c7502f2c2ac56eb089e0b1e38ad7193af8b355e57b"` [INFO] [stderr] Checking serde v1.0.32 [INFO] [stderr] Checking bidir-map v1.0.0 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Compiling serde_derive_internals v0.20.1 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Compiling serde_derive v1.0.32 [INFO] [stderr] Checking csv v1.0.0-beta.5 [INFO] [stderr] Checking katam-rando v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/csv_loader.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | one_way_entrances: one_way_entrances, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `one_way_entrances` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/csv_loader.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | two_way_entrances: two_way_entrances, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `two_way_entrances` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/csv_loader.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | one_way_exits: one_way_exits, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `one_way_exits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/csv_loader.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | two_way_exits: two_way_exits [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `two_way_exits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rom.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | buffer: buffer [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/csv_loader.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | one_way_entrances: one_way_entrances, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `one_way_entrances` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/csv_loader.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | two_way_entrances: two_way_entrances, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `two_way_entrances` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/csv_loader.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | one_way_exits: one_way_exits, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `one_way_exits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/csv_loader.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | two_way_exits: two_way_exits [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `two_way_exits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rom.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | buffer: buffer [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:54:42 [INFO] [stderr] | [INFO] [stderr] 54 | one_way_exits: vec![Exit::new(0, 0x873450, 0x930E04, ExitType::OneWay, -1)], [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0087_3450` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:54:52 [INFO] [stderr] | [INFO] [stderr] 54 | one_way_exits: vec![Exit::new(0, 0x873450, 0x930E04, ExitType::OneWay, -1)], [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0093_0E04` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:54:42 [INFO] [stderr] | [INFO] [stderr] 54 | one_way_exits: vec![Exit::new(0, 0x873450, 0x930E04, ExitType::OneWay, -1)], [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0087_3450` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:54:52 [INFO] [stderr] | [INFO] [stderr] 54 | one_way_exits: vec![Exit::new(0, 0x873450, 0x930E04, ExitType::OneWay, -1)], [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0093_0E04` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/shuffler.rs:4:27 [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Copy, Clone, Eq, Hash, Debug)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/shuffler.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10| / impl PartialEq for Destination { [INFO] [stderr] 11| | fn eq(&self, other: &Destination) -> bool { [INFO] [stderr] 12| | self.id == other.id [INFO] [stderr] 13| | } [INFO] [stderr] 14| | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/shuffler.rs:25:27 [INFO] [stderr] | [INFO] [stderr] 25 | #[derive(Copy, Clone, Eq, Hash, Debug)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/shuffler.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | / impl PartialEq for Exit { [INFO] [stderr] 35 | | fn eq(&self, other: &Exit) -> bool { [INFO] [stderr] 36 | | self.id == other.id [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/shuffler.rs:98:47 [INFO] [stderr] | [INFO] [stderr] 98 | let mut unselected_rooms: Vec = all_rooms.iter().filter(|&room| *room != first_room).map(|room| room.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `all_rooms.iter().filter(|&room| *room != first_room).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/shuffler.rs:99:36 [INFO] [stderr] | [INFO] [stderr] 99 | let mut exits: Vec = first_room.one_way_exits.iter().chain(first_room.two_way_exits.iter()).map(|&exit| exit).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `first_room.one_way_exits.iter().chain(first_room.two_way_exits.iter()).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/shuffler.rs:109:51 [INFO] [stderr] | [INFO] [stderr] 109 | let new_unselected_rooms: Vec = unselected_rooms.iter().filter(|&room| *room != selected_room).map(|room| room.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `unselected_rooms.iter().filter(|&room| *room != selected_room).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/shuffler.rs:120:29 [INFO] [stderr] | [INFO] [stderr] 120 | let one_way_exits = exits.iter() [INFO] [stderr] | _____________________________^ [INFO] [stderr] 121 | | .filter(|&exit| exit.exit_type == ExitType::OneWay) [INFO] [stderr] 122 | | .map(|&exit| exit) [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 120 | let one_way_exits = exits.iter() [INFO] [stderr] 121 | .filter(|&exit| exit.exit_type == ExitType::OneWay).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/shuffler.rs:125:29 [INFO] [stderr] | [INFO] [stderr] 125 | let two_way_exits = exits.iter() [INFO] [stderr] | _____________________________^ [INFO] [stderr] 126 | | .filter(|&exit| exit.exit_type == ExitType::TwoWay) [INFO] [stderr] 127 | | .map(|&exit| exit) [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 125 | let two_way_exits = exits.iter() [INFO] [stderr] 126 | .filter(|&exit| exit.exit_type == ExitType::TwoWay).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/shuffler.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | exits.iter().filter(|&&exit| exit != selected_exit).chain(remaining_exits).map(|&exit| exit).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `exits.iter().filter(|&&exit| exit != selected_exit).chain(remaining_exits).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/shuffler.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | exits.iter().filter(|&exit| exit.exit_type == exit_type).map(|&exit| exit).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `exits.iter().filter(|&exit| exit.exit_type == exit_type).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/shuffler.rs:200:60 [INFO] [stderr] | [INFO] [stderr] 200 | let leftover_one_way_entrances: Vec = selected_room.one_way_entrances.iter() [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 201 | | .filter(|&room_entrance| room_entrance != entrance) [INFO] [stderr] 202 | | .map(|&entrance| entrance) [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 200 | let leftover_one_way_entrances: Vec = selected_room.one_way_entrances.iter() [INFO] [stderr] 201 | .filter(|&room_entrance| room_entrance != entrance).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/shuffler.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | selected_room.one_way_exits.iter().chain(selected_room.two_way_exits.iter()).map(|&exit| exit).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `selected_room.one_way_exits.iter().chain(selected_room.two_way_exits.iter()).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/shuffler.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | selected_room.one_way_exits.iter().chain(two_way_exits).map(|&exit| exit).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `selected_room.one_way_exits.iter().chain(two_way_exits).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/shuffler.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | / unselected_rooms.iter() [INFO] [stderr] 228 | | .filter(|&room| self.room_does_not_block_full_access(room, exits, unselected_rooms) && self.room_has_matching_entrance(room, exits)) [INFO] [stderr] 229 | | .map(|room| room.clone()) [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 227 | unselected_rooms.iter() [INFO] [stderr] 228 | .filter(|&room| self.room_does_not_block_full_access(room, exits, unselected_rooms) && self.room_has_matching_entrance(room, exits)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/shuffler.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | / .collect::>() [INFO] [stderr] 283 | | .len(); [INFO] [stderr] | |__________________^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/shuffler.rs:286:13 [INFO] [stderr] | [INFO] [stderr] 286 | / .collect::>() [INFO] [stderr] 287 | | .len(); [INFO] [stderr] | |__________________^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/csv_loader.rs:69:67 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn load_rooms>(&self, path: P, door_table: &DoorTable) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | / match exit.exit_type { [INFO] [stderr] 36 | | ExitType::TwoWay => { [INFO] [stderr] 37 | | let option_linked_record = &door_table[exit.linked_door_id as usize]; [INFO] [stderr] 38 | | if let Some(ref linked_record) = *option_linked_record { [INFO] [stderr] ... | [INFO] [stderr] 44 | | _ => () [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | if let ExitType::TwoWay = exit.exit_type { [INFO] [stderr] 36 | let option_linked_record = &door_table[exit.linked_door_id as usize]; [INFO] [stderr] 37 | if let Some(ref linked_record) = *option_linked_record { [INFO] [stderr] 38 | let linked_destination = linked_record.extract_destination(); [INFO] [stderr] 39 | let linked_exit = linked_record.extract_exit(); [INFO] [stderr] 40 | original_links.insert(Door(destination, exit), Door(linked_destination, linked_exit)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `katam-rando`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/shuffler.rs:4:27 [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Copy, Clone, Eq, Hash, Debug)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/shuffler.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10| / impl PartialEq for Destination { [INFO] [stderr] 11| | fn eq(&self, other: &Destination) -> bool { [INFO] [stderr] 12| | self.id == other.id [INFO] [stderr] 13| | } [INFO] [stderr] 14| | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/shuffler.rs:25:27 [INFO] [stderr] | [INFO] [stderr] 25 | #[derive(Copy, Clone, Eq, Hash, Debug)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/shuffler.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | / impl PartialEq for Exit { [INFO] [stderr] 35 | | fn eq(&self, other: &Exit) -> bool { [INFO] [stderr] 36 | | self.id == other.id [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/shuffler.rs:98:47 [INFO] [stderr] | [INFO] [stderr] 98 | let mut unselected_rooms: Vec = all_rooms.iter().filter(|&room| *room != first_room).map(|room| room.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `all_rooms.iter().filter(|&room| *room != first_room).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/shuffler.rs:99:36 [INFO] [stderr] | [INFO] [stderr] 99 | let mut exits: Vec = first_room.one_way_exits.iter().chain(first_room.two_way_exits.iter()).map(|&exit| exit).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `first_room.one_way_exits.iter().chain(first_room.two_way_exits.iter()).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/shuffler.rs:109:51 [INFO] [stderr] | [INFO] [stderr] 109 | let new_unselected_rooms: Vec = unselected_rooms.iter().filter(|&room| *room != selected_room).map(|room| room.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `unselected_rooms.iter().filter(|&room| *room != selected_room).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/shuffler.rs:120:29 [INFO] [stderr] | [INFO] [stderr] 120 | let one_way_exits = exits.iter() [INFO] [stderr] | _____________________________^ [INFO] [stderr] 121 | | .filter(|&exit| exit.exit_type == ExitType::OneWay) [INFO] [stderr] 122 | | .map(|&exit| exit) [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 120 | let one_way_exits = exits.iter() [INFO] [stderr] 121 | .filter(|&exit| exit.exit_type == ExitType::OneWay).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/shuffler.rs:125:29 [INFO] [stderr] | [INFO] [stderr] 125 | let two_way_exits = exits.iter() [INFO] [stderr] | _____________________________^ [INFO] [stderr] 126 | | .filter(|&exit| exit.exit_type == ExitType::TwoWay) [INFO] [stderr] 127 | | .map(|&exit| exit) [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 125 | let two_way_exits = exits.iter() [INFO] [stderr] 126 | .filter(|&exit| exit.exit_type == ExitType::TwoWay).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/shuffler.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | exits.iter().filter(|&&exit| exit != selected_exit).chain(remaining_exits).map(|&exit| exit).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `exits.iter().filter(|&&exit| exit != selected_exit).chain(remaining_exits).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/shuffler.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | exits.iter().filter(|&exit| exit.exit_type == exit_type).map(|&exit| exit).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `exits.iter().filter(|&exit| exit.exit_type == exit_type).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/shuffler.rs:200:60 [INFO] [stderr] | [INFO] [stderr] 200 | let leftover_one_way_entrances: Vec = selected_room.one_way_entrances.iter() [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 201 | | .filter(|&room_entrance| room_entrance != entrance) [INFO] [stderr] 202 | | .map(|&entrance| entrance) [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 200 | let leftover_one_way_entrances: Vec = selected_room.one_way_entrances.iter() [INFO] [stderr] 201 | .filter(|&room_entrance| room_entrance != entrance).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/shuffler.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | selected_room.one_way_exits.iter().chain(selected_room.two_way_exits.iter()).map(|&exit| exit).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `selected_room.one_way_exits.iter().chain(selected_room.two_way_exits.iter()).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/shuffler.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | selected_room.one_way_exits.iter().chain(two_way_exits).map(|&exit| exit).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `selected_room.one_way_exits.iter().chain(two_way_exits).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/shuffler.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | / unselected_rooms.iter() [INFO] [stderr] 228 | | .filter(|&room| self.room_does_not_block_full_access(room, exits, unselected_rooms) && self.room_has_matching_entrance(room, exits)) [INFO] [stderr] 229 | | .map(|room| room.clone()) [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 227 | unselected_rooms.iter() [INFO] [stderr] 228 | .filter(|&room| self.room_does_not_block_full_access(room, exits, unselected_rooms) && self.room_has_matching_entrance(room, exits)).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/shuffler.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | / .collect::>() [INFO] [stderr] 283 | | .len(); [INFO] [stderr] | |__________________^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/shuffler.rs:286:13 [INFO] [stderr] | [INFO] [stderr] 286 | / .collect::>() [INFO] [stderr] 287 | | .len(); [INFO] [stderr] | |__________________^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/csv_loader.rs:69:67 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn load_rooms>(&self, path: P, door_table: &DoorTable) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | / match exit.exit_type { [INFO] [stderr] 36 | | ExitType::TwoWay => { [INFO] [stderr] 37 | | let option_linked_record = &door_table[exit.linked_door_id as usize]; [INFO] [stderr] 38 | | if let Some(ref linked_record) = *option_linked_record { [INFO] [stderr] ... | [INFO] [stderr] 44 | | _ => () [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | if let ExitType::TwoWay = exit.exit_type { [INFO] [stderr] 36 | let option_linked_record = &door_table[exit.linked_door_id as usize]; [INFO] [stderr] 37 | if let Some(ref linked_record) = *option_linked_record { [INFO] [stderr] 38 | let linked_destination = linked_record.extract_destination(); [INFO] [stderr] 39 | let linked_exit = linked_record.extract_exit(); [INFO] [stderr] 40 | original_links.insert(Door(destination, exit), Door(linked_destination, linked_exit)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `katam-rando`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "39fda7c54d176d9e5020a8c7502f2c2ac56eb089e0b1e38ad7193af8b355e57b"` [INFO] running `"docker" "rm" "-f" "39fda7c54d176d9e5020a8c7502f2c2ac56eb089e0b1e38ad7193af8b355e57b"` [INFO] [stdout] 39fda7c54d176d9e5020a8c7502f2c2ac56eb089e0b1e38ad7193af8b355e57b