[INFO] updating cached repository karikittie/rust-http-server
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/karikittie/rust-http-server
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/karikittie/rust-http-server" "work/ex/clippy-test-run/sources/stable/gh/karikittie/rust-http-server"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/karikittie/rust-http-server'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/karikittie/rust-http-server" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/karikittie/rust-http-server"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/karikittie/rust-http-server'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 2abf2ce24c04bcf07e68624c5a5af1b0a44c949c
[INFO] sha for GitHub repo karikittie/rust-http-server: 2abf2ce24c04bcf07e68624c5a5af1b0a44c949c
[INFO] validating manifest of karikittie/rust-http-server on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of karikittie/rust-http-server on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing karikittie/rust-http-server
[INFO] finished frobbing karikittie/rust-http-server
[INFO] frobbed toml for karikittie/rust-http-server written to work/ex/clippy-test-run/sources/stable/gh/karikittie/rust-http-server/Cargo.toml
[INFO] started frobbing karikittie/rust-http-server
[INFO] finished frobbing karikittie/rust-http-server
[INFO] frobbed toml for karikittie/rust-http-server written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/karikittie/rust-http-server/Cargo.toml
[INFO] crate karikittie/rust-http-server has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting karikittie/rust-http-server against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/karikittie/rust-http-server:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b2bc9cbca6a94b53ccabfd459bb32847eeb6496c570caf3b9082a48d15383966
[INFO] running `"docker" "start" "-a" "b2bc9cbca6a94b53ccabfd459bb32847eeb6496c570caf3b9082a48d15383966"`
[INFO] [stderr]     Checking servo v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/http/mod.rs:159:9
[INFO] [stderr]     |
[INFO] [stderr] 159 |         new_request
[INFO] [stderr]     |         ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/http/mod.rs:154:27
[INFO] [stderr]     |
[INFO] [stderr] 154 |           let new_request = Request::new()
[INFO] [stderr]     |  ___________________________^
[INFO] [stderr] 155 | |                                   .with_method(found_method)
[INFO] [stderr] 156 | |                                   .with_route(found_route)
[INFO] [stderr] 157 | |                                   .with_headers(found_headers)
[INFO] [stderr] 158 | |                                   .query_params_from_route();
[INFO] [stderr]     | |____________________________________________________________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/http/mod.rs:182:9
[INFO] [stderr]     |
[INFO] [stderr] 182 |         url_args
[INFO] [stderr]     |         ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/http/mod.rs:181:24
[INFO] [stderr]     |
[INFO] [stderr] 181 |         let url_args = self.url_args.clone().join("/");
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/http/mod.rs:351:5
[INFO] [stderr]     |
[INFO] [stderr] 351 |     return Box::new(route_map);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(route_map)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/servo.rs:308:9
[INFO] [stderr]     |
[INFO] [stderr] 308 |         config
[INFO] [stderr]     |         ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/servo.rs:304:22
[INFO] [stderr]     |
[INFO] [stderr] 304 |           let config = Configuration {
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 305 | |             server: Server::new(),
[INFO] [stderr] 306 | |             routes: Routes::new(),
[INFO] [stderr] 307 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/http/content_type.rs:23:22
[INFO] [stderr]    |
[INFO] [stderr] 23 |     pub fn stringify(&self) -> String {
[INFO] [stderr]    |                      ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/http/content_type.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 | /         match self {
[INFO] [stderr] 25 | |             &ContentType::TextHtml => String::from("text/html"),
[INFO] [stderr] 26 | |             &ContentType::TextCss => String::from("text/css"),
[INFO] [stderr] 27 | |             &ContentType::TextJs => String::from("text/javascript"),
[INFO] [stderr] ...  |
[INFO] [stderr] 35 | |             &ContentType::ApplicationXml => String::from("application/xml"),
[INFO] [stderr] 36 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 24 |         match *self {
[INFO] [stderr] 25 |             ContentType::TextHtml => String::from("text/html"),
[INFO] [stderr] 26 |             ContentType::TextCss => String::from("text/css"),
[INFO] [stderr] 27 |             ContentType::TextJs => String::from("text/javascript"),
[INFO] [stderr] 28 |             ContentType::TextSvgXml => String::from("text/svg+xml"),
[INFO] [stderr] 29 |             ContentType::MultipartForm => String::from("multipart/form"),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/http/content_type.rs:48:35
[INFO] [stderr]    |
[INFO] [stderr] 48 | pub fn get_content_type(filename: &String) -> ContentType {
[INFO] [stderr]    |                                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/http/mod.rs:58:18
[INFO] [stderr]    |
[INFO] [stderr] 58 | pub fn not_found<'a>(body: String, content_type: ContentType) -> Response {
[INFO] [stderr]    |                  ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/http/mod.rs:66:11
[INFO] [stderr]    |
[INFO] [stderr] 66 | pub fn ok<'a>(body: String, content_type: ContentType) -> Response {
[INFO] [stderr]    |           ^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/http/mod.rs:74:16
[INFO] [stderr]    |
[INFO] [stderr] 74 | pub fn ok_file<'a>(body: Vec<u8>, content_type: ContentType) -> Response {
[INFO] [stderr]    |                ^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/http/mod.rs:82:21
[INFO] [stderr]    |
[INFO] [stderr] 82 | pub fn server_error<'a>(body: String, content_type: ContentType) -> Response {
[INFO] [stderr]    |                     ^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `http::Request`
[INFO] [stderr]   --> src/http/mod.rs:91:5
[INFO] [stderr]    |
[INFO] [stderr] 91 | /     pub fn new() -> Request {
[INFO] [stderr] 92 | |         Request {
[INFO] [stderr] 93 | |             method : String::from("GET"),
[INFO] [stderr] 94 | |             route : String::from(""),
[INFO] [stderr] ...  |
[INFO] [stderr] 98 | |         }
[INFO] [stderr] 99 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 12 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/http/mod.rs:109:48
[INFO] [stderr]     |
[INFO] [stderr] 109 |         let mut split: Vec<&str> = route.split("?").collect();
[INFO] [stderr]     |                                                ^^^ help: try using a char instead: `'?'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/http/mod.rs:113:54
[INFO] [stderr]     |
[INFO] [stderr] 113 |         let param_section: Vec<&str> = queries.split("&").collect();
[INFO] [stderr]     |                                                      ^^^ help: try using a char instead: `'&'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/http/mod.rs:117:20
[INFO] [stderr]     |
[INFO] [stderr] 117 |                 if i.contains("=") == true {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `i.contains("=")`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/http/mod.rs:117:31
[INFO] [stderr]     |
[INFO] [stderr] 117 |                 if i.contains("=") == true {
[INFO] [stderr]     |                               ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/http/mod.rs:118:52
[INFO] [stderr]     |
[INFO] [stderr] 118 |                 let mut tuple: Vec<&str> = i.split("=").collect();
[INFO] [stderr]     |                                                    ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in lines.enumerate()` or similar iterators
[INFO] [stderr]    --> src/http/mod.rs:135:21
[INFO] [stderr]     |
[INFO] [stderr] 135 |         for line in lines {
[INFO] [stderr]     |                     ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/http/mod.rs:140:42
[INFO] [stderr]     |
[INFO] [stderr] 140 |                 if found_route.ends_with("/") {
[INFO] [stderr]     |                                          ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/http/mod.rs:141:52
[INFO] [stderr]     |
[INFO] [stderr] 141 |                     found_route.trim_right_matches("/");
[INFO] [stderr]     |                                                    ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/http/mod.rs:145:51
[INFO] [stderr]     |
[INFO] [stderr] 145 |                 let pair : Vec<&str> = line.split(":").collect();
[INFO] [stderr]     |                                                   ^^^ help: try using a char instead: `':'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `http::Response`
[INFO] [stderr]    --> src/http/mod.rs:238:5
[INFO] [stderr]     |
[INFO] [stderr] 238 | /     pub fn new() -> Response {
[INFO] [stderr] 239 | |         Response {
[INFO] [stderr] 240 | |             status: 0_i32,
[INFO] [stderr] 241 | |             content_type: ContentType::TextHtml,
[INFO] [stderr] ...   |
[INFO] [stderr] 244 | |         }
[INFO] [stderr] 245 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 236 | impl Default for http::Response {
[INFO] [stderr] 237 |     fn default() -> Self {
[INFO] [stderr] 238 |         Self::new()
[INFO] [stderr] 239 |     }
[INFO] [stderr] 240 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/http/mod.rs:250:22
[INFO] [stderr]     |
[INFO] [stderr] 250 |         let status = self.status.clone();
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.status`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/http/mod.rs:251:28
[INFO] [stderr]     |
[INFO] [stderr] 251 |         let content_type = self.content_type.clone();
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.content_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/http/mod.rs:255:23
[INFO] [stderr]     |
[INFO] [stderr] 255 |         let mut res = String::from(format!("HTTP/1.1 {}\n\r", status));
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("HTTP/1.1 {}\n\r", status)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/http/mod.rs:262:9
[INFO] [stderr]     |
[INFO] [stderr] 262 |         res = res + "\r\n";
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `res += "\r\n"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/http/mod.rs:275:9
[INFO] [stderr]     |
[INFO] [stderr] 275 |         self.status.clone()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.status`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/http/mod.rs:279:9
[INFO] [stderr]     |
[INFO] [stderr] 279 |         self.content_type.clone()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.content_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]    --> src/http/mod.rs:335:22
[INFO] [stderr]     |
[INFO] [stderr] 335 | pub fn route_request<'a>(request : Request) -> Response {
[INFO] [stderr]     |                      ^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/http/mod.rs:349:23
[INFO] [stderr]     |
[INFO] [stderr] 349 | fn get_route_map() -> Box<HashMap<String, fn(Request) -> Response>> {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/servo.rs:48:9
[INFO] [stderr]    |
[INFO] [stderr] 48 | /         match self {
[INFO] [stderr] 49 | |             &HttpProtocol::Http => String::from("http"),
[INFO] [stderr] 50 | |             &HttpProtocol::Https => String::from("https"),
[INFO] [stderr] 51 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 48 |         match *self {
[INFO] [stderr] 49 |             HttpProtocol::Http => String::from("http"),
[INFO] [stderr] 50 |             HttpProtocol::Https => String::from("https"),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Servo`
[INFO] [stderr]   --> src/servo.rs:61:5
[INFO] [stderr]    |
[INFO] [stderr] 61 | /     pub fn new() -> Servo {
[INFO] [stderr] 62 | |         Servo {
[INFO] [stderr] 63 | |             configuration : Configuration::new()
[INFO] [stderr] 64 | |         }
[INFO] [stderr] 65 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 59 | impl Default for Servo {
[INFO] [stderr] 60 |     fn default() -> Self {
[INFO] [stderr] 61 |         Self::new()
[INFO] [stderr] 62 |     }
[INFO] [stderr] 63 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Server`
[INFO] [stderr]    --> src/servo.rs:120:5
[INFO] [stderr]     |
[INFO] [stderr] 120 | /     pub fn new() -> Server {
[INFO] [stderr] 121 | |         Server {
[INFO] [stderr] 122 | |             host : String::from("127.0.0.1"),
[INFO] [stderr] 123 | |             port : String::from("8000"),
[INFO] [stderr] ...   |
[INFO] [stderr] 129 | |         }
[INFO] [stderr] 130 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 111 | impl Default for Server {
[INFO] [stderr] 112 |     fn default() -> Self {
[INFO] [stderr] 113 |         Self::new()
[INFO] [stderr] 114 |     }
[INFO] [stderr] 115 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/servo.rs:193:5
[INFO] [stderr]     |
[INFO] [stderr] 193 | /     pub fn clone(&self) -> Server {
[INFO] [stderr] 194 | |         Server::new()
[INFO] [stderr] 195 | |             .with_host(&self.host)
[INFO] [stderr] 196 | |             .with_port(&self.port)
[INFO] [stderr] ...   |
[INFO] [stderr] 200 | |             .with_router(self.router.clone())
[INFO] [stderr] 201 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/servo.rs:200:26
[INFO] [stderr]     |
[INFO] [stderr] 200 |             .with_router(self.router.clone())
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.router`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Routes`
[INFO] [stderr]    --> src/servo.rs:217:5
[INFO] [stderr]     |
[INFO] [stderr] 217 | /     pub fn new() -> Routes {
[INFO] [stderr] 218 | |         let mut map: BTreeMap<String, CallBack> = BTreeMap::new();
[INFO] [stderr] 219 | |         map.insert(String::from("GET /"), default_home);
[INFO] [stderr] 220 | |         map.insert(String::from("GET /static/{}"), static_route);
[INFO] [stderr] ...   |
[INFO] [stderr] 223 | |         }
[INFO] [stderr] 224 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 207 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/servo.rs:280:5
[INFO] [stderr]     |
[INFO] [stderr] 280 | /     pub fn clone(&self) -> Routes {
[INFO] [stderr] 281 | |         Routes {
[INFO] [stderr] 282 | |             route_map: self.route_map.clone()
[INFO] [stderr] 283 | |         }
[INFO] [stderr] 284 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Configuration`
[INFO] [stderr]    --> src/servo.rs:303:5
[INFO] [stderr]     |
[INFO] [stderr] 303 | /     pub fn new() -> Configuration {
[INFO] [stderr] 304 | |         let config = Configuration {
[INFO] [stderr] 305 | |             server: Server::new(),
[INFO] [stderr] 306 | |             routes: Routes::new(),
[INFO] [stderr] 307 | |         };
[INFO] [stderr] 308 | |         config
[INFO] [stderr] 309 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 302 | impl Default for Configuration {
[INFO] [stderr] 303 |     fn default() -> Self {
[INFO] [stderr] 304 |         Self::new()
[INFO] [stderr] 305 |     }
[INFO] [stderr] 306 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/servo.rs:329:5
[INFO] [stderr]     |
[INFO] [stderr] 329 | /     pub fn clone(&self) -> Configuration {
[INFO] [stderr] 330 | |         Configuration {
[INFO] [stderr] 331 | |             server: self.server.clone(),
[INFO] [stderr] 332 | |             routes: self.routes.clone()
[INFO] [stderr] 333 | |         }
[INFO] [stderr] 334 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/http/mod.rs:159:9
[INFO] [stderr]     |
[INFO] [stderr] 159 |         new_request
[INFO] [stderr]     |         ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/http/mod.rs:154:27
[INFO] [stderr]     |
[INFO] [stderr] 154 |           let new_request = Request::new()
[INFO] [stderr]     |  ___________________________^
[INFO] [stderr] 155 | |                                   .with_method(found_method)
[INFO] [stderr] 156 | |                                   .with_route(found_route)
[INFO] [stderr] 157 | |                                   .with_headers(found_headers)
[INFO] [stderr] 158 | |                                   .query_params_from_route();
[INFO] [stderr]     | |____________________________________________________________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/http/mod.rs:182:9
[INFO] [stderr]     |
[INFO] [stderr] 182 |         url_args
[INFO] [stderr]     |         ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/http/mod.rs:181:24
[INFO] [stderr]     |
[INFO] [stderr] 181 |         let url_args = self.url_args.clone().join("/");
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/http/mod.rs:351:5
[INFO] [stderr]     |
[INFO] [stderr] 351 |     return Box::new(route_map);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(route_map)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/servo.rs:308:9
[INFO] [stderr]     |
[INFO] [stderr] 308 |         config
[INFO] [stderr]     |         ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/servo.rs:304:22
[INFO] [stderr]     |
[INFO] [stderr] 304 |           let config = Configuration {
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 305 | |             server: Server::new(),
[INFO] [stderr] 306 | |             routes: Routes::new(),
[INFO] [stderr] 307 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/servo.rs:422:50
[INFO] [stderr]     |
[INFO] [stderr] 422 |         let mut segments = requested_route.split("/").skip(1).collect::<Vec<&str>>();
[INFO] [stderr]     |                                                  ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/http/content_type.rs:23:22
[INFO] [stderr]    |
[INFO] [stderr] 23 |     pub fn stringify(&self) -> String {
[INFO] [stderr]    |                      ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/http/content_type.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 | /         match self {
[INFO] [stderr] 25 | |             &ContentType::TextHtml => String::from("text/html"),
[INFO] [stderr] 26 | |             &ContentType::TextCss => String::from("text/css"),
[INFO] [stderr] 27 | |             &ContentType::TextJs => String::from("text/javascript"),
[INFO] [stderr] ...  |
[INFO] [stderr] 35 | |             &ContentType::ApplicationXml => String::from("application/xml"),
[INFO] [stderr] 36 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 24 |         match *self {
[INFO] [stderr] 25 |             ContentType::TextHtml => String::from("text/html"),
[INFO] [stderr] 26 |             ContentType::TextCss => String::from("text/css"),
[INFO] [stderr] 27 |             ContentType::TextJs => String::from("text/javascript"),
[INFO] [stderr] 28 |             ContentType::TextSvgXml => String::from("text/svg+xml"),
[INFO] [stderr] 29 |             ContentType::MultipartForm => String::from("multipart/form"),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/http/content_type.rs:48:35
[INFO] [stderr]    |
[INFO] [stderr] 48 | pub fn get_content_type(filename: &String) -> ContentType {
[INFO] [stderr]    |                                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/http/mod.rs:58:18
[INFO] [stderr]    |
[INFO] [stderr] 58 | pub fn not_found<'a>(body: String, content_type: ContentType) -> Response {
[INFO] [stderr]    |                  ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/http/mod.rs:66:11
[INFO] [stderr]    |
[INFO] [stderr] 66 | pub fn ok<'a>(body: String, content_type: ContentType) -> Response {
[INFO] [stderr]    |           ^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/http/mod.rs:74:16
[INFO] [stderr]    |
[INFO] [stderr] 74 | pub fn ok_file<'a>(body: Vec<u8>, content_type: ContentType) -> Response {
[INFO] [stderr]    |                ^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/http/mod.rs:82:21
[INFO] [stderr]    |
[INFO] [stderr] 82 | pub fn server_error<'a>(body: String, content_type: ContentType) -> Response {
[INFO] [stderr]    |                     ^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `http::Request`
[INFO] [stderr]   --> src/http/mod.rs:91:5
[INFO] [stderr]    |
[INFO] [stderr] 91 | /     pub fn new() -> Request {
[INFO] [stderr] 92 | |         Request {
[INFO] [stderr] 93 | |             method : String::from("GET"),
[INFO] [stderr] 94 | |             route : String::from(""),
[INFO] [stderr] ...  |
[INFO] [stderr] 98 | |         }
[INFO] [stderr] 99 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 12 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/http/mod.rs:109:48
[INFO] [stderr]     |
[INFO] [stderr] 109 |         let mut split: Vec<&str> = route.split("?").collect();
[INFO] [stderr]     |                                                ^^^ help: try using a char instead: `'?'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/http/mod.rs:113:54
[INFO] [stderr]     |
[INFO] [stderr] 113 |         let param_section: Vec<&str> = queries.split("&").collect();
[INFO] [stderr]     |                                                      ^^^ help: try using a char instead: `'&'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/http/mod.rs:117:20
[INFO] [stderr]     |
[INFO] [stderr] 117 |                 if i.contains("=") == true {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `i.contains("=")`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/http/mod.rs:117:31
[INFO] [stderr]     |
[INFO] [stderr] 117 |                 if i.contains("=") == true {
[INFO] [stderr]     |                               ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/http/mod.rs:118:52
[INFO] [stderr]     |
[INFO] [stderr] 118 |                 let mut tuple: Vec<&str> = i.split("=").collect();
[INFO] [stderr]     |                                                    ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in lines.enumerate()` or similar iterators
[INFO] [stderr]    --> src/http/mod.rs:135:21
[INFO] [stderr]     |
[INFO] [stderr] 135 |         for line in lines {
[INFO] [stderr]     |                     ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/http/mod.rs:140:42
[INFO] [stderr]     |
[INFO] [stderr] 140 |                 if found_route.ends_with("/") {
[INFO] [stderr]     |                                          ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/http/mod.rs:141:52
[INFO] [stderr]     |
[INFO] [stderr] 141 |                     found_route.trim_right_matches("/");
[INFO] [stderr]     |                                                    ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/http/mod.rs:145:51
[INFO] [stderr]     |
[INFO] [stderr] 145 |                 let pair : Vec<&str> = line.split(":").collect();
[INFO] [stderr]     |                                                   ^^^ help: try using a char instead: `':'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `http::Response`
[INFO] [stderr]    --> src/http/mod.rs:238:5
[INFO] [stderr]     |
[INFO] [stderr] 238 | /     pub fn new() -> Response {
[INFO] [stderr] 239 | |         Response {
[INFO] [stderr] 240 | |             status: 0_i32,
[INFO] [stderr] 241 | |             content_type: ContentType::TextHtml,
[INFO] [stderr] ...   |
[INFO] [stderr] 244 | |         }
[INFO] [stderr] 245 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 236 | impl Default for http::Response {
[INFO] [stderr] 237 |     fn default() -> Self {
[INFO] [stderr] 238 |         Self::new()
[INFO] [stderr] 239 |     }
[INFO] [stderr] 240 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/http/mod.rs:250:22
[INFO] [stderr]     |
[INFO] [stderr] 250 |         let status = self.status.clone();
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.status`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/http/mod.rs:251:28
[INFO] [stderr]     |
[INFO] [stderr] 251 |         let content_type = self.content_type.clone();
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.content_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/http/mod.rs:255:23
[INFO] [stderr]     |
[INFO] [stderr] 255 |         let mut res = String::from(format!("HTTP/1.1 {}\n\r", status));
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("HTTP/1.1 {}\n\r", status)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/http/mod.rs:262:9
[INFO] [stderr]     |
[INFO] [stderr] 262 |         res = res + "\r\n";
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `res += "\r\n"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/http/mod.rs:275:9
[INFO] [stderr]     |
[INFO] [stderr] 275 |         self.status.clone()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.status`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/http/mod.rs:279:9
[INFO] [stderr]     |
[INFO] [stderr] 279 |         self.content_type.clone()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.content_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]    --> src/http/mod.rs:335:22
[INFO] [stderr]     |
[INFO] [stderr] 335 | pub fn route_request<'a>(request : Request) -> Response {
[INFO] [stderr]     |                      ^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/http/mod.rs:349:23
[INFO] [stderr]     |
[INFO] [stderr] 349 | fn get_route_map() -> Box<HashMap<String, fn(Request) -> Response>> {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/servo.rs:48:9
[INFO] [stderr]    |
[INFO] [stderr] 48 | /         match self {
[INFO] [stderr] 49 | |             &HttpProtocol::Http => String::from("http"),
[INFO] [stderr] 50 | |             &HttpProtocol::Https => String::from("https"),
[INFO] [stderr] 51 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 48 |         match *self {
[INFO] [stderr] 49 |             HttpProtocol::Http => String::from("http"),
[INFO] [stderr] 50 |             HttpProtocol::Https => String::from("https"),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Servo`
[INFO] [stderr]   --> src/servo.rs:61:5
[INFO] [stderr]    |
[INFO] [stderr] 61 | /     pub fn new() -> Servo {
[INFO] [stderr] 62 | |         Servo {
[INFO] [stderr] 63 | |             configuration : Configuration::new()
[INFO] [stderr] 64 | |         }
[INFO] [stderr] 65 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 59 | impl Default for Servo {
[INFO] [stderr] 60 |     fn default() -> Self {
[INFO] [stderr] 61 |         Self::new()
[INFO] [stderr] 62 |     }
[INFO] [stderr] 63 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Server`
[INFO] [stderr]    --> src/servo.rs:120:5
[INFO] [stderr]     |
[INFO] [stderr] 120 | /     pub fn new() -> Server {
[INFO] [stderr] 121 | |         Server {
[INFO] [stderr] 122 | |             host : String::from("127.0.0.1"),
[INFO] [stderr] 123 | |             port : String::from("8000"),
[INFO] [stderr] ...   |
[INFO] [stderr] 129 | |         }
[INFO] [stderr] 130 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 111 | impl Default for Server {
[INFO] [stderr] 112 |     fn default() -> Self {
[INFO] [stderr] 113 |         Self::new()
[INFO] [stderr] 114 |     }
[INFO] [stderr] 115 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/servo.rs:193:5
[INFO] [stderr]     |
[INFO] [stderr] 193 | /     pub fn clone(&self) -> Server {
[INFO] [stderr] 194 | |         Server::new()
[INFO] [stderr] 195 | |             .with_host(&self.host)
[INFO] [stderr] 196 | |             .with_port(&self.port)
[INFO] [stderr] ...   |
[INFO] [stderr] 200 | |             .with_router(self.router.clone())
[INFO] [stderr] 201 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/servo.rs:200:26
[INFO] [stderr]     |
[INFO] [stderr] 200 |             .with_router(self.router.clone())
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.router`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Routes`
[INFO] [stderr]    --> src/servo.rs:217:5
[INFO] [stderr]     |
[INFO] [stderr] 217 | /     pub fn new() -> Routes {
[INFO] [stderr] 218 | |         let mut map: BTreeMap<String, CallBack> = BTreeMap::new();
[INFO] [stderr] 219 | |         map.insert(String::from("GET /"), default_home);
[INFO] [stderr] 220 | |         map.insert(String::from("GET /static/{}"), static_route);
[INFO] [stderr] ...   |
[INFO] [stderr] 223 | |         }
[INFO] [stderr] 224 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 207 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/servo.rs:280:5
[INFO] [stderr]     |
[INFO] [stderr] 280 | /     pub fn clone(&self) -> Routes {
[INFO] [stderr] 281 | |         Routes {
[INFO] [stderr] 282 | |             route_map: self.route_map.clone()
[INFO] [stderr] 283 | |         }
[INFO] [stderr] 284 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Configuration`
[INFO] [stderr]    --> src/servo.rs:303:5
[INFO] [stderr]     |
[INFO] [stderr] 303 | /     pub fn new() -> Configuration {
[INFO] [stderr] 304 | |         let config = Configuration {
[INFO] [stderr] 305 | |             server: Server::new(),
[INFO] [stderr] 306 | |             routes: Routes::new(),
[INFO] [stderr] 307 | |         };
[INFO] [stderr] 308 | |         config
[INFO] [stderr] 309 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 302 | impl Default for Configuration {
[INFO] [stderr] 303 |     fn default() -> Self {
[INFO] [stderr] 304 |         Self::new()
[INFO] [stderr] 305 |     }
[INFO] [stderr] 306 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `clone` on this type; consider implementing the `std::clone::Clone` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/servo.rs:329:5
[INFO] [stderr]     |
[INFO] [stderr] 329 | /     pub fn clone(&self) -> Configuration {
[INFO] [stderr] 330 | |         Configuration {
[INFO] [stderr] 331 | |             server: self.server.clone(),
[INFO] [stderr] 332 | |             routes: self.routes.clone()
[INFO] [stderr] 333 | |         }
[INFO] [stderr] 334 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/servo.rs:422:50
[INFO] [stderr]     |
[INFO] [stderr] 422 |         let mut segments = requested_route.split("/").skip(1).collect::<Vec<&str>>();
[INFO] [stderr]     |                                                  ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> tests/req_tests.rs:32:42
[INFO] [stderr]    |
[INFO] [stderr] 32 |                                   .with_content_type(content.clone())
[INFO] [stderr]    |                                                      ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `content`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.10s
[INFO] running `"docker" "inspect" "b2bc9cbca6a94b53ccabfd459bb32847eeb6496c570caf3b9082a48d15383966"`
[INFO] running `"docker" "rm" "-f" "b2bc9cbca6a94b53ccabfd459bb32847eeb6496c570caf3b9082a48d15383966"`
[INFO] [stdout] b2bc9cbca6a94b53ccabfd459bb32847eeb6496c570caf3b9082a48d15383966