[INFO] updating cached repository kanishkd4/Rust-algorithms [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kanishkd4/Rust-algorithms [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kanishkd4/Rust-algorithms" "work/ex/clippy-test-run/sources/stable/gh/kanishkd4/Rust-algorithms"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kanishkd4/Rust-algorithms'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kanishkd4/Rust-algorithms" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kanishkd4/Rust-algorithms"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kanishkd4/Rust-algorithms'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 65a739f98d914c8155425b9a96640b47a2db21f1 [INFO] sha for GitHub repo kanishkd4/Rust-algorithms: 65a739f98d914c8155425b9a96640b47a2db21f1 [INFO] validating manifest of kanishkd4/Rust-algorithms on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kanishkd4/Rust-algorithms on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kanishkd4/Rust-algorithms [INFO] finished frobbing kanishkd4/Rust-algorithms [INFO] frobbed toml for kanishkd4/Rust-algorithms written to work/ex/clippy-test-run/sources/stable/gh/kanishkd4/Rust-algorithms/Cargo.toml [INFO] started frobbing kanishkd4/Rust-algorithms [INFO] finished frobbing kanishkd4/Rust-algorithms [INFO] frobbed toml for kanishkd4/Rust-algorithms written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kanishkd4/Rust-algorithms/Cargo.toml [INFO] crate kanishkd4/Rust-algorithms has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kanishkd4/Rust-algorithms against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kanishkd4/Rust-algorithms:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 30afa6fa3fb503f9571627ab19eefc92e74dd12ce2947ed6ffc8806c2ae2cba2 [INFO] running `"docker" "start" "-a" "30afa6fa3fb503f9571627ab19eefc92e74dd12ce2947ed6ffc8806c2ae2cba2"` [INFO] [stderr] Checking rust_algorithms v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/algorithms/insertion_sort.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/algorithms/prime_number_generator.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return primes; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `primes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/algorithms/insertion_sort.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/algorithms/prime_number_generator.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return primes; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `primes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/algorithms/prime_number_generator.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | for j in j_iter.into_iter().step_by(i) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `j_iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/algorithms/prime_number_generator.rs:13:22 [INFO] [stderr] | [INFO] [stderr] 13 | for j in j_iter.into_iter().step_by(i) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `j_iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/bin/prime.rs:30:51 [INFO] [stderr] | [INFO] [stderr] 30 | prime_number_generator::sieve_of_eratosthenes(1000_000_0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::vec::Vec` [INFO] [stderr] --> src/bin/test.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::vec::Vec; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::vec::Vec` [INFO] [stderr] --> src/bin/test.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::vec::Vec; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/bin/prime.rs:30:51 [INFO] [stderr] | [INFO] [stderr] 30 | prime_number_generator::sieve_of_eratosthenes(1000_000_0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.34s [INFO] running `"docker" "inspect" "30afa6fa3fb503f9571627ab19eefc92e74dd12ce2947ed6ffc8806c2ae2cba2"` [INFO] running `"docker" "rm" "-f" "30afa6fa3fb503f9571627ab19eefc92e74dd12ce2947ed6ffc8806c2ae2cba2"` [INFO] [stdout] 30afa6fa3fb503f9571627ab19eefc92e74dd12ce2947ed6ffc8806c2ae2cba2