[INFO] updating cached repository kamek-pf/stackdriver-logger [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/kamek-pf/stackdriver-logger [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/kamek-pf/stackdriver-logger" "work/ex/clippy-test-run/sources/stable/gh/kamek-pf/stackdriver-logger"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/kamek-pf/stackdriver-logger'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/kamek-pf/stackdriver-logger" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kamek-pf/stackdriver-logger"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kamek-pf/stackdriver-logger'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fbc5302794f431b3373ade6ee38ac396d78f373b [INFO] sha for GitHub repo kamek-pf/stackdriver-logger: fbc5302794f431b3373ade6ee38ac396d78f373b [INFO] validating manifest of kamek-pf/stackdriver-logger on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of kamek-pf/stackdriver-logger on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing kamek-pf/stackdriver-logger [INFO] finished frobbing kamek-pf/stackdriver-logger [INFO] frobbed toml for kamek-pf/stackdriver-logger written to work/ex/clippy-test-run/sources/stable/gh/kamek-pf/stackdriver-logger/Cargo.toml [INFO] started frobbing kamek-pf/stackdriver-logger [INFO] finished frobbing kamek-pf/stackdriver-logger [INFO] frobbed toml for kamek-pf/stackdriver-logger written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/kamek-pf/stackdriver-logger/Cargo.toml [INFO] crate kamek-pf/stackdriver-logger has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting kamek-pf/stackdriver-logger against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/kamek-pf/stackdriver-logger:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 548a37cd44c834a50e93df41c5a60564917d7c48ab3b9300d5b04b5193cb8a01 [INFO] running `"docker" "start" "-a" "548a37cd44c834a50e93df41c5a60564917d7c48ab3b9300d5b04b5193cb8a01"` [INFO] [stderr] Checking serde_json v1.0.19 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Checking pretty_env_logger v0.2.3 [INFO] [stderr] Checking stackdriver_logger v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:110:14 [INFO] [stderr] | [INFO] [stderr] 110 | .unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:109:14 [INFO] [stderr] | [INFO] [stderr] 109 | .or(env::var("CARGO_PKG_NAME")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| env::var("CARGO_PKG_NAME"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:114:14 [INFO] [stderr] | [INFO] [stderr] 114 | .unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:113:14 [INFO] [stderr] | [INFO] [stderr] 113 | .or(env::var("CARGO_PKG_VERSION")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| env::var("CARGO_PKG_VERSION"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:147:21 [INFO] [stderr] | [INFO] [stderr] 147 | fn map_level(input: &Level) -> StackdriverLogLevel { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Level` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:110:14 [INFO] [stderr] | [INFO] [stderr] 110 | .unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:109:14 [INFO] [stderr] | [INFO] [stderr] 109 | .or(env::var("CARGO_PKG_NAME")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| env::var("CARGO_PKG_NAME"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:114:14 [INFO] [stderr] | [INFO] [stderr] 114 | .unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/lib.rs:113:14 [INFO] [stderr] | [INFO] [stderr] 113 | .or(env::var("CARGO_PKG_VERSION")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|_| env::var("CARGO_PKG_VERSION"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:147:21 [INFO] [stderr] | [INFO] [stderr] 147 | fn map_level(input: &Level) -> StackdriverLogLevel { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Level` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.37s [INFO] running `"docker" "inspect" "548a37cd44c834a50e93df41c5a60564917d7c48ab3b9300d5b04b5193cb8a01"` [INFO] running `"docker" "rm" "-f" "548a37cd44c834a50e93df41c5a60564917d7c48ab3b9300d5b04b5193cb8a01"` [INFO] [stdout] 548a37cd44c834a50e93df41c5a60564917d7c48ab3b9300d5b04b5193cb8a01