[INFO] updating cached repository k0nserv/rusttracer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/k0nserv/rusttracer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/k0nserv/rusttracer" "work/ex/clippy-test-run/sources/stable/gh/k0nserv/rusttracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/k0nserv/rusttracer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/k0nserv/rusttracer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/k0nserv/rusttracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/k0nserv/rusttracer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c05e7dcfeed2756b4904b077e80dd0ffa55d2103 [INFO] sha for GitHub repo k0nserv/rusttracer: c05e7dcfeed2756b4904b077e80dd0ffa55d2103 [INFO] validating manifest of k0nserv/rusttracer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of k0nserv/rusttracer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing k0nserv/rusttracer [INFO] finished frobbing k0nserv/rusttracer [INFO] frobbed toml for k0nserv/rusttracer written to work/ex/clippy-test-run/sources/stable/gh/k0nserv/rusttracer/Cargo.toml [INFO] started frobbing k0nserv/rusttracer [INFO] finished frobbing k0nserv/rusttracer [INFO] frobbed toml for k0nserv/rusttracer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/k0nserv/rusttracer/Cargo.toml [INFO] crate k0nserv/rusttracer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting k0nserv/rusttracer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/k0nserv/rusttracer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d37e8c3e29837c4fb5482f59a44af2a0773ffc99a4bae80b0f82e70740b644fb [INFO] running `"docker" "start" "-a" "d37e8c3e29837c4fb5482f59a44af2a0773ffc99a4bae80b0f82e70740b644fb"` [INFO] [stderr] Checking serde v1.0.42 [INFO] [stderr] Compiling quote v0.5.2 [INFO] [stderr] Checking rayon v0.6.0 [INFO] [stderr] Compiling syn v0.13.1 [INFO] [stderr] Compiling serde_derive_internals v0.23.1 [INFO] [stderr] Compiling serde_derive v1.0.42 [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Checking serde_json v1.0.16 [INFO] [stderr] Checking rusttracer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/geometry/sphere.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | let (t, hit, inside) = if t1 > 0.01 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/geometry/sphere.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | let (t, hit, inside) = if t1 > 0.01 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math/three_dimensions.rs:386:17 [INFO] [stderr] | [INFO] [stderr] 386 | 3.756327994, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `3.756_327_994` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math/three_dimensions.rs:432:16 [INFO] [stderr] | [INFO] [stderr] 432 | x: 0.063362486, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.063_362_486` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math/three_dimensions.rs:433:16 [INFO] [stderr] | [INFO] [stderr] 433 | y: 0.99795915, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.997_959_15` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math/three_dimensions.rs:434:16 [INFO] [stderr] | [INFO] [stderr] 434 | z: 0.007920311, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.007_920_311` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math/two_dimensions.rs:240:45 [INFO] [stderr] | [INFO] [stderr] 240 | assert_eq_within_bound!(v.length(), 31.569605636, EPSILON); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `31.569_605_636` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math/two_dimensions.rs:261:20 [INFO] [stderr] | [INFO] [stderr] 261 | x: 0.924940284, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.924_940_284` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/math/two_dimensions.rs:262:20 [INFO] [stderr] | [INFO] [stderr] 262 | y: 0.380112445 [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.380_112_445` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/math/two_dimensions.rs:51:16 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn dot(&self, other: &Self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/math/two_dimensions.rs:51:30 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn dot(&self, other: &Self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/math/two_dimensions.rs:55:19 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn length(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/math/two_dimensions.rs:59:22 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn normalize(&self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/math/two_dimensions.rs:72:21 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn as_point(&self) -> Point2 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/math/two_dimensions.rs:83:22 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn as_vector(&self) -> Vector2 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/color.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn r(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/color.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn r_f32(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/color.rs:72:14 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn g(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/color.rs:77:18 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn g_f32(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/color.rs:82:14 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn b(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/color.rs:87:18 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn b_f32(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/color.rs:92:19 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn as_u32(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/material.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | / pub fn new_with_textures( [INFO] [stderr] 104 | | ambient_color: Color, [INFO] [stderr] 105 | | ambient_texture: OptionalTexture, [INFO] [stderr] 106 | | diffuse_color: Color, [INFO] [stderr] ... | [INFO] [stderr] 126 | | } [INFO] [stderr] 127 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/renderer.rs:95:40 [INFO] [stderr] | [INFO] [stderr] 95 | .flat_map(move |x| self.render_point(max_depth, x, y).into_iter()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self.render_point(max_depth, x, y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/texture/file.rs:61:41 [INFO] [stderr] | [INFO] [stderr] 61 | let x = (f64::from(bounded_u) * ((width - 1) as f64)).round() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(width - 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/texture/file.rs:62:41 [INFO] [stderr] | [INFO] [stderr] 62 | let y = (f64::from(boundex_v) * ((height - 1) as f64)).round() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(height - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/texture/mod.rs:16:26 [INFO] [stderr] | [INFO] [stderr] 16 | fn lookup(&self, uv: &TextureCoord) -> Color; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `TextureCoord` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/math/matrix4.rs:274:5 [INFO] [stderr] | [INFO] [stderr] 274 | / fn inverse_moderate() { [INFO] [stderr] 275 | | let m = Matrix4::new([ [INFO] [stderr] 276 | | [2.0, 3.0, 1.0, 5.0], [INFO] [stderr] 277 | | [1.0, 0.0, 3.0, 1.0], [INFO] [stderr] ... | [INFO] [stderr] 297 | | } [INFO] [stderr] 298 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/math/matrix4.rs:296:28 [INFO] [stderr] | [INFO] [stderr] 296 | assert!(false, "{:?} should be invertible"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::panic_params)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `rows` [INFO] [stderr] --> src/math/matrix4.rs:338:18 [INFO] [stderr] | [INFO] [stderr] 338 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 338 | for (i, ) in rows.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/math/three_dimensions.rs:386:17 [INFO] [stderr] | [INFO] [stderr] 386 | 3.756327994, [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.756_328` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/math/three_dimensions.rs:432:16 [INFO] [stderr] | [INFO] [stderr] 432 | x: 0.063362486, [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.063_362_49` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/math/three_dimensions.rs:433:16 [INFO] [stderr] | [INFO] [stderr] 433 | y: 0.99795915, [INFO] [stderr] | ^^^^^^^^^^ help: consider changing the type or truncating it to: `0.997_959_14` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/math/three_dimensions.rs:574:37 [INFO] [stderr] | [INFO] [stderr] 574 | let expected = Vector3::new(&v.x * -2.0, &v.y * 3.0, &v.z * 5.0); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `v.x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/math/two_dimensions.rs:51:16 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn dot(&self, other: &Self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/math/two_dimensions.rs:51:30 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn dot(&self, other: &Self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/math/two_dimensions.rs:55:19 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn length(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/math/two_dimensions.rs:59:22 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn normalize(&self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/math/two_dimensions.rs:72:21 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn as_point(&self) -> Point2 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/math/two_dimensions.rs:83:22 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn as_vector(&self) -> Vector2 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/math/two_dimensions.rs:240:45 [INFO] [stderr] | [INFO] [stderr] 240 | assert_eq_within_bound!(v.length(), 31.569605636, EPSILON); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider changing the type or truncating it to: `31.569_605` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/math/two_dimensions.rs:261:20 [INFO] [stderr] | [INFO] [stderr] 261 | x: 0.924940284, [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.924_940_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/math/two_dimensions.rs:262:20 [INFO] [stderr] | [INFO] [stderr] 262 | y: 0.380112445 [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.380_112_44` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/color.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn r(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/color.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn r_f32(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/color.rs:72:14 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn g(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/color.rs:77:18 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn g_f32(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/color.rs:82:14 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn b(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/color.rs:87:18 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn b_f32(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/color.rs:92:19 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn as_u32(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/material.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | / pub fn new_with_textures( [INFO] [stderr] 104 | | ambient_color: Color, [INFO] [stderr] 105 | | ambient_texture: OptionalTexture, [INFO] [stderr] 106 | | diffuse_color: Color, [INFO] [stderr] ... | [INFO] [stderr] 126 | | } [INFO] [stderr] 127 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/renderer.rs:95:40 [INFO] [stderr] | [INFO] [stderr] 95 | .flat_map(move |x| self.render_point(max_depth, x, y).into_iter()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self.render_point(max_depth, x, y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/texture/file.rs:61:41 [INFO] [stderr] | [INFO] [stderr] 61 | let x = (f64::from(bounded_u) * ((width - 1) as f64)).round() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(width - 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/texture/file.rs:62:41 [INFO] [stderr] | [INFO] [stderr] 62 | let y = (f64::from(boundex_v) * ((height - 1) as f64)).round() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(height - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/texture/mod.rs:16:26 [INFO] [stderr] | [INFO] [stderr] 16 | fn lookup(&self, uv: &TextureCoord) -> Color; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `TextureCoord` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 29.59s [INFO] running `"docker" "inspect" "d37e8c3e29837c4fb5482f59a44af2a0773ffc99a4bae80b0f82e70740b644fb"` [INFO] running `"docker" "rm" "-f" "d37e8c3e29837c4fb5482f59a44af2a0773ffc99a4bae80b0f82e70740b644fb"` [INFO] [stdout] d37e8c3e29837c4fb5482f59a44af2a0773ffc99a4bae80b0f82e70740b644fb