[INFO] updating cached repository jzinedine/rust_playground [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jzinedine/rust_playground [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jzinedine/rust_playground" "work/ex/clippy-test-run/sources/stable/gh/jzinedine/rust_playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jzinedine/rust_playground'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jzinedine/rust_playground" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jzinedine/rust_playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jzinedine/rust_playground'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 002ba41f1f0aa77940580583d34b36210029890b [INFO] sha for GitHub repo jzinedine/rust_playground: 002ba41f1f0aa77940580583d34b36210029890b [INFO] validating manifest of jzinedine/rust_playground on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jzinedine/rust_playground on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jzinedine/rust_playground [INFO] finished frobbing jzinedine/rust_playground [INFO] frobbed toml for jzinedine/rust_playground written to work/ex/clippy-test-run/sources/stable/gh/jzinedine/rust_playground/Cargo.toml [INFO] started frobbing jzinedine/rust_playground [INFO] finished frobbing jzinedine/rust_playground [INFO] frobbed toml for jzinedine/rust_playground written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jzinedine/rust_playground/Cargo.toml [INFO] crate jzinedine/rust_playground has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jzinedine/rust_playground against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jzinedine/rust_playground:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 700c422b3730a0a794c4006d9d6db0fb1fc64945bef592a193a10e2cb7863dc2 [INFO] running `"docker" "start" "-a" "700c422b3730a0a794c4006d9d6db0fb1fc64945bef592a193a10e2cb7863dc2"` [INFO] [stderr] Checking hanoi_challenge v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:20:39 [INFO] [stderr] | [INFO] [stderr] 20 | fn check_invariant(arg: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:28:101 [INFO] [stderr] | [INFO] [stderr] 28 | fn solve(source: &mut Vec, destination: &mut Vec, aux: &mut Vec, n: u8, moves: &mut u8) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | *moves = *moves + 3 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `*moves += 3` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | *moves = *moves + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `*moves += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:20:39 [INFO] [stderr] | [INFO] [stderr] 20 | fn check_invariant(arg: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:28:101 [INFO] [stderr] | [INFO] [stderr] 28 | fn solve(source: &mut Vec, destination: &mut Vec, aux: &mut Vec, n: u8, moves: &mut u8) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | *moves = *moves + 3 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `*moves += 3` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | *moves = *moves + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `*moves += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.87s [INFO] running `"docker" "inspect" "700c422b3730a0a794c4006d9d6db0fb1fc64945bef592a193a10e2cb7863dc2"` [INFO] running `"docker" "rm" "-f" "700c422b3730a0a794c4006d9d6db0fb1fc64945bef592a193a10e2cb7863dc2"` [INFO] [stdout] 700c422b3730a0a794c4006d9d6db0fb1fc64945bef592a193a10e2cb7863dc2