[INFO] updating cached repository jxub/collatz-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jxub/collatz-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jxub/collatz-rust" "work/ex/clippy-test-run/sources/stable/gh/jxub/collatz-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jxub/collatz-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jxub/collatz-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jxub/collatz-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jxub/collatz-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 018052c21af7d5a5464cb911324c90dc6b773726 [INFO] sha for GitHub repo jxub/collatz-rust: 018052c21af7d5a5464cb911324c90dc6b773726 [INFO] validating manifest of jxub/collatz-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jxub/collatz-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jxub/collatz-rust [INFO] finished frobbing jxub/collatz-rust [INFO] frobbed toml for jxub/collatz-rust written to work/ex/clippy-test-run/sources/stable/gh/jxub/collatz-rust/Cargo.toml [INFO] started frobbing jxub/collatz-rust [INFO] finished frobbing jxub/collatz-rust [INFO] frobbed toml for jxub/collatz-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jxub/collatz-rust/Cargo.toml [INFO] crate jxub/collatz-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jxub/collatz-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jxub/collatz-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3a46212f1b6c3c5956c0f32e4d61d665f719df58db5e79eee7e27cfc39cb29f5 [INFO] running `"docker" "start" "-a" "3a46212f1b6c3c5956c0f32e4d61d665f719df58db5e79eee7e27cfc39cb29f5"` [INFO] [stderr] Checking collatz v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib/mod.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | self.num = self.num / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.num /= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib/mod.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | self.num = self.num / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.num /= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib/mod.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / if self.num != 1 { [INFO] [stderr] 31 | | true [INFO] [stderr] 32 | | } else { [INFO] [stderr] 33 | | false [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `self.num != 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib/mod.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / if self.num != 1 { [INFO] [stderr] 31 | | true [INFO] [stderr] 32 | | } else { [INFO] [stderr] 33 | | false [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `self.num != 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib/mod.rs:39:20 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn is_even(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib/mod.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / if self.num % 2 == 0 { [INFO] [stderr] 41 | | true [INFO] [stderr] 42 | | } else { [INFO] [stderr] 43 | | false [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `self.num % 2 == 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib/mod.rs:39:20 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn is_even(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/main.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | let mut foo = Data::new(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib/mod.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / if self.num % 2 == 0 { [INFO] [stderr] 41 | | true [INFO] [stderr] 42 | | } else { [INFO] [stderr] 43 | | false [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `self.num % 2 == 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/main.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | let mut foo = Data::new(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.73s [INFO] running `"docker" "inspect" "3a46212f1b6c3c5956c0f32e4d61d665f719df58db5e79eee7e27cfc39cb29f5"` [INFO] running `"docker" "rm" "-f" "3a46212f1b6c3c5956c0f32e4d61d665f719df58db5e79eee7e27cfc39cb29f5"` [INFO] [stdout] 3a46212f1b6c3c5956c0f32e4d61d665f719df58db5e79eee7e27cfc39cb29f5