[INFO] updating cached repository jxson/to-directory
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jxson/to-directory
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jxson/to-directory" "work/ex/clippy-test-run/sources/stable/gh/jxson/to-directory"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jxson/to-directory'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jxson/to-directory" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jxson/to-directory"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jxson/to-directory'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d60d9ee0fe1feca25faba8a72d5209b107bfc43e
[INFO] sha for GitHub repo jxson/to-directory: d60d9ee0fe1feca25faba8a72d5209b107bfc43e
[INFO] validating manifest of jxson/to-directory on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jxson/to-directory on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jxson/to-directory
[INFO] finished frobbing jxson/to-directory
[INFO] frobbed toml for jxson/to-directory written to work/ex/clippy-test-run/sources/stable/gh/jxson/to-directory/Cargo.toml
[INFO] started frobbing jxson/to-directory
[INFO] finished frobbing jxson/to-directory
[INFO] frobbed toml for jxson/to-directory written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jxson/to-directory/Cargo.toml
[INFO] crate jxson/to-directory has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jxson/to-directory against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jxson/to-directory:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] af6afbddc860989b50990e29a90ad5844d6c450afa9637db4b04de25b1479253
[INFO] running `"docker" "start" "-a" "af6afbddc860989b50990e29a90ad5844d6c450afa9637db4b04de25b1479253"`
[INFO] [stderr]     Checking rustc-demangle v0.1.6
[INFO] [stderr]     Checking mkdirp v0.1.0
[INFO] [stderr]     Checking dirs v1.0.4
[INFO] [stderr]     Checking csv v0.15.0
[INFO] [stderr]     Checking bincode v0.8.0
[INFO] [stderr]     Checking loggerv v0.6.0
[INFO] [stderr]    Compiling syn v0.15.18
[INFO] [stderr]     Checking remove_dir_all v0.3.0
[INFO] [stderr]     Checking backtrace v0.3.5
[INFO] [stderr]     Checking tempdir v0.3.6
[INFO] [stderr]     Checking prettytable-rs v0.6.7
[INFO] [stderr]     Checking error-chain v0.11.0
[INFO] [stderr]    Compiling synstructure v0.10.1
[INFO] [stderr]    Compiling failure_derive v0.1.3
[INFO] [stderr]     Checking failure v0.1.3
[INFO] [stderr]     Checking to-directory v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cli.rs:144:13
[INFO] [stderr]     |
[INFO] [stderr] 144 |             action: action,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `action`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cli.rs:145:13
[INFO] [stderr]     |
[INFO] [stderr] 145 |             config: config,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `config`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cli.rs:146:13
[INFO] [stderr]     |
[INFO] [stderr] 146 |             path: path,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `path`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cli.rs:148:13
[INFO] [stderr]     |
[INFO] [stderr] 148 |             name: name,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/database.rs:26:13
[INFO] [stderr]    |
[INFO] [stderr] 26 |             name: name,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/database.rs:27:13
[INFO] [stderr]    |
[INFO] [stderr] 27 |             directory: directory,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/database.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             location: location,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `location`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/database.rs:64:13
[INFO] [stderr]    |
[INFO] [stderr] 64 |             bookmarks: bookmarks,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bookmarks`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cli.rs:144:13
[INFO] [stderr]     |
[INFO] [stderr] 144 |             action: action,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `action`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cli.rs:145:13
[INFO] [stderr]     |
[INFO] [stderr] 145 |             config: config,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `config`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cli.rs:146:13
[INFO] [stderr]     |
[INFO] [stderr] 146 |             path: path,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `path`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/cli.rs:148:13
[INFO] [stderr]     |
[INFO] [stderr] 148 |             name: name,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/database.rs:26:13
[INFO] [stderr]    |
[INFO] [stderr] 26 |             name: name,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/database.rs:27:13
[INFO] [stderr]    |
[INFO] [stderr] 27 |             directory: directory,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/database.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |             location: location,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `location`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/database.rs:64:13
[INFO] [stderr]    |
[INFO] [stderr] 64 |             bookmarks: bookmarks,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bookmarks`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/database.rs:48:9
[INFO] [stderr]    |
[INFO] [stderr] 48 | /         let mut bookmarks = Bookmarks::new();
[INFO] [stderr] 49 | |
[INFO] [stderr] 50 | |         if path.exists() {
[INFO] [stderr] 51 | |             let file = File::open(&path)
[INFO] [stderr] ...  |
[INFO] [stderr] 55 | |             bookmarks = hydrate(file)?;
[INFO] [stderr] 56 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let <mut> bookmarks = if path.exists() { ..; hydrate(file)? } else { Bookmarks::new() };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/database.rs:48:9
[INFO] [stderr]    |
[INFO] [stderr] 48 | /         let mut bookmarks = Bookmarks::new();
[INFO] [stderr] 49 | |
[INFO] [stderr] 50 | |         if path.exists() {
[INFO] [stderr] 51 | |             let file = File::open(&path)
[INFO] [stderr] ...  |
[INFO] [stderr] 55 | |             bookmarks = hydrate(file)?;
[INFO] [stderr] 56 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let <mut> bookmarks = if path.exists() { ..; hydrate(file)? } else { Bookmarks::new() };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]  --> tests/integration_test.rs:7:13
[INFO] [stderr]   |
[INFO] [stderr] 7 |     assert!(out.stdout.len() > 0);
[INFO] [stderr]   |             ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!out.stdout.is_empty()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 | /     match loggerv::init_with_level(LogLevel::Debug) {
[INFO] [stderr] 36 | |         Ok(_) => debug!("logger initialized"),
[INFO] [stderr] 37 | |         Err(_) => {} // Ignored due to tests reusing the log singleton.
[INFO] [stderr] 38 | |     }
[INFO] [stderr]    | |_____^ help: try this: `if let Ok(_) = loggerv::init_with_level(LogLevel::Debug) { debug!("logger initialized") }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 | /     match loggerv::init_with_level(LogLevel::Debug) {
[INFO] [stderr] 36 | |         Ok(_) => debug!("logger initialized"),
[INFO] [stderr] 37 | |         Err(_) => {} // Ignored due to tests reusing the log singleton.
[INFO] [stderr] 38 | |     }
[INFO] [stderr]    | |_____^ help: try this: `if let Ok(_) = loggerv::init_with_level(LogLevel::Debug) { debug!("logger initialized") }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 23.69s
[INFO] running `"docker" "inspect" "af6afbddc860989b50990e29a90ad5844d6c450afa9637db4b04de25b1479253"`
[INFO] running `"docker" "rm" "-f" "af6afbddc860989b50990e29a90ad5844d6c450afa9637db4b04de25b1479253"`
[INFO] [stdout] af6afbddc860989b50990e29a90ad5844d6c450afa9637db4b04de25b1479253