[INFO] updating cached repository jw3126/toygrep
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jw3126/toygrep
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jw3126/toygrep" "work/ex/clippy-test-run/sources/stable/gh/jw3126/toygrep"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jw3126/toygrep'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jw3126/toygrep" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jw3126/toygrep"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jw3126/toygrep'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 0d96da56dce80c785dec3ea894b91fb480f71a7e
[INFO] sha for GitHub repo jw3126/toygrep: 0d96da56dce80c785dec3ea894b91fb480f71a7e
[INFO] validating manifest of jw3126/toygrep on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jw3126/toygrep on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jw3126/toygrep
[INFO] finished frobbing jw3126/toygrep
[INFO] frobbed toml for jw3126/toygrep written to work/ex/clippy-test-run/sources/stable/gh/jw3126/toygrep/Cargo.toml
[INFO] started frobbing jw3126/toygrep
[INFO] finished frobbing jw3126/toygrep
[INFO] frobbed toml for jw3126/toygrep written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jw3126/toygrep/Cargo.toml
[INFO] crate jw3126/toygrep has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jw3126/toygrep against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jw3126/toygrep:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8c6427ef470d07c8d3ff168d349a6336cef447e1de55311a30bf955a7b6bea75
[INFO] running `"docker" "start" "-a" "8c6427ef470d07c8d3ff168d349a6336cef447e1de55311a30bf955a7b6bea75"`
[INFO] [stderr]    Compiling serde v1.0.41
[INFO] [stderr]    Compiling num-traits v0.2.2
[INFO] [stderr]     Checking toygrep v0.1.0 (/opt/crater/workdir)
[INFO] [stderr]    Compiling serde_derive v1.0.41
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/libtoygrep.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 |     task
[INFO] [stderr]    |     ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/libtoygrep.rs:51:16
[INFO] [stderr]    |
[INFO] [stderr] 51 |     let task = SearchTask {pattern, filepath, case_sensitive};
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/libtoygrep.rs:29:14
[INFO] [stderr]    |
[INFO] [stderr] 29 |             .expect(&format!("Cannot open {:?}", filepath));
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Cannot open {:?}", filepath))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/libtoygrep.rs:49:10
[INFO] [stderr]    |
[INFO] [stderr] 49 |         .expect(&format!("Problem with path {}", filename));
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Problem with path {}", filename))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr]    Compiling serde_json v1.0.15
[INFO] [stderr]    Compiling semver v0.8.0
[INFO] [stderr]    Compiling cargo_metadata v0.3.3
[INFO] [stderr]    Compiling skeptic v0.13.2
[INFO] [stderr]    Compiling assert_cli v0.5.4
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/libtoygrep.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 |     task
[INFO] [stderr]    |     ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/libtoygrep.rs:51:16
[INFO] [stderr]    |
[INFO] [stderr] 51 |     let task = SearchTask {pattern, filepath, case_sensitive};
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/libtoygrep.rs:29:14
[INFO] [stderr]    |
[INFO] [stderr] 29 |             .expect(&format!("Cannot open {:?}", filepath));
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Cannot open {:?}", filepath))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/libtoygrep.rs:49:10
[INFO] [stderr]    |
[INFO] [stderr] 49 |         .expect(&format!("Problem with path {}", filename));
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Problem with path {}", filename))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> tests/integration.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         return filepath
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^ help: remove `return` as shown: `filepath`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 24.39s
[INFO] running `"docker" "inspect" "8c6427ef470d07c8d3ff168d349a6336cef447e1de55311a30bf955a7b6bea75"`
[INFO] running `"docker" "rm" "-f" "8c6427ef470d07c8d3ff168d349a6336cef447e1de55311a30bf955a7b6bea75"`
[INFO] [stdout] 8c6427ef470d07c8d3ff168d349a6336cef447e1de55311a30bf955a7b6bea75