[INFO] updating cached repository jvhoven/ngmm [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jvhoven/ngmm [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jvhoven/ngmm" "work/ex/clippy-test-run/sources/stable/gh/jvhoven/ngmm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jvhoven/ngmm'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jvhoven/ngmm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jvhoven/ngmm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jvhoven/ngmm'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 32494bb71343a599a6cd3b7f586507721caeb55f [INFO] sha for GitHub repo jvhoven/ngmm: 32494bb71343a599a6cd3b7f586507721caeb55f [INFO] validating manifest of jvhoven/ngmm on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jvhoven/ngmm on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jvhoven/ngmm [INFO] finished frobbing jvhoven/ngmm [INFO] frobbed toml for jvhoven/ngmm written to work/ex/clippy-test-run/sources/stable/gh/jvhoven/ngmm/Cargo.toml [INFO] started frobbing jvhoven/ngmm [INFO] finished frobbing jvhoven/ngmm [INFO] frobbed toml for jvhoven/ngmm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jvhoven/ngmm/Cargo.toml [INFO] crate jvhoven/ngmm has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jvhoven/ngmm against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jvhoven/ngmm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6420c66321681125b01d75788bae5fe391ac29d2fc5bb955a82e4e5e05c1dab9 [INFO] running `"docker" "start" "-a" "6420c66321681125b01d75788bae5fe391ac29d2fc5bb955a82e4e5e05c1dab9"` [INFO] [stderr] Checking term_size v0.2.3 [INFO] [stderr] Checking clap v2.19.3 [INFO] [stderr] Checking ngmm v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | Module { name: name, path: path } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:22:30 [INFO] [stderr] | [INFO] [stderr] 22 | Module { name: name, path: path } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | Module { name: name, path: path } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:22:30 [INFO] [stderr] | [INFO] [stderr] 22 | Module { name: name, path: path } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:35:40 [INFO] [stderr] | [INFO] [stderr] 35 | fn get_information(&self, subject: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:35:40 [INFO] [stderr] | [INFO] [stderr] 35 | fn get_information(&self, subject: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.62s [INFO] running `"docker" "inspect" "6420c66321681125b01d75788bae5fe391ac29d2fc5bb955a82e4e5e05c1dab9"` [INFO] running `"docker" "rm" "-f" "6420c66321681125b01d75788bae5fe391ac29d2fc5bb955a82e4e5e05c1dab9"` [INFO] [stdout] 6420c66321681125b01d75788bae5fe391ac29d2fc5bb955a82e4e5e05c1dab9