[INFO] updating cached repository jvanbruegge/rust-raytracer-assignment [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jvanbruegge/rust-raytracer-assignment [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jvanbruegge/rust-raytracer-assignment" "work/ex/clippy-test-run/sources/stable/gh/jvanbruegge/rust-raytracer-assignment"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jvanbruegge/rust-raytracer-assignment'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jvanbruegge/rust-raytracer-assignment" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jvanbruegge/rust-raytracer-assignment"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jvanbruegge/rust-raytracer-assignment'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c03ba7ff84c5f72d9af29ed1fe1e3cca9e234760 [INFO] sha for GitHub repo jvanbruegge/rust-raytracer-assignment: c03ba7ff84c5f72d9af29ed1fe1e3cca9e234760 [INFO] validating manifest of jvanbruegge/rust-raytracer-assignment on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jvanbruegge/rust-raytracer-assignment on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jvanbruegge/rust-raytracer-assignment [INFO] finished frobbing jvanbruegge/rust-raytracer-assignment [INFO] frobbed toml for jvanbruegge/rust-raytracer-assignment written to work/ex/clippy-test-run/sources/stable/gh/jvanbruegge/rust-raytracer-assignment/Cargo.toml [INFO] started frobbing jvanbruegge/rust-raytracer-assignment [INFO] finished frobbing jvanbruegge/rust-raytracer-assignment [INFO] frobbed toml for jvanbruegge/rust-raytracer-assignment written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jvanbruegge/rust-raytracer-assignment/Cargo.toml [INFO] crate jvanbruegge/rust-raytracer-assignment has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jvanbruegge/rust-raytracer-assignment against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jvanbruegge/rust-raytracer-assignment:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f93406653a86f988c04520b76d5444502245a3cf0b318c92ef9ae34bf3cf9415 [INFO] running `"docker" "start" "-a" "f93406653a86f988c04520b76d5444502245a3cf0b318c92ef9ae34bf3cf9415"` [INFO] [stderr] Checking coding_assignment v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/object/bvh.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | let v = (y * 1024.0).max(0.0).min(1023.0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/object/bvh.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | let w = (z * 1024.0).max(0.0).min(1023.0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/object/object_loader.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | let x = usize::from_str_radix(n, 10).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/object/bvh.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | let v = (y * 1024.0).max(0.0).min(1023.0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/object/bvh.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | let w = (z * 1024.0).max(0.0).min(1023.0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/object/object_loader.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | let x = usize::from_str_radix(n, 10).unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/object/bvh.rs:48:41 [INFO] [stderr] | [INFO] [stderr] 48 | let mut x = (Wrapping(v) * Wrapping(0x00010001u32)) & Wrapping(0xFF0000FFu32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x0001_0001u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/object/bvh.rs:48:68 [INFO] [stderr] | [INFO] [stderr] 48 | let mut x = (Wrapping(v) * Wrapping(0x00010001u32)) & Wrapping(0xFF0000FFu32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xFF00_00FFu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/object/bvh.rs:49:23 [INFO] [stderr] | [INFO] [stderr] 49 | x = (x * Wrapping(0x00000101u32)) & Wrapping(0x0F00F00Fu32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x0000_0101u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/object/bvh.rs:49:50 [INFO] [stderr] | [INFO] [stderr] 49 | x = (x * Wrapping(0x00000101u32)) & Wrapping(0x0F00F00Fu32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x0F00_F00Fu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/object/bvh.rs:50:23 [INFO] [stderr] | [INFO] [stderr] 50 | x = (x * Wrapping(0x00000011u32)) & Wrapping(0xC30C30C3u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x0000_0011u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/object/bvh.rs:50:50 [INFO] [stderr] | [INFO] [stderr] 50 | x = (x * Wrapping(0x00000011u32)) & Wrapping(0xC30C30C3u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xC30C_30C3u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/object/bvh.rs:52:23 [INFO] [stderr] | [INFO] [stderr] 52 | x = (x * Wrapping(0x00000005u32)) & Wrapping(0x49249249u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x0000_0005u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/object/bvh.rs:52:50 [INFO] [stderr] | [INFO] [stderr] 52 | x = (x * Wrapping(0x00000005u32)) & Wrapping(0x49249249u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x4924_9249u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/main.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | impl_vertex!(Vertex, position); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ref_in_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/main.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | impl_vertex!(Vertex, position); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/object/bvh.rs:48:41 [INFO] [stderr] | [INFO] [stderr] 48 | let mut x = (Wrapping(v) * Wrapping(0x00010001u32)) & Wrapping(0xFF0000FFu32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x0001_0001u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/object/bvh.rs:48:68 [INFO] [stderr] | [INFO] [stderr] 48 | let mut x = (Wrapping(v) * Wrapping(0x00010001u32)) & Wrapping(0xFF0000FFu32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xFF00_00FFu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/object/bvh.rs:49:23 [INFO] [stderr] | [INFO] [stderr] 49 | x = (x * Wrapping(0x00000101u32)) & Wrapping(0x0F00F00Fu32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x0000_0101u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/object/bvh.rs:49:50 [INFO] [stderr] | [INFO] [stderr] 49 | x = (x * Wrapping(0x00000101u32)) & Wrapping(0x0F00F00Fu32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x0F00_F00Fu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/object/bvh.rs:50:23 [INFO] [stderr] | [INFO] [stderr] 50 | x = (x * Wrapping(0x00000011u32)) & Wrapping(0xC30C30C3u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x0000_0011u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/object/bvh.rs:50:50 [INFO] [stderr] | [INFO] [stderr] 50 | x = (x * Wrapping(0x00000011u32)) & Wrapping(0xC30C30C3u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xC30C_30C3u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/object/bvh.rs:52:23 [INFO] [stderr] | [INFO] [stderr] 52 | x = (x * Wrapping(0x00000005u32)) & Wrapping(0x49249249u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x0000_0005u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/object/bvh.rs:52:50 [INFO] [stderr] | [INFO] [stderr] 52 | x = (x * Wrapping(0x00000005u32)) & Wrapping(0x49249249u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x4924_9249u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/main.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | impl_vertex!(Vertex, position); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ref_in_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: Creating a reference that is immediately dereferenced. [INFO] [stderr] --> src/main.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | impl_vertex!(Vertex, position); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_in_deref [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/object/bvh.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | fn leading_zeros(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/object/bvh.rs:78:32 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn construct_bvh(vertices: &Vec<[f32; 4]>, indices: &Vec<[u32; 4]>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[[f32; 4]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/object/bvh.rs:78:57 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn construct_bvh(vertices: &Vec<[f32; 4]>, indices: &Vec<[u32; 4]>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[[u32; 4]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/object/bvh.rs:79:60 [INFO] [stderr] | [INFO] [stderr] 79 | let (xmin, xmax, ymin, ymax, zmin, zmax) = (&vertices).into_iter().fold( [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/object/bvh.rs:102:27 [INFO] [stderr] | [INFO] [stderr] 102 | let centers = indices.into_iter().map(|[x, y, z, _]| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/object/bvh.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | fn leading_zeros(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/object/bvh.rs:163:60 [INFO] [stderr] | [INFO] [stderr] 163 | fn flatten_tree(vec: &mut Vec, tree: &BVH, vertices: &Vec<[f32; 4]>) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[[f32; 4]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/object/bvh.rs:78:32 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn construct_bvh(vertices: &Vec<[f32; 4]>, indices: &Vec<[u32; 4]>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[[f32; 4]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/object/bvh.rs:78:57 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn construct_bvh(vertices: &Vec<[f32; 4]>, indices: &Vec<[u32; 4]>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[[u32; 4]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/object/bvh.rs:217:43 [INFO] [stderr] | [INFO] [stderr] 217 | fn calc_leaf_bb(idx: &[u32; 4], vertices: &Vec<[f32; 4]>) -> [f32; 6] { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[[f32; 4]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/object/bvh.rs:234:14 [INFO] [stderr] | [INFO] [stderr] 234 | indices: &Vec<[u32; 4]>, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[[u32; 4]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/object/bvh.rs:79:60 [INFO] [stderr] | [INFO] [stderr] 79 | let (xmin, xmax, ymin, ymax, zmin, zmax) = (&vertices).into_iter().fold( [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/object/bvh.rs:102:27 [INFO] [stderr] | [INFO] [stderr] 102 | let centers = indices.into_iter().map(|[x, y, z, _]| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/object/bvh.rs:163:60 [INFO] [stderr] | [INFO] [stderr] 163 | fn flatten_tree(vec: &mut Vec, tree: &BVH, vertices: &Vec<[f32; 4]>) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[[f32; 4]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/object/bvh.rs:217:43 [INFO] [stderr] | [INFO] [stderr] 217 | fn calc_leaf_bb(idx: &[u32; 4], vertices: &Vec<[f32; 4]>) -> [f32; 6] { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[[f32; 4]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/object/object_loader.rs:30:29 [INFO] [stderr] | [INFO] [stderr] 30 | let n = s.split_whitespace().skip(2).next().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/object/bvh.rs:234:14 [INFO] [stderr] | [INFO] [stderr] 234 | indices: &Vec<[u32; 4]>, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[[u32; 4]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/object/object_loader.rs:38:21 [INFO] [stderr] | [INFO] [stderr] 38 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/object/object_loader.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | vert_count = vert_count - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vert_count -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/object/object_loader.rs:30:29 [INFO] [stderr] | [INFO] [stderr] 30 | let n = s.split_whitespace().skip(2).next().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/object/object_loader.rs:38:21 [INFO] [stderr] | [INFO] [stderr] 38 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/object/object_loader.rs:45:17 [INFO] [stderr] | [INFO] [stderr] 45 | vert_count = vert_count - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vert_count -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:256:12 [INFO] [stderr] | [INFO] [stderr] 256 | if new_time == push_data.time { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(new_time - push_data.time).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:256:12 [INFO] [stderr] | [INFO] [stderr] 256 | if new_time == push_data.time { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:256:12 [INFO] [stderr] | [INFO] [stderr] 256 | if new_time == push_data.time { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(new_time - push_data.time).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:256:12 [INFO] [stderr] | [INFO] [stderr] 256 | if new_time == push_data.time { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `coding_assignment`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `coding_assignment`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f93406653a86f988c04520b76d5444502245a3cf0b318c92ef9ae34bf3cf9415"` [INFO] running `"docker" "rm" "-f" "f93406653a86f988c04520b76d5444502245a3cf0b318c92ef9ae34bf3cf9415"` [INFO] [stdout] f93406653a86f988c04520b76d5444502245a3cf0b318c92ef9ae34bf3cf9415