[INFO] updating cached repository justjake/appear-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/justjake/appear-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/justjake/appear-rs" "work/ex/clippy-test-run/sources/stable/gh/justjake/appear-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/justjake/appear-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/justjake/appear-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justjake/appear-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justjake/appear-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fc931d99a304a49047603c45072bba39b7c40f0a [INFO] sha for GitHub repo justjake/appear-rs: fc931d99a304a49047603c45072bba39b7c40f0a [INFO] validating manifest of justjake/appear-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of justjake/appear-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing justjake/appear-rs [INFO] finished frobbing justjake/appear-rs [INFO] frobbed toml for justjake/appear-rs written to work/ex/clippy-test-run/sources/stable/gh/justjake/appear-rs/Cargo.toml [INFO] started frobbing justjake/appear-rs [INFO] finished frobbing justjake/appear-rs [INFO] frobbed toml for justjake/appear-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justjake/appear-rs/Cargo.toml [INFO] crate justjake/appear-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting justjake/appear-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/justjake/appear-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f162aafd9b9f8c78293bdf0ff6c7ce4650dfdfdb701571e7dee00c464dc335ab [INFO] running `"docker" "start" "-a" "f162aafd9b9f8c78293bdf0ff6c7ce4650dfdfdb701571e7dee00c464dc335ab"` [INFO] [stderr] Checking libc v0.2.39 [INFO] [stderr] Checking simple-error v0.1.10 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking regex v0.2.10 [INFO] [stderr] Checking appear-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | / return Ok(ProcessInfo { [INFO] [stderr] 54 | | pid: i32::from_str_radix(pid, 10).unwrap(), [INFO] [stderr] 55 | | ppid: match ppid { [INFO] [stderr] 56 | | "0" => None, [INFO] [stderr] ... | [INFO] [stderr] 59 | | command: command, [INFO] [stderr] 60 | | }) [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 53 | Ok(ProcessInfo { [INFO] [stderr] 54 | pid: i32::from_str_radix(pid, 10).unwrap(), [INFO] [stderr] 55 | ppid: match ppid { [INFO] [stderr] 56 | "0" => None, [INFO] [stderr] 57 | _ => Some(i32::from_str_radix(ppid, 10).unwrap()), [INFO] [stderr] 58 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | / return Ok(ProcessInfo { [INFO] [stderr] 54 | | pid: i32::from_str_radix(pid, 10).unwrap(), [INFO] [stderr] 55 | | ppid: match ppid { [INFO] [stderr] 56 | | "0" => None, [INFO] [stderr] ... | [INFO] [stderr] 59 | | command: command, [INFO] [stderr] 60 | | }) [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 53 | Ok(ProcessInfo { [INFO] [stderr] 54 | pid: i32::from_str_radix(pid, 10).unwrap(), [INFO] [stderr] 55 | ppid: match ppid { [INFO] [stderr] 56 | "0" => None, [INFO] [stderr] 57 | _ => Some(i32::from_str_radix(ppid, 10).unwrap()), [INFO] [stderr] 58 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.73s [INFO] running `"docker" "inspect" "f162aafd9b9f8c78293bdf0ff6c7ce4650dfdfdb701571e7dee00c464dc335ab"` [INFO] running `"docker" "rm" "-f" "f162aafd9b9f8c78293bdf0ff6c7ce4650dfdfdb701571e7dee00c464dc335ab"` [INFO] [stdout] f162aafd9b9f8c78293bdf0ff6c7ce4650dfdfdb701571e7dee00c464dc335ab