[INFO] updating cached repository justinturpin/ubuntu-package-search-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/justinturpin/ubuntu-package-search-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/justinturpin/ubuntu-package-search-rs" "work/ex/clippy-test-run/sources/stable/gh/justinturpin/ubuntu-package-search-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/justinturpin/ubuntu-package-search-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/justinturpin/ubuntu-package-search-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justinturpin/ubuntu-package-search-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justinturpin/ubuntu-package-search-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 48ecf7a5358f270f03c7eed5d07b4b85d17e92bb [INFO] sha for GitHub repo justinturpin/ubuntu-package-search-rs: 48ecf7a5358f270f03c7eed5d07b4b85d17e92bb [INFO] validating manifest of justinturpin/ubuntu-package-search-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of justinturpin/ubuntu-package-search-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing justinturpin/ubuntu-package-search-rs [INFO] finished frobbing justinturpin/ubuntu-package-search-rs [INFO] frobbed toml for justinturpin/ubuntu-package-search-rs written to work/ex/clippy-test-run/sources/stable/gh/justinturpin/ubuntu-package-search-rs/Cargo.toml [INFO] started frobbing justinturpin/ubuntu-package-search-rs [INFO] finished frobbing justinturpin/ubuntu-package-search-rs [INFO] frobbed toml for justinturpin/ubuntu-package-search-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justinturpin/ubuntu-package-search-rs/Cargo.toml [INFO] crate justinturpin/ubuntu-package-search-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting justinturpin/ubuntu-package-search-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/justinturpin/ubuntu-package-search-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6e346cecf8bd74a47be7e57a184f3d15576d7693f0b3a82ddd1a49a7f5b95534 [INFO] running `"docker" "start" "-a" "6e346cecf8bd74a47be7e57a184f3d15576d7693f0b3a82ddd1a49a7f5b95534"` [INFO] [stderr] Compiling same-file v1.0.4 [INFO] [stderr] Compiling bytecount v0.3.2 [INFO] [stderr] Checking httpdate v0.3.2 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling serde_json v1.0.32 [INFO] [stderr] Compiling backtrace v0.3.9 [INFO] [stderr] Checking flate2 v1.0.5 [INFO] [stderr] Compiling syn v0.15.18 [INFO] [stderr] Checking rusqlite v0.15.0 [INFO] [stderr] Checking tokio-threadpool v0.1.8 [INFO] [stderr] Checking tera v0.11.19 [INFO] [stderr] Compiling walkdir v2.2.6 [INFO] [stderr] Compiling error-chain v0.11.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling parking_lot_core v0.3.1 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.3 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling gotham_derive v0.3.0 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking hyper v0.12.13 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Compiling cargo_metadata v0.5.8 [INFO] [stderr] Checking reqwest v0.9.4 [INFO] [stderr] Compiling skeptic v0.13.3 [INFO] [stderr] Compiling borrow-bag v1.0.0 [INFO] [stderr] Checking gotham v0.3.0 [INFO] [stderr] Checking ubuntu-package-search v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] --> src/loader.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | reader: reader [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | reader: reader [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/sqlite.rs:46:49 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn search_packages(&self, query_string: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/sqlite.rs:74:46 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn search_files(&self, query_string: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/loader.rs:35:52 [INFO] [stderr] | [INFO] [stderr] 35 | let line_split: Vec<&str> = line.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/loader.rs:118:47 [INFO] [stderr] | [INFO] [stderr] 118 | for package in packages.split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/sqlite.rs:46:49 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn search_packages(&self, query_string: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/sqlite.rs:74:46 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn search_files(&self, query_string: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/loader.rs:35:52 [INFO] [stderr] | [INFO] [stderr] 35 | let line_split: Vec<&str> = line.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/loader.rs:118:47 [INFO] [stderr] | [INFO] [stderr] 118 | for package in packages.split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 40.11s [INFO] running `"docker" "inspect" "6e346cecf8bd74a47be7e57a184f3d15576d7693f0b3a82ddd1a49a7f5b95534"` [INFO] running `"docker" "rm" "-f" "6e346cecf8bd74a47be7e57a184f3d15576d7693f0b3a82ddd1a49a7f5b95534"` [INFO] [stdout] 6e346cecf8bd74a47be7e57a184f3d15576d7693f0b3a82ddd1a49a7f5b95534