[INFO] updating cached repository justinmichaud/rust-raytracer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/justinmichaud/rust-raytracer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/justinmichaud/rust-raytracer" "work/ex/clippy-test-run/sources/stable/gh/justinmichaud/rust-raytracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/justinmichaud/rust-raytracer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/justinmichaud/rust-raytracer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justinmichaud/rust-raytracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justinmichaud/rust-raytracer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a1d5aafb53f3a39dc93d901a19a0d44e13cb0671 [INFO] sha for GitHub repo justinmichaud/rust-raytracer: a1d5aafb53f3a39dc93d901a19a0d44e13cb0671 [INFO] validating manifest of justinmichaud/rust-raytracer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of justinmichaud/rust-raytracer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing justinmichaud/rust-raytracer [INFO] finished frobbing justinmichaud/rust-raytracer [INFO] frobbed toml for justinmichaud/rust-raytracer written to work/ex/clippy-test-run/sources/stable/gh/justinmichaud/rust-raytracer/Cargo.toml [INFO] started frobbing justinmichaud/rust-raytracer [INFO] finished frobbing justinmichaud/rust-raytracer [INFO] frobbed toml for justinmichaud/rust-raytracer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justinmichaud/rust-raytracer/Cargo.toml [INFO] crate justinmichaud/rust-raytracer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting justinmichaud/rust-raytracer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/justinmichaud/rust-raytracer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cdcdffbd2ea3dd8381d5d7f6d4ebf7c0193a4fb1d542ddff5c1dd51d60428d37 [INFO] running `"docker" "start" "-a" "cdcdffbd2ea3dd8381d5d7f6d4ebf7c0193a4fb1d542ddff5c1dd51d60428d37"` [INFO] [stderr] Compiling heapsize v0.4.0 [INFO] [stderr] Checking deflate v0.7.6 [INFO] [stderr] Checking rayon-core v1.0.0 [INFO] [stderr] Checking rayon v0.7.0 [INFO] [stderr] Checking euclid v0.13.0 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking jpeg-decoder v0.1.12 [INFO] [stderr] Checking image v0.12.3 [INFO] [stderr] Checking hello_rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `incident_from` [INFO] [stderr] --> src/world.rs:237:56 [INFO] [stderr] | [INFO] [stderr] 237 | fn refract_colour(obj : &WorldObject, at : WorldPoint, incident_from : WorldPoint, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_incident_from` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `contains` [INFO] [stderr] --> src/world.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn contains(&self, pos : WorldPoint) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world.rs:11:56 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn trace(pos : WorldPoint, dir : WorldVec, world : &Vec) -> Option<(&WorldObject, f32)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[WorldObject]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/world.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / match s.intersect(pos, dir) { [INFO] [stderr] 16 | | Some(i) => { [INFO] [stderr] 17 | | if result.is_none() || i < result.unwrap().1 { [INFO] [stderr] 18 | | result = Some((s, i)) [INFO] [stderr] ... | [INFO] [stderr] 21 | | None => () [INFO] [stderr] 22 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | if let Some(i) = s.intersect(pos, dir) { [INFO] [stderr] 16 | if result.is_none() || i < result.unwrap().1 { [INFO] [stderr] 17 | result = Some((s, i)) [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world.rs:29:25 [INFO] [stderr] | [INFO] [stderr] 29 | world : &Vec) -> Colour { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[WorldObject]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world.rs:37:26 [INFO] [stderr] | [INFO] [stderr] 37 | world : &Vec, roughness : f32) -> Colour { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[WorldObject]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world.rs:73:48 [INFO] [stderr] | [INFO] [stderr] 73 | incident_ray : WorldVec, world : &Vec, depth : u8) -> Colour; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[WorldObject]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused variable: `incident_from` [INFO] [stderr] --> src/world.rs:237:56 [INFO] [stderr] | [INFO] [stderr] 237 | fn refract_colour(obj : &WorldObject, at : WorldPoint, incident_from : WorldPoint, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_incident_from` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/world.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | / match trace(at+ray*0.01f32, ray, world) { [INFO] [stderr] 182 | | Some((intersected, t)) => { [INFO] [stderr] 183 | | if s as *const _ != intersected as *const _ { [INFO] [stderr] 184 | | continue; [INFO] [stderr] ... | [INFO] [stderr] 194 | | _ => () [INFO] [stderr] 195 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 181 | if let Some((intersected, t)) = trace(at+ray*0.01f32, ray, world) { [INFO] [stderr] 182 | if s as *const _ != intersected as *const _ { [INFO] [stderr] 183 | continue; [INFO] [stderr] 184 | } [INFO] [stderr] 185 | let light_colour = s.material [INFO] [stderr] 186 | .colour(s, at + ray * t, at, ray, world, depth + 1) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world.rs:238:52 [INFO] [stderr] | [INFO] [stderr] 238 | incident_ray : WorldVec, world : &Vec, depth : u8) -> Colour { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[WorldObject]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:11:67 [INFO] [stderr] | [INFO] [stderr] 11 | fn get_pixel(x : f32, y : f32, width : u32, height : u32, world : &Vec) -> Colour { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[WorldObject]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | let ref mut out = File::create(&Path::new("out.png")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^------------------------------------------------ help: try: `let out = &mut File::create(&Path::new("out.png")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: method is never used: `contains` [INFO] [stderr] --> src/world.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn contains(&self, pos : WorldPoint) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world.rs:11:56 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn trace(pos : WorldPoint, dir : WorldVec, world : &Vec) -> Option<(&WorldObject, f32)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[WorldObject]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/world.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / match s.intersect(pos, dir) { [INFO] [stderr] 16 | | Some(i) => { [INFO] [stderr] 17 | | if result.is_none() || i < result.unwrap().1 { [INFO] [stderr] 18 | | result = Some((s, i)) [INFO] [stderr] ... | [INFO] [stderr] 21 | | None => () [INFO] [stderr] 22 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | if let Some(i) = s.intersect(pos, dir) { [INFO] [stderr] 16 | if result.is_none() || i < result.unwrap().1 { [INFO] [stderr] 17 | result = Some((s, i)) [INFO] [stderr] 18 | } [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world.rs:29:25 [INFO] [stderr] | [INFO] [stderr] 29 | world : &Vec) -> Colour { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[WorldObject]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world.rs:37:26 [INFO] [stderr] | [INFO] [stderr] 37 | world : &Vec, roughness : f32) -> Colour { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[WorldObject]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world.rs:73:48 [INFO] [stderr] | [INFO] [stderr] 73 | incident_ray : WorldVec, world : &Vec, depth : u8) -> Colour; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[WorldObject]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/world.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | / match trace(at+ray*0.01f32, ray, world) { [INFO] [stderr] 182 | | Some((intersected, t)) => { [INFO] [stderr] 183 | | if s as *const _ != intersected as *const _ { [INFO] [stderr] 184 | | continue; [INFO] [stderr] ... | [INFO] [stderr] 194 | | _ => () [INFO] [stderr] 195 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 181 | if let Some((intersected, t)) = trace(at+ray*0.01f32, ray, world) { [INFO] [stderr] 182 | if s as *const _ != intersected as *const _ { [INFO] [stderr] 183 | continue; [INFO] [stderr] 184 | } [INFO] [stderr] 185 | let light_colour = s.material [INFO] [stderr] 186 | .colour(s, at + ray * t, at, ray, world, depth + 1) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/world.rs:238:52 [INFO] [stderr] | [INFO] [stderr] 238 | incident_ray : WorldVec, world : &Vec, depth : u8) -> Colour { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[WorldObject]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:11:67 [INFO] [stderr] | [INFO] [stderr] 11 | fn get_pixel(x : f32, y : f32, width : u32, height : u32, world : &Vec) -> Colour { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[WorldObject]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | let ref mut out = File::create(&Path::new("out.png")).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^------------------------------------------------ help: try: `let out = &mut File::create(&Path::new("out.png")).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.41s [INFO] running `"docker" "inspect" "cdcdffbd2ea3dd8381d5d7f6d4ebf7c0193a4fb1d542ddff5c1dd51d60428d37"` [INFO] running `"docker" "rm" "-f" "cdcdffbd2ea3dd8381d5d7f6d4ebf7c0193a4fb1d542ddff5c1dd51d60428d37"` [INFO] [stdout] cdcdffbd2ea3dd8381d5d7f6d4ebf7c0193a4fb1d542ddff5c1dd51d60428d37