[INFO] updating cached repository justinjhendrick/a-light-in-the-dark
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/justinjhendrick/a-light-in-the-dark
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/justinjhendrick/a-light-in-the-dark" "work/ex/clippy-test-run/sources/stable/gh/justinjhendrick/a-light-in-the-dark"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/justinjhendrick/a-light-in-the-dark'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/justinjhendrick/a-light-in-the-dark" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justinjhendrick/a-light-in-the-dark"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justinjhendrick/a-light-in-the-dark'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] b74de414ce65c21297b8620a00a6ec146607a7be
[INFO] sha for GitHub repo justinjhendrick/a-light-in-the-dark: b74de414ce65c21297b8620a00a6ec146607a7be
[INFO] validating manifest of justinjhendrick/a-light-in-the-dark on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of justinjhendrick/a-light-in-the-dark on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing justinjhendrick/a-light-in-the-dark
[INFO] finished frobbing justinjhendrick/a-light-in-the-dark
[INFO] frobbed toml for justinjhendrick/a-light-in-the-dark written to work/ex/clippy-test-run/sources/stable/gh/justinjhendrick/a-light-in-the-dark/Cargo.toml
[INFO] started frobbing justinjhendrick/a-light-in-the-dark
[INFO] finished frobbing justinjhendrick/a-light-in-the-dark
[INFO] frobbed toml for justinjhendrick/a-light-in-the-dark written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justinjhendrick/a-light-in-the-dark/Cargo.toml
[INFO] crate justinjhendrick/a-light-in-the-dark has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting justinjhendrick/a-light-in-the-dark against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/justinjhendrick/a-light-in-the-dark:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 58de22afbd3cc5e07201fc994a3d9f6f621eaf4e3bfc622b168754cf2925a919
[INFO] running `"docker" "start" "-a" "58de22afbd3cc5e07201fc994a3d9f6f621eaf4e3bfc622b168754cf2925a919"`
[INFO] [stderr]     Checking serde v1.0.41
[INFO] [stderr]    Compiling libloading v0.5.0
[INFO] [stderr]     Checking tempfile v3.0.1
[INFO] [stderr]     Checking crossbeam-epoch v0.3.1
[INFO] [stderr]     Checking ordered-float v0.5.0
[INFO] [stderr]    Compiling gl_generator v0.9.0
[INFO] [stderr]     Checking nalgebra v0.13.1
[INFO] [stderr]    Compiling serde_derive v1.0.41
[INFO] [stderr]     Checking rusttype v0.4.3
[INFO] [stderr]     Checking crossbeam-deque v0.2.0
[INFO] [stderr]     Checking rayon-core v1.4.0
[INFO] [stderr]     Checking piston2d-graphics v0.26.0
[INFO] [stderr]     Checking dlib v0.4.1
[INFO] [stderr]    Compiling gl v0.10.0
[INFO] [stderr]     Checking wayland-sys v0.12.5
[INFO] [stderr]     Checking rayon v1.0.1
[INFO] [stderr]     Checking wayland-client v0.12.5
[INFO] [stderr]     Checking wayland-protocols v0.12.5
[INFO] [stderr]     Checking wayland-kbd v0.13.1
[INFO] [stderr]     Checking jpeg-decoder v0.1.14
[INFO] [stderr]     Checking image v0.18.0
[INFO] [stderr]     Checking pistoncore-input v0.20.0
[INFO] [stderr]     Checking wayland-window v0.13.3
[INFO] [stderr]     Checking winit v0.10.0
[INFO] [stderr]     Checking pistoncore-window v0.31.0
[INFO] [stderr]     Checking glutin v0.12.2
[INFO] [stderr]     Checking pistoncore-event_loop v0.36.0
[INFO] [stderr]     Checking piston2d-opengl_graphics v0.52.1
[INFO] [stderr]     Checking piston v0.36.0
[INFO] [stderr]     Checking pistoncore-glutin_window v0.45.3
[INFO] [stderr]     Checking ncollide_math v0.8.0
[INFO] [stderr]     Checking ncollide_utils v0.8.0
[INFO] [stderr]     Checking ncollide_procedural v0.8.0
[INFO] [stderr]     Checking ncollide_geometry v0.5.1
[INFO] [stderr]     Checking ncollide_transformation v0.8.0
[INFO] [stderr]     Checking ncollide_pipeline v0.12.1
[INFO] [stderr]     Checking ncollide v0.13.0
[INFO] [stderr]     Checking nphysics2d v0.7.2
[INFO] [stderr]     Checking a_light_in_the_dark v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/player.rs:25:9
[INFO] [stderr]    |
[INFO] [stderr] 25 |         result
[INFO] [stderr]    |         ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/player.rs:24:22
[INFO] [stderr]    |
[INFO] [stderr] 24 |         let result = matrix.translation * Point2::new(1.0, 1.0);
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Isometry2`
[INFO] [stderr]  --> src/physics.rs:5:47
[INFO] [stderr]   |
[INFO] [stderr] 5 | use nalgebra::{Point2, Translation2, Vector2, Isometry2};
[INFO] [stderr]   |                                               ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `graphics::color::WHITE`
[INFO] [stderr]   --> src/physics.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 | use graphics::color::WHITE;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/player.rs:25:9
[INFO] [stderr]    |
[INFO] [stderr] 25 |         result
[INFO] [stderr]    |         ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/player.rs:24:22
[INFO] [stderr]    |
[INFO] [stderr] 24 |         let result = matrix.translation * Point2::new(1.0, 1.0);
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Isometry2`
[INFO] [stderr]  --> src/physics.rs:5:47
[INFO] [stderr]   |
[INFO] [stderr] 5 | use nalgebra::{Point2, Translation2, Vector2, Isometry2};
[INFO] [stderr]   |                                               ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `graphics::color::WHITE`
[INFO] [stderr]   --> src/physics.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 | use graphics::color::WHITE;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:53:32
[INFO] [stderr]    |
[INFO] [stderr] 53 |     fn update(&mut self, args: &UpdateArgs) {
[INFO] [stderr]    |                                ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:53:32
[INFO] [stderr]    |
[INFO] [stderr] 53 |     fn update(&mut self, args: &UpdateArgs) {
[INFO] [stderr]    |                                ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 46.42s
[INFO] running `"docker" "inspect" "58de22afbd3cc5e07201fc994a3d9f6f621eaf4e3bfc622b168754cf2925a919"`
[INFO] running `"docker" "rm" "-f" "58de22afbd3cc5e07201fc994a3d9f6f621eaf4e3bfc622b168754cf2925a919"`
[INFO] [stdout] 58de22afbd3cc5e07201fc994a3d9f6f621eaf4e3bfc622b168754cf2925a919