[INFO] updating cached repository justicz/henlo_linker [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/justicz/henlo_linker [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/justicz/henlo_linker" "work/ex/clippy-test-run/sources/stable/gh/justicz/henlo_linker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/justicz/henlo_linker'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/justicz/henlo_linker" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justicz/henlo_linker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justicz/henlo_linker'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 89b94af0987ae98ffc6adfa17560191d4c191b13 [INFO] sha for GitHub repo justicz/henlo_linker: 89b94af0987ae98ffc6adfa17560191d4c191b13 [INFO] validating manifest of justicz/henlo_linker on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of justicz/henlo_linker on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing justicz/henlo_linker [INFO] finished frobbing justicz/henlo_linker [INFO] frobbed toml for justicz/henlo_linker written to work/ex/clippy-test-run/sources/stable/gh/justicz/henlo_linker/Cargo.toml [INFO] started frobbing justicz/henlo_linker [INFO] finished frobbing justicz/henlo_linker [INFO] frobbed toml for justicz/henlo_linker written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justicz/henlo_linker/Cargo.toml [INFO] crate justicz/henlo_linker has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting justicz/henlo_linker against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/justicz/henlo_linker:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e3ca3d9c7e930c332a8ac2360310e89b4f15536565d49af891148e0261b03313 [INFO] running `"docker" "start" "-a" "e3ca3d9c7e930c332a8ac2360310e89b4f15536565d49af891148e0261b03313"` [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Checking parity-wasm v0.31.0 [INFO] [stderr] Compiling scroll_derive v0.9.4 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Checking scroll v0.9.0 [INFO] [stderr] Checking goblin v0.0.15 [INFO] [stderr] Checking object v0.9.0 [INFO] [stderr] Checking henlo_linker v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | const CLEAR_R_AC: u16 = 0b0110110110110000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0110_1101_1011_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:12:25 [INFO] [stderr] | [INFO] [stderr] 12 | const SHIFT_R_AC: u16 = 0b0011110100000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0011_1101_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | const JMP_R_AC: u16 = 0b1011110000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b1011_1100_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:14:23 [INFO] [stderr] | [INFO] [stderr] 14 | const ADDI_R_AC: u8 = 0b00011100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | const HLT: u8 = 0b11111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return ac; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `ac` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:74:21 [INFO] [stderr] | [INFO] [stderr] 74 | Ok(file) => return Some(file), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(file)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | const CLEAR_R_AC: u16 = 0b0110110110110000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0110_1101_1011_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:12:25 [INFO] [stderr] | [INFO] [stderr] 12 | const SHIFT_R_AC: u16 = 0b0011110100000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b0011_1101_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | const JMP_R_AC: u16 = 0b1011110000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0b1011_1100_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:14:23 [INFO] [stderr] | [INFO] [stderr] 14 | const ADDI_R_AC: u8 = 0b00011100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | const HLT: u8 = 0b11111111; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return ac; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `ac` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:74:21 [INFO] [stderr] | [INFO] [stderr] 74 | Ok(file) => return Some(file), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(file)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | / match symbol.name() { [INFO] [stderr] 132 | | Some(ref name) => { [INFO] [stderr] 133 | | ss.name = Some(String::from(*name)); [INFO] [stderr] 134 | | [INFO] [stderr] ... | [INFO] [stderr] 153 | | None => () [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 131 | if let Some(ref name) = symbol.name() { [INFO] [stderr] 132 | ss.name = Some(String::from(*name)); [INFO] [stderr] 133 | [INFO] [stderr] 134 | match symbol.section_kind() { [INFO] [stderr] 135 | Some(_) => { [INFO] [stderr] 136 | match symbol_addresses.get(*name) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:135:21 [INFO] [stderr] | [INFO] [stderr] 135 | / match symbol.section_kind() { [INFO] [stderr] 136 | | Some(_) => { [INFO] [stderr] 137 | | match symbol_addresses.get(*name) { [INFO] [stderr] 138 | | Some(_) => { [INFO] [stderr] ... | [INFO] [stderr] 150 | | None => () [INFO] [stderr] 151 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 135 | if let Some(_) = symbol.section_kind() { [INFO] [stderr] 136 | match symbol_addresses.get(*name) { [INFO] [stderr] 137 | Some(_) => { [INFO] [stderr] 138 | println!("Duplicate symbol: {}", *name); [INFO] [stderr] 139 | return; [INFO] [stderr] 140 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | / match main_last_instruction_offset { [INFO] [stderr] 180 | | Some(offset) => { [INFO] [stderr] 181 | | let mut v = Vec::new(); [INFO] [stderr] 182 | | v.push(HLT); [INFO] [stderr] ... | [INFO] [stderr] 186 | | None => () [INFO] [stderr] 187 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 179 | if let Some(offset) = main_last_instruction_offset { [INFO] [stderr] 180 | let mut v = Vec::new(); [INFO] [stderr] 181 | v.push(HLT); [INFO] [stderr] 182 | v.push(HLT); [INFO] [stderr] 183 | executable.splice(offset..(offset + 2), v.iter().cloned()); [INFO] [stderr] 184 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | / match symbol.name() { [INFO] [stderr] 132 | | Some(ref name) => { [INFO] [stderr] 133 | | ss.name = Some(String::from(*name)); [INFO] [stderr] 134 | | [INFO] [stderr] ... | [INFO] [stderr] 153 | | None => () [INFO] [stderr] 154 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 131 | if let Some(ref name) = symbol.name() { [INFO] [stderr] 132 | ss.name = Some(String::from(*name)); [INFO] [stderr] 133 | [INFO] [stderr] 134 | match symbol.section_kind() { [INFO] [stderr] 135 | Some(_) => { [INFO] [stderr] 136 | match symbol_addresses.get(*name) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:135:21 [INFO] [stderr] | [INFO] [stderr] 135 | / match symbol.section_kind() { [INFO] [stderr] 136 | | Some(_) => { [INFO] [stderr] 137 | | match symbol_addresses.get(*name) { [INFO] [stderr] 138 | | Some(_) => { [INFO] [stderr] ... | [INFO] [stderr] 150 | | None => () [INFO] [stderr] 151 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 135 | if let Some(_) = symbol.section_kind() { [INFO] [stderr] 136 | match symbol_addresses.get(*name) { [INFO] [stderr] 137 | Some(_) => { [INFO] [stderr] 138 | println!("Duplicate symbol: {}", *name); [INFO] [stderr] 139 | return; [INFO] [stderr] 140 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | / match main_last_instruction_offset { [INFO] [stderr] 180 | | Some(offset) => { [INFO] [stderr] 181 | | let mut v = Vec::new(); [INFO] [stderr] 182 | | v.push(HLT); [INFO] [stderr] ... | [INFO] [stderr] 186 | | None => () [INFO] [stderr] 187 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 179 | if let Some(offset) = main_last_instruction_offset { [INFO] [stderr] 180 | let mut v = Vec::new(); [INFO] [stderr] 181 | v.push(HLT); [INFO] [stderr] 182 | v.push(HLT); [INFO] [stderr] 183 | executable.splice(offset..(offset + 2), v.iter().cloned()); [INFO] [stderr] 184 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.46s [INFO] running `"docker" "inspect" "e3ca3d9c7e930c332a8ac2360310e89b4f15536565d49af891148e0261b03313"` [INFO] running `"docker" "rm" "-f" "e3ca3d9c7e930c332a8ac2360310e89b4f15536565d49af891148e0261b03313"` [INFO] [stdout] e3ca3d9c7e930c332a8ac2360310e89b4f15536565d49af891148e0261b03313