[INFO] updating cached repository justacid/breakout-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/justacid/breakout-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/justacid/breakout-rs" "work/ex/clippy-test-run/sources/stable/gh/justacid/breakout-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/justacid/breakout-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/justacid/breakout-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justacid/breakout-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justacid/breakout-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 306880f552f5a6967f3f04bf16b994e7dc707153 [INFO] sha for GitHub repo justacid/breakout-rs: 306880f552f5a6967f3f04bf16b994e7dc707153 [INFO] validating manifest of justacid/breakout-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of justacid/breakout-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing justacid/breakout-rs [INFO] finished frobbing justacid/breakout-rs [INFO] frobbed toml for justacid/breakout-rs written to work/ex/clippy-test-run/sources/stable/gh/justacid/breakout-rs/Cargo.toml [INFO] started frobbing justacid/breakout-rs [INFO] finished frobbing justacid/breakout-rs [INFO] frobbed toml for justacid/breakout-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/justacid/breakout-rs/Cargo.toml [INFO] crate justacid/breakout-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting justacid/breakout-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/justacid/breakout-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 83c63977a516442860546fac61bf50cae13136bf133917c7d8c7aeb204788d39 [INFO] running `"docker" "start" "-a" "83c63977a516442860546fac61bf50cae13136bf133917c7d8c7aeb204788d39"` [INFO] [stderr] Checking shared_library v0.1.7 [INFO] [stderr] Compiling x11-dl v2.16.0 [INFO] [stderr] Compiling cmake v0.1.29 [INFO] [stderr] Checking rayon-core v1.3.0 [INFO] [stderr] Compiling gl_generator v0.7.0 [INFO] [stderr] Checking num-bigint v0.1.41 [INFO] [stderr] Checking piston2d-graphics v0.24.0 [INFO] [stderr] Checking gfx v0.16.3 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Compiling glfw-sys v3.2.2 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Compiling gl v0.7.0 [INFO] [stderr] Compiling gfx_gl v0.4.0 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking num-rational v0.1.40 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking num v0.1.40 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking glfw v0.20.0 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking wayland-window v0.8.0 [INFO] [stderr] Checking winit v0.8.3 [INFO] [stderr] Checking gfx_device_gl v0.14.6 [INFO] [stderr] Checking glutin v0.10.1 [INFO] [stderr] Checking piston-gfx_texture v0.30.0 [INFO] [stderr] Checking pistoncore-glfw_window v0.39.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.47.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.43.0 [INFO] [stderr] Checking piston_window v0.74.0 [INFO] [stderr] Checking breakout-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | settings: settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/ball.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | bounds: bounds, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bounds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/ball.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/ball.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | velocity: velocity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `velocity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paddle.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | bounds: bounds, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bounds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paddle.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paddle.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | board_size: board_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `board_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paddle.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | speed: speed, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `speed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/brick.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | bounds: bounds, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bounds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/brick.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rect.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rect.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rect.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rect.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | settings: settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/ball.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | bounds: bounds, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bounds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/ball.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/ball.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | velocity: velocity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `velocity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paddle.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | bounds: bounds, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bounds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paddle.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paddle.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | board_size: board_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `board_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/paddle.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | speed: speed, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `speed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/brick.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | bounds: bounds, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bounds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/objects/brick.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rect.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rect.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rect.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rect.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:114:57 [INFO] [stderr] | [INFO] [stderr] 114 | bricks.push(Brick::new(Rect::new(50.0 + x as f64 * 55.0, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:115:58 [INFO] [stderr] | [INFO] [stderr] 115 | 100.0 + y as f64 * 15.0, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | if let Some(_) = e.render_args() { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 50 | | window.draw_2d(&e, |c, g| { [INFO] [stderr] 51 | | game.render(c, g); [INFO] [stderr] 52 | | }); [INFO] [stderr] 53 | | }; [INFO] [stderr] | |_____________- help: try this: `if e.render_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:114:57 [INFO] [stderr] | [INFO] [stderr] 114 | bricks.push(Brick::new(Rect::new(50.0 + x as f64 * 55.0, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/game.rs:115:58 [INFO] [stderr] | [INFO] [stderr] 115 | 100.0 + y as f64 * 15.0, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | if let Some(_) = e.render_args() { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 50 | | window.draw_2d(&e, |c, g| { [INFO] [stderr] 51 | | game.render(c, g); [INFO] [stderr] 52 | | }); [INFO] [stderr] 53 | | }; [INFO] [stderr] | |_____________- help: try this: `if e.render_args().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 48.23s [INFO] running `"docker" "inspect" "83c63977a516442860546fac61bf50cae13136bf133917c7d8c7aeb204788d39"` [INFO] running `"docker" "rm" "-f" "83c63977a516442860546fac61bf50cae13136bf133917c7d8c7aeb204788d39"` [INFO] [stdout] 83c63977a516442860546fac61bf50cae13136bf133917c7d8c7aeb204788d39