[INFO] updating cached repository jupart/bitmap_png_text_boxes [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jupart/bitmap_png_text_boxes [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jupart/bitmap_png_text_boxes" "work/ex/clippy-test-run/sources/stable/gh/jupart/bitmap_png_text_boxes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jupart/bitmap_png_text_boxes'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jupart/bitmap_png_text_boxes" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jupart/bitmap_png_text_boxes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jupart/bitmap_png_text_boxes'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 06cfd186c93606f9fae9797c7fa5c5bd19a7d975 [INFO] sha for GitHub repo jupart/bitmap_png_text_boxes: 06cfd186c93606f9fae9797c7fa5c5bd19a7d975 [INFO] validating manifest of jupart/bitmap_png_text_boxes on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jupart/bitmap_png_text_boxes on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jupart/bitmap_png_text_boxes [INFO] finished frobbing jupart/bitmap_png_text_boxes [INFO] frobbed toml for jupart/bitmap_png_text_boxes written to work/ex/clippy-test-run/sources/stable/gh/jupart/bitmap_png_text_boxes/Cargo.toml [INFO] started frobbing jupart/bitmap_png_text_boxes [INFO] finished frobbing jupart/bitmap_png_text_boxes [INFO] frobbed toml for jupart/bitmap_png_text_boxes written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jupart/bitmap_png_text_boxes/Cargo.toml [INFO] crate jupart/bitmap_png_text_boxes has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jupart/bitmap_png_text_boxes against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jupart/bitmap_png_text_boxes:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6ba6b4e807676463c921a41ec487a13655afe74706774a67307a931ce34ca733 [INFO] running `"docker" "start" "-a" "6ba6b4e807676463c921a41ec487a13655afe74706774a67307a931ce34ca733"` [INFO] [stderr] Checking bit-set v0.3.0 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking bdf v0.5.5 [INFO] [stderr] Checking png_text_box v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:67:38 [INFO] [stderr] | [INFO] [stderr] 67 | let input_text_lines = wrap_text(input.clone(), wrap); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 67 | let input_text_lines = wrap_text(&(*input).clone(), wrap); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 67 | let input_text_lines = wrap_text(&str::clone(input), wrap); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:111:28 [INFO] [stderr] | [INFO] [stderr] 111 | fn get_max_line_len(input: &Vec) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:199:9 [INFO] [stderr] | [INFO] [stderr] 199 | let ref mut w = BufWriter::new(file); [INFO] [stderr] | ----^^^^^^^^^------------------------ help: try: `let w = &mut BufWriter::new(file);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `png_text_box`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:67:38 [INFO] [stderr] | [INFO] [stderr] 67 | let input_text_lines = wrap_text(input.clone(), wrap); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 67 | let input_text_lines = wrap_text(&(*input).clone(), wrap); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 67 | let input_text_lines = wrap_text(&str::clone(input), wrap); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:111:28 [INFO] [stderr] | [INFO] [stderr] 111 | fn get_max_line_len(input: &Vec) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:199:9 [INFO] [stderr] | [INFO] [stderr] 199 | let ref mut w = BufWriter::new(file); [INFO] [stderr] | ----^^^^^^^^^------------------------ help: try: `let w = &mut BufWriter::new(file);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `png_text_box`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6ba6b4e807676463c921a41ec487a13655afe74706774a67307a931ce34ca733"` [INFO] running `"docker" "rm" "-f" "6ba6b4e807676463c921a41ec487a13655afe74706774a67307a931ce34ca733"` [INFO] [stdout] 6ba6b4e807676463c921a41ec487a13655afe74706774a67307a931ce34ca733