[INFO] updating cached repository julian3ng/gbemu [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/julian3ng/gbemu [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/julian3ng/gbemu" "work/ex/clippy-test-run/sources/stable/gh/julian3ng/gbemu"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/julian3ng/gbemu'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/julian3ng/gbemu" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/julian3ng/gbemu"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/julian3ng/gbemu'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 11b52e8dad270115fb3f2372d1f09cb1ed19dbc3 [INFO] sha for GitHub repo julian3ng/gbemu: 11b52e8dad270115fb3f2372d1f09cb1ed19dbc3 [INFO] validating manifest of julian3ng/gbemu on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of julian3ng/gbemu on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing julian3ng/gbemu [INFO] finished frobbing julian3ng/gbemu [INFO] frobbed toml for julian3ng/gbemu written to work/ex/clippy-test-run/sources/stable/gh/julian3ng/gbemu/Cargo.toml [INFO] started frobbing julian3ng/gbemu [INFO] finished frobbing julian3ng/gbemu [INFO] frobbed toml for julian3ng/gbemu written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/julian3ng/gbemu/Cargo.toml [INFO] crate julian3ng/gbemu has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting julian3ng/gbemu against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/julian3ng/gbemu:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8054911b2a6b3c00fe7b3cadb14600d370717d4b4cf1684e9dc3242241b871e3 [INFO] running `"docker" "start" "-a" "8054911b2a6b3c00fe7b3cadb14600d370717d4b4cf1684e9dc3242241b871e3"` [INFO] [stderr] Checking gbemu v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `mmu::MMU` [INFO] [stderr] --> src/mmu.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new() -> Self { [INFO] [stderr] 9 | | MMU { } [INFO] [stderr] 10 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `cpu::CPU` [INFO] [stderr] --> src/cpu.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> Self { [INFO] [stderr] 36 | | CPU { [INFO] [stderr] 37 | | a: 0, f: 0, [INFO] [stderr] 38 | | b: 0, c: 0, [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | impl Default for cpu::CPU { [INFO] [stderr] 35 | fn default() -> Self { [INFO] [stderr] 36 | Self::new() [INFO] [stderr] 37 | } [INFO] [stderr] 38 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:68:28 [INFO] [stderr] | [INFO] [stderr] 68 | fn af(&self) -> u16 { ((self.a as u16) << 8) | (self.f as u16) } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:68:52 [INFO] [stderr] | [INFO] [stderr] 68 | fn af(&self) -> u16 { ((self.a as u16) << 8) | (self.f as u16) } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:69:28 [INFO] [stderr] | [INFO] [stderr] 69 | fn bc(&self) -> u16 { ((self.b as u16) << 8) | (self.c as u16) } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:69:52 [INFO] [stderr] | [INFO] [stderr] 69 | fn bc(&self) -> u16 { ((self.b as u16) << 8) | (self.c as u16) } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:70:28 [INFO] [stderr] | [INFO] [stderr] 70 | fn de(&self) -> u16 { ((self.d as u16) << 8) | (self.e as u16) } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:70:52 [INFO] [stderr] | [INFO] [stderr] 70 | fn de(&self) -> u16 { ((self.d as u16) << 8) | (self.e as u16) } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:71:28 [INFO] [stderr] | [INFO] [stderr] 71 | fn hl(&self) -> u16 { ((self.h as u16) << 8) | (self.l as u16) } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:71:52 [INFO] [stderr] | [INFO] [stderr] 71 | fn hl(&self) -> u16 { ((self.h as u16) << 8) | (self.l as u16) } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.l)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `mmu::MMU` [INFO] [stderr] --> src/mmu.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new() -> Self { [INFO] [stderr] 9 | | MMU { } [INFO] [stderr] 10 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `cpu::CPU` [INFO] [stderr] --> src/cpu.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> Self { [INFO] [stderr] 36 | | CPU { [INFO] [stderr] 37 | | a: 0, f: 0, [INFO] [stderr] 38 | | b: 0, c: 0, [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 34 | impl Default for cpu::CPU { [INFO] [stderr] 35 | fn default() -> Self { [INFO] [stderr] 36 | Self::new() [INFO] [stderr] 37 | } [INFO] [stderr] 38 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:68:28 [INFO] [stderr] | [INFO] [stderr] 68 | fn af(&self) -> u16 { ((self.a as u16) << 8) | (self.f as u16) } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:68:52 [INFO] [stderr] | [INFO] [stderr] 68 | fn af(&self) -> u16 { ((self.a as u16) << 8) | (self.f as u16) } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:69:28 [INFO] [stderr] | [INFO] [stderr] 69 | fn bc(&self) -> u16 { ((self.b as u16) << 8) | (self.c as u16) } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:69:52 [INFO] [stderr] | [INFO] [stderr] 69 | fn bc(&self) -> u16 { ((self.b as u16) << 8) | (self.c as u16) } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:70:28 [INFO] [stderr] | [INFO] [stderr] 70 | fn de(&self) -> u16 { ((self.d as u16) << 8) | (self.e as u16) } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:70:52 [INFO] [stderr] | [INFO] [stderr] 70 | fn de(&self) -> u16 { ((self.d as u16) << 8) | (self.e as u16) } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:71:28 [INFO] [stderr] | [INFO] [stderr] 71 | fn hl(&self) -> u16 { ((self.h as u16) << 8) | (self.l as u16) } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:71:52 [INFO] [stderr] | [INFO] [stderr] 71 | fn hl(&self) -> u16 { ((self.h as u16) << 8) | (self.l as u16) } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.l)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.49s [INFO] running `"docker" "inspect" "8054911b2a6b3c00fe7b3cadb14600d370717d4b4cf1684e9dc3242241b871e3"` [INFO] running `"docker" "rm" "-f" "8054911b2a6b3c00fe7b3cadb14600d370717d4b4cf1684e9dc3242241b871e3"` [INFO] [stdout] 8054911b2a6b3c00fe7b3cadb14600d370717d4b4cf1684e9dc3242241b871e3