[INFO] updating cached repository julian-goldsmith/huffman-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/julian-goldsmith/huffman-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/julian-goldsmith/huffman-rust" "work/ex/clippy-test-run/sources/stable/gh/julian-goldsmith/huffman-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/julian-goldsmith/huffman-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/julian-goldsmith/huffman-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/julian-goldsmith/huffman-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/julian-goldsmith/huffman-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 00bbdcbbf28f2644feb89eaf59f88b5f716ee33b [INFO] sha for GitHub repo julian-goldsmith/huffman-rust: 00bbdcbbf28f2644feb89eaf59f88b5f716ee33b [INFO] validating manifest of julian-goldsmith/huffman-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of julian-goldsmith/huffman-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing julian-goldsmith/huffman-rust [INFO] finished frobbing julian-goldsmith/huffman-rust [INFO] frobbed toml for julian-goldsmith/huffman-rust written to work/ex/clippy-test-run/sources/stable/gh/julian-goldsmith/huffman-rust/Cargo.toml [INFO] started frobbing julian-goldsmith/huffman-rust [INFO] finished frobbing julian-goldsmith/huffman-rust [INFO] frobbed toml for julian-goldsmith/huffman-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/julian-goldsmith/huffman-rust/Cargo.toml [INFO] crate julian-goldsmith/huffman-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting julian-goldsmith/huffman-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/julian-goldsmith/huffman-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a21f38ed544d6f2ecba044ed9efde74cd5ac03a340d370f59d13c536df41d58c [INFO] running `"docker" "start" "-a" "a21f38ed544d6f2ecba044ed9efde74cd5ac03a340d370f59d13c536df41d58c"` [INFO] [stderr] Checking huffman-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/huffman/encode.rs:34:48 [INFO] [stderr] | [INFO] [stderr] 34 | State::Right(&Node::Tree { left: _, ref right }) => { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Tree { ref right, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/huffman/encode.rs:43:41 [INFO] [stderr] | [INFO] [stderr] 43 | State::Left(node @ &Node::Tree { left: _, right: _ }) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Tree { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/huffman/encode.rs:45:53 [INFO] [stderr] | [INFO] [stderr] 45 | &Node::Tree { ref left, right: _ } => left, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Tree { ref left, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unused imports: `ReadBytesExt`, `WriteBytesExt` [INFO] [stderr] --> src/huffman/mod.rs:8:17 [INFO] [stderr] | [INFO] [stderr] 8 | use byteorder::{ReadBytesExt, WriteBytesExt}; [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::iter` [INFO] [stderr] --> src/rle.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::iter; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/huffman/encode.rs:34:48 [INFO] [stderr] | [INFO] [stderr] 34 | State::Right(&Node::Tree { left: _, ref right }) => { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Tree { ref right, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/huffman/encode.rs:43:41 [INFO] [stderr] | [INFO] [stderr] 43 | State::Left(node @ &Node::Tree { left: _, right: _ }) => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Tree { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/huffman/encode.rs:45:53 [INFO] [stderr] | [INFO] [stderr] 45 | &Node::Tree { ref left, right: _ } => left, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Tree { ref left, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unused imports: `ReadBytesExt`, `WriteBytesExt` [INFO] [stderr] --> src/huffman/mod.rs:8:17 [INFO] [stderr] | [INFO] [stderr] 8 | use byteorder::{ReadBytesExt, WriteBytesExt}; [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::iter` [INFO] [stderr] --> src/rle.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::iter; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/bitstream.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | Err(err) => return Ok(None), // FIXME: handle non-EOF [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/huffman/mod.rs:25:27 [INFO] [stderr] | [INFO] [stderr] 25 | fn write_freqs(&self, mut writer: &mut Write) -> io::Result { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/bitstream.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | Err(err) => return Ok(None), // FIXME: handle non-EOF [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/huffman/mod.rs:25:27 [INFO] [stderr] | [INFO] [stderr] 25 | fn write_freqs(&self, mut writer: &mut Write) -> io::Result { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/bitstream.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | reader.read(&mut retval.data[0..byte_len])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/huffman/decode.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | / match node { [INFO] [stderr] 12 | | &Node::Leaf(val) => { acc.push(val); node = &root; }, [INFO] [stderr] 13 | | &Node::Tree { ref left, ref right } => [INFO] [stderr] 14 | | match s.pop_start() { [INFO] [stderr] ... | [INFO] [stderr] 19 | | }, [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 11 | match *node { [INFO] [stderr] 12 | Node::Leaf(val) => { acc.push(val); node = &root; }, [INFO] [stderr] 13 | Node::Tree { ref left, ref right } => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/huffman/encode.rs:44:36 [INFO] [stderr] | [INFO] [stderr] 44 | let left = match node { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 45 | | &Node::Tree { ref left, right: _ } => left, [INFO] [stderr] 46 | | _ => unreachable!(), [INFO] [stderr] 47 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 44 | let left = match *node { [INFO] [stderr] 45 | Node::Tree { ref left, right: _ } => left, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/huffman/encode.rs:71:21 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn encode(data: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/huffman/mod.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match reader.read(&mut freqs[0..]) { [INFO] [stderr] 36 | | Err(_) => return Ok(None), // FIXME: errors other than EOF? [INFO] [stderr] 37 | | Ok(_) => (), [INFO] [stderr] 38 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(_) = reader.read(&mut freqs[0..]) { return Ok(None) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rle.rs:36:21 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn decode(data: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `perms`. [INFO] [stderr] --> src/bwt.rs:27:14 [INFO] [stderr] | [INFO] [stderr] 27 | for i in 0..len { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 27 | for in perms.iter().take(len) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `c` is only used to index `num_char_appearances`. [INFO] [stderr] --> src/bwt.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | for c in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 48 | for in num_char_appearances.iter().take(256) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:44:40 [INFO] [stderr] | [INFO] [stderr] 44 | fn encode(mut write_file: &File, data: &Vec) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/bitstream.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | reader.read(&mut retval.data[0..byte_len])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | Err(_) => panic!("Error encoding"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/huffman/decode.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | / match node { [INFO] [stderr] 12 | | &Node::Leaf(val) => { acc.push(val); node = &root; }, [INFO] [stderr] 13 | | &Node::Tree { ref left, ref right } => [INFO] [stderr] 14 | | match s.pop_start() { [INFO] [stderr] ... | [INFO] [stderr] 19 | | }, [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 11 | match *node { [INFO] [stderr] 12 | Node::Leaf(val) => { acc.push(val); node = &root; }, [INFO] [stderr] 13 | Node::Tree { ref left, ref right } => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: The function/method `encode` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:87:12 [INFO] [stderr] | [INFO] [stderr] 87 | encode(&mut write_file, &data); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `decode` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:90:25 [INFO] [stderr] | [INFO] [stderr] 90 | let lz_dec = decode(&mut read_file); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/huffman/encode.rs:44:36 [INFO] [stderr] | [INFO] [stderr] 44 | let left = match node { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 45 | | &Node::Tree { ref left, right: _ } => left, [INFO] [stderr] 46 | | _ => unreachable!(), [INFO] [stderr] 47 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 44 | let left = match *node { [INFO] [stderr] 45 | Node::Tree { ref left, right: _ } => left, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/huffman/encode.rs:71:21 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn encode(data: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/huffman/mod.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match reader.read(&mut freqs[0..]) { [INFO] [stderr] 36 | | Err(_) => return Ok(None), // FIXME: errors other than EOF? [INFO] [stderr] 37 | | Ok(_) => (), [INFO] [stderr] 38 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(_) = reader.read(&mut freqs[0..]) { return Ok(None) }` [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rle.rs:36:21 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn decode(data: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: Could not compile `huffman-rust`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the loop variable `i` is only used to index `perms`. [INFO] [stderr] --> src/bwt.rs:27:14 [INFO] [stderr] | [INFO] [stderr] 27 | for i in 0..len { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 27 | for in perms.iter().take(len) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `c` is only used to index `num_char_appearances`. [INFO] [stderr] --> src/bwt.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | for c in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 48 | for in num_char_appearances.iter().take(256) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/bwt.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | let input = "this is a test.".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"this is a test."` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/bwt.rs:76:31 [INFO] [stderr] | [INFO] [stderr] 76 | let expected_output = "ssat tt hiies .".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ssat tt hiies ."` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/bwt.rs:92:48 [INFO] [stderr] | [INFO] [stderr] 92 | let input = [0, 0, 0, 14].iter().chain("ssat tt hiies .".as_bytes().iter()).cloned().collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"ssat tt hiies ."` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/bwt.rs:93:31 [INFO] [stderr] | [INFO] [stderr] 93 | let expected_string = "this is a test.".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"this is a test."` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/bwt.rs:104:21 [INFO] [stderr] | [INFO] [stderr] 104 | let input = "^BANANA|".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"^BANANA|"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:44:40 [INFO] [stderr] | [INFO] [stderr] 44 | fn encode(mut write_file: &File, data: &Vec) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | Err(_) => panic!("Error encoding"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: The function/method `encode` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:87:12 [INFO] [stderr] | [INFO] [stderr] 87 | encode(&mut write_file, &data); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `decode` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:90:25 [INFO] [stderr] | [INFO] [stderr] 90 | let lz_dec = decode(&mut read_file); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `huffman-rust`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a21f38ed544d6f2ecba044ed9efde74cd5ac03a340d370f59d13c536df41d58c"` [INFO] running `"docker" "rm" "-f" "a21f38ed544d6f2ecba044ed9efde74cd5ac03a340d370f59d13c536df41d58c"` [INFO] [stdout] a21f38ed544d6f2ecba044ed9efde74cd5ac03a340d370f59d13c536df41d58c