[INFO] updating cached repository jtthill/rocketbot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jtthill/rocketbot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jtthill/rocketbot" "work/ex/clippy-test-run/sources/stable/gh/jtthill/rocketbot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jtthill/rocketbot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jtthill/rocketbot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jtthill/rocketbot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jtthill/rocketbot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7f419568deae7af4d6b92a85af24c3e50f370561 [INFO] sha for GitHub repo jtthill/rocketbot: 7f419568deae7af4d6b92a85af24c3e50f370561 [INFO] validating manifest of jtthill/rocketbot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jtthill/rocketbot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jtthill/rocketbot [INFO] finished frobbing jtthill/rocketbot [INFO] frobbed toml for jtthill/rocketbot written to work/ex/clippy-test-run/sources/stable/gh/jtthill/rocketbot/Cargo.toml [INFO] started frobbing jtthill/rocketbot [INFO] finished frobbing jtthill/rocketbot [INFO] frobbed toml for jtthill/rocketbot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jtthill/rocketbot/Cargo.toml [INFO] crate jtthill/rocketbot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jtthill/rocketbot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jtthill/rocketbot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f4a3285430eb0db5fc174f095fdc6652b21bfec951283d3589f686fbabed1451 [INFO] running `"docker" "start" "-a" "f4a3285430eb0db5fc174f095fdc6652b21bfec951283d3589f686fbabed1451"` [INFO] [stderr] Checking irc v0.11.6 [INFO] [stderr] Checking rocketbot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/user.rs:30:4 [INFO] [stderr] | [INFO] [stderr] 30 | badges: badges [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `badges` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/user.rs:30:4 [INFO] [stderr] | [INFO] [stderr] 30 | badges: badges [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `badges` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `location` [INFO] [stderr] --> src/logging.rs:20:61 [INFO] [stderr] | [INFO] [stderr] 20 | format: Box::new(|msg: &str, level: &log::LogLevel, location: &log::LogLocation| { [INFO] [stderr] | ^^^^^^^^ help: consider using `_location` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config.rs:37:24 [INFO] [stderr] | [INFO] [stderr] 37 | nickname: Some(format!("rocketlobot")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"rocketlobot".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config.rs:38:22 [INFO] [stderr] | [INFO] [stderr] 38 | server: Some(format!("irc.chat.twitch.tv")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"irc.chat.twitch.tv".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config.rs:40:29 [INFO] [stderr] | [INFO] [stderr] 40 | channels: Some(vec![format!("#rocketlobster")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"#rocketlobster".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config.rs:41:24 [INFO] [stderr] | [INFO] [stderr] 41 | password: Some(format!("oauth:mqn0sjxtuojbstj81r37h3dztixk9c")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"oauth:mqn0sjxtuojbstj81r37h3dztixk9c".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: unused variable: `location` [INFO] [stderr] --> src/logging.rs:20:61 [INFO] [stderr] | [INFO] [stderr] 20 | format: Box::new(|msg: &str, level: &log::LogLevel, location: &log::LogLocation| { [INFO] [stderr] | ^^^^^^^^ help: consider using `_location` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/twitch.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | / match message.command { [INFO] [stderr] 25 | | Command::PRIVMSG(ref target, ref msg) => { [INFO] [stderr] 26 | | // User struct contains all relevant info about sender [INFO] [stderr] 27 | | let user = User::new(&message); [INFO] [stderr] ... | [INFO] [stderr] 34 | | _ => (), [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | if let Command::PRIVMSG(ref target, ref msg) = message.command { [INFO] [stderr] 25 | // User struct contains all relevant info about sender [INFO] [stderr] 26 | let user = User::new(&message); [INFO] [stderr] 27 | info!("{}: {}", user.display_name, msg); [INFO] [stderr] 28 | if msg.contains("pickles") { [INFO] [stderr] 29 | self.server.send_privmsg(target, "Hi!").unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config.rs:37:24 [INFO] [stderr] | [INFO] [stderr] 37 | nickname: Some(format!("rocketlobot")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"rocketlobot".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config.rs:38:22 [INFO] [stderr] | [INFO] [stderr] 38 | server: Some(format!("irc.chat.twitch.tv")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"irc.chat.twitch.tv".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config.rs:40:29 [INFO] [stderr] | [INFO] [stderr] 40 | channels: Some(vec![format!("#rocketlobster")]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"#rocketlobster".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/config.rs:41:24 [INFO] [stderr] | [INFO] [stderr] 41 | password: Some(format!("oauth:mqn0sjxtuojbstj81r37h3dztixk9c")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"oauth:mqn0sjxtuojbstj81r37h3dztixk9c".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/twitch.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | / match message.command { [INFO] [stderr] 25 | | Command::PRIVMSG(ref target, ref msg) => { [INFO] [stderr] 26 | | // User struct contains all relevant info about sender [INFO] [stderr] 27 | | let user = User::new(&message); [INFO] [stderr] ... | [INFO] [stderr] 34 | | _ => (), [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | if let Command::PRIVMSG(ref target, ref msg) = message.command { [INFO] [stderr] 25 | // User struct contains all relevant info about sender [INFO] [stderr] 26 | let user = User::new(&message); [INFO] [stderr] 27 | info!("{}: {}", user.display_name, msg); [INFO] [stderr] 28 | if msg.contains("pickles") { [INFO] [stderr] 29 | self.server.send_privmsg(target, "Hi!").unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.25s [INFO] running `"docker" "inspect" "f4a3285430eb0db5fc174f095fdc6652b21bfec951283d3589f686fbabed1451"` [INFO] running `"docker" "rm" "-f" "f4a3285430eb0db5fc174f095fdc6652b21bfec951283d3589f686fbabed1451"` [INFO] [stdout] f4a3285430eb0db5fc174f095fdc6652b21bfec951283d3589f686fbabed1451