[INFO] updating cached repository jtdowney/som-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jtdowney/som-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jtdowney/som-rust" "work/ex/clippy-test-run/sources/stable/gh/jtdowney/som-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jtdowney/som-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jtdowney/som-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jtdowney/som-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jtdowney/som-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2efe4a39b364bbe3d0ffbdb163ae3fb1eafad4b3 [INFO] sha for GitHub repo jtdowney/som-rust: 2efe4a39b364bbe3d0ffbdb163ae3fb1eafad4b3 [INFO] validating manifest of jtdowney/som-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jtdowney/som-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jtdowney/som-rust [INFO] finished frobbing jtdowney/som-rust [INFO] frobbed toml for jtdowney/som-rust written to work/ex/clippy-test-run/sources/stable/gh/jtdowney/som-rust/Cargo.toml [INFO] started frobbing jtdowney/som-rust [INFO] finished frobbing jtdowney/som-rust [INFO] frobbed toml for jtdowney/som-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jtdowney/som-rust/Cargo.toml [INFO] crate jtdowney/som-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jtdowney/som-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jtdowney/som-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2b81f1b55662a11d1433266e6a1aeb1ba945230767d607cfd555ed1cdb08c22d [INFO] running `"docker" "start" "-a" "2b81f1b55662a11d1433266e6a1aeb1ba945230767d607cfd555ed1cdb08c22d"` [INFO] [stderr] Checking som v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | superclass: superclass, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `superclass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | instance_methods: instance_methods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instance_methods` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | instance_variables: instance_variables, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instance_variables` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | class_methods: class_methods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `class_methods` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | class_variables: class_variables, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `class_variables` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | superclass: superclass, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `superclass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:103:13 [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] 103 | instance_methods: instance_methods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instance_methods` [INFO] [stderr] --> src/compiler/parser.rs:126:17 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] 126 | parameters: parameters, [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:104:13 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameters` [INFO] [stderr] | [INFO] [stderr] 104 | instance_variables: instance_variables, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instance_variables` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | class_methods: class_methods, [INFO] [stderr] | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `class_methods` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | class_variables: class_variables, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `class_variables` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | parameters: parameters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameters` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:133:17 [INFO] [stderr] | [INFO] [stderr] 133 | parameters: parameters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:133:17 [INFO] [stderr] | [INFO] [stderr] 133 | parameters: parameters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:413:71 [INFO] [stderr] | [INFO] [stderr] 413 | Ok(ast::Expression::UnaryMessage { receiver: Box::new(value), message: message }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:432:13 [INFO] [stderr] | [INFO] [stderr] 432 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:433:13 [INFO] [stderr] | [INFO] [stderr] 433 | parameters: parameters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:481:13 [INFO] [stderr] | [INFO] [stderr] 481 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:413:71 [INFO] [stderr] | [INFO] [stderr] 413 | Ok(ast::Expression::UnaryMessage { receiver: Box::new(value), message: message }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:432:13 [INFO] [stderr] | [INFO] [stderr] 432 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:433:13 [INFO] [stderr] | [INFO] [stderr] 433 | parameters: parameters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util/peekable_buffer.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler/parser.rs:481:13 [INFO] [stderr] | [INFO] [stderr] 481 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util/peekable_buffer.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/compiler/lexer.rs:297:22 [INFO] [stderr] | [INFO] [stderr] 297 | for _ in (0..count) { [INFO] [stderr] | ^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/compiler/parser.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | Err(Error::MismatchError { expected: _, found: _, location: _ }) => Ok("Object".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `MismatchError { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/compiler/parser.rs:168:21 [INFO] [stderr] | [INFO] [stderr] 168 | Err(Error::MismatchError { expected: _, found: _, location: _ }) => break, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `MismatchError { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/compiler/parser.rs:488:18 [INFO] [stderr] | [INFO] [stderr] 488 | for _ in (self.queue.len()..n) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/compiler/parser.rs:502:18 [INFO] [stderr] | [INFO] [stderr] 502 | for _ in (0..n) { [INFO] [stderr] | ^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/compiler/lexer.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/compiler/lexer.rs:297:22 [INFO] [stderr] | [INFO] [stderr] 297 | for _ in (0..count) { [INFO] [stderr] | ^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/compiler/lexer.rs:499:80 [INFO] [stderr] | [INFO] [stderr] 499 | assert_eq!(lexer.read_token().unwrap(), Token(Symbol::Identifier, Some(("run".to_string())))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/compiler/lexer.rs:499:80 [INFO] [stderr] | [INFO] [stderr] 499 | assert_eq!(lexer.read_token().unwrap(), Token(Symbol::Identifier, Some(("run".to_string())))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/compiler/parser.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | Err(Error::MismatchError { expected: _, found: _, location: _ }) => Ok("Object".to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `MismatchError { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/compiler/parser.rs:168:21 [INFO] [stderr] | [INFO] [stderr] 168 | Err(Error::MismatchError { expected: _, found: _, location: _ }) => break, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `MismatchError { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/compiler/parser.rs:488:18 [INFO] [stderr] | [INFO] [stderr] 488 | for _ in (self.queue.len()..n) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/compiler/parser.rs:502:18 [INFO] [stderr] | [INFO] [stderr] 502 | for _ in (0..n) { [INFO] [stderr] | ^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/compiler/lexer.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/compiler/lexer.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/compiler/lexer.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/compiler/lexer.rs:241:9 [INFO] [stderr] | [INFO] [stderr] 241 | / loop { [INFO] [stderr] 242 | | match self.buffer.peek() { [INFO] [stderr] 243 | | Some(c @ '0'...'9') => { [INFO] [stderr] 244 | | text.push(c); [INFO] [stderr] ... | [INFO] [stderr] 248 | | } [INFO] [stderr] 249 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(c @ '0'...'9') = self.buffer.peek() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/compiler/lexer.rs:259:17 [INFO] [stderr] | [INFO] [stderr] 259 | / loop { [INFO] [stderr] 260 | | match self.buffer.peek() { [INFO] [stderr] 261 | | Some(c @ '0'...'9') => { [INFO] [stderr] 262 | | text.push(c); [INFO] [stderr] ... | [INFO] [stderr] 266 | | } [INFO] [stderr] 267 | | } [INFO] [stderr] | |_________________^ help: try: `while let Some(c @ '0'...'9') = self.buffer.peek() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/compiler/parser.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / match symbol { [INFO] [stderr] 21 | | &Symbol::And => "&", [INFO] [stderr] 22 | | &Symbol::At => "@", [INFO] [stderr] 23 | | &Symbol::Comma => ",", [INFO] [stderr] ... | [INFO] [stderr] 35 | | _ => unreachable!(), [INFO] [stderr] 36 | | }.to_string() [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 20 | match *symbol { [INFO] [stderr] 21 | Symbol::And => "&", [INFO] [stderr] 22 | Symbol::At => "@", [INFO] [stderr] 23 | Symbol::Comma => ",", [INFO] [stderr] 24 | Symbol::Divide => "/", [INFO] [stderr] 25 | Symbol::Equal => "=", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/compiler/parser.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | / loop { [INFO] [stderr] 193 | | match self.accept(Symbol::Identifier) { [INFO] [stderr] 194 | | Ok(Token(_, text)) => locals.push(text.unwrap()), [INFO] [stderr] 195 | | _ => break, [INFO] [stderr] 196 | | } [INFO] [stderr] 197 | | } [INFO] [stderr] | |_____________^ help: try: `while let Ok(Token(_, text)) = self.accept(Symbol::Identifier) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/compiler/parser.rs:311:17 [INFO] [stderr] | [INFO] [stderr] 311 | / loop { [INFO] [stderr] 312 | | if let Ok(Token(Symbol::Identifier, _)) = self.peek(1) { [INFO] [stderr] 313 | | expression = try!(self.parse_expression_unary_message(expression)); [INFO] [stderr] 314 | | } else { [INFO] [stderr] 315 | | break; [INFO] [stderr] 316 | | } [INFO] [stderr] 317 | | } [INFO] [stderr] | |_________________^ help: try: `while let Ok(Token(Symbol::Identifier, _)) = self.peek(1) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/compiler/parser.rs:458:9 [INFO] [stderr] | [INFO] [stderr] 458 | / loop { [INFO] [stderr] 459 | | match self.peek(1) { [INFO] [stderr] 460 | | Ok(Token(Symbol::Identifier, _)) => { [INFO] [stderr] 461 | | value = try!(self.parse_expression_unary_message(value)); [INFO] [stderr] ... | [INFO] [stderr] 464 | | } [INFO] [stderr] 465 | | } [INFO] [stderr] | |_________^ help: try: `while let Ok(Token(Symbol::Identifier, _)) = self.peek(1) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/util/peekable_buffer.rs:26:16 [INFO] [stderr] | [INFO] [stderr] 26 | if let Some(_) = self.fill_buffer() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 27 | | return None; [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________- help: try this: `if self.fill_buffer().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/util/peekable_buffer.rs:71:16 [INFO] [stderr] | [INFO] [stderr] 71 | if let Some(_) = self.fill_buffer() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 72 | | return None; [INFO] [stderr] 73 | | } [INFO] [stderr] | |_________- help: try this: `if self.fill_buffer().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/compiler/lexer.rs:241:9 [INFO] [stderr] | [INFO] [stderr] 241 | / loop { [INFO] [stderr] 242 | | match self.buffer.peek() { [INFO] [stderr] 243 | | Some(c @ '0'...'9') => { [INFO] [stderr] 244 | | text.push(c); [INFO] [stderr] ... | [INFO] [stderr] 248 | | } [INFO] [stderr] 249 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(c @ '0'...'9') = self.buffer.peek() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/compiler/lexer.rs:259:17 [INFO] [stderr] | [INFO] [stderr] 259 | / loop { [INFO] [stderr] 260 | | match self.buffer.peek() { [INFO] [stderr] 261 | | Some(c @ '0'...'9') => { [INFO] [stderr] 262 | | text.push(c); [INFO] [stderr] ... | [INFO] [stderr] 266 | | } [INFO] [stderr] 267 | | } [INFO] [stderr] | |_________________^ help: try: `while let Some(c @ '0'...'9') = self.buffer.peek() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/lexer.rs:330:22 [INFO] [stderr] | [INFO] [stderr] 330 | let source = "Hello".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Hello"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/lexer.rs:337:22 [INFO] [stderr] | [INFO] [stderr] 337 | let source = "foo:".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"foo:"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/lexer.rs:344:22 [INFO] [stderr] | [INFO] [stderr] 344 | let source = "foo:bar:".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"foo:bar:"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/lexer.rs:351:22 [INFO] [stderr] | [INFO] [stderr] 351 | let source = "foo:bar:baz:".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"foo:bar:baz:"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/lexer.rs:358:22 [INFO] [stderr] | [INFO] [stderr] 358 | let source = "primitive".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"primitive"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/lexer.rs:365:22 [INFO] [stderr] | [INFO] [stderr] 365 | let source = "-".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"-"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/lexer.rs:372:22 [INFO] [stderr] | [INFO] [stderr] 372 | let source = "--".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"--"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/lexer.rs:380:22 [INFO] [stderr] | [INFO] [stderr] 380 | let source = "---".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"---"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/lexer.rs:389:22 [INFO] [stderr] | [INFO] [stderr] 389 | let source = "-----".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"-----"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/lexer.rs:404:22 [INFO] [stderr] | [INFO] [stderr] 404 | let source = "1".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/lexer.rs:411:22 [INFO] [stderr] | [INFO] [stderr] 411 | let source = "1.".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"1."` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/lexer.rs:419:22 [INFO] [stderr] | [INFO] [stderr] 419 | let source = "3.14".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"3.14"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/lexer.rs:426:22 [INFO] [stderr] | [INFO] [stderr] 426 | let source = ":".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b":"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/lexer.rs:433:22 [INFO] [stderr] | [INFO] [stderr] 433 | let source = "foo := 'Hello'".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"foo := 'Hello'"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/lexer.rs:442:22 [INFO] [stderr] | [INFO] [stderr] 442 | let source = "[]()#^.".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"[]()#^."` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/lexer.rs:474:22 [INFO] [stderr] | [INFO] [stderr] 474 | let source = "<=".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"<="` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/compiler/parser.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / match symbol { [INFO] [stderr] 21 | | &Symbol::And => "&", [INFO] [stderr] 22 | | &Symbol::At => "@", [INFO] [stderr] 23 | | &Symbol::Comma => ",", [INFO] [stderr] ... | [INFO] [stderr] 35 | | _ => unreachable!(), [INFO] [stderr] 36 | | }.to_string() [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 20 | match *symbol { [INFO] [stderr] 21 | Symbol::And => "&", [INFO] [stderr] 22 | Symbol::At => "@", [INFO] [stderr] 23 | Symbol::Comma => ",", [INFO] [stderr] 24 | Symbol::Divide => "/", [INFO] [stderr] 25 | Symbol::Equal => "=", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/compiler/parser.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | / loop { [INFO] [stderr] 193 | | match self.accept(Symbol::Identifier) { [INFO] [stderr] 194 | | Ok(Token(_, text)) => locals.push(text.unwrap()), [INFO] [stderr] 195 | | _ => break, [INFO] [stderr] 196 | | } [INFO] [stderr] 197 | | } [INFO] [stderr] | |_____________^ help: try: `while let Ok(Token(_, text)) = self.accept(Symbol::Identifier) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/compiler/parser.rs:311:17 [INFO] [stderr] | [INFO] [stderr] 311 | / loop { [INFO] [stderr] 312 | | if let Ok(Token(Symbol::Identifier, _)) = self.peek(1) { [INFO] [stderr] 313 | | expression = try!(self.parse_expression_unary_message(expression)); [INFO] [stderr] 314 | | } else { [INFO] [stderr] 315 | | break; [INFO] [stderr] 316 | | } [INFO] [stderr] 317 | | } [INFO] [stderr] | |_________________^ help: try: `while let Ok(Token(Symbol::Identifier, _)) = self.peek(1) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/compiler/parser.rs:458:9 [INFO] [stderr] | [INFO] [stderr] 458 | / loop { [INFO] [stderr] 459 | | match self.peek(1) { [INFO] [stderr] 460 | | Ok(Token(Symbol::Identifier, _)) => { [INFO] [stderr] 461 | | value = try!(self.parse_expression_unary_message(value)); [INFO] [stderr] ... | [INFO] [stderr] 464 | | } [INFO] [stderr] 465 | | } [INFO] [stderr] | |_________^ help: try: `while let Ok(Token(Symbol::Identifier, _)) = self.peek(1) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:575:22 [INFO] [stderr] | [INFO] [stderr] 575 | let source = "Hello".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Hello"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:601:22 [INFO] [stderr] | [INFO] [stderr] 601 | let source = "hello = primitive".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"hello = primitive"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:609:22 [INFO] [stderr] | [INFO] [stderr] 609 | let source = "a := 'test'".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"a := 'test'"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:621:22 [INFO] [stderr] | [INFO] [stderr] 621 | let source = "a := b := 'test'".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"a := b := 'test'"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:633:22 [INFO] [stderr] | [INFO] [stderr] 633 | let source = "'test' println".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"'test' println"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:645:22 [INFO] [stderr] | [INFO] [stderr] 645 | let source = "[ :arg | arg print. ' ' print ]".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"[ :arg | arg print. ' ' print ]"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:666:22 [INFO] [stderr] | [INFO] [stderr] 666 | let source = "a".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"a"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:674:22 [INFO] [stderr] | [INFO] [stderr] 674 | let source = "'test'".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"'test'"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:682:22 [INFO] [stderr] | [INFO] [stderr] 682 | let source = "nil".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"nil"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:690:22 [INFO] [stderr] | [INFO] [stderr] 690 | let source = "true || false".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"true || false"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:702:22 [INFO] [stderr] | [INFO] [stderr] 702 | let source = "#test #'test-case' #run:with:".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"#test #'test-case' #run:with:"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:714:22 [INFO] [stderr] | [INFO] [stderr] 714 | let source = "1".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:722:22 [INFO] [stderr] | [INFO] [stderr] 722 | let source = "-1".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"-1"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:730:22 [INFO] [stderr] | [INFO] [stderr] 730 | let source = "-3.14".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"-3.14"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/compiler/parser.rs:733:64 [INFO] [stderr] | [INFO] [stderr] 733 | assert_eq!(expression, ast::Expression::LiteralDouble(-3.14)); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:738:22 [INFO] [stderr] | [INFO] [stderr] 738 | let source = "3.14".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"3.14"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/compiler/parser.rs:741:63 [INFO] [stderr] | [INFO] [stderr] 741 | assert_eq!(expression, ast::Expression::LiteralDouble(3.14)); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:746:22 [INFO] [stderr] | [INFO] [stderr] 746 | let source = "1 println".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"1 println"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:757:22 [INFO] [stderr] | [INFO] [stderr] 757 | let source = "1 test println".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"1 test println"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:771:22 [INFO] [stderr] | [INFO] [stderr] 771 | let source = "1 with: a and: b".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"1 with: a and: b"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:786:22 [INFO] [stderr] | [INFO] [stderr] 786 | let source = "1 with: a length and: 1 + 2".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"1 with: a length and: 1 + 2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:809:22 [INFO] [stderr] | [INFO] [stderr] 809 | let source = "1 + 2".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"1 + 2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:821:22 [INFO] [stderr] | [INFO] [stderr] 821 | let source = "1 <= 2".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"1 <= 2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:833:22 [INFO] [stderr] | [INFO] [stderr] 833 | let source = "1 + (2 - 1)".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"1 + (2 - 1)"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:850:22 [INFO] [stderr] | [INFO] [stderr] 850 | let source = "1 test + 2".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"1 test + 2"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:865:22 [INFO] [stderr] | [INFO] [stderr] 865 | let source = "Hello = Test ()".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Hello = Test ()"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:874:22 [INFO] [stderr] | [INFO] [stderr] 874 | let source = " [INFO] [stderr] | ______________________^ [INFO] [stderr] 875 | | test = ( |a b| [INFO] [stderr] 876 | | a println [INFO] [stderr] 877 | | ) [INFO] [stderr] 878 | | ".as_bytes(); [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 874 | let source = b" [INFO] [stderr] 875 | test = ( |a b| [INFO] [stderr] 876 | a println [INFO] [stderr] 877 | ) [INFO] [stderr] 878 | "; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:896:22 [INFO] [stderr] | [INFO] [stderr] 896 | let source = " [INFO] [stderr] | ______________________^ [INFO] [stderr] 897 | | test = ( |a b| [INFO] [stderr] 898 | | a println. [INFO] [stderr] 899 | | b println. [INFO] [stderr] 900 | | ) [INFO] [stderr] 901 | | ".as_bytes(); [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 896 | let source = b" [INFO] [stderr] 897 | test = ( |a b| [INFO] [stderr] 898 | a println. [INFO] [stderr] 899 | b println. [INFO] [stderr] 900 | ) [INFO] [stderr] 901 | "; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:923:22 [INFO] [stderr] | [INFO] [stderr] 923 | let source = " [INFO] [stderr] | ______________________^ [INFO] [stderr] 924 | | test: a with: b = ( [INFO] [stderr] 925 | | a println [INFO] [stderr] 926 | | ) [INFO] [stderr] 927 | | ".as_bytes(); [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 923 | let source = b" [INFO] [stderr] 924 | test: a with: b = ( [INFO] [stderr] 925 | a println [INFO] [stderr] 926 | ) [INFO] [stderr] 927 | "; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/compiler/parser.rs:945:22 [INFO] [stderr] | [INFO] [stderr] 945 | let source = " [INFO] [stderr] | ______________________^ [INFO] [stderr] 946 | | test = ( [INFO] [stderr] 947 | | ^ 1 + 1. [INFO] [stderr] 948 | | ) [INFO] [stderr] 949 | | ".as_bytes(); [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 945 | let source = b" [INFO] [stderr] 946 | test = ( [INFO] [stderr] 947 | ^ 1 + 1. [INFO] [stderr] 948 | ) [INFO] [stderr] 949 | "; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/util/peekable_buffer.rs:26:16 [INFO] [stderr] | [INFO] [stderr] 26 | if let Some(_) = self.fill_buffer() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 27 | | return None; [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________- help: try this: `if self.fill_buffer().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/util/peekable_buffer.rs:71:16 [INFO] [stderr] | [INFO] [stderr] 71 | if let Some(_) = self.fill_buffer() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 72 | | return None; [INFO] [stderr] 73 | | } [INFO] [stderr] | |_________- help: try this: `if self.fill_buffer().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/util/peekable_buffer.rs:102:22 [INFO] [stderr] | [INFO] [stderr] 102 | let source = "abc".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/util/peekable_buffer.rs:123:22 [INFO] [stderr] | [INFO] [stderr] 123 | let source = "abc".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/util/peekable_buffer.rs:131:22 [INFO] [stderr] | [INFO] [stderr] 131 | let source = "abc".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/util/peekable_buffer.rs:139:22 [INFO] [stderr] | [INFO] [stderr] 139 | let source = "abc".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/util/peekable_buffer.rs:148:22 [INFO] [stderr] | [INFO] [stderr] 148 | let source = "abc".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/util/peekable_buffer.rs:155:22 [INFO] [stderr] | [INFO] [stderr] 155 | let source = "abc".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/util/peekable_buffer.rs:163:22 [INFO] [stderr] | [INFO] [stderr] 163 | let source = "abc".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/util/peekable_buffer.rs:172:22 [INFO] [stderr] | [INFO] [stderr] 172 | let source = "abc".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"abc"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `som`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "2b81f1b55662a11d1433266e6a1aeb1ba945230767d607cfd555ed1cdb08c22d"` [INFO] running `"docker" "rm" "-f" "2b81f1b55662a11d1433266e6a1aeb1ba945230767d607cfd555ed1cdb08c22d"` [INFO] [stdout] 2b81f1b55662a11d1433266e6a1aeb1ba945230767d607cfd555ed1cdb08c22d