[INFO] updating cached repository jtdowney/advent-2016 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jtdowney/advent-2016 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jtdowney/advent-2016" "work/ex/clippy-test-run/sources/stable/gh/jtdowney/advent-2016"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jtdowney/advent-2016'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jtdowney/advent-2016" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jtdowney/advent-2016"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jtdowney/advent-2016'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 98937fc05513ce63b9d3229a3ecd1d8c8713dc09 [INFO] sha for GitHub repo jtdowney/advent-2016: 98937fc05513ce63b9d3229a3ecd1d8c8713dc09 [INFO] validating manifest of jtdowney/advent-2016 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jtdowney/advent-2016 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jtdowney/advent-2016 [INFO] finished frobbing jtdowney/advent-2016 [INFO] frobbed toml for jtdowney/advent-2016 written to work/ex/clippy-test-run/sources/stable/gh/jtdowney/advent-2016/Cargo.toml [INFO] started frobbing jtdowney/advent-2016 [INFO] finished frobbing jtdowney/advent-2016 [INFO] frobbed toml for jtdowney/advent-2016 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jtdowney/advent-2016/Cargo.toml [INFO] crate jtdowney/advent-2016 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jtdowney/advent-2016 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jtdowney/advent-2016:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b3dd4ccb514ad60b12b3a8fd1cb0ea24add329730ba7535d8ce96ec7412ca1d3 [INFO] running `"docker" "start" "-a" "b3dd4ccb514ad60b12b3a8fd1cb0ea24add329730ba7535d8ce96ec7412ca1d3"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] [stderr] Checking either v1.0.2 [INFO] [stderr] Compiling backtrace-sys v0.1.5 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Checking num-complex v0.1.35 [INFO] [stderr] Checking num-bigint v0.1.35 [INFO] [stderr] Checking itertools v0.5.8 [INFO] [stderr] Checking backtrace v0.3.0 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Checking error-chain v0.7.2 [INFO] [stderr] Checking num v0.1.36 [INFO] [stderr] Checking interval_tree v0.2.0 [INFO] [stderr] Checking advent v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day22.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | used: used, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `used` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day22.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | available: available, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `available` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/bin/day22.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | writeln!(f, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day22.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | nodes: nodes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day22.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | goal: goal, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `goal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/day18.rs:89:42 [INFO] [stderr] | [INFO] [stderr] 89 | Problem::Part2 => solve(&buffer, 400000)?, [INFO] [stderr] | ^^^^^^ help: consider: `400_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/day16.rs:60:42 [INFO] [stderr] | [INFO] [stderr] 60 | Problem::Part2 => solve(&buffer, 35651584)?, [INFO] [stderr] | ^^^^^^^^ help: consider: `35_651_584` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/day24.rs:135:28 [INFO] [stderr] | [INFO] [stderr] 135 | let mut data: Vec<_> = (1..(max_number + 1)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=max_number)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day11.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | floors: floors, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `floors` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day03.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | fn is_possible(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/day24.rs:135:28 [INFO] [stderr] | [INFO] [stderr] 135 | let mut data: Vec<_> = (1..(max_number + 1)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=max_number)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bin/day04.rs:73:40 [INFO] [stderr] | [INFO] [stderr] 73 | let shifted_offset = ((offset as u32 + self.sector) % 26) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day22.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | used: used, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `used` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day22.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | available: available, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `available` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/bin/day22.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | writeln!(f, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day22.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | nodes: nodes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day22.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | goal: goal, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `goal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bin/day08.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | write!(formatter, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day08.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | grid: grid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day08.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/day21.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | const START_WORD: &'static str = "abcdefgh"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/day21.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | const TARGET_SCRAMBLE: &'static str = "fbgdceah"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/day23.rs:176:32 [INFO] [stderr] | [INFO] [stderr] 176 | println!("Register A: {}", registers.get(&'a').unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `®isters[&'a']` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/day23.rs:187:32 [INFO] [stderr] | [INFO] [stderr] 187 | println!("Register A: {}", registers.get(&'a').unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `®isters[&'a']` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day15.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | current_position: current_position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_position` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day11.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | floors: floors, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `floors` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day03.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | fn is_possible(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/day21.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | const START_WORD: &'static str = "abcdefgh"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/day21.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | const TARGET_SCRAMBLE: &'static str = "fbgdceah"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day15.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | fn step(&self, t: u64) -> Disc { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bin/day15.rs:32:36 [INFO] [stderr] | [INFO] [stderr] 32 | num_integer::mod_floor(self.current_position as u64 + t, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.current_position)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bin/day15.rs:33:36 [INFO] [stderr] | [INFO] [stderr] 33 | self.position_count as u64) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.position_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/day16.rs:60:42 [INFO] [stderr] | [INFO] [stderr] 60 | Problem::Part2 => solve(&buffer, 35651584)?, [INFO] [stderr] | ^^^^^^^^ help: consider: `35_651_584` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bin/day04.rs:73:40 [INFO] [stderr] | [INFO] [stderr] 73 | let shifted_offset = ((offset as u32 + self.sector) % 26) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/day18.rs:89:42 [INFO] [stderr] | [INFO] [stderr] 89 | Problem::Part2 => solve(&buffer, 400000)?, [INFO] [stderr] | ^^^^^^ help: consider: `400_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/day12.rs:105:32 [INFO] [stderr] | [INFO] [stderr] 105 | println!("Register A: {}", registers.get(&'a').unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `®isters[&'a']` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/day12.rs:119:32 [INFO] [stderr] | [INFO] [stderr] 119 | println!("Register A: {}", registers.get(&'a').unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `®isters[&'a']` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day15.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | current_position: current_position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_position` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/bin/day08.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | write!(formatter, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day08.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | grid: grid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day08.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/day23.rs:176:32 [INFO] [stderr] | [INFO] [stderr] 176 | println!("Register A: {}", registers.get(&'a').unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `®isters[&'a']` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/day23.rs:187:32 [INFO] [stderr] | [INFO] [stderr] 187 | println!("Register A: {}", registers.get(&'a').unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `®isters[&'a']` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day15.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | fn step(&self, t: u64) -> Disc { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bin/day15.rs:32:36 [INFO] [stderr] | [INFO] [stderr] 32 | num_integer::mod_floor(self.current_position as u64 + t, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.current_position)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bin/day15.rs:33:36 [INFO] [stderr] | [INFO] [stderr] 33 | self.position_count as u64) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.position_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/day12.rs:105:32 [INFO] [stderr] | [INFO] [stderr] 105 | println!("Register A: {}", registers.get(&'a').unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `®isters[&'a']` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/bin/day12.rs:119:32 [INFO] [stderr] | [INFO] [stderr] 119 | println!("Register A: {}", registers.get(&'a').unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `®isters[&'a']` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 42.55s [INFO] running `"docker" "inspect" "b3dd4ccb514ad60b12b3a8fd1cb0ea24add329730ba7535d8ce96ec7412ca1d3"` [INFO] running `"docker" "rm" "-f" "b3dd4ccb514ad60b12b3a8fd1cb0ea24add329730ba7535d8ce96ec7412ca1d3"` [INFO] [stdout] b3dd4ccb514ad60b12b3a8fd1cb0ea24add329730ba7535d8ce96ec7412ca1d3