[INFO] updating cached repository jsfr/lines-king
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jsfr/lines-king
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jsfr/lines-king" "work/ex/clippy-test-run/sources/stable/gh/jsfr/lines-king"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jsfr/lines-king'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jsfr/lines-king" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jsfr/lines-king"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jsfr/lines-king'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 8e060b810b987953aac6476258409e7c4a037aa0
[INFO] sha for GitHub repo jsfr/lines-king: 8e060b810b987953aac6476258409e7c4a037aa0
[INFO] validating manifest of jsfr/lines-king on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jsfr/lines-king on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jsfr/lines-king
[INFO] finished frobbing jsfr/lines-king
[INFO] frobbed toml for jsfr/lines-king written to work/ex/clippy-test-run/sources/stable/gh/jsfr/lines-king/Cargo.toml
[INFO] started frobbing jsfr/lines-king
[INFO] finished frobbing jsfr/lines-king
[INFO] frobbed toml for jsfr/lines-king written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jsfr/lines-king/Cargo.toml
[INFO] crate jsfr/lines-king has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] [stderr]     Blocking waiting for file lock on the registry index
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jsfr/lines-king against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jsfr/lines-king:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 43d7f145fb5bdbe557218e52c8b1ca4fe807ffed2c6d01c317fa96718d55af96
[INFO] running `"docker" "start" "-a" "43d7f145fb5bdbe557218e52c8b1ca4fe807ffed2c6d01c317fa96718d55af96"`
[INFO] [stderr]     Checking image v0.12.0
[INFO] [stderr]     Checking nalgebra v0.10.1
[INFO] [stderr]     Checking winit v0.5.7
[INFO] [stderr]     Checking glutin v0.7.2
[INFO] [stderr]     Checking pistoncore-glutin_window v0.33.0
[INFO] [stderr]     Checking piston2d-opengl_graphics v0.37.0
[INFO] [stderr]     Checking lines-king v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:115:13
[INFO] [stderr]     |
[INFO] [stderr] 115 |             width: width,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `width`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:116:13
[INFO] [stderr]     |
[INFO] [stderr] 116 |             height: height,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `height`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:117:13
[INFO] [stderr]     |
[INFO] [stderr] 117 |             tiles: tiles
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `tiles`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:197:9
[INFO] [stderr]     |
[INFO] [stderr] 197 |         players: players,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^ help: replace it with: `players`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:198:9
[INFO] [stderr]     |
[INFO] [stderr] 198 |         board: board,
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `board`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:115:13
[INFO] [stderr]     |
[INFO] [stderr] 115 |             width: width,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `width`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:116:13
[INFO] [stderr]     |
[INFO] [stderr] 116 |             height: height,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `height`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:117:13
[INFO] [stderr]     |
[INFO] [stderr] 117 |             tiles: tiles
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `tiles`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:197:9
[INFO] [stderr]     |
[INFO] [stderr] 197 |         players: players,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^ help: replace it with: `players`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:198:9
[INFO] [stderr]     |
[INFO] [stderr] 198 |         board: board,
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `board`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `args`
[INFO] [stderr]    --> src/main.rs:148:26
[INFO] [stderr]     |
[INFO] [stderr] 148 |     fn update(&mut self, args: &UpdateArgs) {
[INFO] [stderr]     |                          ^^^^ help: consider using `_args` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `GREEN`
[INFO] [stderr]   --> src/main.rs:18:1
[INFO] [stderr]    |
[INFO] [stderr] 18 | const GREEN:  Color = [0.0, 1.0, 0.0, 1.0];
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `YELLOW`
[INFO] [stderr]   --> src/main.rs:20:1
[INFO] [stderr]    |
[INFO] [stderr] 20 | const YELLOW: Color = [0.0, 1.0, 1.0, 1.0];
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `PLAYER_SIZE`
[INFO] [stderr]   --> src/main.rs:26:1
[INFO] [stderr]    |
[INFO] [stderr] 26 | const PLAYER_SIZE: usize = 4;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:109:50
[INFO] [stderr]     |
[INFO] [stderr] 109 |     fn new(width: usize, height: usize, players: &Vec<Player>) -> Board {
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^ help: change this to: `&[Player]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/main.rs:129:13
[INFO] [stderr]     |
[INFO] [stderr] 129 |         let ref tiles = self.board.tiles;
[INFO] [stderr]     |         ----^^^^^^^^^-------------------- help: try: `let tiles = &self.board.tiles;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:148:32
[INFO] [stderr]     |
[INFO] [stderr] 148 |     fn update(&mut self, args: &UpdateArgs) {
[INFO] [stderr]     |                                ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `args`
[INFO] [stderr]    --> src/main.rs:148:26
[INFO] [stderr]     |
[INFO] [stderr] 148 |     fn update(&mut self, args: &UpdateArgs) {
[INFO] [stderr]     |                          ^^^^ help: consider using `_args` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `GREEN`
[INFO] [stderr]   --> src/main.rs:18:1
[INFO] [stderr]    |
[INFO] [stderr] 18 | const GREEN:  Color = [0.0, 1.0, 0.0, 1.0];
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `YELLOW`
[INFO] [stderr]   --> src/main.rs:20:1
[INFO] [stderr]    |
[INFO] [stderr] 20 | const YELLOW: Color = [0.0, 1.0, 1.0, 1.0];
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `PLAYER_SIZE`
[INFO] [stderr]   --> src/main.rs:26:1
[INFO] [stderr]    |
[INFO] [stderr] 26 | const PLAYER_SIZE: usize = 4;
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:109:50
[INFO] [stderr]     |
[INFO] [stderr] 109 |     fn new(width: usize, height: usize, players: &Vec<Player>) -> Board {
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^ help: change this to: `&[Player]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/main.rs:129:13
[INFO] [stderr]     |
[INFO] [stderr] 129 |         let ref tiles = self.board.tiles;
[INFO] [stderr]     |         ----^^^^^^^^^-------------------- help: try: `let tiles = &self.board.tiles;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:148:32
[INFO] [stderr]     |
[INFO] [stderr] 148 |     fn update(&mut self, args: &UpdateArgs) {
[INFO] [stderr]     |                                ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 20.30s
[INFO] running `"docker" "inspect" "43d7f145fb5bdbe557218e52c8b1ca4fe807ffed2c6d01c317fa96718d55af96"`
[INFO] running `"docker" "rm" "-f" "43d7f145fb5bdbe557218e52c8b1ca4fe807ffed2c6d01c317fa96718d55af96"`
[INFO] [stdout] 43d7f145fb5bdbe557218e52c8b1ca4fe807ffed2c6d01c317fa96718d55af96