[INFO] updating cached repository jsdw/wasm-fractal [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jsdw/wasm-fractal [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jsdw/wasm-fractal" "work/ex/clippy-test-run/sources/stable/gh/jsdw/wasm-fractal"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jsdw/wasm-fractal'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jsdw/wasm-fractal" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jsdw/wasm-fractal"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jsdw/wasm-fractal'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3761793c89a529b20c188adc62a96a1dce44e784 [INFO] sha for GitHub repo jsdw/wasm-fractal: 3761793c89a529b20c188adc62a96a1dce44e784 [INFO] validating manifest of jsdw/wasm-fractal on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jsdw/wasm-fractal on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jsdw/wasm-fractal [INFO] finished frobbing jsdw/wasm-fractal [INFO] frobbed toml for jsdw/wasm-fractal written to work/ex/clippy-test-run/sources/stable/gh/jsdw/wasm-fractal/Cargo.toml [INFO] started frobbing jsdw/wasm-fractal [INFO] finished frobbing jsdw/wasm-fractal [INFO] frobbed toml for jsdw/wasm-fractal written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jsdw/wasm-fractal/Cargo.toml [INFO] crate jsdw/wasm-fractal has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jsdw/wasm-fractal against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jsdw/wasm-fractal:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 47b2227ae2ce17a1386af943efd208d21dcacae4661861a4103a6d021864ac16 [INFO] running `"docker" "start" "-a" "47b2227ae2ce17a1386af943efd208d21dcacae4661861a4103a6d021864ac16"` [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.22 [INFO] [stderr] Compiling wasm-bindgen v0.2.22 [INFO] [stderr] Compiling serde_json v1.0.30 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.22 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.22 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.22 [INFO] [stderr] Checking wasm-fractal v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/fractal.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return frac [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `frac` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | return Colour::new(0,0,0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Colour::new(0,0,0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Renderer` [INFO] [stderr] --> src/lib.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn new() -> Renderer { [INFO] [stderr] 40 | | Renderer { [INFO] [stderr] 41 | | name: String::new(), [INFO] [stderr] 42 | | gradients: Gradients::bw(), [INFO] [stderr] ... | [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 36 | impl Default for Renderer { [INFO] [stderr] 37 | fn default() -> Self { [INFO] [stderr] 38 | Self::new() [INFO] [stderr] 39 | } [INFO] [stderr] 40 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Gradients` [INFO] [stderr] --> src/lib.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | / pub fn new() -> Gradients { [INFO] [stderr] 128 | | Gradients { [INFO] [stderr] 129 | | gradients: vec![] [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 119 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:151:12 [INFO] [stderr] | [INFO] [stderr] 151 | if self.gradients.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.gradients.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Opts` [INFO] [stderr] --> src/lib.rs:251:5 [INFO] [stderr] | [INFO] [stderr] 251 | / pub fn new() -> Opts { [INFO] [stderr] 252 | | Opts { [INFO] [stderr] 253 | | height: 0, [INFO] [stderr] 254 | | width: 0, [INFO] [stderr] ... | [INFO] [stderr] 259 | | } [INFO] [stderr] 260 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 238 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/fractal.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return frac [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `frac` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | return Colour::new(0,0,0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Colour::new(0,0,0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Renderer` [INFO] [stderr] --> src/lib.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn new() -> Renderer { [INFO] [stderr] 40 | | Renderer { [INFO] [stderr] 41 | | name: String::new(), [INFO] [stderr] 42 | | gradients: Gradients::bw(), [INFO] [stderr] ... | [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 36 | impl Default for Renderer { [INFO] [stderr] 37 | fn default() -> Self { [INFO] [stderr] 38 | Self::new() [INFO] [stderr] 39 | } [INFO] [stderr] 40 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Gradients` [INFO] [stderr] --> src/lib.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | / pub fn new() -> Gradients { [INFO] [stderr] 128 | | Gradients { [INFO] [stderr] 129 | | gradients: vec![] [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 119 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:151:12 [INFO] [stderr] | [INFO] [stderr] 151 | if self.gradients.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.gradients.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Opts` [INFO] [stderr] --> src/lib.rs:251:5 [INFO] [stderr] | [INFO] [stderr] 251 | / pub fn new() -> Opts { [INFO] [stderr] 252 | | Opts { [INFO] [stderr] 253 | | height: 0, [INFO] [stderr] 254 | | width: 0, [INFO] [stderr] ... | [INFO] [stderr] 259 | | } [INFO] [stderr] 260 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 238 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.74s [INFO] running `"docker" "inspect" "47b2227ae2ce17a1386af943efd208d21dcacae4661861a4103a6d021864ac16"` [INFO] running `"docker" "rm" "-f" "47b2227ae2ce17a1386af943efd208d21dcacae4661861a4103a6d021864ac16"` [INFO] [stdout] 47b2227ae2ce17a1386af943efd208d21dcacae4661861a4103a6d021864ac16