[INFO] updating cached repository jsdf/lisp.rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jsdf/lisp.rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jsdf/lisp.rs" "work/ex/clippy-test-run/sources/stable/gh/jsdf/lisp.rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jsdf/lisp.rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jsdf/lisp.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jsdf/lisp.rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jsdf/lisp.rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ab03c416841554eb66f0efe361bf5a7ee770b380
[INFO] sha for GitHub repo jsdf/lisp.rs: ab03c416841554eb66f0efe361bf5a7ee770b380
[INFO] validating manifest of jsdf/lisp.rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jsdf/lisp.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jsdf/lisp.rs
[INFO] finished frobbing jsdf/lisp.rs
[INFO] frobbed toml for jsdf/lisp.rs written to work/ex/clippy-test-run/sources/stable/gh/jsdf/lisp.rs/Cargo.toml
[INFO] started frobbing jsdf/lisp.rs
[INFO] finished frobbing jsdf/lisp.rs
[INFO] frobbed toml for jsdf/lisp.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jsdf/lisp.rs/Cargo.toml
[INFO] crate jsdf/lisp.rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jsdf/lisp.rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jsdf/lisp.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 46a0a3bb3d3eea018b93d75b47de5c8a96f3f68e6f7a7666b3541447d817e387
[INFO] running `"docker" "start" "-a" "46a0a3bb3d3eea018b93d75b47de5c8a96f3f68e6f7a7666b3541447d817e387"`
[INFO] [stderr]     Checking lisp_rs v0.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lisp.rs:27:13
[INFO] [stderr]    |
[INFO] [stderr] 27 |             params: params,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `params`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lisp.rs:28:13
[INFO] [stderr]    |
[INFO] [stderr] 28 |             body: body,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `body`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lisp.rs:29:13
[INFO] [stderr]    |
[INFO] [stderr] 29 |             env: env,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `env`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lisp.rs:61:13
[INFO] [stderr]    |
[INFO] [stderr] 61 |             parent: parent,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `parent`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lisp.rs:27:13
[INFO] [stderr]    |
[INFO] [stderr] 27 |             params: params,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `params`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lisp.rs:28:13
[INFO] [stderr]    |
[INFO] [stderr] 28 |             body: body,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `body`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lisp.rs:29:13
[INFO] [stderr]    |
[INFO] [stderr] 29 |             env: env,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `env`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lisp.rs:61:13
[INFO] [stderr]    |
[INFO] [stderr] 61 |             parent: parent,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `parent`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/lisp.rs:305:5
[INFO] [stderr]     |
[INFO] [stderr] 305 |     result
[INFO] [stderr]     |     ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/lisp.rs:253:18
[INFO] [stderr]     |
[INFO] [stderr] 253 |       let result = match val {
[INFO] [stderr]     |  __________________^
[INFO] [stderr] 254 | |         Val::Symbol(x) => Rc::try_unwrap(env).unwrap().unwrap().access(&x),
[INFO] [stderr] 255 | |         Val::Number(_) => val,
[INFO] [stderr] 256 | |         Val::List(list) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 302 | |         },
[INFO] [stderr] 303 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/lisp.rs:305:5
[INFO] [stderr]     |
[INFO] [stderr] 305 |     result
[INFO] [stderr]     |     ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/lisp.rs:253:18
[INFO] [stderr]     |
[INFO] [stderr] 253 |       let result = match val {
[INFO] [stderr]     |  __________________^
[INFO] [stderr] 254 | |         Val::Symbol(x) => Rc::try_unwrap(env).unwrap().unwrap().access(&x),
[INFO] [stderr] 255 | |         Val::Number(_) => val,
[INFO] [stderr] 256 | |         Val::List(list) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 302 | |         },
[INFO] [stderr] 303 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new`
[INFO] [stderr]   --> src/lisp.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     fn new(params: Vec<Val>, body: Val, env: EnvRef) -> Proc {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `call`
[INFO] [stderr]   --> src/lisp.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 |     fn call(&self, args: Vec<Val>) -> Val {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `assign`
[INFO] [stderr]   --> src/lisp.rs:84:5
[INFO] [stderr]    |
[INFO] [stderr] 84 |     fn assign(&mut self, var_name: &String, val: Val) {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lisp.rs:65:32
[INFO] [stderr]    |
[INFO] [stderr] 65 |     fn access(&self, var_name: &String) -> Val {
[INFO] [stderr]    |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lisp.rs:77:36
[INFO] [stderr]    |
[INFO] [stderr] 77 |     fn define(&mut self, var_name: &String, val: Val) {
[INFO] [stderr]    |                                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/lisp.rs:78:9
[INFO] [stderr]    |
[INFO] [stderr] 78 | /         match self.vars.insert(var_name.to_owned(), val) {
[INFO] [stderr] 79 | |             Some(_) => panic!("can't define variable '{}', already defined in this scope", var_name),
[INFO] [stderr] 80 | |             None => (),
[INFO] [stderr] 81 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(_) = self.vars.insert(var_name.to_owned(), val) { panic!("can't define variable '{}', already defined in this scope", var_name) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lisp.rs:84:36
[INFO] [stderr]    |
[INFO] [stderr] 84 |     fn assign(&mut self, var_name: &String, val: Val) {
[INFO] [stderr]    |                                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]    --> src/lisp.rs:108:9
[INFO] [stderr]     |
[INFO] [stderr] 108 | /         io::stdin().read_line(&mut input)
[INFO] [stderr] 109 | |             .ok()
[INFO] [stderr] 110 | |             .expect("Failed to read line");
[INFO] [stderr]     | |__________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lisp.rs:122:22
[INFO] [stderr]     |
[INFO] [stderr] 122 | fn format_list(list: &Vec<Val>) -> String {
[INFO] [stderr]     |                      ^^^^^^^^^ help: change this to: `&[Val]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lisp.rs:132:31
[INFO] [stderr]     |
[INFO] [stderr] 132 |         Val::Symbol(ref x) => format!("{}", x),
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `x.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lisp.rs:179:8
[INFO] [stderr]     |
[INFO] [stderr] 179 |     if tokens.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tokens.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/lisp.rs:184:8
[INFO] [stderr]     |
[INFO] [stderr] 184 |     if "(".to_string() == token {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^ help: try: `"("`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/lisp.rs:186:28
[INFO] [stderr]     |
[INFO] [stderr] 186 |         while tokens[0] != ")".to_string() {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^ help: try: `")"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/lisp.rs:191:15
[INFO] [stderr]     |
[INFO] [stderr] 191 |     } else if ")".to_string() == token {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^ help: try: `")"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/lisp.rs:308:25
[INFO] [stderr]     |
[INFO] [stderr] 308 | fn call_proc(proc_name: &String, mut args: Vec<Val>) -> Val {
[INFO] [stderr]     |                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `args`
[INFO] [stderr]    --> src/lisp.rs:333:14
[INFO] [stderr]     |
[INFO] [stderr] 333 |     for i in 0..args.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 333 |     for (i, <item>) in args.iter().enumerate() {
[INFO] [stderr]     |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new`
[INFO] [stderr]   --> src/lisp.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     fn new(params: Vec<Val>, body: Val, env: EnvRef) -> Proc {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `call`
[INFO] [stderr]   --> src/lisp.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 |     fn call(&self, args: Vec<Val>) -> Val {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `assign`
[INFO] [stderr]   --> src/lisp.rs:84:5
[INFO] [stderr]    |
[INFO] [stderr] 84 |     fn assign(&mut self, var_name: &String, val: Val) {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lisp.rs:65:32
[INFO] [stderr]    |
[INFO] [stderr] 65 |     fn access(&self, var_name: &String) -> Val {
[INFO] [stderr]    |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lisp.rs:77:36
[INFO] [stderr]    |
[INFO] [stderr] 77 |     fn define(&mut self, var_name: &String, val: Val) {
[INFO] [stderr]    |                                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/lisp.rs:78:9
[INFO] [stderr]    |
[INFO] [stderr] 78 | /         match self.vars.insert(var_name.to_owned(), val) {
[INFO] [stderr] 79 | |             Some(_) => panic!("can't define variable '{}', already defined in this scope", var_name),
[INFO] [stderr] 80 | |             None => (),
[INFO] [stderr] 81 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(_) = self.vars.insert(var_name.to_owned(), val) { panic!("can't define variable '{}', already defined in this scope", var_name) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lisp.rs:84:36
[INFO] [stderr]    |
[INFO] [stderr] 84 |     fn assign(&mut self, var_name: &String, val: Val) {
[INFO] [stderr]    |                                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]    --> src/lisp.rs:108:9
[INFO] [stderr]     |
[INFO] [stderr] 108 | /         io::stdin().read_line(&mut input)
[INFO] [stderr] 109 | |             .ok()
[INFO] [stderr] 110 | |             .expect("Failed to read line");
[INFO] [stderr]     | |__________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lisp.rs:122:22
[INFO] [stderr]     |
[INFO] [stderr] 122 | fn format_list(list: &Vec<Val>) -> String {
[INFO] [stderr]     |                      ^^^^^^^^^ help: change this to: `&[Val]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lisp.rs:132:31
[INFO] [stderr]     |
[INFO] [stderr] 132 |         Val::Symbol(ref x) => format!("{}", x),
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `x.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lisp.rs:179:8
[INFO] [stderr]     |
[INFO] [stderr] 179 |     if tokens.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tokens.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/lisp.rs:184:8
[INFO] [stderr]     |
[INFO] [stderr] 184 |     if "(".to_string() == token {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^ help: try: `"("`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/lisp.rs:186:28
[INFO] [stderr]     |
[INFO] [stderr] 186 |         while tokens[0] != ")".to_string() {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^ help: try: `")"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/lisp.rs:191:15
[INFO] [stderr]     |
[INFO] [stderr] 191 |     } else if ")".to_string() == token {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^ help: try: `")"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/lisp.rs:308:25
[INFO] [stderr]     |
[INFO] [stderr] 308 | fn call_proc(proc_name: &String, mut args: Vec<Val>) -> Val {
[INFO] [stderr]     |                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `args`
[INFO] [stderr]    --> src/lisp.rs:333:14
[INFO] [stderr]     |
[INFO] [stderr] 333 |     for i in 0..args.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 333 |     for (i, <item>) in args.iter().enumerate() {
[INFO] [stderr]     |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.15s
[INFO] running `"docker" "inspect" "46a0a3bb3d3eea018b93d75b47de5c8a96f3f68e6f7a7666b3541447d817e387"`
[INFO] running `"docker" "rm" "-f" "46a0a3bb3d3eea018b93d75b47de5c8a96f3f68e6f7a7666b3541447d817e387"`
[INFO] [stdout] 46a0a3bb3d3eea018b93d75b47de5c8a96f3f68e6f7a7666b3541447d817e387