[INFO] updating cached repository jrvidal/r5.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jrvidal/r5.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jrvidal/r5.rs" "work/ex/clippy-test-run/sources/stable/gh/jrvidal/r5.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jrvidal/r5.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jrvidal/r5.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jrvidal/r5.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jrvidal/r5.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ae715768cf6c46ab228ede11aaddbb7f8f428260 [INFO] sha for GitHub repo jrvidal/r5.rs: ae715768cf6c46ab228ede11aaddbb7f8f428260 [INFO] validating manifest of jrvidal/r5.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jrvidal/r5.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jrvidal/r5.rs [INFO] finished frobbing jrvidal/r5.rs [INFO] frobbed toml for jrvidal/r5.rs written to work/ex/clippy-test-run/sources/stable/gh/jrvidal/r5.rs/Cargo.toml [INFO] started frobbing jrvidal/r5.rs [INFO] finished frobbing jrvidal/r5.rs [INFO] frobbed toml for jrvidal/r5.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jrvidal/r5.rs/Cargo.toml [INFO] crate jrvidal/r5.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jrvidal/r5.rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jrvidal/r5.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 957febcb6061aaa05008729e6c372e7021eccc184d76de6d8e59ee056fb8df14 [INFO] running `"docker" "start" "-a" "957febcb6061aaa05008729e6c372e7021eccc184d76de6d8e59ee056fb8df14"` [INFO] [stderr] Checking gc v0.3.2 [INFO] [stderr] Checking atty v0.2.10 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking regex v1.0.0 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Checking rustyline v1.0.0 [INFO] [stderr] Checking r5rs v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/compiler/mod.rs:190:1 [INFO] [stderr] | [INFO] [stderr] 190 | / fn compile_expression_inner(d: Datum, tail: bool) -> Result, CompilerError> { [INFO] [stderr] 191 | | macro_rules! simple_datum { [INFO] [stderr] 192 | | ($T:ident, $c:expr) => { [INFO] [stderr] 193 | | Ok(vec![Instruction::$T($c)]) [INFO] [stderr] ... | [INFO] [stderr] 714 | | } [INFO] [stderr] 715 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/vm/mod.rs:72:18 [INFO] [stderr] | [INFO] [stderr] 72 | next_branch: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/compiler/mod.rs:190:1 [INFO] [stderr] | [INFO] [stderr] 190 | / fn compile_expression_inner(d: Datum, tail: bool) -> Result, CompilerError> { [INFO] [stderr] 191 | | macro_rules! simple_datum { [INFO] [stderr] 192 | | ($T:ident, $c:expr) => { [INFO] [stderr] 193 | | Ok(vec![Instruction::$T($c)]) [INFO] [stderr] ... | [INFO] [stderr] 714 | | } [INFO] [stderr] 715 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/interpreter/mod.rs:34:22 [INFO] [stderr] | [INFO] [stderr] 34 | .map_err(|e| InterpreterError::Exec(e))?); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `InterpreterError::Exec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 46 [INFO] [stderr] --> src/lexer/number/test.rs:196:1 [INFO] [stderr] | [INFO] [stderr] 196 | / fn parse_real_with_decimal() { [INFO] [stderr] 197 | | let n = "1.2"; [INFO] [stderr] 198 | | let t = parse_real(&mut Chars::from_str(n), None).ok().unwrap(); [INFO] [stderr] 199 | | assert_dec!(t, 0, "12", 1); [INFO] [stderr] ... | [INFO] [stderr] 251 | | ); [INFO] [stderr] 252 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 34 [INFO] [stderr] --> src/lexer/number/test.rs:281:1 [INFO] [stderr] | [INFO] [stderr] 281 | / fn parse_complex_with_cartesian() { [INFO] [stderr] 282 | | let n = "1+i"; [INFO] [stderr] 283 | | let t = parse_complex(&mut Chars::from_str(n), None).ok().unwrap(); [INFO] [stderr] 284 | | let (s, r) = t.real_part().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 326 | | assert_frac!(r.unwrap(), [0, "2"], [0, "1"]); [INFO] [stderr] 327 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/vm/mod.rs:72:18 [INFO] [stderr] | [INFO] [stderr] 72 | next_branch: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.48s [INFO] running `"docker" "inspect" "957febcb6061aaa05008729e6c372e7021eccc184d76de6d8e59ee056fb8df14"` [INFO] running `"docker" "rm" "-f" "957febcb6061aaa05008729e6c372e7021eccc184d76de6d8e59ee056fb8df14"` [INFO] [stdout] 957febcb6061aaa05008729e6c372e7021eccc184d76de6d8e59ee056fb8df14