[INFO] updating cached repository jrobar/Fibonacci [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jrobar/Fibonacci [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jrobar/Fibonacci" "work/ex/clippy-test-run/sources/stable/gh/jrobar/Fibonacci"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jrobar/Fibonacci'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jrobar/Fibonacci" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jrobar/Fibonacci"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jrobar/Fibonacci'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f34f539261878f3c613d20f8b082a718b8bcfe8b [INFO] sha for GitHub repo jrobar/Fibonacci: f34f539261878f3c613d20f8b082a718b8bcfe8b [INFO] validating manifest of jrobar/Fibonacci on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jrobar/Fibonacci on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jrobar/Fibonacci [INFO] finished frobbing jrobar/Fibonacci [INFO] frobbed toml for jrobar/Fibonacci written to work/ex/clippy-test-run/sources/stable/gh/jrobar/Fibonacci/Cargo.toml [INFO] started frobbing jrobar/Fibonacci [INFO] finished frobbing jrobar/Fibonacci [INFO] frobbed toml for jrobar/Fibonacci written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jrobar/Fibonacci/Cargo.toml [INFO] crate jrobar/Fibonacci has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jrobar/Fibonacci against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jrobar/Fibonacci:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4e0a4b805895432f35fc6feee2996338fb67832f11519cf32371de06b33ee626 [INFO] running `"docker" "start" "-a" "4e0a4b805895432f35fc6feee2996338fb67832f11519cf32371de06b33ee626"` [INFO] [stderr] Checking fibonacci v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | let mut c = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | let mut c = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: value assigned to `c` is never read [INFO] [stderr] --> src/main.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | let mut c = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | let mut i = get_num(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | let mut num: i32 = num.trim().parse().expect("invalid input"); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | n = n + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `n += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: value assigned to `c` is never read [INFO] [stderr] --> src/main.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | let mut c = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | let mut i = get_num(); [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | let mut num: i32 = num.trim().parse().expect("invalid input"); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | n = n + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `n += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.57s [INFO] running `"docker" "inspect" "4e0a4b805895432f35fc6feee2996338fb67832f11519cf32371de06b33ee626"` [INFO] running `"docker" "rm" "-f" "4e0a4b805895432f35fc6feee2996338fb67832f11519cf32371de06b33ee626"` [INFO] [stdout] 4e0a4b805895432f35fc6feee2996338fb67832f11519cf32371de06b33ee626