[INFO] updating cached repository jreyes33/verbotso [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jreyes33/verbotso [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jreyes33/verbotso" "work/ex/clippy-test-run/sources/stable/gh/jreyes33/verbotso"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jreyes33/verbotso'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jreyes33/verbotso" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jreyes33/verbotso"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jreyes33/verbotso'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0ae3711004c8ef5a936a6a4781619515c69ef0c7 [INFO] sha for GitHub repo jreyes33/verbotso: 0ae3711004c8ef5a936a6a4781619515c69ef0c7 [INFO] validating manifest of jreyes33/verbotso on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jreyes33/verbotso on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jreyes33/verbotso [INFO] finished frobbing jreyes33/verbotso [INFO] frobbed toml for jreyes33/verbotso written to work/ex/clippy-test-run/sources/stable/gh/jreyes33/verbotso/Cargo.toml [INFO] started frobbing jreyes33/verbotso [INFO] finished frobbing jreyes33/verbotso [INFO] frobbed toml for jreyes33/verbotso written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jreyes33/verbotso/Cargo.toml [INFO] crate jreyes33/verbotso has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jreyes33/verbotso against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jreyes33/verbotso:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6469049c7a14ad31e47690286f4b1e756bf2b60db9f32520199ab644c1a75d6a [INFO] running `"docker" "start" "-a" "6469049c7a14ad31e47690286f4b1e756bf2b60db9f32520199ab644c1a75d6a"` [INFO] [stderr] Checking verbotso v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | synonyms [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | let synonyms = match contents.find(format!("\n{}", term).as_str()) { [INFO] [stderr] | ____________________^ [INFO] [stderr] 24 | | Some(pos) => read_synonyms(&contents, pos), [INFO] [stderr] 25 | | None => vec![], [INFO] [stderr] 26 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | synonyms [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | let synonyms = match contents.find(format!("\n{}", term).as_str()) { [INFO] [stderr] | ____________________^ [INFO] [stderr] 24 | | Some(pos) => read_synonyms(&contents, pos), [INFO] [stderr] 25 | | None => vec![], [INFO] [stderr] 26 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | file.read_to_string(&mut contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:35:37 [INFO] [stderr] | [INFO] [stderr] 35 | .flat_map(|line| line.split("|").skip(1)) [INFO] [stderr] | ^^^ help: try using a char instead: `'|'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | file.read_to_string(&mut contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:35:37 [INFO] [stderr] | [INFO] [stderr] 35 | .flat_map(|line| line.split("|").skip(1)) [INFO] [stderr] | ^^^ help: try using a char instead: `'|'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.44s [INFO] running `"docker" "inspect" "6469049c7a14ad31e47690286f4b1e756bf2b60db9f32520199ab644c1a75d6a"` [INFO] running `"docker" "rm" "-f" "6469049c7a14ad31e47690286f4b1e756bf2b60db9f32520199ab644c1a75d6a"` [INFO] [stdout] 6469049c7a14ad31e47690286f4b1e756bf2b60db9f32520199ab644c1a75d6a