[INFO] updating cached repository jpypi/rust-som [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jpypi/rust-som [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jpypi/rust-som" "work/ex/clippy-test-run/sources/stable/gh/jpypi/rust-som"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jpypi/rust-som'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jpypi/rust-som" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jpypi/rust-som"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jpypi/rust-som'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 837e1b1b9002d3a9b6f2b8b0720f4316cbc6cfb3 [INFO] sha for GitHub repo jpypi/rust-som: 837e1b1b9002d3a9b6f2b8b0720f4316cbc6cfb3 [INFO] validating manifest of jpypi/rust-som on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jpypi/rust-som on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jpypi/rust-som [INFO] finished frobbing jpypi/rust-som [INFO] frobbed toml for jpypi/rust-som written to work/ex/clippy-test-run/sources/stable/gh/jpypi/rust-som/Cargo.toml [INFO] started frobbing jpypi/rust-som [INFO] finished frobbing jpypi/rust-som [INFO] frobbed toml for jpypi/rust-som written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jpypi/rust-som/Cargo.toml [INFO] crate jpypi/rust-som has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jpypi/rust-som against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jpypi/rust-som:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e673213a44fd1cda76125df30f6233d4b0c55828f0d97fce0e5ec836774fa7af [INFO] running `"docker" "start" "-a" "e673213a44fd1cda76125df30f6233d4b0c55828f0d97fce0e5ec836774fa7af"` [INFO] [stderr] Compiling glutin v0.8.1 [INFO] [stderr] Checking png v0.8.0 [INFO] [stderr] Checking wayland-sys v0.8.7 [INFO] [stderr] Checking wayland-client v0.8.7 [INFO] [stderr] Checking image v0.14.0 [INFO] [stderr] Checking wayland-kbd v0.8.0 [INFO] [stderr] Checking wayland-window v0.5.0 [INFO] [stderr] Checking winit v0.6.4 [INFO] [stderr] Checking piston2d-opengl_graphics v0.44.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.37.0 [INFO] [stderr] Checking som v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/som.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | return loc; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `loc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/som.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | return loc; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `loc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:50 [INFO] [stderr] | [INFO] [stderr] 37 | let square = rectangle::square(0.0, 0.0, SCALE as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(SCALE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `r` is used to index `lattice` [INFO] [stderr] --> src/main.rs:45:22 [INFO] [stderr] | [INFO] [stderr] 45 | for r in 0..size.0 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 45 | for (r, ) in lattice.iter().enumerate().take(size.0) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:47:57 [INFO] [stderr] | [INFO] [stderr] 47 | let transform = ctr.transform.trans((c as u32*SCALE) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(c as u32*SCALE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:48:57 [INFO] [stderr] | [INFO] [stderr] 48 | (r as u32*SCALE) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(r as u32*SCALE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:50 [INFO] [stderr] | [INFO] [stderr] 37 | let square = rectangle::square(0.0, 0.0, SCALE as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(SCALE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `r` is used to index `lattice` [INFO] [stderr] --> src/main.rs:45:22 [INFO] [stderr] | [INFO] [stderr] 45 | for r in 0..size.0 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 45 | for (r, ) in lattice.iter().enumerate().take(size.0) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:47:57 [INFO] [stderr] | [INFO] [stderr] 47 | let transform = ctr.transform.trans((c as u32*SCALE) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(c as u32*SCALE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:48:57 [INFO] [stderr] | [INFO] [stderr] 48 | (r as u32*SCALE) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(r as u32*SCALE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.24s [INFO] running `"docker" "inspect" "e673213a44fd1cda76125df30f6233d4b0c55828f0d97fce0e5ec836774fa7af"` [INFO] running `"docker" "rm" "-f" "e673213a44fd1cda76125df30f6233d4b0c55828f0d97fce0e5ec836774fa7af"` [INFO] [stdout] e673213a44fd1cda76125df30f6233d4b0c55828f0d97fce0e5ec836774fa7af