[INFO] updating cached repository jpypi/orbits
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jpypi/orbits
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jpypi/orbits" "work/ex/clippy-test-run/sources/stable/gh/jpypi/orbits"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jpypi/orbits'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jpypi/orbits" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jpypi/orbits"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jpypi/orbits'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 60a9781b6d2d0d3b17775d6c45cef26248bff70b
[INFO] sha for GitHub repo jpypi/orbits: 60a9781b6d2d0d3b17775d6c45cef26248bff70b
[INFO] validating manifest of jpypi/orbits on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jpypi/orbits on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jpypi/orbits
[INFO] finished frobbing jpypi/orbits
[INFO] frobbed toml for jpypi/orbits written to work/ex/clippy-test-run/sources/stable/gh/jpypi/orbits/Cargo.toml
[INFO] started frobbing jpypi/orbits
[INFO] finished frobbing jpypi/orbits
[INFO] frobbed toml for jpypi/orbits written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jpypi/orbits/Cargo.toml
[INFO] crate jpypi/orbits has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jpypi/orbits against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jpypi/orbits:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 829876a551ef97b976b15008c977e3d409fec0d15663334e01a9bb871782e7e9
[INFO] running `"docker" "start" "-a" "829876a551ef97b976b15008c977e3d409fec0d15663334e01a9bb871782e7e9"`
[INFO] [stderr]    Compiling num-traits v0.2.0
[INFO] [stderr]    Compiling wayland-scanner v0.8.7
[INFO] [stderr]     Checking num-iter v0.1.35
[INFO] [stderr]     Checking num-rational v0.1.42
[INFO] [stderr]     Checking rusttype v0.2.3
[INFO] [stderr]     Checking fs2 v0.2.5
[INFO] [stderr]    Compiling glutin v0.8.1
[INFO] [stderr]    Compiling target_build_utils v0.3.1
[INFO] [stderr]     Checking png v0.8.0
[INFO] [stderr]     Checking memmap v0.4.0
[INFO] [stderr]    Compiling num-traits v0.1.43
[INFO] [stderr]    Compiling wayland-client v0.8.7
[INFO] [stderr]    Compiling serde_json v0.9.10
[INFO] [stderr]     Checking image v0.14.0
[INFO] [stderr]     Checking piston2d-opengl_graphics v0.44.0
[INFO] [stderr]    Compiling libloading v0.3.4
[INFO] [stderr]     Checking dlib v0.3.1
[INFO] [stderr]     Checking wayland-sys v0.8.7
[INFO] [stderr]     Checking wayland-kbd v0.8.0
[INFO] [stderr]     Checking wayland-window v0.5.0
[INFO] [stderr]     Checking winit v0.6.4
[INFO] [stderr]     Checking pistoncore-glutin_window v0.37.0
[INFO] [stderr]     Checking orbits v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/planet.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 |         return (pos, vel);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(pos, vel)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:26:24
[INFO] [stderr]    |
[INFO] [stderr] 26 | const DIST_MOON: f64 = 384400.0; // km
[INFO] [stderr]    |                        ^^^^^^^^ help: consider: `384_400.0`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:68:61
[INFO] [stderr]    |
[INFO] [stderr] 68 |             updates.push(p.update(&self.universe, args.dt * 100000.0));
[INFO] [stderr]    |                                                             ^^^^^^^^ help: consider: `100_000.0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:94:15
[INFO] [stderr]    |
[INFO] [stderr] 94 |         zoom: 0.000004,
[INFO] [stderr]    |               ^^^^^^^^ help: consider: `0.000_004`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/main.rs:117:16
[INFO] [stderr]     |
[INFO] [stderr] 117 |         mass:  7.34767309e22,
[INFO] [stderr]     |                ^^^^^^^^^^^^^ help: consider: `7.347_673_09e22`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/planet.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 |         return (pos, vel);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(pos, vel)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:26:24
[INFO] [stderr]    |
[INFO] [stderr] 26 | const DIST_MOON: f64 = 384400.0; // km
[INFO] [stderr]    |                        ^^^^^^^^ help: consider: `384_400.0`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:68:61
[INFO] [stderr]    |
[INFO] [stderr] 68 |             updates.push(p.update(&self.universe, args.dt * 100000.0));
[INFO] [stderr]    |                                                             ^^^^^^^^ help: consider: `100_000.0`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:94:15
[INFO] [stderr]    |
[INFO] [stderr] 94 |         zoom: 0.000004,
[INFO] [stderr]    |               ^^^^^^^^ help: consider: `0.000_004`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/main.rs:117:16
[INFO] [stderr]     |
[INFO] [stderr] 117 |         mass:  7.34767309e22,
[INFO] [stderr]     |                ^^^^^^^^^^^^^ help: consider: `7.347_673_09e22`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/planet.rs:24:36
[INFO] [stderr]    |
[INFO] [stderr] 24 |     pub fn update(&self, universe: &Vec<Planet>, dt: f64) -> (Vec2d, Vec2d) {
[INFO] [stderr]    |                                    ^^^^^^^^^^^^ help: change this to: `&[Planet]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/planet.rs:24:36
[INFO] [stderr]    |
[INFO] [stderr] 24 |     pub fn update(&self, universe: &Vec<Planet>, dt: f64) -> (Vec2d, Vec2d) {
[INFO] [stderr]    |                                    ^^^^^^^^^^^^ help: change this to: `&[Planet]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:47:41
[INFO] [stderr]    |
[INFO] [stderr] 47 |             let t = ctr.transform.trans((size.width as f64)/2.0,
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(size.width)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:48:41
[INFO] [stderr]    |
[INFO] [stderr] 48 |                                         (size.height as f64)/2.0);
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(size.height)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:56:55
[INFO] [stderr]    |
[INFO] [stderr] 56 |             let text_trans = ctr.transform.trans(2.0, size.height as f64 - 2.0);
[INFO] [stderr]    |                                                       ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(size.height)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:64:32
[INFO] [stderr]    |
[INFO] [stderr] 64 |     fn update(&mut self, args: &UpdateArgs) {
[INFO] [stderr]    |                                ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `updates`
[INFO] [stderr]   --> src/main.rs:71:18
[INFO] [stderr]    |
[INFO] [stderr] 71 |         for i in 0..self.universe.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 71 |         for (i, <item>) in updates.iter().enumerate().take(self.universe.len()) {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:47:41
[INFO] [stderr]    |
[INFO] [stderr] 47 |             let t = ctr.transform.trans((size.width as f64)/2.0,
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(size.width)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:48:41
[INFO] [stderr]    |
[INFO] [stderr] 48 |                                         (size.height as f64)/2.0);
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(size.height)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:56:55
[INFO] [stderr]    |
[INFO] [stderr] 56 |             let text_trans = ctr.transform.trans(2.0, size.height as f64 - 2.0);
[INFO] [stderr]    |                                                       ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(size.height)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:64:32
[INFO] [stderr]    |
[INFO] [stderr] 64 |     fn update(&mut self, args: &UpdateArgs) {
[INFO] [stderr]    |                                ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `updates`
[INFO] [stderr]   --> src/main.rs:71:18
[INFO] [stderr]    |
[INFO] [stderr] 71 |         for i in 0..self.universe.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 71 |         for (i, <item>) in updates.iter().enumerate().take(self.universe.len()) {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:86:9
[INFO] [stderr]    |
[INFO] [stderr] 86 |     let ref mut glyphs = GlyphCache::new("DejaVuSans.ttf")
[INFO] [stderr]    |         ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 86 |     let glyphs = &mut GlyphCache::new("DejaVuSans.ttf")
[INFO] [stderr] 87 |                          .expect("Could not load font");
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:86:9
[INFO] [stderr]    |
[INFO] [stderr] 86 |     let ref mut glyphs = GlyphCache::new("DejaVuSans.ttf")
[INFO] [stderr]    |         ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 86 |     let glyphs = &mut GlyphCache::new("DejaVuSans.ttf")
[INFO] [stderr] 87 |                          .expect("Could not load font");
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 32.10s
[INFO] running `"docker" "inspect" "829876a551ef97b976b15008c977e3d409fec0d15663334e01a9bb871782e7e9"`
[INFO] running `"docker" "rm" "-f" "829876a551ef97b976b15008c977e3d409fec0d15663334e01a9bb871782e7e9"`
[INFO] [stdout] 829876a551ef97b976b15008c977e3d409fec0d15663334e01a9bb871782e7e9