[INFO] updating cached repository jpastuszek/varnishslog [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jpastuszek/varnishslog [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jpastuszek/varnishslog" "work/ex/clippy-test-run/sources/stable/gh/jpastuszek/varnishslog"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jpastuszek/varnishslog'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jpastuszek/varnishslog" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jpastuszek/varnishslog"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jpastuszek/varnishslog'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9aed4098523e87e54fd5aefd5c5011f0325334e8 [INFO] sha for GitHub repo jpastuszek/varnishslog: 9aed4098523e87e54fd5aefd5c5011f0325334e8 [INFO] validating manifest of jpastuszek/varnishslog on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jpastuszek/varnishslog on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jpastuszek/varnishslog [INFO] finished frobbing jpastuszek/varnishslog [INFO] frobbed toml for jpastuszek/varnishslog written to work/ex/clippy-test-run/sources/stable/gh/jpastuszek/varnishslog/Cargo.toml [INFO] started frobbing jpastuszek/varnishslog [INFO] finished frobbing jpastuszek/varnishslog [INFO] frobbed toml for jpastuszek/varnishslog written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jpastuszek/varnishslog/Cargo.toml [INFO] crate jpastuszek/varnishslog has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jpastuszek/varnishslog against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jpastuszek/varnishslog:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 91409ac723e50546397e12cf4eaefc6be575d4721f595ea625e7b9acf620af35 [INFO] running `"docker" "start" "-a" "91409ac723e50546397e12cf4eaefc6be575d4721f595ea625e7b9acf620af35"` [INFO] [stderr] Compiling libc v0.2.14 [INFO] [stderr] Compiling quote v0.3.3 [INFO] [stderr] Checking num-traits v0.1.35 [INFO] [stderr] Checking boolinator v0.1.0 [INFO] [stderr] Checking assert_matches v1.2.0 [INFO] [stderr] Checking bencher v0.1.1 [INFO] [stderr] Compiling syntex_pos v0.44.0 [INFO] [stderr] Compiling term v0.4.4 [INFO] [stderr] Compiling syn v0.9.0 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking time v0.1.35 [INFO] [stderr] Checking atty v0.2.6 [INFO] [stderr] Checking num-integer v0.1.32 [INFO] [stderr] Checking serde_json v0.8.6 [INFO] [stderr] Checking thread_local v0.2.6 [INFO] [stderr] Checking aho-corasick v0.5.2 [INFO] [stderr] Checking clap v2.30.0 [INFO] [stderr] Checking num-iter v0.1.32 [INFO] [stderr] Checking regex v0.1.73 [INFO] [stderr] Compiling syntex_errors v0.44.0 [INFO] [stderr] Checking num v0.1.35 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Compiling serde_codegen_internals v0.10.0 [INFO] [stderr] Compiling syntex_syntax v0.44.1 [INFO] [stderr] Checking env_logger v0.3.5 [INFO] [stderr] Checking flexi_logger v0.5.0 [INFO] [stderr] Compiling syntex v0.44.0 [INFO] [stderr] Compiling serde_codegen v0.8.12 [INFO] [stderr] Compiling varnishslog v0.7.1-alpha.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream_buf.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/store.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | max_slots: max_slots, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_slots` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/store.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | max_slots: max_slots, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_slots` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/store.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | max_epoch_diff: max_epoch_diff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_epoch_diff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/store.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | evict_count: evict_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `evict_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/store.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | stat_epoch_interval: stat_epoch_interval, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stat_epoch_interval` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/store.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/mod.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/mod.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | ident: ident, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:828:21 [INFO] [stderr] | [INFO] [stderr] 828 | ttl: ttl, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ttl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:829:21 [INFO] [stderr] | [INFO] [stderr] 829 | grace: grace, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `grace` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:830:21 [INFO] [stderr] | [INFO] [stderr] 830 | keep: keep, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `keep` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:831:21 [INFO] [stderr] | [INFO] [stderr] 831 | since: since, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `since` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:832:21 [INFO] [stderr] | [INFO] [stderr] 832 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:842:21 [INFO] [stderr] | [INFO] [stderr] 842 | recv_header: recv_header, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recv_header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:843:21 [INFO] [stderr] | [INFO] [stderr] 843 | recv_body: recv_body, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recv_body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:844:21 [INFO] [stderr] | [INFO] [stderr] 844 | recv_total: recv_total, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recv_total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:845:21 [INFO] [stderr] | [INFO] [stderr] 845 | sent_header: sent_header, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sent_header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:846:21 [INFO] [stderr] | [INFO] [stderr] 846 | sent_body: sent_body, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sent_body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:847:21 [INFO] [stderr] | [INFO] [stderr] 847 | sent_total: sent_total, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sent_total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:857:21 [INFO] [stderr] | [INFO] [stderr] 857 | sent_header: sent_header, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sent_header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:858:21 [INFO] [stderr] | [INFO] [stderr] 858 | sent_body: sent_body, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sent_body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:859:21 [INFO] [stderr] | [INFO] [stderr] 859 | sent_total: sent_total, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sent_total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:860:21 [INFO] [stderr] | [INFO] [stderr] 860 | recv_header: recv_header, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recv_header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:861:21 [INFO] [stderr] | [INFO] [stderr] 861 | recv_body: recv_body, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recv_body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:862:21 [INFO] [stderr] | [INFO] [stderr] 862 | recv_total: recv_total, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recv_total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:887:21 [INFO] [stderr] | [INFO] [stderr] 887 | fd: fd, [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1096:25 [INFO] [stderr] | [INFO] [stderr] 1096 | operation: operation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `operation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1097:25 [INFO] [stderr] | [INFO] [stderr] 1097 | bytes_in: bytes_in, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_in` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1098:25 [INFO] [stderr] | [INFO] [stderr] 1098 | bytes_out: bytes_out, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1108:21 [INFO] [stderr] | [INFO] [stderr] 1108 | streamed: streamed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `streamed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1232:29 [INFO] [stderr] | [INFO] [stderr] 1232 | transaction: transaction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transaction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1270:37 [INFO] [stderr] | [INFO] [stderr] 1270 | fetch_mode: fetch_mode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fetch_mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1271:37 [INFO] [stderr] | [INFO] [stderr] 1271 | fetch_streamed: fetch_streamed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fetch_streamed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1280:37 [INFO] [stderr] | [INFO] [stderr] 1280 | cache_object: cache_object, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cache_object` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1336:29 [INFO] [stderr] | [INFO] [stderr] 1336 | parent: parent, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1337:29 [INFO] [stderr] | [INFO] [stderr] 1337 | reason: reason, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reason` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1338:29 [INFO] [stderr] | [INFO] [stderr] 1338 | transaction: transaction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transaction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1339:29 [INFO] [stderr] | [INFO] [stderr] 1339 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:436:13 [INFO] [stderr] | [INFO] [stderr] 436 | vars: vars, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:437:13 [INFO] [stderr] | [INFO] [stderr] 437 | messages: messages, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `messages` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:438:13 [INFO] [stderr] | [INFO] [stderr] 438 | acl_matched: acl_matched, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `acl_matched` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:439:13 [INFO] [stderr] | [INFO] [stderr] 439 | acl_not_matched: acl_not_matched, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `acl_not_matched` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:510:25 [INFO] [stderr] | [INFO] [stderr] 510 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:517:25 [INFO] [stderr] | [INFO] [stderr] 517 | retry: retry, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `retry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:533:25 [INFO] [stderr] | [INFO] [stderr] 533 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:540:25 [INFO] [stderr] | [INFO] [stderr] 540 | retry: retry, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `retry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:558:25 [INFO] [stderr] | [INFO] [stderr] 558 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:565:25 [INFO] [stderr] | [INFO] [stderr] 565 | retry: retry, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `retry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:600:21 [INFO] [stderr] | [INFO] [stderr] 600 | record: record, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:601:21 [INFO] [stderr] | [INFO] [stderr] 601 | final_record: final_record, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `final_record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:603:21 [INFO] [stderr] | [INFO] [stderr] 603 | response: response, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `response` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:610:21 [INFO] [stderr] | [INFO] [stderr] 610 | accounting: accounting, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `accounting` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:612:21 [INFO] [stderr] | [INFO] [stderr] 612 | restart_count: restart_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `restart_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:630:21 [INFO] [stderr] | [INFO] [stderr] 630 | record: record, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:631:21 [INFO] [stderr] | [INFO] [stderr] 631 | final_record: final_record, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `final_record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:633:21 [INFO] [stderr] | [INFO] [stderr] 633 | response: response, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `response` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:640:21 [INFO] [stderr] | [INFO] [stderr] 640 | accounting: accounting, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `accounting` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:642:21 [INFO] [stderr] | [INFO] [stderr] 642 | restart_count: restart_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `restart_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:657:21 [INFO] [stderr] | [INFO] [stderr] 657 | record: record, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:658:21 [INFO] [stderr] | [INFO] [stderr] 658 | final_record: final_record, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `final_record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:660:21 [INFO] [stderr] | [INFO] [stderr] 660 | response: response, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `response` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:667:21 [INFO] [stderr] | [INFO] [stderr] 667 | accounting: accounting, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `accounting` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:669:21 [INFO] [stderr] | [INFO] [stderr] 669 | restart_count: restart_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `restart_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:680:21 [INFO] [stderr] | [INFO] [stderr] 680 | record: record, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:681:21 [INFO] [stderr] | [INFO] [stderr] 681 | final_record: final_record, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `final_record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:683:21 [INFO] [stderr] | [INFO] [stderr] 683 | response: response, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `response` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:690:21 [INFO] [stderr] | [INFO] [stderr] 690 | accounting: accounting, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `accounting` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:692:21 [INFO] [stderr] | [INFO] [stderr] 692 | restart_count: restart_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `restart_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:711:33 [INFO] [stderr] | [INFO] [stderr] 711 | record: record, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:712:33 [INFO] [stderr] | [INFO] [stderr] 712 | final_record: final_record, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `final_record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:713:33 [INFO] [stderr] | [INFO] [stderr] 713 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:714:33 [INFO] [stderr] | [INFO] [stderr] 714 | backend_request: backend_request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `backend_request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:717:33 [INFO] [stderr] | [INFO] [stderr] 717 | accounting: accounting, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `accounting` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:974:29 [INFO] [stderr] | [INFO] [stderr] 974 | process_duration: process_duration, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `process_duration` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:975:29 [INFO] [stderr] | [INFO] [stderr] 975 | ttfb_duration: ttfb_duration, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ttfb_duration` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:978:29 [INFO] [stderr] | [INFO] [stderr] 978 | log: log, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `log` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stream_buf.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/store.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | max_slots: max_slots, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_slots` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/store.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | max_slots: max_slots, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_slots` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/store.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | max_epoch_diff: max_epoch_diff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_epoch_diff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/store.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | evict_count: evict_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `evict_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/store.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | stat_epoch_interval: stat_epoch_interval, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stat_epoch_interval` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/store.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/mod.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/mod.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | ident: ident, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:828:21 [INFO] [stderr] | [INFO] [stderr] 828 | ttl: ttl, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ttl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:829:21 [INFO] [stderr] | [INFO] [stderr] 829 | grace: grace, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `grace` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:830:21 [INFO] [stderr] | [INFO] [stderr] 830 | keep: keep, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `keep` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:831:21 [INFO] [stderr] | [INFO] [stderr] 831 | since: since, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `since` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:832:21 [INFO] [stderr] | [INFO] [stderr] 832 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:842:21 [INFO] [stderr] | [INFO] [stderr] 842 | recv_header: recv_header, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recv_header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:843:21 [INFO] [stderr] | [INFO] [stderr] 843 | recv_body: recv_body, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recv_body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:844:21 [INFO] [stderr] | [INFO] [stderr] 844 | recv_total: recv_total, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recv_total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:845:21 [INFO] [stderr] | [INFO] [stderr] 845 | sent_header: sent_header, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sent_header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:846:21 [INFO] [stderr] | [INFO] [stderr] 846 | sent_body: sent_body, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sent_body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:847:21 [INFO] [stderr] | [INFO] [stderr] 847 | sent_total: sent_total, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sent_total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:857:21 [INFO] [stderr] | [INFO] [stderr] 857 | sent_header: sent_header, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sent_header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:858:21 [INFO] [stderr] | [INFO] [stderr] 858 | sent_body: sent_body, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sent_body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:859:21 [INFO] [stderr] | [INFO] [stderr] 859 | sent_total: sent_total, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sent_total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:860:21 [INFO] [stderr] | [INFO] [stderr] 860 | recv_header: recv_header, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recv_header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:861:21 [INFO] [stderr] | [INFO] [stderr] 861 | recv_body: recv_body, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recv_body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:862:21 [INFO] [stderr] | [INFO] [stderr] 862 | recv_total: recv_total, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `recv_total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:887:21 [INFO] [stderr] | [INFO] [stderr] 887 | fd: fd, [INFO] [stderr] | ^^^^^^ help: replace it with: `fd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1096:25 [INFO] [stderr] | [INFO] [stderr] 1096 | operation: operation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `operation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1097:25 [INFO] [stderr] | [INFO] [stderr] 1097 | bytes_in: bytes_in, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_in` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1098:25 [INFO] [stderr] | [INFO] [stderr] 1098 | bytes_out: bytes_out, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1108:21 [INFO] [stderr] | [INFO] [stderr] 1108 | streamed: streamed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `streamed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1232:29 [INFO] [stderr] | [INFO] [stderr] 1232 | transaction: transaction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transaction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1270:37 [INFO] [stderr] | [INFO] [stderr] 1270 | fetch_mode: fetch_mode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fetch_mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1271:37 [INFO] [stderr] | [INFO] [stderr] 1271 | fetch_streamed: fetch_streamed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fetch_streamed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1280:37 [INFO] [stderr] | [INFO] [stderr] 1280 | cache_object: cache_object, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cache_object` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1336:29 [INFO] [stderr] | [INFO] [stderr] 1336 | parent: parent, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1337:29 [INFO] [stderr] | [INFO] [stderr] 1337 | reason: reason, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reason` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1338:29 [INFO] [stderr] | [INFO] [stderr] 1338 | transaction: transaction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transaction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1339:29 [INFO] [stderr] | [INFO] [stderr] 1339 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:436:13 [INFO] [stderr] | [INFO] [stderr] 436 | vars: vars, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:437:13 [INFO] [stderr] | [INFO] [stderr] 437 | messages: messages, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `messages` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:438:13 [INFO] [stderr] | [INFO] [stderr] 438 | acl_matched: acl_matched, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `acl_matched` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:439:13 [INFO] [stderr] | [INFO] [stderr] 439 | acl_not_matched: acl_not_matched, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `acl_not_matched` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:510:25 [INFO] [stderr] | [INFO] [stderr] 510 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:517:25 [INFO] [stderr] | [INFO] [stderr] 517 | retry: retry, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `retry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:533:25 [INFO] [stderr] | [INFO] [stderr] 533 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:540:25 [INFO] [stderr] | [INFO] [stderr] 540 | retry: retry, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `retry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:558:25 [INFO] [stderr] | [INFO] [stderr] 558 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:565:25 [INFO] [stderr] | [INFO] [stderr] 565 | retry: retry, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `retry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:600:21 [INFO] [stderr] | [INFO] [stderr] 600 | record: record, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:601:21 [INFO] [stderr] | [INFO] [stderr] 601 | final_record: final_record, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `final_record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:603:21 [INFO] [stderr] | [INFO] [stderr] 603 | response: response, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `response` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:610:21 [INFO] [stderr] | [INFO] [stderr] 610 | accounting: accounting, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `accounting` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:612:21 [INFO] [stderr] | [INFO] [stderr] 612 | restart_count: restart_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `restart_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:630:21 [INFO] [stderr] | [INFO] [stderr] 630 | record: record, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:631:21 [INFO] [stderr] | [INFO] [stderr] 631 | final_record: final_record, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `final_record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:633:21 [INFO] [stderr] | [INFO] [stderr] 633 | response: response, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `response` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:640:21 [INFO] [stderr] | [INFO] [stderr] 640 | accounting: accounting, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `accounting` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:642:21 [INFO] [stderr] | [INFO] [stderr] 642 | restart_count: restart_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `restart_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:657:21 [INFO] [stderr] | [INFO] [stderr] 657 | record: record, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:658:21 [INFO] [stderr] | [INFO] [stderr] 658 | final_record: final_record, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `final_record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:660:21 [INFO] [stderr] | [INFO] [stderr] 660 | response: response, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `response` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:667:21 [INFO] [stderr] | [INFO] [stderr] 667 | accounting: accounting, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `accounting` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:669:21 [INFO] [stderr] | [INFO] [stderr] 669 | restart_count: restart_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `restart_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:680:21 [INFO] [stderr] | [INFO] [stderr] 680 | record: record, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:681:21 [INFO] [stderr] | [INFO] [stderr] 681 | final_record: final_record, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `final_record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:683:21 [INFO] [stderr] | [INFO] [stderr] 683 | response: response, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `response` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:690:21 [INFO] [stderr] | [INFO] [stderr] 690 | accounting: accounting, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `accounting` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:692:21 [INFO] [stderr] | [INFO] [stderr] 692 | restart_count: restart_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `restart_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:711:33 [INFO] [stderr] | [INFO] [stderr] 711 | record: record, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:712:33 [INFO] [stderr] | [INFO] [stderr] 712 | final_record: final_record, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `final_record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:713:33 [INFO] [stderr] | [INFO] [stderr] 713 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:714:33 [INFO] [stderr] | [INFO] [stderr] 714 | backend_request: backend_request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `backend_request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:717:33 [INFO] [stderr] | [INFO] [stderr] 717 | accounting: accounting, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `accounting` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:974:29 [INFO] [stderr] | [INFO] [stderr] 974 | process_duration: process_duration, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `process_duration` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:975:29 [INFO] [stderr] | [INFO] [stderr] 975 | ttfb_duration: ttfb_duration, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ttfb_duration` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialization.rs:978:29 [INFO] [stderr] | [INFO] [stderr] 978 | log: log, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `log` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/store.rs:177:136 [INFO] [stderr] | [INFO] [stderr] 177 | pub fn log_expire(store_name: &str, current_epoch: Wrapping, record_epoch: Wrapping, record_ident: VslIdent, record: &T) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/store.rs:180:134 [INFO] [stderr] | [INFO] [stderr] 180 | pub fn log_nuke(store_name: &str, current_epoch: Wrapping, record_epoch: Wrapping, record_ident: VslIdent, record: &T) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/vsl/record/tag_e.rs:5:23 [INFO] [stderr] | [INFO] [stderr] 5 | pub const VSL_CLASS: &'static [u8; 4usize] = b"Log\0"; [INFO] [stderr] | -^^^^^^^------------- help: consider removing `'static`: `&[u8; 4usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vsl/record/tag_e.rs:7:35 [INFO] [stderr] | [INFO] [stderr] 7 | pub const VSL_CLIENTMARKER: u32 = 1073741824; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_073_741_824` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vsl/record/tag_e.rs:8:36 [INFO] [stderr] | [INFO] [stderr] 8 | pub const VSL_BACKENDMARKER: u32 = 2147483648; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vsl/record/tag_e.rs:9:33 [INFO] [stderr] | [INFO] [stderr] 9 | pub const VSL_IDENTMASK: i64 = -3221225473; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_221_225_473` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/vsl/record/tag_e.rs:12:26 [INFO] [stderr] | [INFO] [stderr] 12 | pub const NODEF_NOTICE: &'static [u8; 46usize] = [INFO] [stderr] | -^^^^^^^-------------- help: consider removing `'static`: `&[u8; 46usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/access_log/record_state/mod.rs:57:134 [INFO] [stderr] | [INFO] [stderr] 57 | fn on_expire(store_name: &str, current_epoch: Wrapping, record_epoch: Wrapping, record_ident: VslIdent, record: &Slot) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/access_log/record_state/mod.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/access_log/record_state/mod.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/access_log/record_state/mod.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | Continue => return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/store.rs:177:136 [INFO] [stderr] | [INFO] [stderr] 177 | pub fn log_expire(store_name: &str, current_epoch: Wrapping, record_epoch: Wrapping, record_ident: VslIdent, record: &T) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/store.rs:180:134 [INFO] [stderr] | [INFO] [stderr] 180 | pub fn log_nuke(store_name: &str, current_epoch: Wrapping, record_epoch: Wrapping, record_ident: VslIdent, record: &T) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/vsl/record/tag_e.rs:5:23 [INFO] [stderr] | [INFO] [stderr] 5 | pub const VSL_CLASS: &'static [u8; 4usize] = b"Log\0"; [INFO] [stderr] | -^^^^^^^------------- help: consider removing `'static`: `&[u8; 4usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vsl/record/tag_e.rs:7:35 [INFO] [stderr] | [INFO] [stderr] 7 | pub const VSL_CLIENTMARKER: u32 = 1073741824; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_073_741_824` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vsl/record/tag_e.rs:8:36 [INFO] [stderr] | [INFO] [stderr] 8 | pub const VSL_BACKENDMARKER: u32 = 2147483648; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/vsl/record/tag_e.rs:9:33 [INFO] [stderr] | [INFO] [stderr] 9 | pub const VSL_IDENTMASK: i64 = -3221225473; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_221_225_473` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/vsl/record/tag_e.rs:12:26 [INFO] [stderr] | [INFO] [stderr] 12 | pub const NODEF_NOTICE: &'static [u8; 46usize] = [INFO] [stderr] | -^^^^^^^-------------- help: consider removing `'static`: `&[u8; 46usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/store.rs:103:12 [INFO] [stderr] | [INFO] [stderr] 103 | if !(max_slots > 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `max_slots <= 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/store.rs:106:12 [INFO] [stderr] | [INFO] [stderr] 106 | if !(max_epoch_diff > 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `max_epoch_diff <= 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/store.rs:109:12 [INFO] [stderr] | [INFO] [stderr] 109 | if !(evict_count > 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `evict_count <= 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/store.rs:207:38 [INFO] [stderr] | [INFO] [stderr] 207 | pub fn get_mut(&mut self, ident: &VslIdent) -> Option<&mut T> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `VslIdent` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/store.rs:211:30 [INFO] [stderr] | [INFO] [stderr] 211 | pub fn get(&self, ident: &VslIdent) -> Option<&T> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `VslIdent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/store.rs:215:39 [INFO] [stderr] | [INFO] [stderr] 215 | pub fn contains_key(&self, ident: &VslIdent) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `VslIdent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/store.rs:219:37 [INFO] [stderr] | [INFO] [stderr] 219 | pub fn remove(&mut self, ident: &VslIdent) -> Option { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `VslIdent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3290:13 [INFO] [stderr] | [INFO] [stderr] 3290 | 120386761, SLT_Begin, "bereq 120386760 bgfetch"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3291:13 [INFO] [stderr] | [INFO] [stderr] 3291 | 120386761, SLT_Timestamp, "Start: 1478876416.764800 0.000000 0.000000"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3292:13 [INFO] [stderr] | [INFO] [stderr] 3292 | 120386761, SLT_BereqMethod, "GET"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3293:13 [INFO] [stderr] | [INFO] [stderr] 3293 | 120386761, SLT_BereqURL, "/"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3294:13 [INFO] [stderr] | [INFO] [stderr] 3294 | 120386761, SLT_BereqProtocol, "HTTP/1.1"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3295:13 [INFO] [stderr] | [INFO] [stderr] 3295 | 120386761, SLT_BereqHeader, "Host: www.example.com"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3296:13 [INFO] [stderr] | [INFO] [stderr] 3296 | 120386761, SLT_BereqHeader, "Accept: */*"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3297:13 [INFO] [stderr] | [INFO] [stderr] 3297 | 120386761, SLT_BereqHeader, "User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.1"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3298:13 [INFO] [stderr] | [INFO] [stderr] 3298 | 120386761, SLT_BereqHeader, "Accept-Encoding: gzip"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3299:13 [INFO] [stderr] | [INFO] [stderr] 3299 | 120386761, SLT_BereqHeader, "If-None-Match: W/\"371132087\""; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3300:13 [INFO] [stderr] | [INFO] [stderr] 3300 | 120386761, SLT_BereqHeader, "X-Varnish: 120386761"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3301:13 [INFO] [stderr] | [INFO] [stderr] 3301 | 120386761, SLT_VCL_call, "BACKEND_FETCH"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3302:13 [INFO] [stderr] | [INFO] [stderr] 3302 | 120386761, SLT_BereqUnset, "Accept-Encoding: gzip"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3303:13 [INFO] [stderr] | [INFO] [stderr] 3303 | 120386761, SLT_BereqHeader, "Accept-Encoding: gzip"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3304:13 [INFO] [stderr] | [INFO] [stderr] 3304 | 120386761, SLT_VCL_return, "fetch"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3305:13 [INFO] [stderr] | [INFO] [stderr] 3305 | 120386761, SLT_BackendOpen, "51 reload_2016-11-11T09:47:37.origin 10.1.1.22 2081 10.3.1.217 33152"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3306:13 [INFO] [stderr] | [INFO] [stderr] 3306 | 120386761, SLT_BackendStart, "10.1.1.22 2081"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3307:13 [INFO] [stderr] | [INFO] [stderr] 3307 | 120386760, SLT_Link, "bereq 120386761 bgfetch"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_760` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3308:13 [INFO] [stderr] | [INFO] [stderr] 3308 | 120386761, SLT_Timestamp, "Bereq: 1478876416.764860 0.000060 0.000060"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3309:13 [INFO] [stderr] | [INFO] [stderr] 3309 | 120386761, SLT_Timestamp, "Beresp: 1478876417.148921 0.384121 0.384061"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3310:13 [INFO] [stderr] | [INFO] [stderr] 3310 | 120386761, SLT_BerespProtocol, "HTTP/1.1"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3311:13 [INFO] [stderr] | [INFO] [stderr] 3311 | 120386761, SLT_BerespStatus, "304"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3312:13 [INFO] [stderr] | [INFO] [stderr] 3312 | 120386761, SLT_BerespReason, "Not Modified"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3313:13 [INFO] [stderr] | [INFO] [stderr] 3313 | 120386761, SLT_BerespHeader, "Cache-Control: private, must-revalidate, s-maxage=3644"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3314:13 [INFO] [stderr] | [INFO] [stderr] 3314 | 120386761, SLT_BerespHeader, "Content-Type: text/html; charset=utf-8"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3315:13 [INFO] [stderr] | [INFO] [stderr] 3315 | 120386761, SLT_TTL, "RFC 3644 10 -1 1478876417 1478872579 1478872569 0 3644"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3316:13 [INFO] [stderr] | [INFO] [stderr] 3316 | 120386761, SLT_BerespProtocol, "HTTP/1.1"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3317:13 [INFO] [stderr] | [INFO] [stderr] 3317 | 120386761, SLT_BerespStatus, "200"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3318:13 [INFO] [stderr] | [INFO] [stderr] 3318 | 120386761, SLT_BerespReason, "OK"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3319:13 [INFO] [stderr] | [INFO] [stderr] 3319 | 120386761, SLT_BerespHeader, "x-url: /"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3320:13 [INFO] [stderr] | [INFO] [stderr] 3320 | 120386761, SLT_VCL_call, "BACKEND_RESPONSE"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3321:13 [INFO] [stderr] | [INFO] [stderr] 3321 | 120386761, SLT_TTL, "VCL 3644 259200 0 1478872579"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3322:13 [INFO] [stderr] | [INFO] [stderr] 3322 | 120386761, SLT_VCL_return, "deliver"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3323:13 [INFO] [stderr] | [INFO] [stderr] 3323 | 120386761, SLT_Storage, "malloc s0"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3324:13 [INFO] [stderr] | [INFO] [stderr] 3324 | 120386761, SLT_ObjProtocol, "HTTP/1.1"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3325:13 [INFO] [stderr] | [INFO] [stderr] 3325 | 120386761, SLT_ObjStatus, "200"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3326:13 [INFO] [stderr] | [INFO] [stderr] 3326 | 120386761, SLT_ObjReason, "OK"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3327:13 [INFO] [stderr] | [INFO] [stderr] 3327 | 120386761, SLT_ObjHeader, "Cache-Control: private, must-revalidate, s-maxage=3644"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3328:13 [INFO] [stderr] | [INFO] [stderr] 3328 | 120386761, SLT_ObjHeader, "Content-Type: text/html; charset=utf-8"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3329:13 [INFO] [stderr] | [INFO] [stderr] 3329 | 120386761, SLT_ObjHeader, "Server: Microsoft-IIS/7.5"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3330:13 [INFO] [stderr] | [INFO] [stderr] 3330 | 120386761, SLT_BackendReuse, "51 reload_2016-11-11T09:47:37.origin"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3331:13 [INFO] [stderr] | [INFO] [stderr] 3331 | 120386761, SLT_Timestamp, "BerespBody: 1478876417.149090 0.384290 0.000168"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3332:13 [INFO] [stderr] | [INFO] [stderr] 3332 | 120386761, SLT_Length, "182259"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3333:13 [INFO] [stderr] | [INFO] [stderr] 3333 | 120386761, SLT_BereqAcct, "1041 0 1041 562 0 562"; [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3336:43 [INFO] [stderr] | [INFO] [stderr] 3336 | let record = apply_last!(builder, 120386761, SLT_End, "") [INFO] [stderr] | ^^^^^^^^^ help: consider: `120_386_761` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/access_log/record_state/mod.rs:57:134 [INFO] [stderr] | [INFO] [stderr] 57 | fn on_expire(store_name: &str, current_epoch: Wrapping, record_epoch: Wrapping, record_ident: VslIdent, record: &Slot) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/access_log/record_state/mod.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/access_log/record_state/mod.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/access_log/record_state/mod.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | Continue => return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/access_log/record_state/mod.rs:188:54 [INFO] [stderr] | [INFO] [stderr] 188 | Some(&Slot::Builder(ref builder)) => return Some(builder), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(builder)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vsl/record/parser.rs:56:15 [INFO] [stderr] | [INFO] [stderr] 56 | let num = num as u32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/access_log/record.rs:219:5 [INFO] [stderr] | [INFO] [stderr] 219 | / Full { [INFO] [stderr] 220 | | request: HttpRequest, [INFO] [stderr] 221 | | response: HttpResponse, [INFO] [stderr] 222 | | /// Backend connection used/created [INFO] [stderr] ... | [INFO] [stderr] 234 | | accounting: Accounting, [INFO] [stderr] 235 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/access_log/record.rs:219:5 [INFO] [stderr] | [INFO] [stderr] 219 | / Full { [INFO] [stderr] 220 | | request: HttpRequest, [INFO] [stderr] 221 | | response: HttpResponse, [INFO] [stderr] 222 | | /// Backend connection used/created [INFO] [stderr] ... | [INFO] [stderr] 234 | | accounting: Accounting, [INFO] [stderr] 235 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/access_log/record.rs:306:5 [INFO] [stderr] | [INFO] [stderr] 306 | BackendAccess(BackendAccessRecord), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 306 | BackendAccess(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:249:5 [INFO] [stderr] | [INFO] [stderr] 249 | BackendAccess(BackendAccessRecord), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 249 | BackendAccess(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:651:5 [INFO] [stderr] | [INFO] [stderr] 651 | / pub fn apply<'r>(&mut self, vsl: &VslRecord<'r>) -> Result { [INFO] [stderr] 652 | | match vsl.tag { [INFO] [stderr] 653 | | SLT_Begin => return Err(RecordBuilderError::SpuriousBegin(vsl.tag)), [INFO] [stderr] 654 | | SLT_ReqStart => { [INFO] [stderr] ... | [INFO] [stderr] 1116 | | Ok(false) [INFO] [stderr] 1117 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:983:25 [INFO] [stderr] | [INFO] [stderr] 983 | / match self.record_type { [INFO] [stderr] 984 | | RecordType::ClientAccess { [INFO] [stderr] 985 | | transaction: ref mut transaction @ ClientAccessTransactionType::Piped, [INFO] [stderr] 986 | | .. [INFO] [stderr] ... | [INFO] [stderr] 992 | | _ => () [INFO] [stderr] 993 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 983 | if let RecordType::ClientAccess { [INFO] [stderr] 984 | transaction: ref mut transaction @ ClientAccessTransactionType::Piped, [INFO] [stderr] 985 | .. [INFO] [stderr] 986 | } = self.record_type { [INFO] [stderr] 987 | debug!("Changing Piped transaction to Full with Pass handling due to Varnish forced PASS"); [INFO] [stderr] 988 | *transaction = ClientAccessTransactionType::Full; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/access_log/record_state/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Builder(RecordBuilder), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 14 | Builder(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/access_log/record_state/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | New(RecordBuilder), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 21 | New(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/access_log/record_state/mod.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / if let &Slot::Tombstone(_) = record { [INFO] [stderr] 59 | | return; // it is normal to expire Tombstone [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 58 | if let Slot::Tombstone(_) = *record { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/access_log/record_state/mod.rs:142:17 [INFO] [stderr] | [INFO] [stderr] 142 | / match &err { [INFO] [stderr] 143 | | &RecordBuilderError::SpuriousBegin(_) => [INFO] [stderr] 144 | | warn!("Cannot build record with ident {} after applying {}: {}", &vsl.ident, &vsl, &err), [INFO] [stderr] 145 | | _ => [INFO] [stderr] 146 | | error!("Error while building record with ident {} while applying {}: {}", &vsl.ident, &vsl, &err) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 142 | match err { [INFO] [stderr] 143 | RecordBuilderError::SpuriousBegin(_) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/access_log/record_state/mod.rs:156:41 [INFO] [stderr] | [INFO] [stderr] 156 | pub fn lookup_session(&self, ident: &VslIdent) -> Option>> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `VslIdent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:34:43 [INFO] [stderr] | [INFO] [stderr] 34 | "ClientAccess" , 0 + 1 + 1 + 1 + 1 + 1 + 1 + 1 + 1 + [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:189:44 [INFO] [stderr] | [INFO] [stderr] 189 | "BackendAccess" , 0 + 1 + 1 + 1 + 1 + 1 + 1 + 1 + 1 + [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:317:42 [INFO] [stderr] | [INFO] [stderr] 317 | "PipeSession" , 0 + 1 + 1 + 1 + 1 + 1 + 1 + 1 + 1 + 1 [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:415:38 [INFO] [stderr] | [INFO] [stderr] 415 | "Address" , 0 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:440:9 [INFO] [stderr] | [INFO] [stderr] 440 | / match self { [INFO] [stderr] 441 | | &Headers::Raw(slice) => slice.serialize(serializer), [INFO] [stderr] 442 | | &Headers::Indexed(ref index) => index.serialize(serializer), [INFO] [stderr] 443 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 440 | match *self { [INFO] [stderr] 441 | Headers::Raw(slice) => slice.serialize(serializer), [INFO] [stderr] 442 | Headers::Indexed(ref index) => index.serialize(serializer), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:457:36 [INFO] [stderr] | [INFO] [stderr] 457 | "Proxy" , 0 + 1 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:488:42 [INFO] [stderr] | [INFO] [stderr] 488 | "SessionInfo" , 0 + 1 + 1 + 1 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:526:42 [INFO] [stderr] | [INFO] [stderr] 526 | "HttpRequest" , 0 + 1 + 1 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:558:43 [INFO] [stderr] | [INFO] [stderr] 558 | "HttpResponse" , 0 + 1 + 1 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:590:42 [INFO] [stderr] | [INFO] [stderr] 590 | "Compression" , 0 + 1 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if Option :: is_none ( & self . raw_log ) [INFO] [stderr] { 0 } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:621:34 [INFO] [stderr] | [INFO] [stderr] 621 | "Log" , 0 + if Option :: is_none ( & self . raw_log ) [INFO] [stderr] | __________________________________^ [INFO] [stderr] 622 | | { 0 } else { 1 } + if Option :: is_none ( [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:679:42 [INFO] [stderr] | [INFO] [stderr] 679 | "RawLogEntry" , 0 + 1 + 1 + if Option :: is_none ( [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:709:17 [INFO] [stderr] | [INFO] [stderr] 709 | / match log_entry { [INFO] [stderr] 710 | | &VslLogEntry::Vcl(ref msg) => ("VCL", msg.as_str(), None), [INFO] [stderr] 711 | | &VslLogEntry::VclError(ref msg) => [INFO] [stderr] 712 | | ("VCL Error", msg.as_str(), None), [INFO] [stderr] ... | [INFO] [stderr] 729 | | }, [INFO] [stderr] 730 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 709 | match *log_entry { [INFO] [stderr] 710 | VslLogEntry::Vcl(ref msg) => ("VCL", msg.as_str(), None), [INFO] [stderr] 711 | VslLogEntry::VclError(ref msg) => [INFO] [stderr] 712 | ("VCL Error", msg.as_str(), None), [INFO] [stderr] 713 | VslLogEntry::Debug(ref msg) => [INFO] [stderr] 714 | ("Debug", msg.as_str(), None), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:722:21 [INFO] [stderr] | [INFO] [stderr] 722 | / match result { [INFO] [stderr] 723 | | &VslAclResult::Match => [INFO] [stderr] 724 | | ("ACL Match", name.as_str(), [INFO] [stderr] 725 | | addr.as_ref().map(String::as_str)), [INFO] [stderr] ... | [INFO] [stderr] 728 | | addr.as_ref().map(String::as_str)), [INFO] [stderr] 729 | | }, [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 722 | match *result { [INFO] [stderr] 723 | VslAclResult::Match => [INFO] [stderr] 724 | ("ACL Match", name.as_str(), [INFO] [stderr] 725 | addr.as_ref().map(String::as_str)), [INFO] [stderr] 726 | VslAclResult::NoMatch => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:788:42 [INFO] [stderr] | [INFO] [stderr] 788 | "CacheObject" , 0 + 1 + 1 + 1 + 1 + 1 + 1 + 1 + 1 + 1 [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:848:48 [INFO] [stderr] | [INFO] [stderr] 848 | "BackendConnection" , 0 + 1 + 1 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/main.rs:266:1 [INFO] [stderr] | [INFO] [stderr] 266 | / arg_enum! { [INFO] [stderr] 267 | | #[derive(Debug)] [INFO] [stderr] 268 | | enum OutputFormat { [INFO] [stderr] 269 | | Log, [INFO] [stderr] ... | [INFO] [stderr] 276 | | } [INFO] [stderr] 277 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/main.rs:266:1 [INFO] [stderr] | [INFO] [stderr] 266 | / arg_enum! { [INFO] [stderr] 267 | | #[derive(Debug)] [INFO] [stderr] 268 | | enum OutputFormat { [INFO] [stderr] 269 | | Log, [INFO] [stderr] ... | [INFO] [stderr] 276 | | } [INFO] [stderr] 277 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:282:8 [INFO] [stderr] | [INFO] [stderr] 282 | if !(v > 0) { [INFO] [stderr] | ^^^^^^^^ help: try: `v <= 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:292:8 [INFO] [stderr] | [INFO] [stderr] 292 | if !(v > 0) { [INFO] [stderr] | ^^^^^^^^ help: try: `v <= 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/main.rs:302:8 [INFO] [stderr] | [INFO] [stderr] 302 | if !(v > 0.0) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_cmp_op_on_partial_ord)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:312:8 [INFO] [stderr] | [INFO] [stderr] 312 | if !(v > 0) { [INFO] [stderr] | ^^^^^^^^ help: try: `v <= 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> benches/access_log.rs:160:1 [INFO] [stderr] | [INFO] [stderr] 160 | benchmark_main!(benches); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `varnishslog`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:282:8 [INFO] [stderr] | [INFO] [stderr] 282 | if !(v > 0) { [INFO] [stderr] | ^^^^^^^^ help: try: `v <= 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:292:8 [INFO] [stderr] | [INFO] [stderr] 292 | if !(v > 0) { [INFO] [stderr] | ^^^^^^^^ help: try: `v <= 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/main.rs:302:8 [INFO] [stderr] | [INFO] [stderr] 302 | if !(v > 0.0) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_cmp_op_on_partial_ord)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:312:8 [INFO] [stderr] | [INFO] [stderr] 312 | if !(v > 0) { [INFO] [stderr] | ^^^^^^^^ help: try: `v <= 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> benches/stream_buf.rs:107:1 [INFO] [stderr] | [INFO] [stderr] 107 | benchmark_main!(benches); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `varnishslog`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/stream_buf.rs:370:9 [INFO] [stderr] | [INFO] [stderr] 370 | / fn comb<'a>(input: &'a[u8]) -> IResult<&'a[u8], &'a[u8]> { [INFO] [stderr] 371 | | tag!(input, [0, 1, 2]) [INFO] [stderr] 372 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/store.rs:103:12 [INFO] [stderr] | [INFO] [stderr] 103 | if !(max_slots > 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `max_slots <= 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/store.rs:106:12 [INFO] [stderr] | [INFO] [stderr] 106 | if !(max_epoch_diff > 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `max_epoch_diff <= 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/store.rs:109:12 [INFO] [stderr] | [INFO] [stderr] 109 | if !(evict_count > 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `evict_count <= 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/store.rs:207:38 [INFO] [stderr] | [INFO] [stderr] 207 | pub fn get_mut(&mut self, ident: &VslIdent) -> Option<&mut T> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `VslIdent` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/store.rs:211:30 [INFO] [stderr] | [INFO] [stderr] 211 | pub fn get(&self, ident: &VslIdent) -> Option<&T> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `VslIdent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/store.rs:215:39 [INFO] [stderr] | [INFO] [stderr] 215 | pub fn contains_key(&self, ident: &VslIdent) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `VslIdent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/store.rs:219:37 [INFO] [stderr] | [INFO] [stderr] 219 | pub fn remove(&mut self, ident: &VslIdent) -> Option { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `VslIdent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vsl/record/parser.rs:56:15 [INFO] [stderr] | [INFO] [stderr] 56 | let num = num as u32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/access_log/record.rs:219:5 [INFO] [stderr] | [INFO] [stderr] 219 | / Full { [INFO] [stderr] 220 | | request: HttpRequest, [INFO] [stderr] 221 | | response: HttpResponse, [INFO] [stderr] 222 | | /// Backend connection used/created [INFO] [stderr] ... | [INFO] [stderr] 234 | | accounting: Accounting, [INFO] [stderr] 235 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/access_log/record.rs:219:5 [INFO] [stderr] | [INFO] [stderr] 219 | / Full { [INFO] [stderr] 220 | | request: HttpRequest, [INFO] [stderr] 221 | | response: HttpResponse, [INFO] [stderr] 222 | | /// Backend connection used/created [INFO] [stderr] ... | [INFO] [stderr] 234 | | accounting: Accounting, [INFO] [stderr] 235 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/access_log/record.rs:306:5 [INFO] [stderr] | [INFO] [stderr] 306 | BackendAccess(BackendAccessRecord), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 306 | BackendAccess(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 91 [INFO] [stderr] --> src/access_log/session_state.rs:353:5 [INFO] [stderr] | [INFO] [stderr] 353 | / fn apply_session_state() { [INFO] [stderr] 354 | | log(); [INFO] [stderr] 355 | | let mut state = SessionState::new(); [INFO] [stderr] 356 | | [INFO] [stderr] ... | [INFO] [stderr] 532 | | ); [INFO] [stderr] 533 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/session_state.rs:433:17 [INFO] [stderr] | [INFO] [stderr] 433 | assert_eq!(start, parse!("1469180762.484544")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/session_state.rs:433:17 [INFO] [stderr] | [INFO] [stderr] 433 | assert_eq!(start, parse!("1469180762.484544")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/session_state.rs:434:17 [INFO] [stderr] | [INFO] [stderr] 434 | assert_eq!(end, parse!("1469180766.484544")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/session_state.rs:434:17 [INFO] [stderr] | [INFO] [stderr] 434 | assert_eq!(end, parse!("1469180766.484544")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/session_state.rs:492:25 [INFO] [stderr] | [INFO] [stderr] 492 | assert_eq!(start, parse!("1469180762.484544")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/session_state.rs:492:25 [INFO] [stderr] | [INFO] [stderr] 492 | assert_eq!(start, parse!("1469180762.484544")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/session_state.rs:493:25 [INFO] [stderr] | [INFO] [stderr] 493 | assert_eq!(end, parse!("1469180764.484544")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/session_state.rs:493:25 [INFO] [stderr] | [INFO] [stderr] 493 | assert_eq!(end, parse!("1469180764.484544")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 170 [INFO] [stderr] --> src/access_log/session_state.rs:536:5 [INFO] [stderr] | [INFO] [stderr] 536 | / fn apply_session_state_esi() { [INFO] [stderr] 537 | | log(); [INFO] [stderr] 538 | | let mut state = SessionState::new(); [INFO] [stderr] 539 | | [INFO] [stderr] ... | [INFO] [stderr] 731 | | ); [INFO] [stderr] 732 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 56 [INFO] [stderr] --> src/access_log/session_state.rs:735:5 [INFO] [stderr] | [INFO] [stderr] 735 | / fn apply_session_state_grace() { [INFO] [stderr] 736 | | log(); [INFO] [stderr] 737 | | let mut state = SessionState::new(); [INFO] [stderr] 738 | | [INFO] [stderr] ... | [INFO] [stderr] 807 | | ); [INFO] [stderr] 808 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 80 [INFO] [stderr] --> src/access_log/session_state.rs:811:5 [INFO] [stderr] | [INFO] [stderr] 811 | / fn apply_session_state_restart() { [INFO] [stderr] 812 | | log(); [INFO] [stderr] 813 | | let mut state = SessionState::new(); [INFO] [stderr] 814 | | [INFO] [stderr] ... | [INFO] [stderr] 905 | | ); [INFO] [stderr] 906 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 88 [INFO] [stderr] --> src/access_log/session_state.rs:909:5 [INFO] [stderr] | [INFO] [stderr] 909 | / fn apply_session_state_retry() { [INFO] [stderr] 910 | | log(); [INFO] [stderr] 911 | | let mut state = SessionState::new(); [INFO] [stderr] 912 | | [INFO] [stderr] ... | [INFO] [stderr] 1033 | | ); [INFO] [stderr] 1034 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 38 [INFO] [stderr] --> src/access_log/session_state.rs:1037:5 [INFO] [stderr] | [INFO] [stderr] 1037 | / fn apply_session_state_piped() { [INFO] [stderr] 1038 | | log(); [INFO] [stderr] 1039 | | let mut state = SessionState::new(); [INFO] [stderr] 1040 | | [INFO] [stderr] ... | [INFO] [stderr] 1088 | | ); [INFO] [stderr] 1089 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:249:5 [INFO] [stderr] | [INFO] [stderr] 249 | BackendAccess(BackendAccessRecord), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 249 | BackendAccess(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:651:5 [INFO] [stderr] | [INFO] [stderr] 651 | / pub fn apply<'r>(&mut self, vsl: &VslRecord<'r>) -> Result { [INFO] [stderr] 652 | | match vsl.tag { [INFO] [stderr] 653 | | SLT_Begin => return Err(RecordBuilderError::SpuriousBegin(vsl.tag)), [INFO] [stderr] 654 | | SLT_ReqStart => { [INFO] [stderr] ... | [INFO] [stderr] 1116 | | Ok(false) [INFO] [stderr] 1117 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:983:25 [INFO] [stderr] | [INFO] [stderr] 983 | / match self.record_type { [INFO] [stderr] 984 | | RecordType::ClientAccess { [INFO] [stderr] 985 | | transaction: ref mut transaction @ ClientAccessTransactionType::Piped, [INFO] [stderr] 986 | | .. [INFO] [stderr] ... | [INFO] [stderr] 992 | | _ => () [INFO] [stderr] 993 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 983 | if let RecordType::ClientAccess { [INFO] [stderr] 984 | transaction: ref mut transaction @ ClientAccessTransactionType::Piped, [INFO] [stderr] 985 | .. [INFO] [stderr] 986 | } = self.record_type { [INFO] [stderr] 987 | debug!("Changing Piped transaction to Full with Pass handling due to Varnish forced PASS"); [INFO] [stderr] 988 | *transaction = ClientAccessTransactionType::Full; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1824:9 [INFO] [stderr] | [INFO] [stderr] 1824 | assert_eq!(record.start, parse!("1470403413.664824")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1824:9 [INFO] [stderr] | [INFO] [stderr] 1824 | assert_eq!(record.start, parse!("1470403413.664824")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1836:17 [INFO] [stderr] | [INFO] [stderr] 1836 | assert_eq!(process, parse!("1.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1836:17 [INFO] [stderr] | [INFO] [stderr] 1836 | assert_eq!(process, parse!("1.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1837:17 [INFO] [stderr] | [INFO] [stderr] 1837 | assert_eq!(fetch, parse!("0.007491")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1837:17 [INFO] [stderr] | [INFO] [stderr] 1837 | assert_eq!(fetch, parse!("0.007491")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1838:17 [INFO] [stderr] | [INFO] [stderr] 1838 | assert_eq!(ttfb, parse!("1.007601")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1838:17 [INFO] [stderr] | [INFO] [stderr] 1838 | assert_eq!(ttfb, parse!("1.007601")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1839:17 [INFO] [stderr] | [INFO] [stderr] 1839 | assert_eq!(serve, parse!("1.007634")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1839:17 [INFO] [stderr] | [INFO] [stderr] 1839 | assert_eq!(serve, parse!("1.007634")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1872:9 [INFO] [stderr] | [INFO] [stderr] 1872 | assert_eq!(record.start, parse!("1471355414.450311")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1872:9 [INFO] [stderr] | [INFO] [stderr] 1872 | assert_eq!(record.start, parse!("1471355414.450311")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1927:9 [INFO] [stderr] | [INFO] [stderr] 1927 | assert_eq!(record.start, parse!("1471355414.450311")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1927:9 [INFO] [stderr] | [INFO] [stderr] 1927 | assert_eq!(record.start, parse!("1471355414.450311")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1944:17 [INFO] [stderr] | [INFO] [stderr] 1944 | assert_eq!(process, parse!("0.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1944:17 [INFO] [stderr] | [INFO] [stderr] 1944 | assert_eq!(process, parse!("0.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1981:9 [INFO] [stderr] | [INFO] [stderr] 1981 | assert_eq!(record.start, parse!("1471355444.744141")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:1981:9 [INFO] [stderr] | [INFO] [stderr] 1981 | assert_eq!(record.start, parse!("1471355444.744141")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2005:17 [INFO] [stderr] | [INFO] [stderr] 2005 | assert_eq!(process, parse!("0.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2005:17 [INFO] [stderr] | [INFO] [stderr] 2005 | assert_eq!(process, parse!("0.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2006:17 [INFO] [stderr] | [INFO] [stderr] 2006 | assert_eq!(ttfb, parse!("0.000209")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2006:17 [INFO] [stderr] | [INFO] [stderr] 2006 | assert_eq!(ttfb, parse!("0.000209")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2043:9 [INFO] [stderr] | [INFO] [stderr] 2043 | assert_eq!(record.start, parse!("1475491757.258461")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2043:9 [INFO] [stderr] | [INFO] [stderr] 2043 | assert_eq!(record.start, parse!("1475491757.258461")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2067:17 [INFO] [stderr] | [INFO] [stderr] 2067 | assert_eq!(process, parse!("0.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2067:17 [INFO] [stderr] | [INFO] [stderr] 2067 | assert_eq!(process, parse!("0.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2293:17 [INFO] [stderr] | [INFO] [stderr] 2293 | assert_eq!(send, parse!("0.000128")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2293:17 [INFO] [stderr] | [INFO] [stderr] 2293 | assert_eq!(send, parse!("0.000128")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2294:17 [INFO] [stderr] | [INFO] [stderr] 2294 | assert_eq!(ttfb, parse!("0.007524")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2294:17 [INFO] [stderr] | [INFO] [stderr] 2294 | assert_eq!(ttfb, parse!("0.007524")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2295:17 [INFO] [stderr] | [INFO] [stderr] 2295 | assert_eq!(wait, parse!("0.007396")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2295:17 [INFO] [stderr] | [INFO] [stderr] 2295 | assert_eq!(wait, parse!("0.007396")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2426:17 [INFO] [stderr] | [INFO] [stderr] 2426 | assert_eq!(send, parse!("0.004549")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2426:17 [INFO] [stderr] | [INFO] [stderr] 2426 | assert_eq!(send, parse!("0.004549")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2427:17 [INFO] [stderr] | [INFO] [stderr] 2427 | assert_eq!(ttfb, parse!("0.007262")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2427:17 [INFO] [stderr] | [INFO] [stderr] 2427 | assert_eq!(ttfb, parse!("0.007262")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2428:17 [INFO] [stderr] | [INFO] [stderr] 2428 | assert_eq!(wait, parse!("0.002713")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2428:17 [INFO] [stderr] | [INFO] [stderr] 2428 | assert_eq!(wait, parse!("0.002713")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2429:17 [INFO] [stderr] | [INFO] [stderr] 2429 | assert_eq!(fetch, parse!("0.007367")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2429:17 [INFO] [stderr] | [INFO] [stderr] 2429 | assert_eq!(fetch, parse!("0.007367")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2474:17 [INFO] [stderr] | [INFO] [stderr] 2474 | assert_eq!(send, parse!("0.004549")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2474:17 [INFO] [stderr] | [INFO] [stderr] 2474 | assert_eq!(send, parse!("0.004549")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2475:17 [INFO] [stderr] | [INFO] [stderr] 2475 | assert_eq!(ttfb, parse!("0.007262")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2475:17 [INFO] [stderr] | [INFO] [stderr] 2475 | assert_eq!(ttfb, parse!("0.007262")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2476:17 [INFO] [stderr] | [INFO] [stderr] 2476 | assert_eq!(wait, parse!("0.002713")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2476:17 [INFO] [stderr] | [INFO] [stderr] 2476 | assert_eq!(wait, parse!("0.002713")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2477:17 [INFO] [stderr] | [INFO] [stderr] 2477 | assert_eq!(fetch, parse!("0.007367")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2477:17 [INFO] [stderr] | [INFO] [stderr] 2477 | assert_eq!(fetch, parse!("0.007367")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2580:13 [INFO] [stderr] | [INFO] [stderr] 2580 | assert_eq!(synth, parse!("0.000093")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2580:13 [INFO] [stderr] | [INFO] [stderr] 2580 | assert_eq!(synth, parse!("0.000093")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2654:13 [INFO] [stderr] | [INFO] [stderr] 2654 | assert_eq!(synth, parse!("0.000054")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2654:13 [INFO] [stderr] | [INFO] [stderr] 2654 | assert_eq!(synth, parse!("0.000054")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2964:17 [INFO] [stderr] | [INFO] [stderr] 2964 | assert_eq!(ttfb, 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2964:17 [INFO] [stderr] | [INFO] [stderr] 2964 | assert_eq!(ttfb, 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2965:17 [INFO] [stderr] | [INFO] [stderr] 2965 | assert_eq!(serve, 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:2965:17 [INFO] [stderr] | [INFO] [stderr] 2965 | assert_eq!(serve, 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3170:17 [INFO] [stderr] | [INFO] [stderr] 3170 | assert_eq!(ttl, parse!("120.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3170:17 [INFO] [stderr] | [INFO] [stderr] 3170 | assert_eq!(ttl, parse!("120.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3171:17 [INFO] [stderr] | [INFO] [stderr] 3171 | assert_eq!(grace, parse!("10.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3171:17 [INFO] [stderr] | [INFO] [stderr] 3171 | assert_eq!(grace, parse!("10.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3172:17 [INFO] [stderr] | [INFO] [stderr] 3172 | assert_eq!(since, parse!("1471339883.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3172:17 [INFO] [stderr] | [INFO] [stderr] 3172 | assert_eq!(since, parse!("1471339883.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3173:17 [INFO] [stderr] | [INFO] [stderr] 3173 | assert_eq!(origin, parse!("1471339880.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3173:17 [INFO] [stderr] | [INFO] [stderr] 3173 | assert_eq!(origin, parse!("1471339880.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3226:17 [INFO] [stderr] | [INFO] [stderr] 3226 | assert_eq!(ttl, parse!("12345.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3226:17 [INFO] [stderr] | [INFO] [stderr] 3226 | assert_eq!(ttl, parse!("12345.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3227:17 [INFO] [stderr] | [INFO] [stderr] 3227 | assert_eq!(grace, parse!("259200.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3227:17 [INFO] [stderr] | [INFO] [stderr] 3227 | assert_eq!(grace, parse!("259200.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3228:17 [INFO] [stderr] | [INFO] [stderr] 3228 | assert_eq!(keep, parse!("0.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3228:17 [INFO] [stderr] | [INFO] [stderr] 3228 | assert_eq!(keep, parse!("0.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3229:17 [INFO] [stderr] | [INFO] [stderr] 3229 | assert_eq!(since, parse!("1470304807.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3229:17 [INFO] [stderr] | [INFO] [stderr] 3229 | assert_eq!(since, parse!("1470304807.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3231:17 [INFO] [stderr] | [INFO] [stderr] 3231 | assert_eq!(origin, parse!("1471339880.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3231:17 [INFO] [stderr] | [INFO] [stderr] 3231 | assert_eq!(origin, parse!("1471339880.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3467:17 [INFO] [stderr] | [INFO] [stderr] 3467 | assert_eq!(send, parse!("12345.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3467:17 [INFO] [stderr] | [INFO] [stderr] 3467 | assert_eq!(send, parse!("12345.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3468:17 [INFO] [stderr] | [INFO] [stderr] 3468 | assert_eq!(wait, parse!("259200.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3468:17 [INFO] [stderr] | [INFO] [stderr] 3468 | assert_eq!(wait, parse!("259200.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3469:17 [INFO] [stderr] | [INFO] [stderr] 3469 | assert_eq!(ttfb, parse!("0.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/record_builder.rs:3469:17 [INFO] [stderr] | [INFO] [stderr] 3469 | assert_eq!(ttfb, parse!("0.0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/access_log/record_state/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Builder(RecordBuilder), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 14 | Builder(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/access_log/record_state/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | New(RecordBuilder), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 21 | New(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/access_log/record_state/mod.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / if let &Slot::Tombstone(_) = record { [INFO] [stderr] 59 | | return; // it is normal to expire Tombstone [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 58 | if let Slot::Tombstone(_) = *record { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/access_log/record_state/mod.rs:142:17 [INFO] [stderr] | [INFO] [stderr] 142 | / match &err { [INFO] [stderr] 143 | | &RecordBuilderError::SpuriousBegin(_) => [INFO] [stderr] 144 | | warn!("Cannot build record with ident {} after applying {}: {}", &vsl.ident, &vsl, &err), [INFO] [stderr] 145 | | _ => [INFO] [stderr] 146 | | error!("Error while building record with ident {} while applying {}: {}", &vsl.ident, &vsl, &err) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 142 | match err { [INFO] [stderr] 143 | RecordBuilderError::SpuriousBegin(_) => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/access_log/record_state/mod.rs:156:41 [INFO] [stderr] | [INFO] [stderr] 156 | pub fn lookup_session(&self, ident: &VslIdent) -> Option>> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `VslIdent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 61 [INFO] [stderr] --> src/access_log/record_state/mod.rs:204:5 [INFO] [stderr] | [INFO] [stderr] 204 | / fn apply_record_state_client_access() { [INFO] [stderr] 205 | | log(); [INFO] [stderr] 206 | | let mut state = RecordState::new(); [INFO] [stderr] 207 | | [INFO] [stderr] ... | [INFO] [stderr] 323 | | ); [INFO] [stderr] 324 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/mod.rs:283:17 [INFO] [stderr] | [INFO] [stderr] 283 | assert_eq!(start, parse!("1471355385.239203")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/mod.rs:283:17 [INFO] [stderr] | [INFO] [stderr] 283 | assert_eq!(start, parse!("1471355385.239203")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/mod.rs:284:17 [INFO] [stderr] | [INFO] [stderr] 284 | assert_eq!(end, parse!("1471355385.239652")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/mod.rs:284:17 [INFO] [stderr] | [INFO] [stderr] 284 | assert_eq!(end, parse!("1471355385.239652")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 43 [INFO] [stderr] --> src/access_log/record_state/mod.rs:327:5 [INFO] [stderr] | [INFO] [stderr] 327 | / fn apply_record_state_backend_access() { [INFO] [stderr] 328 | | log(); [INFO] [stderr] 329 | | let mut state = RecordState::new(); [INFO] [stderr] 330 | | [INFO] [stderr] ... | [INFO] [stderr] 415 | | ); [INFO] [stderr] 416 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/mod.rs:375:17 [INFO] [stderr] | [INFO] [stderr] 375 | assert_eq!(start, parse!("1469180762.484544")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/mod.rs:375:17 [INFO] [stderr] | [INFO] [stderr] 375 | assert_eq!(start, parse!("1469180762.484544")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/mod.rs:376:17 [INFO] [stderr] | [INFO] [stderr] 376 | assert_eq!(end, parse!("1469180763.484544")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/mod.rs:376:17 [INFO] [stderr] | [INFO] [stderr] 376 | assert_eq!(end, parse!("1469180763.484544")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/access_log/record_state/mod.rs:419:5 [INFO] [stderr] | [INFO] [stderr] 419 | / fn apply_record_state_session_head() { [INFO] [stderr] 420 | | log(); [INFO] [stderr] 421 | | let mut state = RecordState::new(); [INFO] [stderr] 422 | | [INFO] [stderr] ... | [INFO] [stderr] 503 | | ); [INFO] [stderr] 504 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/mod.rs:452:21 [INFO] [stderr] | [INFO] [stderr] 452 | assert_eq!(open, parse!("1469180762.484344")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/mod.rs:452:21 [INFO] [stderr] | [INFO] [stderr] 452 | assert_eq!(open, parse!("1469180762.484344")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/mod.rs:491:17 [INFO] [stderr] | [INFO] [stderr] 491 | assert_eq!(open, parse!("1469180762.484344")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/mod.rs:491:17 [INFO] [stderr] | [INFO] [stderr] 491 | assert_eq!(open, parse!("1469180762.484344")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/access_log/record_state/mod.rs:500:17 [INFO] [stderr] | [INFO] [stderr] 500 | assert_eq!(duration, parse!("0.001")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/access_log/record_state/mod.rs:500:17 [INFO] [stderr] | [INFO] [stderr] 500 | assert_eq!(duration, parse!("0.001")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:34:43 [INFO] [stderr] | [INFO] [stderr] 34 | "ClientAccess" , 0 + 1 + 1 + 1 + 1 + 1 + 1 + 1 + 1 + [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:189:44 [INFO] [stderr] | [INFO] [stderr] 189 | "BackendAccess" , 0 + 1 + 1 + 1 + 1 + 1 + 1 + 1 + 1 + [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:317:42 [INFO] [stderr] | [INFO] [stderr] 317 | "PipeSession" , 0 + 1 + 1 + 1 + 1 + 1 + 1 + 1 + 1 + 1 [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:415:38 [INFO] [stderr] | [INFO] [stderr] 415 | "Address" , 0 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:440:9 [INFO] [stderr] | [INFO] [stderr] 440 | / match self { [INFO] [stderr] 441 | | &Headers::Raw(slice) => slice.serialize(serializer), [INFO] [stderr] 442 | | &Headers::Indexed(ref index) => index.serialize(serializer), [INFO] [stderr] 443 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 440 | match *self { [INFO] [stderr] 441 | Headers::Raw(slice) => slice.serialize(serializer), [INFO] [stderr] 442 | Headers::Indexed(ref index) => index.serialize(serializer), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:457:36 [INFO] [stderr] | [INFO] [stderr] 457 | "Proxy" , 0 + 1 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:488:42 [INFO] [stderr] | [INFO] [stderr] 488 | "SessionInfo" , 0 + 1 + 1 + 1 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:526:42 [INFO] [stderr] | [INFO] [stderr] 526 | "HttpRequest" , 0 + 1 + 1 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:558:43 [INFO] [stderr] | [INFO] [stderr] 558 | "HttpResponse" , 0 + 1 + 1 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:590:42 [INFO] [stderr] | [INFO] [stderr] 590 | "Compression" , 0 + 1 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if Option :: is_none ( & self . raw_log ) [INFO] [stderr] { 0 } else { 1 }` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:621:34 [INFO] [stderr] | [INFO] [stderr] 621 | "Log" , 0 + if Option :: is_none ( & self . raw_log ) [INFO] [stderr] | __________________________________^ [INFO] [stderr] 622 | | { 0 } else { 1 } + if Option :: is_none ( [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:679:42 [INFO] [stderr] | [INFO] [stderr] 679 | "RawLogEntry" , 0 + 1 + 1 + if Option :: is_none ( [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:709:17 [INFO] [stderr] | [INFO] [stderr] 709 | / match log_entry { [INFO] [stderr] 710 | | &VslLogEntry::Vcl(ref msg) => ("VCL", msg.as_str(), None), [INFO] [stderr] 711 | | &VslLogEntry::VclError(ref msg) => [INFO] [stderr] 712 | | ("VCL Error", msg.as_str(), None), [INFO] [stderr] ... | [INFO] [stderr] 729 | | }, [INFO] [stderr] 730 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 709 | match *log_entry { [INFO] [stderr] 710 | VslLogEntry::Vcl(ref msg) => ("VCL", msg.as_str(), None), [INFO] [stderr] 711 | VslLogEntry::VclError(ref msg) => [INFO] [stderr] 712 | ("VCL Error", msg.as_str(), None), [INFO] [stderr] 713 | VslLogEntry::Debug(ref msg) => [INFO] [stderr] 714 | ("Debug", msg.as_str(), None), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:722:21 [INFO] [stderr] | [INFO] [stderr] 722 | / match result { [INFO] [stderr] 723 | | &VslAclResult::Match => [INFO] [stderr] 724 | | ("ACL Match", name.as_str(), [INFO] [stderr] 725 | | addr.as_ref().map(String::as_str)), [INFO] [stderr] ... | [INFO] [stderr] 728 | | addr.as_ref().map(String::as_str)), [INFO] [stderr] 729 | | }, [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 722 | match *result { [INFO] [stderr] 723 | VslAclResult::Match => [INFO] [stderr] 724 | ("ACL Match", name.as_str(), [INFO] [stderr] 725 | addr.as_ref().map(String::as_str)), [INFO] [stderr] 726 | VslAclResult::NoMatch => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:788:42 [INFO] [stderr] | [INFO] [stderr] 788 | "CacheObject" , 0 + 1 + 1 + 1 + 1 + 1 + 1 + 1 + 1 + 1 [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/varnishslog-b6c8eb879e06175d/out/serde_types.rs:848:48 [INFO] [stderr] | [INFO] [stderr] 848 | "BackendConnection" , 0 + 1 + 1 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: aborting due to 51 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `varnishslog`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "91409ac723e50546397e12cf4eaefc6be575d4721f595ea625e7b9acf620af35"` [INFO] running `"docker" "rm" "-f" "91409ac723e50546397e12cf4eaefc6be575d4721f595ea625e7b9acf620af35"` [INFO] [stdout] 91409ac723e50546397e12cf4eaefc6be575d4721f595ea625e7b9acf620af35