[INFO] updating cached repository jpastuszek/varnishslog-search [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jpastuszek/varnishslog-search [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jpastuszek/varnishslog-search" "work/ex/clippy-test-run/sources/stable/gh/jpastuszek/varnishslog-search"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jpastuszek/varnishslog-search'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jpastuszek/varnishslog-search" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jpastuszek/varnishslog-search"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jpastuszek/varnishslog-search'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 31672d13b67d251fbc3eb64bcbd2f8fc1c02a7be [INFO] sha for GitHub repo jpastuszek/varnishslog-search: 31672d13b67d251fbc3eb64bcbd2f8fc1c02a7be [INFO] validating manifest of jpastuszek/varnishslog-search on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jpastuszek/varnishslog-search on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jpastuszek/varnishslog-search [INFO] finished frobbing jpastuszek/varnishslog-search [INFO] frobbed toml for jpastuszek/varnishslog-search written to work/ex/clippy-test-run/sources/stable/gh/jpastuszek/varnishslog-search/Cargo.toml [INFO] started frobbing jpastuszek/varnishslog-search [INFO] finished frobbing jpastuszek/varnishslog-search [INFO] frobbed toml for jpastuszek/varnishslog-search written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jpastuszek/varnishslog-search/Cargo.toml [INFO] crate jpastuszek/varnishslog-search has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jpastuszek/varnishslog-search against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jpastuszek/varnishslog-search:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 057a5ef1e7a4bcc137e5a20c84a528b788d352c8e42cae6f5af302bc76aaa726 [INFO] running `"docker" "start" "-a" "057a5ef1e7a4bcc137e5a20c84a528b788d352c8e42cae6f5af302bc76aaa726"` [INFO] [stderr] Checking serde_json v1.0.10 [INFO] [stderr] Checking dot_json v0.2.0 [INFO] [stderr] Checking varnishslog-serch v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/process.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | let to_str = match value { [INFO] [stderr] | __________________________^ [INFO] [stderr] 15 | | &mut Value::Number(ref num) if num.is_u64() => false, [INFO] [stderr] 16 | | &mut Value::String(_) => false, [INFO] [stderr] 17 | | _ => true [INFO] [stderr] 18 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | let to_str = match *value { [INFO] [stderr] 15 | Value::Number(ref num) if num.is_u64() => false, [INFO] [stderr] 16 | Value::String(_) => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/process.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | let to_str = match value { [INFO] [stderr] | __________________________^ [INFO] [stderr] 15 | | &mut Value::Number(ref num) if num.is_u64() => false, [INFO] [stderr] 16 | | &mut Value::String(_) => false, [INFO] [stderr] 17 | | _ => true [INFO] [stderr] 18 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | let to_str = match *value { [INFO] [stderr] 15 | Value::Number(ref num) if num.is_u64() => false, [INFO] [stderr] 16 | Value::String(_) => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.74s [INFO] running `"docker" "inspect" "057a5ef1e7a4bcc137e5a20c84a528b788d352c8e42cae6f5af302bc76aaa726"` [INFO] running `"docker" "rm" "-f" "057a5ef1e7a4bcc137e5a20c84a528b788d352c8e42cae6f5af302bc76aaa726"` [INFO] [stdout] 057a5ef1e7a4bcc137e5a20c84a528b788d352c8e42cae6f5af302bc76aaa726