[INFO] updating cached repository jostly/terragen [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jostly/terragen [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jostly/terragen" "work/ex/clippy-test-run/sources/stable/gh/jostly/terragen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jostly/terragen'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jostly/terragen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jostly/terragen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jostly/terragen'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 482242c6b9b34aa04565ed4a6bfc1c0b4d37d165 [INFO] sha for GitHub repo jostly/terragen: 482242c6b9b34aa04565ed4a6bfc1c0b4d37d165 [INFO] validating manifest of jostly/terragen on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jostly/terragen on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jostly/terragen [INFO] finished frobbing jostly/terragen [INFO] frobbed toml for jostly/terragen written to work/ex/clippy-test-run/sources/stable/gh/jostly/terragen/Cargo.toml [INFO] started frobbing jostly/terragen [INFO] finished frobbing jostly/terragen [INFO] frobbed toml for jostly/terragen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jostly/terragen/Cargo.toml [INFO] crate jostly/terragen has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jostly/terragen against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jostly/terragen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 296ecf07c325d897714534b530adbbc743aeedc0c9e639991f07431ac30a7483 [INFO] running `"docker" "start" "-a" "296ecf07c325d897714534b530adbbc743aeedc0c9e639991f07431ac30a7483"` [INFO] [stderr] Compiling gcc v0.3.49 [INFO] [stderr] Checking bitflags v0.3.3 [INFO] [stderr] Checking lzw v0.9.0 [INFO] [stderr] Checking num-complex v0.1.37 [INFO] [stderr] Compiling freetype-sys v0.4.0 [INFO] [stderr] Compiling gl_generator v0.5.3 [INFO] [stderr] Checking num-bigint v0.1.37 [INFO] [stderr] Checking noise v0.4.1 [INFO] [stderr] Checking textwrap v0.6.0 [INFO] [stderr] Checking generic-array v0.2.1 [INFO] [stderr] Checking gif v0.7.0 [INFO] [stderr] Checking alga v0.5.1 [INFO] [stderr] Checking clap v2.25.0 [INFO] [stderr] Compiling miniz-sys v0.1.9 [INFO] [stderr] Compiling libz-sys v1.0.13 [INFO] [stderr] Compiling cmake v0.1.24 [INFO] [stderr] Checking num-rational v0.1.36 [INFO] [stderr] Compiling glfw-sys v3.2.2 [INFO] [stderr] Checking num v0.1.37 [INFO] [stderr] Compiling gl v0.6.2 [INFO] [stderr] Checking stopwatch v0.0.7 [INFO] [stderr] Checking freetype-rs v0.9.0 [INFO] [stderr] Checking flate2 v0.2.19 [INFO] [stderr] Checking nalgebra v0.12.3 [INFO] [stderr] Checking png v0.4.3 [INFO] [stderr] Checking image v0.6.1 [INFO] [stderr] Checking glfw v0.8.0 [INFO] [stderr] Checking ncollide_math v0.7.0 [INFO] [stderr] Checking ncollide_utils v0.7.0 [INFO] [stderr] Checking ncollide_procedural v0.7.0 [INFO] [stderr] Checking kiss3d v0.9.0 [INFO] [stderr] Checking terragen v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/generator/edge.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | a: a, [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/generator/edge.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | b: b, [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/generator/face.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | points: points, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/generator/face.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | edges: edges, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `edges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/generator/node.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | point: point, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/generator/node.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | elevation: elevation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elevation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/generator/mod.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | nodes: nodes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/generator/mod.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | edges: edges, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `edges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/generator/mod.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | faces: faces, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `faces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/generator/edge.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | a: a, [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/generator/edge.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | b: b, [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/generator/face.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | points: points, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/generator/face.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | edges: edges, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `edges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/generator/node.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | point: point, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/generator/node.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | elevation: elevation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elevation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/generator/mod.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | nodes: nodes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/generator/mod.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | edges: edges, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `edges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/generator/mod.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | faces: faces, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `faces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/planet/plate.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/planet/plate.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | base_elevation: base_elevation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `base_elevation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/planet/tile.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | vertices: vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/planet/tile.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | num_vertices: num_vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_vertices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/planet/tile.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | midpoint: midpoint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `midpoint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] --> src/terrain/planet/plate.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/planet/plate.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | base_elevation: base_elevation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `base_elevation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/planet/tile.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | vertices: vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/planet/tile.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | num_vertices: num_vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_vertices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/planet/tile.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | midpoint: midpoint, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `midpoint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] --> src/terrain/planet/mod.rs:131:13 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] --> src/terrain/planet/mod.rs:131:13 [INFO] [stderr] 131 | vertices: vertices, [INFO] [stderr] | [INFO] [stderr] 131 | vertices: vertices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/planet/mod.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | tiles: tiles, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `tiles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/planet/mod.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | elevations: elevations, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elevations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/planet/mod.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | tile_neighbours: tile_neighbours, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tile_neighbours` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/planet/mod.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | tiles: tiles, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `tiles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/planet/mod.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | elevations: elevations, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elevations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/planet/mod.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | tile_neighbours: tile_neighbours, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tile_neighbours` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/planet/mod.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | num_corners: num_corners, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_corners` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/planet/mod.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | num_tiles: num_tiles, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_tiles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/planet/mod.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | num_corners: num_corners, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_corners` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/planet/mod.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | num_tiles: num_tiles, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_tiles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math/vector.rs:12:16 [INFO] [stderr] | [INFO] [stderr] 12 | Vec3 { x: x, y: y, z: z } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math/vector.rs:12:22 [INFO] [stderr] | [INFO] [stderr] 12 | Vec3 { x: x, y: y, z: z } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math/vector.rs:12:28 [INFO] [stderr] | [INFO] [stderr] 12 | Vec3 { x: x, y: y, z: z } [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/wireframe_material.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | shader: shader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `shader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math/vector.rs:12:16 [INFO] [stderr] | [INFO] [stderr] 12 | Vec3 { x: x, y: y, z: z } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math/vector.rs:12:22 [INFO] [stderr] | [INFO] [stderr] 12 | Vec3 { x: x, y: y, z: z } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/math/vector.rs:12:28 [INFO] [stderr] | [INFO] [stderr] 12 | Vec3 { x: x, y: y, z: z } [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/wireframe_material.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | shader: shader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `shader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geom.rs:294:12 [INFO] [stderr] | [INFO] [stderr] 294 | 510100000 / total_faces); [INFO] [stderr] | ^^^^^^^^^ help: consider: `510_100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/render/wireframe_material.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / macro_rules! verify( [INFO] [stderr] 14 | | ($e: expr) => { [INFO] [stderr] 15 | | unsafe { [INFO] [stderr] 16 | | let res = $e; [INFO] [stderr] ... | [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/render/wireframe_material.rs:119:28 [INFO] [stderr] | [INFO] [stderr] 119 | const A_VERY_LONG_STRING: &'static str = "#version 120 [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/render/wireframe_material.rs:129:34 [INFO] [stderr] | [INFO] [stderr] 129 | const ANOTHER_VERY_LONG_STRING: &'static str = "#version 120 [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geom.rs:294:12 [INFO] [stderr] | [INFO] [stderr] 294 | 510100000 / total_faces); [INFO] [stderr] | ^^^^^^^^^ help: consider: `510_100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/render/wireframe_material.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / macro_rules! verify( [INFO] [stderr] 14 | | ($e: expr) => { [INFO] [stderr] 15 | | unsafe { [INFO] [stderr] 16 | | let res = $e; [INFO] [stderr] ... | [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/render/wireframe_material.rs:119:28 [INFO] [stderr] | [INFO] [stderr] 119 | const A_VERY_LONG_STRING: &'static str = "#version 120 [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/render/wireframe_material.rs:129:34 [INFO] [stderr] | [INFO] [stderr] 129 | const ANOTHER_VERY_LONG_STRING: &'static str = "#version 120 [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/terrain/generator/face.rs:38:60 [INFO] [stderr] | [INFO] [stderr] 38 | } else if self.points.x == b && self.points.y == a { [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 39 | | 2 [INFO] [stderr] 40 | | } else if self.points.y == a && self.points.z == b { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/terrain/generator/face.rs:36:53 [INFO] [stderr] | [INFO] [stderr] 36 | if self.points.x == a && self.points.y == b { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 37 | | 2 [INFO] [stderr] 38 | | } else if self.points.x == b && self.points.y == a { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/terrain/generator/mod.rs:116:60 [INFO] [stderr] | [INFO] [stderr] 116 | fn assign_links_to_nodes(nodes: &mut Vec, edges: &Vec, faces: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Edge]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/terrain/generator/mod.rs:116:79 [INFO] [stderr] | [INFO] [stderr] 116 | fn assign_links_to_nodes(nodes: &mut Vec, edges: &Vec, faces: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Face]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/terrain/generator/mod.rs:138:60 [INFO] [stderr] | [INFO] [stderr] 138 | fn assign_links_to_edges(edges: &mut Vec, faces: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Face]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in point_shifts.iter_mut().enumerate()` or similar iterators [INFO] [stderr] --> src/terrain/generator/mod.rs:479:24 [INFO] [stderr] | [INFO] [stderr] 479 | for mut vec in point_shifts.iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/terrain/planet/mod.rs:61:57 [INFO] [stderr] | [INFO] [stderr] 61 | let mut tiles = borders_map.entry(pair).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `plates` [INFO] [stderr] --> src/terrain/planet/mod.rs:334:31 [INFO] [stderr] | [INFO] [stderr] 334 | 'lp: for i in 1..plates.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 334 | 'lp: for (i, ) in plates.iter().enumerate().skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/math/vector.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | / fn index_mut<'a>(&'a mut self, index: u32) -> &'a mut Self::Output { [INFO] [stderr] 192 | | match index % 3 { [INFO] [stderr] 193 | | 0 => &mut self.x, [INFO] [stderr] 194 | | 1 => &mut self.y, [INFO] [stderr] 195 | | _ => &mut self.z, [INFO] [stderr] 196 | | } [INFO] [stderr] 197 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/geom.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | let ref vert = gen_vertices[*idx as usize]; [INFO] [stderr] | ----^^^^^^^^------------------------------- help: try: `let vert = &gen_vertices[*idx as usize];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/geom.rs:133:1 [INFO] [stderr] | [INFO] [stderr] 133 | / fn generate_dual(generator: Generator, [INFO] [stderr] 134 | | planet: Planet, [INFO] [stderr] 135 | | generate_wireframe: bool, [INFO] [stderr] 136 | | show_plates: bool) [INFO] [stderr] ... | [INFO] [stderr] 307 | | r [INFO] [stderr] 308 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geom.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | uv.clone() [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `uv` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geom.rs:225:31 [INFO] [stderr] | [INFO] [stderr] 225 | mesh_normals.push(normal.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geom.rs:226:33 [INFO] [stderr] | [INFO] [stderr] 226 | mesh_texcoords.push(uv_outer.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `uv_outer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geom.rs:235:35 [INFO] [stderr] | [INFO] [stderr] 235 | mesh_normals.push(normal.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geom.rs:236:37 [INFO] [stderr] | [INFO] [stderr] 236 | mesh_texcoords.push(uv.clone()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `uv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/geom.rs:331:34 [INFO] [stderr] | [INFO] [stderr] 331 | fn encode_wireframes(wireframes: &Vec) -> Option>> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | / match rx.try_recv() { [INFO] [stderr] 219 | | Ok(Message::Complete(vertices, faces, normals, texcoords, terr, pla)) => { [INFO] [stderr] 220 | | if let Some(mut c) = planet_node { [INFO] [stderr] 221 | | window.remove(&mut c); [INFO] [stderr] ... | [INFO] [stderr] 235 | | _ => {} [INFO] [stderr] 236 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 218 | if let Ok(Message::Complete(vertices, faces, normals, texcoords, terr, pla)) = rx.try_recv() { [INFO] [stderr] 219 | if let Some(mut c) = planet_node { [INFO] [stderr] 220 | window.remove(&mut c); [INFO] [stderr] 221 | } [INFO] [stderr] 222 | let (wirecoords, wirefaces) = generate_plate_vectors(&pla); [INFO] [stderr] 223 | planet_node = Some(add_mesh(visualization_types[visualization_index], [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:249:25 [INFO] [stderr] | [INFO] [stderr] 249 | wireframes: Option<(Vec>, Vec>)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/main.rs:243:1 [INFO] [stderr] | [INFO] [stderr] 243 | / fn add_mesh(visualization: Visualization, [INFO] [stderr] 244 | | parent: &mut SceneNode, [INFO] [stderr] 245 | | vertices: Vec>, [INFO] [stderr] 246 | | faces: Vec>, [INFO] [stderr] ... | [INFO] [stderr] 276 | | grp [INFO] [stderr] 277 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `terragen`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/terrain/generator/face.rs:38:60 [INFO] [stderr] | [INFO] [stderr] 38 | } else if self.points.x == b && self.points.y == a { [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 39 | | 2 [INFO] [stderr] 40 | | } else if self.points.y == a && self.points.z == b { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/terrain/generator/face.rs:36:53 [INFO] [stderr] | [INFO] [stderr] 36 | if self.points.x == a && self.points.y == b { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 37 | | 2 [INFO] [stderr] 38 | | } else if self.points.x == b && self.points.y == a { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/terrain/generator/mod.rs:116:60 [INFO] [stderr] | [INFO] [stderr] 116 | fn assign_links_to_nodes(nodes: &mut Vec, edges: &Vec, faces: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Edge]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/terrain/generator/mod.rs:116:79 [INFO] [stderr] | [INFO] [stderr] 116 | fn assign_links_to_nodes(nodes: &mut Vec, edges: &Vec, faces: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Face]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/terrain/generator/mod.rs:138:60 [INFO] [stderr] | [INFO] [stderr] 138 | fn assign_links_to_edges(edges: &mut Vec, faces: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Face]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in point_shifts.iter_mut().enumerate()` or similar iterators [INFO] [stderr] --> src/terrain/generator/mod.rs:479:24 [INFO] [stderr] | [INFO] [stderr] 479 | for mut vec in point_shifts.iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/terrain/generator/mod.rs:789:17 [INFO] [stderr] | [INFO] [stderr] 789 | let ref e0 = terr.edges[f.edges.x as usize]; [INFO] [stderr] | ----^^^^^^---------------------------------- help: try: `let e0 = &terr.edges[f.edges.x as usize];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/terrain/generator/mod.rs:790:17 [INFO] [stderr] | [INFO] [stderr] 790 | let ref e1 = terr.edges[f.edges.y as usize]; [INFO] [stderr] | ----^^^^^^---------------------------------- help: try: `let e1 = &terr.edges[f.edges.y as usize];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/terrain/generator/mod.rs:791:17 [INFO] [stderr] | [INFO] [stderr] 791 | let ref e2 = terr.edges[f.edges.z as usize]; [INFO] [stderr] | ----^^^^^^---------------------------------- help: try: `let e2 = &terr.edges[f.edges.z as usize];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/terrain/planet/mod.rs:61:57 [INFO] [stderr] | [INFO] [stderr] 61 | let mut tiles = borders_map.entry(pair).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `plates` [INFO] [stderr] --> src/terrain/planet/mod.rs:334:31 [INFO] [stderr] | [INFO] [stderr] 334 | 'lp: for i in 1..plates.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 334 | 'lp: for (i, ) in plates.iter().enumerate().skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/math/vector.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | / fn index_mut<'a>(&'a mut self, index: u32) -> &'a mut Self::Output { [INFO] [stderr] 192 | | match index % 3 { [INFO] [stderr] 193 | | 0 => &mut self.x, [INFO] [stderr] 194 | | 1 => &mut self.y, [INFO] [stderr] 195 | | _ => &mut self.z, [INFO] [stderr] 196 | | } [INFO] [stderr] 197 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/math/vector.rs:277:21 [INFO] [stderr] | [INFO] [stderr] 277 | let ref ra = $a; [INFO] [stderr] | ----^^^^^^------ help: try: `let ra = &Vec3::new(1, 2, 3);` [INFO] [stderr] ... [INFO] [stderr] 319 | binop_test!(add_vectors; Vec3::new(1, 2, 3), Vec3::new(4, 7, 11) => add => Vec3::new(5, 9, 14)); [INFO] [stderr] | ------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/math/vector.rs:278:21 [INFO] [stderr] | [INFO] [stderr] 278 | let ref rb = $b; [INFO] [stderr] | ----^^^^^^------ help: try: `let rb = &Vec3::new(4, 7, 11);` [INFO] [stderr] ... [INFO] [stderr] 319 | binop_test!(add_vectors; Vec3::new(1, 2, 3), Vec3::new(4, 7, 11) => add => Vec3::new(5, 9, 14)); [INFO] [stderr] | ------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/math/vector.rs:277:21 [INFO] [stderr] | [INFO] [stderr] 277 | let ref ra = $a; [INFO] [stderr] | ----^^^^^^------ help: try: `let ra = &Vec3::new(4, 7, 11);` [INFO] [stderr] ... [INFO] [stderr] 320 | binop_test!(sub_vectors; Vec3::new(4, 7, 11), Vec3::new(1, 2, 3) => sub => Vec3::new(3, 5, 8)); [INFO] [stderr] | ----------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/math/vector.rs:278:21 [INFO] [stderr] | [INFO] [stderr] 278 | let ref rb = $b; [INFO] [stderr] | ----^^^^^^------ help: try: `let rb = &Vec3::new(1, 2, 3);` [INFO] [stderr] ... [INFO] [stderr] 320 | binop_test!(sub_vectors; Vec3::new(4, 7, 11), Vec3::new(1, 2, 3) => sub => Vec3::new(3, 5, 8)); [INFO] [stderr] | ----------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/math/vector.rs:293:21 [INFO] [stderr] | [INFO] [stderr] 293 | let ref rb = $b; [INFO] [stderr] | ----^^^^^^------ help: try: `let rb = &Vec3::new(4, 7, 11);` [INFO] [stderr] ... [INFO] [stderr] 321 | assignop_test!(add_assign_vectors; Vec3::new(1, 2, 3), Vec3::new(4, 7, 11) => add_assign => Vec3::new(5, 9, 14)); [INFO] [stderr] | ----------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/math/vector.rs:293:21 [INFO] [stderr] | [INFO] [stderr] 293 | let ref rb = $b; [INFO] [stderr] | ----^^^^^^------ help: try: `let rb = &Vec3::new(1, 2, 3);` [INFO] [stderr] ... [INFO] [stderr] 322 | assignop_test!(sub_assign_vectors; Vec3::new(4, 7, 11), Vec3::new(1, 2, 3) => sub_assign => Vec3::new(3, 5, 8)); [INFO] [stderr] | ---------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/math/vector.rs:277:21 [INFO] [stderr] | [INFO] [stderr] 277 | let ref ra = $a; [INFO] [stderr] | ----^^^^^^------ help: try: `let ra = &Vec3::new(4, 7, 11);` [INFO] [stderr] ... [INFO] [stderr] 324 | binop_test!(scalar_mul; Vec3::new(4, 7, 11), 2 => mul => Vec3::new(8, 14, 22)); [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/math/vector.rs:278:21 [INFO] [stderr] | [INFO] [stderr] 278 | let ref rb = $b; [INFO] [stderr] | ----^^^^^^------ help: try: `let rb = &2;` [INFO] [stderr] ... [INFO] [stderr] 324 | binop_test!(scalar_mul; Vec3::new(4, 7, 11), 2 => mul => Vec3::new(8, 14, 22)); [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/math/vector.rs:277:21 [INFO] [stderr] | [INFO] [stderr] 277 | let ref ra = $a; [INFO] [stderr] | ----^^^^^^------ help: try: `let ra = &Vec3::new(8, 14, 22);` [INFO] [stderr] ... [INFO] [stderr] 327 | binop_test!(scalar_div; Vec3::new(8, 14, 22), 2 => div => Vec3::new(4, 7, 11)); [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/math/vector.rs:278:21 [INFO] [stderr] | [INFO] [stderr] 278 | let ref rb = $b; [INFO] [stderr] | ----^^^^^^------ help: try: `let rb = &2;` [INFO] [stderr] ... [INFO] [stderr] 327 | binop_test!(scalar_div; Vec3::new(8, 14, 22), 2 => div => Vec3::new(4, 7, 11)); [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/math/vector.rs:277:21 [INFO] [stderr] | [INFO] [stderr] 277 | let ref ra = $a; [INFO] [stderr] | ----^^^^^^------ help: try: `let ra = &Vec3::new(3, 4, 5);` [INFO] [stderr] ... [INFO] [stderr] 330 | binop_test!(dot_product; Vec3::new(3, 4, 5), Vec3::new(4, 7, 11) => dot => 3 * 4 + 4 * 7 + 5 * 11); [INFO] [stderr] | --------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/math/vector.rs:278:21 [INFO] [stderr] | [INFO] [stderr] 278 | let ref rb = $b; [INFO] [stderr] | ----^^^^^^------ help: try: `let rb = &Vec3::new(4, 7, 11);` [INFO] [stderr] ... [INFO] [stderr] 330 | binop_test!(dot_product; Vec3::new(3, 4, 5), Vec3::new(4, 7, 11) => dot => 3 * 4 + 4 * 7 + 5 * 11); [INFO] [stderr] | --------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/math/linalg.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | let ref a = Vec3::new(2.0, 0.0, 0.0); [INFO] [stderr] | ----^^^^^---------------------------- help: try: `let a = &Vec3::new(2.0, 0.0, 0.0);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/math/linalg.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | let ref b = Vec3::new(0.0, 2.0, 0.0); [INFO] [stderr] | ----^^^^^---------------------------- help: try: `let b = &Vec3::new(0.0, 2.0, 0.0);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/math/stat.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | assert_eq!(variance(iter), 2.0f32 / 3.0f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/math/stat.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | assert_eq!(variance(iter), 2.0f32 / 3.0f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/geom.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | let ref vert = gen_vertices[*idx as usize]; [INFO] [stderr] | ----^^^^^^^^------------------------------- help: try: `let vert = &gen_vertices[*idx as usize];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/geom.rs:133:1 [INFO] [stderr] | [INFO] [stderr] 133 | / fn generate_dual(generator: Generator, [INFO] [stderr] 134 | | planet: Planet, [INFO] [stderr] 135 | | generate_wireframe: bool, [INFO] [stderr] 136 | | show_plates: bool) [INFO] [stderr] ... | [INFO] [stderr] 307 | | r [INFO] [stderr] 308 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geom.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | uv.clone() [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `uv` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geom.rs:225:31 [INFO] [stderr] | [INFO] [stderr] 225 | mesh_normals.push(normal.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geom.rs:226:33 [INFO] [stderr] | [INFO] [stderr] 226 | mesh_texcoords.push(uv_outer.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `uv_outer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geom.rs:235:35 [INFO] [stderr] | [INFO] [stderr] 235 | mesh_normals.push(normal.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/geom.rs:236:37 [INFO] [stderr] | [INFO] [stderr] 236 | mesh_texcoords.push(uv.clone()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `uv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/geom.rs:331:34 [INFO] [stderr] | [INFO] [stderr] 331 | fn encode_wireframes(wireframes: &Vec) -> Option>> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | / match rx.try_recv() { [INFO] [stderr] 219 | | Ok(Message::Complete(vertices, faces, normals, texcoords, terr, pla)) => { [INFO] [stderr] 220 | | if let Some(mut c) = planet_node { [INFO] [stderr] 221 | | window.remove(&mut c); [INFO] [stderr] ... | [INFO] [stderr] 235 | | _ => {} [INFO] [stderr] 236 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 218 | if let Ok(Message::Complete(vertices, faces, normals, texcoords, terr, pla)) = rx.try_recv() { [INFO] [stderr] 219 | if let Some(mut c) = planet_node { [INFO] [stderr] 220 | window.remove(&mut c); [INFO] [stderr] 221 | } [INFO] [stderr] 222 | let (wirecoords, wirefaces) = generate_plate_vectors(&pla); [INFO] [stderr] 223 | planet_node = Some(add_mesh(visualization_types[visualization_index], [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:249:25 [INFO] [stderr] | [INFO] [stderr] 249 | wireframes: Option<(Vec>, Vec>)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/main.rs:243:1 [INFO] [stderr] | [INFO] [stderr] 243 | / fn add_mesh(visualization: Visualization, [INFO] [stderr] 244 | | parent: &mut SceneNode, [INFO] [stderr] 245 | | vertices: Vec>, [INFO] [stderr] 246 | | faces: Vec>, [INFO] [stderr] ... | [INFO] [stderr] 276 | | grp [INFO] [stderr] 277 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `terragen`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "296ecf07c325d897714534b530adbbc743aeedc0c9e639991f07431ac30a7483"` [INFO] running `"docker" "rm" "-f" "296ecf07c325d897714534b530adbbc743aeedc0c9e639991f07431ac30a7483"` [INFO] [stdout] 296ecf07c325d897714534b530adbbc743aeedc0c9e639991f07431ac30a7483