[INFO] updating cached repository josler/promptly-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/josler/promptly-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/josler/promptly-rs" "work/ex/clippy-test-run/sources/stable/gh/josler/promptly-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/josler/promptly-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/josler/promptly-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/josler/promptly-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/josler/promptly-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5310daa7cc1ac6851c7a3c8189ceb31d765c67bb
[INFO] sha for GitHub repo josler/promptly-rs: 5310daa7cc1ac6851c7a3c8189ceb31d765c67bb
[INFO] validating manifest of josler/promptly-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of josler/promptly-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing josler/promptly-rs
[INFO] finished frobbing josler/promptly-rs
[INFO] frobbed toml for josler/promptly-rs written to work/ex/clippy-test-run/sources/stable/gh/josler/promptly-rs/Cargo.toml
[INFO] started frobbing josler/promptly-rs
[INFO] finished frobbing josler/promptly-rs
[INFO] frobbed toml for josler/promptly-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/josler/promptly-rs/Cargo.toml
[INFO] crate josler/promptly-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting josler/promptly-rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/josler/promptly-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 30a226fdc48f08ef45d58cd2992bbb0575552eba1c95dc75d1419700edbc9705
[INFO] running `"docker" "start" "-a" "30a226fdc48f08ef45d58cd2992bbb0575552eba1c95dc75d1419700edbc9705"`
[INFO] [stderr]     Checking termion v1.5.1
[INFO] [stderr]     Checking dirs v1.0.4
[INFO] [stderr]     Checking backtrace-sys v0.1.24
[INFO] [stderr]    Compiling syn v0.15.13
[INFO] [stderr]     Checking backtrace v0.3.9
[INFO] [stderr]     Checking failure v0.1.2
[INFO] [stderr]    Compiling serde_derive v1.0.80
[INFO] [stderr]     Checking promptly v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cli.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 | /         return match res {
[INFO] [stderr] 25 | |             Err(err) => Err(err),
[INFO] [stderr] 26 | |             Ok(val) => {
[INFO] [stderr] 27 | |                 let yes_values: [String; 3] = ["yes".to_string(), "y".into(), "1".into()];
[INFO] [stderr] ...  |
[INFO] [stderr] 33 | |             }
[INFO] [stderr] 34 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 24 |         match res {
[INFO] [stderr] 25 |             Err(err) => Err(err),
[INFO] [stderr] 26 |             Ok(val) => {
[INFO] [stderr] 27 |                 let yes_values: [String; 3] = ["yes".to_string(), "y".into(), "1".into()];
[INFO] [stderr] 28 |                 if yes_values.contains(&val) {
[INFO] [stderr] 29 |                     Ok(true)
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/cli.rs:56:9
[INFO] [stderr]    |
[INFO] [stderr] 56 |         lower
[INFO] [stderr]    |         ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/cli.rs:55:21
[INFO] [stderr]    |
[INFO] [stderr] 55 |         let lower = trimmed.to_lowercase();
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/cli.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 | /         return match res {
[INFO] [stderr] 25 | |             Err(err) => Err(err),
[INFO] [stderr] 26 | |             Ok(val) => {
[INFO] [stderr] 27 | |                 let yes_values: [String; 3] = ["yes".to_string(), "y".into(), "1".into()];
[INFO] [stderr] ...  |
[INFO] [stderr] 33 | |             }
[INFO] [stderr] 34 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 24 |         match res {
[INFO] [stderr] 25 |             Err(err) => Err(err),
[INFO] [stderr] 26 |             Ok(val) => {
[INFO] [stderr] 27 |                 let yes_values: [String; 3] = ["yes".to_string(), "y".into(), "1".into()];
[INFO] [stderr] 28 |                 if yes_values.contains(&val) {
[INFO] [stderr] 29 |                     Ok(true)
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/cli.rs:56:9
[INFO] [stderr]    |
[INFO] [stderr] 56 |         lower
[INFO] [stderr]    |         ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/cli.rs:55:21
[INFO] [stderr]    |
[INFO] [stderr] 55 |         let lower = trimmed.to_lowercase();
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/cli.rs:60:25
[INFO] [stderr]    |
[INFO] [stderr] 60 |           let formatted = match default.is_empty() {
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 61 | |             true => format!("{}\n", text),
[INFO] [stderr] 62 | |             false => format!("{} |{}|\n", text, default),
[INFO] [stderr] 63 | |         };
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if default.is_empty() { format!("{}\n", text) } else { format!("{} |{}|\n", text, default) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/cli.rs:60:25
[INFO] [stderr]    |
[INFO] [stderr] 60 |           let formatted = match default.is_empty() {
[INFO] [stderr]    |  _________________________^
[INFO] [stderr] 61 | |             true => format!("{}\n", text),
[INFO] [stderr] 62 | |             false => format!("{} |{}|\n", text, default),
[INFO] [stderr] 63 | |         };
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if default.is_empty() { format!("{}\n", text) } else { format!("{} |{}|\n", text, default) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/question.rs:100:10
[INFO] [stderr]     |
[INFO] [stderr] 100 |         .or_insert("pr description".to_string())
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| "pr description".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/question.rs:100:10
[INFO] [stderr]     |
[INFO] [stderr] 100 |         .or_insert("pr description".to_string())
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| "pr description".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/main.rs:68:27
[INFO] [stderr]    |
[INFO] [stderr] 68 | fn while_question_success<'a>(questions: Vec<&Question>) {
[INFO] [stderr]    |                           ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:71:9
[INFO] [stderr]    |
[INFO] [stderr] 71 | /         match question.ask(&mut context) {
[INFO] [stderr] 72 | |             Err(_) => return,
[INFO] [stderr] 73 | |             Ok(_) => {}
[INFO] [stderr] 74 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Err(_) = question.ask(&mut context) { return }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/main.rs:68:27
[INFO] [stderr]    |
[INFO] [stderr] 68 | fn while_question_success<'a>(questions: Vec<&Question>) {
[INFO] [stderr]    |                           ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:71:9
[INFO] [stderr]    |
[INFO] [stderr] 71 | /         match question.ask(&mut context) {
[INFO] [stderr] 72 | |             Err(_) => return,
[INFO] [stderr] 73 | |             Ok(_) => {}
[INFO] [stderr] 74 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Err(_) = question.ask(&mut context) { return }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 22.79s
[INFO] running `"docker" "inspect" "30a226fdc48f08ef45d58cd2992bbb0575552eba1c95dc75d1419700edbc9705"`
[INFO] running `"docker" "rm" "-f" "30a226fdc48f08ef45d58cd2992bbb0575552eba1c95dc75d1419700edbc9705"`
[INFO] [stdout] 30a226fdc48f08ef45d58cd2992bbb0575552eba1c95dc75d1419700edbc9705