[INFO] updating cached repository joshleeb/mercury [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/joshleeb/mercury [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/joshleeb/mercury" "work/ex/clippy-test-run/sources/stable/gh/joshleeb/mercury"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/joshleeb/mercury'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/joshleeb/mercury" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joshleeb/mercury"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joshleeb/mercury'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0c0d6b0ec374291d8b17c0fe9fa8c6ec4a984352 [INFO] sha for GitHub repo joshleeb/mercury: 0c0d6b0ec374291d8b17c0fe9fa8c6ec4a984352 [INFO] validating manifest of joshleeb/mercury on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of joshleeb/mercury on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing joshleeb/mercury [INFO] finished frobbing joshleeb/mercury [INFO] frobbed toml for joshleeb/mercury written to work/ex/clippy-test-run/sources/stable/gh/joshleeb/mercury/Cargo.toml [INFO] started frobbing joshleeb/mercury [INFO] finished frobbing joshleeb/mercury [INFO] frobbed toml for joshleeb/mercury written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joshleeb/mercury/Cargo.toml [INFO] crate joshleeb/mercury has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting joshleeb/mercury against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/joshleeb/mercury:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f1a0f734446a171f2de6fb766aff5bb44c7b321a21b9af5de28a685d4350851e [INFO] running `"docker" "start" "-a" "f1a0f734446a171f2de6fb766aff5bb44c7b321a21b9af5de28a685d4350851e"` [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Checking openssl-sys v0.9.26 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking openssl v0.9.24 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking mqtt-protocol v0.3.1 [INFO] [stderr] Checking rumqtt v0.10.1 [INFO] [stderr] Checking mercury v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client.rs:5:19 [INFO] [stderr] | [INFO] [stderr] 5 | const CLIENT_ID: &'static str = "SOME_ID"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client.rs:6:21 [INFO] [stderr] | [INFO] [stderr] 6 | const BROKER_ADDR: &'static str = "test.mosquitto.org:1883"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | const CHANNEL: &'static str = "hello/rustclub"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client.rs:5:19 [INFO] [stderr] | [INFO] [stderr] 5 | const CLIENT_ID: &'static str = "SOME_ID"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client.rs:6:21 [INFO] [stderr] | [INFO] [stderr] 6 | const BROKER_ADDR: &'static str = "test.mosquitto.org:1883"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | const CHANNEL: &'static str = "hello/rustclub"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: method is never used: `publish` [INFO] [stderr] --> src/client.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn publish(&mut self, path: &str, quality: QoS, message: Vec) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: empty `loop {}` detected. You may want to either use `panic!()` or add `std::thread::sleep(..);` to the loop body. [INFO] [stderr] --> src/main.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | loop {} [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::empty_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop [INFO] [stderr] [INFO] [stderr] warning: method is never used: `publish` [INFO] [stderr] --> src/client.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn publish(&mut self, path: &str, quality: QoS, message: Vec) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: empty `loop {}` detected. You may want to either use `panic!()` or add `std::thread::sleep(..);` to the loop body. [INFO] [stderr] --> src/main.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | loop {} [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::empty_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.14s [INFO] running `"docker" "inspect" "f1a0f734446a171f2de6fb766aff5bb44c7b321a21b9af5de28a685d4350851e"` [INFO] running `"docker" "rm" "-f" "f1a0f734446a171f2de6fb766aff5bb44c7b321a21b9af5de28a685d4350851e"` [INFO] [stdout] f1a0f734446a171f2de6fb766aff5bb44c7b321a21b9af5de28a685d4350851e