[INFO] updating cached repository joshLong145/rust_jump [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/joshLong145/rust_jump [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/joshLong145/rust_jump" "work/ex/clippy-test-run/sources/stable/gh/joshLong145/rust_jump"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/joshLong145/rust_jump'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/joshLong145/rust_jump" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joshLong145/rust_jump"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joshLong145/rust_jump'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 043ffdc63310e4ca022250888d6dc5946004dd33 [INFO] sha for GitHub repo joshLong145/rust_jump: 043ffdc63310e4ca022250888d6dc5946004dd33 [INFO] validating manifest of joshLong145/rust_jump on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of joshLong145/rust_jump on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing joshLong145/rust_jump [INFO] finished frobbing joshLong145/rust_jump [INFO] frobbed toml for joshLong145/rust_jump written to work/ex/clippy-test-run/sources/stable/gh/joshLong145/rust_jump/Cargo.toml [INFO] started frobbing joshLong145/rust_jump [INFO] finished frobbing joshLong145/rust_jump [INFO] frobbed toml for joshLong145/rust_jump written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/joshLong145/rust_jump/Cargo.toml [INFO] crate joshLong145/rust_jump has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting joshLong145/rust_jump against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/joshLong145/rust_jump:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 791bbce90f8b4628601ff7d94934250aaf1b28e2cf4b042e1be3c02837769544 [INFO] running `"docker" "start" "-a" "791bbce90f8b4628601ff7d94934250aaf1b28e2cf4b042e1be3c02837769544"` [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking chrome-game v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: the loop variable `i` is only used to index `_enemies`. [INFO] [stderr] --> src/main.rs:53:18 [INFO] [stderr] | [INFO] [stderr] 53 | for i in 0.._enemies.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 53 | for in &mut _enemies{ [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `_stars`. [INFO] [stderr] --> src/main.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | for i in 0.._stars.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 63 | for in &mut _stars{ [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:79:26 [INFO] [stderr] | [INFO] [stderr] 79 | }else if t.as_secs() <= 0 && _enemies.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using t.as_secs() == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:79:46 [INFO] [stderr] | [INFO] [stderr] 79 | }else if t.as_secs() <= 0 && _enemies.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `_enemies.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:92:55 [INFO] [stderr] | [INFO] [stderr] 92 | fn drawenviorment(_x: &mut u16, _y: &mut u16, _stars: &Vec<(u16, u16)>, _terminal_coords: &Result<(u16, u16), Error>){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[(u16, u16)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `_stars`. [INFO] [stderr] --> src/main.rs:105:14 [INFO] [stderr] | [INFO] [stderr] 105 | for i in 0.._stars.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 105 | for in &_stars{ [INFO] [stderr] | ^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:111:25 [INFO] [stderr] | [INFO] [stderr] 111 | fn drawenemes(_enemies: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Obj]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: The function/method `drawplayer` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:219:19 [INFO] [stderr] | [INFO] [stderr] 219 | drawplayer(&mut player); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `drawenviorment` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:221:55 [INFO] [stderr] | [INFO] [stderr] 221 | drawenviorment(&mut env_x, &mut env_y, &stars, &mut terminal_dimension); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `chrome-game`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the loop variable `i` is only used to index `_enemies`. [INFO] [stderr] --> src/main.rs:53:18 [INFO] [stderr] | [INFO] [stderr] 53 | for i in 0.._enemies.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 53 | for in &mut _enemies{ [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `_stars`. [INFO] [stderr] --> src/main.rs:63:18 [INFO] [stderr] | [INFO] [stderr] 63 | for i in 0.._stars.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 63 | for in &mut _stars{ [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:79:26 [INFO] [stderr] | [INFO] [stderr] 79 | }else if t.as_secs() <= 0 && _enemies.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using t.as_secs() == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:79:46 [INFO] [stderr] | [INFO] [stderr] 79 | }else if t.as_secs() <= 0 && _enemies.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `_enemies.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:92:55 [INFO] [stderr] | [INFO] [stderr] 92 | fn drawenviorment(_x: &mut u16, _y: &mut u16, _stars: &Vec<(u16, u16)>, _terminal_coords: &Result<(u16, u16), Error>){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[(u16, u16)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `_stars`. [INFO] [stderr] --> src/main.rs:105:14 [INFO] [stderr] | [INFO] [stderr] 105 | for i in 0.._stars.len(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 105 | for in &_stars{ [INFO] [stderr] | ^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:111:25 [INFO] [stderr] | [INFO] [stderr] 111 | fn drawenemes(_enemies: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Obj]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: The function/method `drawplayer` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:219:19 [INFO] [stderr] | [INFO] [stderr] 219 | drawplayer(&mut player); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `drawenviorment` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:221:55 [INFO] [stderr] | [INFO] [stderr] 221 | drawenviorment(&mut env_x, &mut env_y, &stars, &mut terminal_dimension); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `chrome-game`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "791bbce90f8b4628601ff7d94934250aaf1b28e2cf4b042e1be3c02837769544"` [INFO] running `"docker" "rm" "-f" "791bbce90f8b4628601ff7d94934250aaf1b28e2cf4b042e1be3c02837769544"` [INFO] [stdout] 791bbce90f8b4628601ff7d94934250aaf1b28e2cf4b042e1be3c02837769544