[INFO] updating cached repository josephscade/ffind [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/josephscade/ffind [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/josephscade/ffind" "work/ex/clippy-test-run/sources/stable/gh/josephscade/ffind"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/josephscade/ffind'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/josephscade/ffind" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/josephscade/ffind"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/josephscade/ffind'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ca192d0e504a49fc33094f72c88cb43281842582 [INFO] sha for GitHub repo josephscade/ffind: ca192d0e504a49fc33094f72c88cb43281842582 [INFO] validating manifest of josephscade/ffind on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of josephscade/ffind on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing josephscade/ffind [INFO] finished frobbing josephscade/ffind [INFO] frobbed toml for josephscade/ffind written to work/ex/clippy-test-run/sources/stable/gh/josephscade/ffind/Cargo.toml [INFO] started frobbing josephscade/ffind [INFO] finished frobbing josephscade/ffind [INFO] frobbed toml for josephscade/ffind written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/josephscade/ffind/Cargo.toml [INFO] crate josephscade/ffind has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting josephscade/ffind against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/josephscade/ffind:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 79c6b7648f4861ed46e5adf57f5bb8c8db2ede0697f976965d8d65f8d22ddf8a [INFO] running `"docker" "start" "-a" "79c6b7648f4861ed46e5adf57f5bb8c8db2ede0697f976965d8d65f8d22ddf8a"` [INFO] [stderr] Checking clap v2.27.1 [INFO] [stderr] Checking ffind v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/dir_walk.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | / if entry.is_dir() { [INFO] [stderr] 44 | | if !entry.is_hidden() || args.hidden_directories { [INFO] [stderr] 45 | | list_dir(entry.root.as_path(), &args); [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 43 | if entry.is_dir() && (!entry.is_hidden() || args.hidden_directories) { [INFO] [stderr] 44 | list_dir(entry.root.as_path(), &args); [INFO] [stderr] 45 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/dir_walk.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | / if entry.is_dir() { [INFO] [stderr] 44 | | if !entry.is_hidden() || args.hidden_directories { [INFO] [stderr] 45 | | list_dir(entry.root.as_path(), &args); [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 43 | if entry.is_dir() && (!entry.is_hidden() || args.hidden_directories) { [INFO] [stderr] 44 | list_dir(entry.root.as_path(), &args); [INFO] [stderr] 45 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/dir_walk.rs:54:50 [INFO] [stderr] | [INFO] [stderr] 54 | let printed_string: String = match args.color { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 55 | | false => entry.get_path(), [INFO] [stderr] 56 | | true => String::from( [INFO] [stderr] 57 | | args.find_regex [INFO] [stderr] 58 | | .replace_all(entry.get_path().as_str(), "\x1B[31m$match\x1B[0m"), [INFO] [stderr] 59 | | ), [INFO] [stderr] 60 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 54 | let printed_string: String = if args.color { String::from( [INFO] [stderr] 55 | args.find_regex [INFO] [stderr] 56 | .replace_all(entry.get_path().as_str(), "\x1B[31m$match\x1B[0m"), [INFO] [stderr] 57 | ) } else { entry.get_path() }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/dir_walk.rs:54:50 [INFO] [stderr] | [INFO] [stderr] 54 | let printed_string: String = match args.color { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 55 | | false => entry.get_path(), [INFO] [stderr] 56 | | true => String::from( [INFO] [stderr] 57 | | args.find_regex [INFO] [stderr] 58 | | .replace_all(entry.get_path().as_str(), "\x1B[31m$match\x1B[0m"), [INFO] [stderr] 59 | | ), [INFO] [stderr] 60 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 54 | let printed_string: String = if args.color { String::from( [INFO] [stderr] 55 | args.find_regex [INFO] [stderr] 56 | .replace_all(entry.get_path().as_str(), "\x1B[31m$match\x1B[0m"), [INFO] [stderr] 57 | ) } else { entry.get_path() }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.21s [INFO] running `"docker" "inspect" "79c6b7648f4861ed46e5adf57f5bb8c8db2ede0697f976965d8d65f8d22ddf8a"` [INFO] running `"docker" "rm" "-f" "79c6b7648f4861ed46e5adf57f5bb8c8db2ede0697f976965d8d65f8d22ddf8a"` [INFO] [stdout] 79c6b7648f4861ed46e5adf57f5bb8c8db2ede0697f976965d8d65f8d22ddf8a