[INFO] updating cached repository josephglanville/wobot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/josephglanville/wobot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/josephglanville/wobot" "work/ex/clippy-test-run/sources/stable/gh/josephglanville/wobot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/josephglanville/wobot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/josephglanville/wobot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/josephglanville/wobot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/josephglanville/wobot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 23a7d8775bc57c7de2831be834056825fa11e9cf [INFO] sha for GitHub repo josephglanville/wobot: 23a7d8775bc57c7de2831be834056825fa11e9cf [INFO] validating manifest of josephglanville/wobot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of josephglanville/wobot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing josephglanville/wobot [INFO] finished frobbing josephglanville/wobot [INFO] frobbed toml for josephglanville/wobot written to work/ex/clippy-test-run/sources/stable/gh/josephglanville/wobot/Cargo.toml [INFO] started frobbing josephglanville/wobot [INFO] finished frobbing josephglanville/wobot [INFO] frobbed toml for josephglanville/wobot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/josephglanville/wobot/Cargo.toml [INFO] crate josephglanville/wobot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting josephglanville/wobot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/josephglanville/wobot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5313e0fde2c3189f0c335cd84fd37f65a86dfe971474e78d94da4a0e67775caf [INFO] running `"docker" "start" "-a" "5313e0fde2c3189f0c335cd84fd37f65a86dfe971474e78d94da4a0e67775caf"` [INFO] [stderr] Checking wobot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/robot.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | grid: grid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | y: y [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction.rs:38:43 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(Instruction::Place(Place { x: x, y: y, dir: dir })) [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction.rs:38:49 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(Instruction::Place(Place { x: x, y: y, dir: dir })) [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction.rs:38:55 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(Instruction::Place(Place { x: x, y: y, dir: dir })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/robot.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | grid: grid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | y: y [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction.rs:38:43 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(Instruction::Place(Place { x: x, y: y, dir: dir })) [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction.rs:38:49 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(Instruction::Place(Place { x: x, y: y, dir: dir })) [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction.rs:38:55 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(Instruction::Place(Place { x: x, y: y, dir: dir })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/grid.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/grid.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/robot.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | self.x = self.x + x; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.x += x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/robot.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | self.y = self.y + y; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.y += y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/instruction.rs:18:36 [INFO] [stderr] | [INFO] [stderr] 18 | let v: Vec<&str> = input.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/robot.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | self.x = self.x + x; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.x += x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/robot.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | self.y = self.y + y; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.y += y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/instruction.rs:18:36 [INFO] [stderr] | [INFO] [stderr] 18 | let v: Vec<&str> = input.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.44s [INFO] running `"docker" "inspect" "5313e0fde2c3189f0c335cd84fd37f65a86dfe971474e78d94da4a0e67775caf"` [INFO] running `"docker" "rm" "-f" "5313e0fde2c3189f0c335cd84fd37f65a86dfe971474e78d94da4a0e67775caf"` [INFO] [stdout] 5313e0fde2c3189f0c335cd84fd37f65a86dfe971474e78d94da4a0e67775caf