[INFO] updating cached repository jorissoris/brainfuck-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jorissoris/brainfuck-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jorissoris/brainfuck-rust" "work/ex/clippy-test-run/sources/stable/gh/jorissoris/brainfuck-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jorissoris/brainfuck-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jorissoris/brainfuck-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jorissoris/brainfuck-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jorissoris/brainfuck-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3a7f6458bb6aed96aa86bb31ee56fea4d8e9a28f [INFO] sha for GitHub repo jorissoris/brainfuck-rust: 3a7f6458bb6aed96aa86bb31ee56fea4d8e9a28f [INFO] validating manifest of jorissoris/brainfuck-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jorissoris/brainfuck-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jorissoris/brainfuck-rust [INFO] finished frobbing jorissoris/brainfuck-rust [INFO] frobbed toml for jorissoris/brainfuck-rust written to work/ex/clippy-test-run/sources/stable/gh/jorissoris/brainfuck-rust/Cargo.toml [INFO] started frobbing jorissoris/brainfuck-rust [INFO] finished frobbing jorissoris/brainfuck-rust [INFO] frobbed toml for jorissoris/brainfuck-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jorissoris/brainfuck-rust/Cargo.toml [INFO] crate jorissoris/brainfuck-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jorissoris/brainfuck-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jorissoris/brainfuck-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 73c552aa33234aa56c4946ccd48f88a988f65f37cf181867697156fc88c23719 [INFO] running `"docker" "start" "-a" "73c552aa33234aa56c4946ccd48f88a988f65f37cf181867697156fc88c23719"` [INFO] [stderr] Checking brainfuck_rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:8:38 [INFO] [stderr] | [INFO] [stderr] 8 | let mut array: Vec = vec![0; 1000000]; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:8:38 [INFO] [stderr] | [INFO] [stderr] 8 | let mut array: Vec = vec![0; 1000000]; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `input` [INFO] [stderr] --> src/main.rs:52:30 [INFO] [stderr] | [INFO] [stderr] 52 | for i in (index + 1)..array.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 52 | for (i, ) in input.iter().enumerate().take(array.len()).skip((index + 1)) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `input` [INFO] [stderr] --> src/main.rs:52:30 [INFO] [stderr] | [INFO] [stderr] 52 | for i in (index + 1)..array.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 52 | for (i, ) in input.iter().enumerate().take(array.len()).skip((index + 1)) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.73s [INFO] running `"docker" "inspect" "73c552aa33234aa56c4946ccd48f88a988f65f37cf181867697156fc88c23719"` [INFO] running `"docker" "rm" "-f" "73c552aa33234aa56c4946ccd48f88a988f65f37cf181867697156fc88c23719"` [INFO] [stdout] 73c552aa33234aa56c4946ccd48f88a988f65f37cf181867697156fc88c23719