[INFO] updating cached repository jorge-marques/hacker-rank-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jorge-marques/hacker-rank-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jorge-marques/hacker-rank-rs" "work/ex/clippy-test-run/sources/stable/gh/jorge-marques/hacker-rank-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jorge-marques/hacker-rank-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jorge-marques/hacker-rank-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jorge-marques/hacker-rank-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jorge-marques/hacker-rank-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] f7a9ec21aa6349afd08595901ecfd4da8f7acc76
[INFO] sha for GitHub repo jorge-marques/hacker-rank-rs: f7a9ec21aa6349afd08595901ecfd4da8f7acc76
[INFO] validating manifest of jorge-marques/hacker-rank-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jorge-marques/hacker-rank-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jorge-marques/hacker-rank-rs
[INFO] finished frobbing jorge-marques/hacker-rank-rs
[INFO] frobbed toml for jorge-marques/hacker-rank-rs written to work/ex/clippy-test-run/sources/stable/gh/jorge-marques/hacker-rank-rs/Cargo.toml
[INFO] started frobbing jorge-marques/hacker-rank-rs
[INFO] finished frobbing jorge-marques/hacker-rank-rs
[INFO] frobbed toml for jorge-marques/hacker-rank-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jorge-marques/hacker-rank-rs/Cargo.toml
[INFO] crate jorge-marques/hacker-rank-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jorge-marques/hacker-rank-rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jorge-marques/hacker-rank-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9a187026fc1a12943fe79e1d7161a3369b827534be659d37553d8eedfef1f920
[INFO] running `"docker" "start" "-a" "9a187026fc1a12943fe79e1d7161a3369b827534be659d37553d8eedfef1f920"`
[INFO] [stderr]     Checking hacker-rank v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:68:21
[INFO] [stderr]    |
[INFO] [stderr] 68 |                     return Person { age };
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Person { age }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:105:17
[INFO] [stderr]     |
[INFO] [stderr] 105 |                 return input;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^ help: remove `return` as shown: `input`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:119:17
[INFO] [stderr]     |
[INFO] [stderr] 119 |                 return input;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^ help: remove `return` as shown: `input`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:305:21
[INFO] [stderr]     |
[INFO] [stderr] 305 |                     return input;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^ help: remove `return` as shown: `input`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:322:21
[INFO] [stderr]     |
[INFO] [stderr] 322 |                     return res;
[INFO] [stderr]     |                     ^^^^^^^^^^^ help: remove `return` as shown: `res`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:330:21
[INFO] [stderr]     |
[INFO] [stderr] 330 |                     return input;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^ help: remove `return` as shown: `input`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:366:21
[INFO] [stderr]     |
[INFO] [stderr] 366 |                     return input;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^ help: remove `return` as shown: `input`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:401:17
[INFO] [stderr]     |
[INFO] [stderr] 401 |                 return from + of - (from % of);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `from + of - (from % of)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:535:17
[INFO] [stderr]     |
[INFO] [stderr] 535 |                 return input;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^ help: remove `return` as shown: `input`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:68:21
[INFO] [stderr]    |
[INFO] [stderr] 68 |                     return Person { age };
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Person { age }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:105:17
[INFO] [stderr]     |
[INFO] [stderr] 105 |                 return input;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^ help: remove `return` as shown: `input`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:119:17
[INFO] [stderr]     |
[INFO] [stderr] 119 |                 return input;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^ help: remove `return` as shown: `input`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:305:21
[INFO] [stderr]     |
[INFO] [stderr] 305 |                     return input;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^ help: remove `return` as shown: `input`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:322:21
[INFO] [stderr]     |
[INFO] [stderr] 322 |                     return res;
[INFO] [stderr]     |                     ^^^^^^^^^^^ help: remove `return` as shown: `res`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:330:21
[INFO] [stderr]     |
[INFO] [stderr] 330 |                     return input;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^ help: remove `return` as shown: `input`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:366:21
[INFO] [stderr]     |
[INFO] [stderr] 366 |                     return input;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^ help: remove `return` as shown: `input`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:401:17
[INFO] [stderr]     |
[INFO] [stderr] 401 |                 return from + of - (from % of);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `from + of - (from % of)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:535:17
[INFO] [stderr]     |
[INFO] [stderr] 535 |                 return input;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^ help: remove `return` as shown: `input`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:176:42
[INFO] [stderr]     |
[INFO] [stderr] 176 |                 fn process_argument(arg: &String) -> [i32; 3] {
[INFO] [stderr]     |                                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/main.rs:274:40
[INFO] [stderr]     |
[INFO] [stderr] 274 |                     println!("{:>1$}", (0..(i + 1)).map(|_| "#").collect::<String>(), size);
[INFO] [stderr]     |                                        ^^^^^^^^^^^^ help: use: `(0..=i)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `scores`.
[INFO] [stderr]    --> src/main.rs:500:26
[INFO] [stderr]     |
[INFO] [stderr] 500 |                 for i in 1..scores.len() {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 500 |                 for <item> in scores.iter().skip(1) {
[INFO] [stderr]     |                     ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:176:42
[INFO] [stderr]     |
[INFO] [stderr] 176 |                 fn process_argument(arg: &String) -> [i32; 3] {
[INFO] [stderr]     |                                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/main.rs:274:40
[INFO] [stderr]     |
[INFO] [stderr] 274 |                     println!("{:>1$}", (0..(i + 1)).map(|_| "#").collect::<String>(), size);
[INFO] [stderr]     |                                        ^^^^^^^^^^^^ help: use: `(0..=i)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `scores`.
[INFO] [stderr]    --> src/main.rs:500:26
[INFO] [stderr]     |
[INFO] [stderr] 500 |                 for i in 1..scores.len() {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 500 |                 for <item> in scores.iter().skip(1) {
[INFO] [stderr]     |                     ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.97s
[INFO] running `"docker" "inspect" "9a187026fc1a12943fe79e1d7161a3369b827534be659d37553d8eedfef1f920"`
[INFO] running `"docker" "rm" "-f" "9a187026fc1a12943fe79e1d7161a3369b827534be659d37553d8eedfef1f920"`
[INFO] [stdout] 9a187026fc1a12943fe79e1d7161a3369b827534be659d37553d8eedfef1f920