[INFO] updating cached repository jorenvo/git-merge-xml [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jorenvo/git-merge-xml [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jorenvo/git-merge-xml" "work/ex/clippy-test-run/sources/stable/gh/jorenvo/git-merge-xml"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jorenvo/git-merge-xml'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jorenvo/git-merge-xml" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jorenvo/git-merge-xml"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jorenvo/git-merge-xml'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 161cdff306cb13592b28cc1ab6394649d2fa69fa [INFO] sha for GitHub repo jorenvo/git-merge-xml: 161cdff306cb13592b28cc1ab6394649d2fa69fa [INFO] validating manifest of jorenvo/git-merge-xml on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jorenvo/git-merge-xml on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jorenvo/git-merge-xml [INFO] finished frobbing jorenvo/git-merge-xml [INFO] frobbed toml for jorenvo/git-merge-xml written to work/ex/clippy-test-run/sources/stable/gh/jorenvo/git-merge-xml/Cargo.toml [INFO] started frobbing jorenvo/git-merge-xml [INFO] finished frobbing jorenvo/git-merge-xml [INFO] frobbed toml for jorenvo/git-merge-xml written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jorenvo/git-merge-xml/Cargo.toml [INFO] crate jorenvo/git-merge-xml has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jorenvo/git-merge-xml against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jorenvo/git-merge-xml:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5abffe2bf9cdf47038dc87a2f8ba05cd04c73fe97f8de331720be3d33ac7f1ed [INFO] running `"docker" "start" "-a" "5abffe2bf9cdf47038dc87a2f8ba05cd04c73fe97f8de331720be3d33ac7f1ed"` [INFO] [stderr] Checking git-merge-xml v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / String::from(format!( [INFO] [stderr] 9 | | "{} [INFO] [stderr] 10 | | {} [INFO] [stderr] 11 | | {} [INFO] [stderr] ... | [INFO] [stderr] 14 | | CONFLICT_MARKER_OPEN, a, CONFLICT_MARKER_MID, b, CONFLICT_MARKER_CLOSE [INFO] [stderr] 15 | | )) [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `String::from()` [INFO] [stderr] | [INFO] [stderr] 8 | format!( [INFO] [stderr] 9 | "{} [INFO] [stderr] 10 | {} [INFO] [stderr] 11 | {} [INFO] [stderr] 12 | {} [INFO] [stderr] 13 | {}", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:43:41 [INFO] [stderr] | [INFO] [stderr] 43 | for (i, _) in content.match_indices("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:44:43 [INFO] [stderr] | [INFO] [stderr] 44 | result.push(String::from(&content[start..i + 1])); [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `start..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / String::from(format!( [INFO] [stderr] 9 | | "{} [INFO] [stderr] 10 | | {} [INFO] [stderr] 11 | | {} [INFO] [stderr] ... | [INFO] [stderr] 14 | | CONFLICT_MARKER_OPEN, a, CONFLICT_MARKER_MID, b, CONFLICT_MARKER_CLOSE [INFO] [stderr] 15 | | )) [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `String::from()` [INFO] [stderr] | [INFO] [stderr] 8 | format!( [INFO] [stderr] 9 | "{} [INFO] [stderr] 10 | {} [INFO] [stderr] 11 | {} [INFO] [stderr] 12 | {} [INFO] [stderr] 13 | {}", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:43:41 [INFO] [stderr] | [INFO] [stderr] 43 | for (i, _) in content.match_indices("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:44:43 [INFO] [stderr] | [INFO] [stderr] 44 | result.push(String::from(&content[start..i + 1])); [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `start..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/git-merge-xml.rs:35:20 [INFO] [stderr] | [INFO] [stderr] 35 | let content = &format!("\n\n\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"\n\n\n".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/git-merge-xml.rs:41:19 [INFO] [stderr] | [INFO] [stderr] 41 | let parent = &format!("pangolin\npenguin\nelephant"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"pangolin\npenguin\nelephant".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/git-merge-xml.rs:42:14 [INFO] [stderr] | [INFO] [stderr] 42 | let a = &format!("pangolin\npolar bear\nelephant"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"pangolin\npolar bear\nelephant".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/git-merge-xml.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | let b = &format!("pangolin\npenguin\nelephant"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"pangolin\npenguin\nelephant".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/git-merge-xml.rs:49:19 [INFO] [stderr] | [INFO] [stderr] 49 | let parent = &format!("pangolin\npenguin\nelephant"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"pangolin\npenguin\nelephant".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/git-merge-xml.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | let a = &format!("pangolin\npolar bear\nelephant"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"pangolin\npolar bear\nelephant".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/git-merge-xml.rs:51:14 [INFO] [stderr] | [INFO] [stderr] 51 | let b = &format!("pangolin\npenguin\nparrot"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"pangolin\npenguin\nparrot".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/git-merge-xml.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | format!("pangolin\npolar bear\nparrot") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"pangolin\npolar bear\nparrot".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/git-merge-xml.rs:60:19 [INFO] [stderr] | [INFO] [stderr] 60 | let parent = &format!("pangolin\npenguin\nelephant"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"pangolin\npenguin\nelephant".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/git-merge-xml.rs:61:14 [INFO] [stderr] | [INFO] [stderr] 61 | let a = &format!("pangolin\npolar bear\nelephant"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"pangolin\npolar bear\nelephant".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/git-merge-xml.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | let b = &format!("pangolin\nquokka\nelephant"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"pangolin\nquokka\nelephant".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/git-merge-xml.rs:74:19 [INFO] [stderr] | [INFO] [stderr] 74 | let parent = &format!("bear\nbunny"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bear\nbunny".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/git-merge-xml.rs:75:14 [INFO] [stderr] | [INFO] [stderr] 75 | let a = &format!("bear"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bear".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/git-merge-xml.rs:82:19 [INFO] [stderr] | [INFO] [stderr] 82 | let parent = &format!("bear\nbunny\nhedgehog"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bear\nbunny\nhedgehog".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/git-merge-xml.rs:83:14 [INFO] [stderr] | [INFO] [stderr] 83 | let a = &format!("bear\nhedgehog"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bear\nhedgehog".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.64s [INFO] running `"docker" "inspect" "5abffe2bf9cdf47038dc87a2f8ba05cd04c73fe97f8de331720be3d33ac7f1ed"` [INFO] running `"docker" "rm" "-f" "5abffe2bf9cdf47038dc87a2f8ba05cd04c73fe97f8de331720be3d33ac7f1ed"` [INFO] [stdout] 5abffe2bf9cdf47038dc87a2f8ba05cd04c73fe97f8de331720be3d33ac7f1ed