[INFO] updating cached repository jonny7/rust-ownership
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/jonny7/rust-ownership
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/jonny7/rust-ownership" "work/ex/clippy-test-run/sources/stable/gh/jonny7/rust-ownership"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jonny7/rust-ownership'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/jonny7/rust-ownership" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonny7/rust-ownership"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonny7/rust-ownership'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] f54265e8b091db866bad7abc334d76d1d70787f0
[INFO] sha for GitHub repo jonny7/rust-ownership: f54265e8b091db866bad7abc334d76d1d70787f0
[INFO] validating manifest of jonny7/rust-ownership on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of jonny7/rust-ownership on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing jonny7/rust-ownership
[INFO] finished frobbing jonny7/rust-ownership
[INFO] frobbed toml for jonny7/rust-ownership written to work/ex/clippy-test-run/sources/stable/gh/jonny7/rust-ownership/Cargo.toml
[INFO] started frobbing jonny7/rust-ownership
[INFO] finished frobbing jonny7/rust-ownership
[INFO] frobbed toml for jonny7/rust-ownership written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonny7/rust-ownership/Cargo.toml
[INFO] crate jonny7/rust-ownership has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting jonny7/rust-ownership against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jonny7/rust-ownership:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 1adf5b0d615407d41945560bca3121766d916432091e0ef7a436ebee9461783b
[INFO] running `"docker" "start" "-a" "1adf5b0d615407d41945560bca3121766d916432091e0ef7a436ebee9461783b"`
[INFO] [stderr]     Checking ownership v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 |     some_string                              // some_string is returned and
[INFO] [stderr]    |     ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:42:23
[INFO] [stderr]    |
[INFO] [stderr] 42 |     let some_string = String::from("hello"); // some_string comes into scope.
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `s1`
[INFO] [stderr]   --> src/main.rs:27:9
[INFO] [stderr]    |
[INFO] [stderr] 27 |     let s1 = gives_ownership();         // gives_ownership moves its return
[INFO] [stderr]    |         ^^ help: consider using `_s1` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `s3`
[INFO] [stderr]   --> src/main.rs:32:9
[INFO] [stderr]    |
[INFO] [stderr] 32 |     let s3 = takes_and_gives_back(s2);  // s2 is moved into
[INFO] [stderr]    |         ^^ help: consider using `_s3` instead
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 |     some_string                              // some_string is returned and
[INFO] [stderr]    |     ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:42:23
[INFO] [stderr]    |
[INFO] [stderr] 42 |     let some_string = String::from("hello"); // some_string comes into scope.
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `s1`
[INFO] [stderr]   --> src/main.rs:27:9
[INFO] [stderr]    |
[INFO] [stderr] 27 |     let s1 = gives_ownership();         // gives_ownership moves its return
[INFO] [stderr]    |         ^^ help: consider using `_s1` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `s3`
[INFO] [stderr]   --> src/main.rs:32:9
[INFO] [stderr]    |
[INFO] [stderr] 32 |     let s3 = takes_and_gives_back(s2);  // s2 is moved into
[INFO] [stderr]    |         ^^ help: consider using `_s3` instead
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.93s
[INFO] running `"docker" "inspect" "1adf5b0d615407d41945560bca3121766d916432091e0ef7a436ebee9461783b"`
[INFO] running `"docker" "rm" "-f" "1adf5b0d615407d41945560bca3121766d916432091e0ef7a436ebee9461783b"`
[INFO] [stdout] 1adf5b0d615407d41945560bca3121766d916432091e0ef7a436ebee9461783b