[INFO] updating cached repository jonkgrimes/juno-server [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/jonkgrimes/juno-server [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/jonkgrimes/juno-server" "work/ex/clippy-test-run/sources/stable/gh/jonkgrimes/juno-server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/jonkgrimes/juno-server'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/jonkgrimes/juno-server" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonkgrimes/juno-server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonkgrimes/juno-server'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4c8ede93369c56bff09a3ef45e405715a786a5bf [INFO] sha for GitHub repo jonkgrimes/juno-server: 4c8ede93369c56bff09a3ef45e405715a786a5bf [INFO] validating manifest of jonkgrimes/juno-server on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of jonkgrimes/juno-server on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing jonkgrimes/juno-server [INFO] finished frobbing jonkgrimes/juno-server [INFO] frobbed toml for jonkgrimes/juno-server written to work/ex/clippy-test-run/sources/stable/gh/jonkgrimes/juno-server/Cargo.toml [INFO] started frobbing jonkgrimes/juno-server [INFO] finished frobbing jonkgrimes/juno-server [INFO] frobbed toml for jonkgrimes/juno-server written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/jonkgrimes/juno-server/Cargo.toml [INFO] crate jonkgrimes/juno-server has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting jonkgrimes/juno-server against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/jonkgrimes/juno-server:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1cef7794c778a3cb29acda448a2987a5c0ed50aefd127a847d8f95d3c47c3c49 [INFO] running `"docker" "start" "-a" "1cef7794c778a3cb29acda448a2987a5c0ed50aefd127a847d8f95d3c47c3c49"` [INFO] [stderr] Compiling actix-web v0.7.3 [INFO] [stderr] Checking r2d2 v0.8.2 [INFO] [stderr] Checking tokio-io v0.1.7 [INFO] [stderr] Checking mio-uds v0.6.6 [INFO] [stderr] Compiling syn v0.14.5 [INFO] [stderr] Compiling syn v0.15.15 [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Compiling pest_derive v1.0.7 [INFO] [stderr] Checking flate2 v1.0.2 [INFO] [stderr] Checking tokio-threadpool v0.1.5 [INFO] [stderr] Checking dotenv v0.9.0 [INFO] [stderr] Checking diesel v1.3.3 [INFO] [stderr] Checking tokio-reactor v0.1.2 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking h2 v0.1.11 [INFO] [stderr] Checking tokio-fs v0.1.2 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-signal v0.2.1 [INFO] [stderr] Checking tera v0.11.11 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking trust-dns-proto v0.4.0 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking trust-dns-resolver v0.9.0 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling actix_derive v0.3.0 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking actix v0.7.3 [INFO] [stderr] Checking juno-server v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | uuid: uuid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `uuid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | uuid: uuid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `uuid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/db.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | new_agent [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/db.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | let new_agent = NewAgent { [INFO] [stderr] | _____________________^ [INFO] [stderr] 57 | | uuid: uuid, [INFO] [stderr] 58 | | hostname: &msg.hostname, [INFO] [stderr] 59 | | ip: msg.ip.parse().unwrap() [INFO] [stderr] 60 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/db.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | new_agent [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/db.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | let new_agent = NewAgent { [INFO] [stderr] | _____________________^ [INFO] [stderr] 57 | | uuid: uuid, [INFO] [stderr] 58 | | hostname: &msg.hostname, [INFO] [stderr] 59 | | ip: msg.ip.parse().unwrap() [INFO] [stderr] 60 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/db.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | / fn new_agent<'a>(msg: &'a RegisterAgent) -> NewAgent<'a> { [INFO] [stderr] 55 | | let uuid = uuid::Uuid::new_v4(); [INFO] [stderr] 56 | | let new_agent = NewAgent { [INFO] [stderr] 57 | | uuid: uuid, [INFO] [stderr] ... | [INFO] [stderr] 61 | | new_agent [INFO] [stderr] 62 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/agent_server.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | session.do_send(Message(message.to_owned())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/db.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | / fn new_agent<'a>(msg: &'a RegisterAgent) -> NewAgent<'a> { [INFO] [stderr] 55 | | let uuid = uuid::Uuid::new_v4(); [INFO] [stderr] 56 | | let new_agent = NewAgent { [INFO] [stderr] 57 | | uuid: uuid, [INFO] [stderr] ... | [INFO] [stderr] 61 | | new_agent [INFO] [stderr] 62 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/agent_server.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | session.do_send(Message(message.to_owned())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 51s [INFO] running `"docker" "inspect" "1cef7794c778a3cb29acda448a2987a5c0ed50aefd127a847d8f95d3c47c3c49"` [INFO] running `"docker" "rm" "-f" "1cef7794c778a3cb29acda448a2987a5c0ed50aefd127a847d8f95d3c47c3c49"` [INFO] [stdout] 1cef7794c778a3cb29acda448a2987a5c0ed50aefd127a847d8f95d3c47c3c49